Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c: In function
rtl8812ae_phy_config_rf_with_headerfile:
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:2079:7: warning: variable
rtstatus set but not used [-Wunused-but-set-variable]
drivers/n
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c: In function
rtl8723_cmd_send_packet:
drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c:226:5: warning:
variable own set but not used [-Wunused-but-set-variable]
It is not used s
zhengbin (8):
rtlwifi: rtl8821ae: Remove set but not used variables 'rtstatus','bd'
rtlwifi: rtl8723ae: Remove set but not used variables
'reg_ecc','reg_ec4','reg_eac','b_pathb_ok'
rtlwifi: rtl8192c: Remove set but not used variables
'reg_ecc','reg_eac'
rtlwifi: rtl8188ee: Remove se
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c: In function
phy_config_bb_with_pghdr:
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c:652:22: warning: variable
v3 set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/r
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.c: In function
btc8192e2ant_tdma_duration_adjust:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.c:1584:6:
warning: variable result set but not used [-Wunused-but-set-var
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c: In function
rtl88e_dm_pwdb_monitor:
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c:763:6: warning: variable
h2c_parameter set but not used [-Wunused-but-set-variable]
It is not used since co
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c: In function
rtl8723e_phy_iq_calibrate:
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c:1346:6: warning: variable
reg_ecc set but not used [-Wunused-but-set-variable]
drivers/net/wireless/rea
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c: In function
rtl92c_phy_iq_calibrate:
drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c:1373:6: warning:
variable reg_ecc set but not used [-Wunused-but-set-variable]
drivers/net/wi
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c: In function
btc8723b1ant_tdma_dur_adj_for_acl:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c:1428:7:
warning: variable wifi_busy set but not used [-Wunused-but-set-
On Fri, 2019-10-04 at 16:43 +0800, zhengbin wrote:
> zhengbin (8):
> rtlwifi: rtl8821ae: Remove set but not used variables 'rtstatus','bd'
> rtlwifi: rtl8723ae: Remove set but not used variables
> 'reg_ecc','reg_ec4','reg_eac','b_pathb_ok'
> rtlwifi: rtl8192c: Remove set but not used vari
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function
rtw8822c_dpk_dc_corr_check:
drivers/net/wireless/realtek/rtw88/rtw8822c.c:2166:5: warning: variable
corr_val set but not used [-Wunused-but-set-variable]
It is not used since commit 5227c2e
On 10/3/2019 10:08 PM, Hans de Goede wrote:
With the new edmg support struct cfg80211_chan_def has been extended
with a number of new members. brcmf_cfg80211_get_channel() was not setting
(clearing) these causing the cfg80211_edmg_chandef_valid() check in
cfg80211_chandef_valid() to fail. Trigger
Ensure the SSID element is bounds-checked prior to invoking memcpy()
with its length field.
Cc:
Cc: Johannes Berg
Cc: Kees Cook
Reported-by: Nicolas Waisman
Signed-off-by: Will Deacon
---
net/wireless/wext-sme.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/
Although this shouldn't occur in practice, it's a good idea to bounds
check the length field of the SSID element prior to using it for things
like allocations or memcpy operations.
Cc:
Cc: Johannes Berg
Cc: Kees Cook
Reported-by: Nicolas Waisman
Signed-off-by: Will Deacon
---
net/mac80211/ml
Hans de Goede writes:
> With the new edmg support struct cfg80211_chan_def has been extended
> with a number of new members. brcmf_cfg80211_get_channel() was not setting
> (clearing) these causing the cfg80211_edmg_chandef_valid() check in
> cfg80211_chandef_valid() to fail. Triggering a WARN_ON
Hi,
On 10/4/19 12:34 PM, Kalle Valo wrote:
Hans de Goede writes:
With the new edmg support struct cfg80211_chan_def has been extended
with a number of new members. brcmf_cfg80211_get_channel() was not setting
(clearing) these causing the cfg80211_edmg_chandef_valid() check in
cfg80211_chandef
Hans de Goede writes:
> Hi,
>
> On 10/4/19 12:34 PM, Kalle Valo wrote:
>> Hans de Goede writes:
>>
>>> With the new edmg support struct cfg80211_chan_def has been extended
>>> with a number of new members. brcmf_cfg80211_get_channel() was not setting
>>> (clearing) these causing the cfg80211_edm
Hi,
I was tempted to apply this (sans the feature advertisement part that I
don't think should be in nl80211), but:
>
> Signed-off-by: James Prestwood
Please add a commit log.
> +static int ieee80211_can_live_addr_change(struct ieee80211_sub_if_data
> *sdata)
> +{
> + if (netif_carrier_o
On Thu, 2019-10-03 at 08:13 +, Aaron Komisar wrote:
> > The real reason of scan failure is because mac80211 checks if it's DFS
> > channel, but it doesn't check if CAC is done or not.
>
> The problem is that scan request is blocked in ETSI reg domains. In non-ETSI
> reg domains the behavior i
Just took a very brief look so I can think about it while offline ;-)
But some (editorial) comments:
> +/**
> + * ieee80211_sta_register_pending_airtime - register the estimated airtime
> for
> + * the frames pending in lower layer (firmware/hardware) txq.
That doesn't work - the short descript
On Thu, 2019-10-03 at 23:21 -0700, Kan Yan wrote:
>
> +/* The firmware's transmit queue size limit in airtime */
> +#define IEEE80211_DEFAULT_AQL_INTERFACE_LIMIT24000
I'm not sure I understand this completely, but IMHO rewording it to be
like a "NIC limit" would be better.
However, I'm n
From: Johannes Berg
We can process deauth frames and all, but we drop them very
early in the RX path today - this could never have worked.
Fixes: 2cc59e784b54 ("mac80211: reply to AUTH with DEAUTH if sta allocation
fails in IBSS")
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
n
From: Luca Coelho
Hi,
A couple of patches with mac80211 and cfg80211 changes from our
internal tree.
Please review, though you have already reviewed most if not all of
them ;)
Cheers,
Luca.
Johannes Berg (1):
mac80211: accept deauth frames in IBSS mode
Sara Sharon (1):
cfg80211: fix a b
From: Sara Sharon
cfg80211_update_notlisted_nontrans() leaves the RCU critical session
too early, while still using nontrans_ssid which is RCU protected. In
addition, it performs a bunch of RCU pointer update operations such
as rcu_access_pointer and rcu_assign_pointer.
The caller, cfg80211_info
From: Navid Emamdoost
In iwl_pcie_ctxt_info_gen3_init there are cases that the allocated dma
memory is leaked in case of error.
DMA memories prph_scratch, prph_info, and ctxt_info_gen3 are allocated
and initialized to be later assigned to trans_pcie. But in any error case
before such assignment
From: Johannes Berg
We don't handle failures in the rb_allocator workqueue allocation
correctly. To fix that, move the code earlier so the cleanup is
easier and we don't have to undo all the interrupt allocations in
this case.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
driver
From: Navid Emamdoost
In alloc_sgtable if alloc_page fails, the alocated table should be
released.
Signed-off-by: Navid Emamdoost
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/intel/iwlwifi/f
From: Johannes Berg
We got a crash in iwl_trans_pcie_get_cmdlen(), while the TFD was
being accessed to sum up the lengths.
We want to access the TFD here, which is the information for the
hardware. We always only allocate 32 buffers for the cmd queue,
but on newer hardware (using TFH) we can als
From: Luca Coelho
We copy cfg->trans to trans->trans_cfg at the very beginning, so don't
try to access it via cfg->trans anymore, because the cfg may be unset
in later cases.
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/iwl-io.h | 12 ++--
1 file changed, 6 inserti
From: Luca Coelho
This is my first patchset with fixes for v5.4.
The changes are:
* fix for an ACPI table parsing bug;
* a fix for a NULL pointer dereference in the cfg with specific
devices;
* fix the rb_allocator;
* prevent multiple phy configuration with new devices;
* fix a race-condition
From: Haim Dreyfuss
The PHY is initialized during device initialization, but devices with
the tx_siso_diversity flag set need to send PHY_CONFIGURATION_CMD first,
otherwise the PHY would be reinitialized, causing a SYSASSERT.
To fix this, use a bit that tells the FW not to complete the PHY
initi
From: Naftali Goldstein
Consider the following flow:
1. Driver starts to sync the rx queues due to a delba.
mvm->queue_sync_cookie=1.
This rx-queues-sync is synchronous, so it doesn't increment the
cookie until all rx queues handle the notification from FW.
2. During this time, driv
From: Luca Coelho
We can't check for the ACPI table revision validity in the same if
where we check if the package was read correctly, because we return
PTR_ERR(pkg) and if the table is not valid but the pointer is, we
would return a valid pointer as an error. Fix that by moving the
table checks
From: Pawel Dembicki
mt76x0e driver only supports MAC addresses from
calibration data eeprom. Many routers however do not
have a valid stock address set in this field.
This patch makes it possible to take a MAC address
from OF (e.g. from mtd).
Cc: Felix Fietkau
Signed-off-by: Pawel Dembicki
Luca Coelho writes:
> From: Naftali Goldstein
>
> Consider the following flow:
> 1. Driver starts to sync the rx queues due to a delba.
> mvm->queue_sync_cookie=1.
> This rx-queues-sync is synchronous, so it doesn't increment the
> cookie until all rx queues handle the notification
wrote:
> From: Chin-Yen Lee
>
> Driver needs to wait for firmware to restore hardware setting
> to active mode after leaving lps.
>
> After getting H2C from driver for leaving lps, firmware will
> issue null packet without PS bit to inform AP driver is active,
> and then restore REG_TCR Regist
Chi-Hsien Lin wrote:
> From: Chung-Hsien Hsu
>
> The firmware may have SAE authentication code built-in. This is
> detected by the driver and indicated in the wiphy features flags.
> User-space can use this flag to determine whether or not to provide
> the password material for SAE authenticati
Kan Yan writes:
> In order for the Fq_CoDel integrated in mac80211 layer operates
> effectively to control excessive queueing latency, the CoDel algorithm
> requires an accurate measure of how long the packets stays in the
> queue, aka sojourn time. The sojourn time measured at mac80211 layer
> d
On Fri, Oct 04, 2019 at 10:51:31AM +0100, Will Deacon wrote:
> Although this shouldn't occur in practice, it's a good idea to bounds
> check the length field of the SSID element prior to using it for things
> like allocations or memcpy operations.
>
> Cc:
> Cc: Johannes Berg
> Cc: Kees Cook
> R
On Fri, Oct 04, 2019 at 10:51:32AM +0100, Will Deacon wrote:
> Ensure the SSID element is bounds-checked prior to invoking memcpy()
> with its length field.
>
> Cc:
> Cc: Johannes Berg
> Cc: Kees Cook
> Reported-by: Nicolas Waisman
> Signed-off-by: Will Deacon
Reviewed-by: Kees Cook
-Kees
On Fri, 2019-10-04 at 13:56 +0200, Johannes Berg wrote:
> Hi,
>
> I was tempted to apply this (sans the feature advertisement part that
> I
> don't think should be in nl80211), but:
>
> >
> > Signed-off-by: James Prestwood
>
> Please add a commit log.
>
> > +static int ieee80211_can_live_addr
Hi Johannes,
After thinking about this more:
On Fri, 2019-10-04 at 09:25 -0700, James Prestwood wrote:
> On Fri, 2019-10-04 at 13:56 +0200, Johannes Berg wrote:
> > Hi,
> >
> > I was tempted to apply this (sans the feature advertisement part
> > that
> > I
> > don't think should be in nl80211),
On 10/4/19 5:15 AM, Johannes Berg wrote:
On Thu, 2019-10-03 at 08:13 +, Aaron Komisar wrote:
The real reason of scan failure is because mac80211 checks if it's DFS
channel, but it doesn't check if CAC is done or not.
The problem is that scan request is blocked in ETSI reg domains. In non
On Fri, 2019-10-04 at 16:41 +0300, Kalle Valo wrote:
> Luca Coelho writes:
>
> > From: Naftali Goldstein
> >
> > Consider the following flow:
> > 1. Driver starts to sync the rx queues due to a delba.
> > mvm->queue_sync_cookie=1.
> > This rx-queues-sync is synchronous, so it doesn't i
From: Adham Abozaeid
WILC doesn't support per-vif tx power, and hence, wdev will always be
null in calls to set_tx_power.
Instead, wiphy should be used to execute the operation
Signed-off-by: Adham Abozaeid
---
.../staging/wilc1000/wilc_wfi_cfgoperations.c| 16 +++-
1 file chan
Hi Johannes,
Thanks for help review this patch. I will fix all style errors.
> > +ieee80211_txq_airtime_check(struct ieee80211_hw *hw, struct ieee80211_txq
> > *txq);
> Why is it necessary to call this, vs. just returning NULL when an SKB is
> requested?
This function is also called by ath10k,
Hi Toke,
> So I think it'll be better to pass up the last_rate and have mac80211
> calculate the airtime (like I did in my patch set). But we can keep the
> rest of your logic and just switch the calculation, I guess?
Sounds like a good plan to me. Moving the airtime calculation do makes
it easier
47 matches
Mail list logo
