Re: [PATCH] rtlwifi: rtl_pci: Fix problem of too small skb->len

2019-10-19 Thread Larry Finger
On 10/19/19 5:23 PM, ian.schram wrote: Hi, This patch doesn't appear to do anything? The increased length is not actually used, is a part of the patch missing? ps: superficial reading, i am not hampered by any specific knowledge of this driver. On 2019-10-19 21:02, Larry Finger wrote: In

[PATCH V2] rtlwifi: rtl_pci: Fix problem of too small skb->len

2019-10-19 Thread Larry Finger
In commit 8020919a9b99 ("mac80211: Properly handle SKB with radiotap only"), buffers whose length is too short cause a WARN_ON(1) to be executed. This change exposed a fault in rtlwifi drivers, which is fixed by increasing the length of the affected buffer before it is sent to mac80211. Cc: Stable

Re: [PATCH] rtlwifi: rtl_pci: Fix problem of too small skb->len

2019-10-19 Thread ian.schram
Hi, This patch doesn't appear to do anything? The increased length is not actually used, is a part of the patch missing? ps: superficial reading, i am not hampered by any specific knowledge of this driver. On 2019-10-19 21:02, Larry Finger wrote: In commit 8020919a9b99 ("mac80211: Properly

[PATCH] rtlwifi: rtl_pci: Fix problem of too small skb->len

2019-10-19 Thread Larry Finger
In commit 8020919a9b99 ("mac80211: Properly handle SKB with radiotap only"), buffers whose length is too short cause a WARN_ON(1) to be executed. This change exposed a fault in rtlwifi drivers, which is fixed by increasing the length of the affected buffer before it is sent to mac80211. Cc: Stable

Re: [PATCH v2] rtlwifi: Fix potential overflow on P2P code

2019-10-19 Thread Laura Abbott
On 10/19/19 6:51 AM, Kalle Valo wrote: Laura Abbott writes: Nicolas Waisman noticed that even though noa_len is checked for a compatible length it's still possible to overrun the buffers of p2pinfo since there's no check on the upper bound of noa_num. Bound noa_num against P2P_MAX_NOA_NUM. Re

Re: [PATCH v2 5/6] rtw88: add set_bitrate_mask support

2019-10-19 Thread Kalle Valo
Chris Chiu writes: > On Wed, Oct 16, 2019 at 8:33 PM wrote: >> >> From: Tzu-En Huang >> > >> + >> + band = hal->current_band_type; >> + if (band == RTW_BAND_2G) { >> + band = NL80211_BAND_2GHZ; >> + cfg_mask = mask->control[band].legacy; >> + } else

Re: [PATCH v2 4/6] rtw88: update regulatory settings implementaion

2019-10-19 Thread Kalle Valo
Brian Norris writes: > On Wed, Oct 16, 2019 at 7:55 PM Tony Chuang wrote: >> >> From: Brian Norris >> > >> > On Wed, Oct 16, 2019 at 5:33 AM wrote: >> > > This also supports user regulatory hints, and it should only be >> > > enabled for specific distributions that need this to correct >> > > t

[PATCH 4/5] iwlwifi: pcie: add workaround for power gating in integrated 22000

2019-10-19 Thread Luca Coelho
From: Luca Coelho Add a workaround that forces power gating to be enabled on integrated 22000 devices. This improves power saving in certain situations. Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/iwl-csr.h | 1 + drivers/net/wireless/intel/iwlwifi/iwl-prph.h | 5

[PATCH 2/5] iwlwifi: pcie: fix all 9460 entries for qnj

2019-10-19 Thread Luca Coelho
From: Luca Coelho A bunch of the entries for qnj were wrong. The 9460 device doesn't exist, so update them to 9461 and 9462. There are still a bunch of other occurrences of 9460, but that will be fixed separately. Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c |

[PATCH 3/5] iwlwifi: mvm: handle iwl_mvm_tvqm_enable_txq() error return

2019-10-19 Thread Luca Coelho
From: Johannes Berg iwl_mvm_tvqm_enable_txq() can return an error, notably if unable to allocate memory for the queue. Handle this error throughout, avoiding storing the invalid value into a u16 which later leads to a disable of an invalid queue ("queue 65524 not used", where 65524 is just -ENOME

[PATCH 5/5] iwlwifi: pcie: 0x2720 is qu and 0x30DC is not

2019-10-19 Thread Luca Coelho
From: Luca Coelho When converting the wrong qu configurations in an earlier commit, I accidentally swapped 0x2720 and 0x30DC. Instead of converting 0x2720, I converted 0x30DC. Undo 0x30DC and convert 0x2720. Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 109 +

[PATCH 1/5] iwlwifi: pcie: fix PCI ID 0x2720 configs that should be soc

2019-10-19 Thread Luca Coelho
From: Luca Coelho Some entries for PCI ID 0x2720 were using iwl9260_2ac_cfg, but the correct is to use iwl9260_2ac_cfg_soc. Fix that. Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH 0/5] iwlwifi: fixes intended for 5.4 2019-10-19

2019-10-19 Thread Luca Coelho
From: Luca Coelho This is my third patchset with fixes for v5.4. This time I have five important fixes. The changes are: * Fix a bogus queue number when allocation fails; * A few PCI ID mapping fixes; * A workaround to force power gating in integrated 22000 devices. As usual, I'm pushing this

[PATCH 04/12] iwlwifi: mvm: in VHT connection use only VHT capabilities

2019-10-19 Thread Luca Coelho
From: Mordechay Goodstein mac80211 limits amsdu size to the minimum of HT and VHT capabilities but since in a VHT connection we don't transmit HT frames we can discard HT limits. Signed-off-by: Mordechay Goodstein Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c |

[PATCH 10/12] iwlwifi: mvm: print rate_n_flags in a pretty format

2019-10-19 Thread Luca Coelho
From: Mordechay Goodstein Use the rs_pretty_print_rate() function to print the rate_n_flags in more human-readable format. Signed-off-by: Mordechay Goodstein Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c | 6 -- drivers/net/wireless/intel/iwlwifi/mvm/rs.c

[PATCH 07/12] iwlwifi: scan: create function for scan scheduling params

2019-10-19 Thread Luca Coelho
From: Tova Mussai In the next patch, this code will be used from different places. As preparation export this code into function. Signed-off-by: Tova Mussai Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 61 --- 1 file changed, 38 insertions(+),

[PATCH 11/12] iwlwifi: FW API: reference enum in docs of modify_mask

2019-10-19 Thread Luca Coelho
From: Johannes Berg Add a reference to the correct enum rather than showing the pattern of the actual constants. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/fw/api/sta.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff -

[PATCH 01/12] iwlwifi: mvm: fix support for single antenna diversity

2019-10-19 Thread Luca Coelho
From: Luca Coelho When the single antenna diversity support was sent upstream, only some definitions were sent, due to a bad revert. Fix this by adding the actual code. Fixes: 5952e0ec3f05 ("iwlwifi: mvm: add support for single antenna diversity") Signed-off-by: Luca Coelho --- drivers/net/wi

[PATCH 12/12] iwlwifi: bump FW API to 51 for 22000 series

2019-10-19 Thread Luca Coelho
From: Luca Coelho Start supporting API version 51 for 22000 series. Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwl

[PATCH 05/12] iwlwifi: pcie: make iwl_pcie_gen2_update_byte_tbl static

2019-10-19 Thread Luca Coelho
From: Emmanuel Grumbach It is called within tx-gen2.c only. Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/internal.h | 3 --- drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 6 +++--- 2 files changed, 3 insertions(+), 6 deletions(

[PATCH 09/12] iwlwifi: scan: adapt the code to use api ver 11

2019-10-19 Thread Luca Coelho
From: Tova Mussai FW scan api ver 11 adds support for some new features, in this version the fw did also some cleanup in the api, which causes the driver not to be able to use the current scan req struct. Therefore, in this patch the driver has new version for the scan command code Signed-off-b

[PATCH 00/12] iwlwifi: updates intended for v5.5 2019-19

2019-10-19 Thread Luca Coelho
From: Luca Coelho Hi, Here's the third set of patches intended for v5.5. It's the usual development, new features, cleanups and bugfixes. The changes are: * Update scan FW API; * Fix single antenna diversity support; * Bump the supported FW API version; * Add debug dump collection on assert i

[PATCH 03/12] iwlwifi: nvm: update iwl_uhb_nvm_channels

2019-10-19 Thread Luca Coelho
From: Tova Mussai Update uhb channels numbers to start from 1 Signed-off-by: Tova Mussai Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-pa

[PATCH 02/12] iwlwifi: mvm: remove else-if in iwl_send_phy_cfg_cmd()

2019-10-19 Thread Luca Coelho
From: Luca Coelho We return in the if block, so it's unnecessary to have an else statement. Remove it. Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.

[PATCH 08/12] iwlwifi: scan: Create function to build scan cmd

2019-10-19 Thread Luca Coelho
From: Tova Mussai Currently, the code to build scan cmd is duplicated in iwl_mvm_reg_scan_start and iwl_mvm_sched_scan_start. Create a function to build this command, and call the function instead. Signed-off-by: Tova Mussai Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/m

[PATCH 06/12] iwlwifi: dbg_ini: support dump collection upon assert during D3

2019-10-19 Thread Luca Coelho
From: Shahar S Matityahu add assert time point in the D3 resume flow in case there was an assert during D3. Signed-off-by: Shahar S Matityahu Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/i