Re: [RFC PATCH v2 0/2] Extended Key ID support for linux

2018-12-08 Thread Alexander Wetzel
I got the impression Extended Key IDs were added without updating all sections which should get updates. But the pattern is suspect, even the igtk numbers fit into the pattern: PTK 0 & 1 GTK 1 & 2 & 3 iGTK 4 & 5 An AP is allowed to do this, but there is no requirement for doing so. The

Re: [PATCH 2/5] mt76x02: fixup MT_PROT_RATE_* defines

2018-12-08 Thread Lorenzo Bianconi
> > On new mt76 chips, phy mode is configured by last 3 bits > of rate value. Hence OFDM bit is marked by 0x2000 > instead of 0x4000. > > Signed-off-by: Stanislaw Gruszka > --- > drivers/net/wireless/mediatek/mt76/mt76x02_regs.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [PATCH 5/5] mt76x2: initialize fall-back rate registers

2018-12-08 Thread Lorenzo Bianconi
> > Initialize MT_LG_FBK_CFG{0,1} and MT_VHT_HT_FBK_CFG{0,1} registers. > > Signed-off-by: Stanislaw Gruszka > --- > drivers/net/wireless/mediatek/mt76/mt76x0/initvals.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/initvals.h >

Re: [PATCH 4/5] mt76x2: initialize fall-back rate registers

2018-12-08 Thread Lorenzo Bianconi
> > Initialize MT_LG_FBK_CFG{0,1} and MT_VHT_HT_FBK_CFG0 registers. > MT_VHT_HT_FBK_CFG1 was already configured. > > Signed-off-by: Stanislaw Gruszka > --- > drivers/net/wireless/mediatek/mt76/mt76x2/init.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCH 1/5] mt76x02: do not set protection on set_rts_threshold callback

2018-12-08 Thread Lorenzo Bianconi
On Fri, Dec 7, 2018 at 2:27 PM Stanislaw Gruszka wrote: > > Use set_rts_threshold calback to enable/disable threshold only for > legacy traffic. > > Protection for HT and VHT traffic is defined by HT operation element > and it's provided by remote AP or by hostapd. > > Signed-off-by: Stanislaw

Re: [EXT] Re: [PATCH] mwifiex: fix nested rtnl locking on BG_SCAN_STOPPED

2018-12-07 Thread Brian Norris
Hi Ganapathi, For some reason, I'm daft enough to reply to this ancient thread. It appears as if you probably have not resolved this issue yet though, so I figured I could lend some advice. On Wed, Apr 25, 2018 at 1:06 AM Ganapathi Bhat wrote: > > Ganapathi Bhat writes: > > > ---

Re: [PATCH 2/5] cfg80211: Properly track transmitting and non-transmitting BSS

2018-12-07 Thread kbuild test robot
Hi Sara, Thank you for the patch! Yet something to improve: [auto build test ERROR on mac80211-next/master] [also build test ERROR on v4.20-rc5 next-20181207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Urgently need money? We can help you!

2018-12-07 Thread Mr. Muller Dieter
Urgently need money? We can help you! Are you by the current situation in trouble or threatens you in trouble? In this way, we give you the ability to take a new development. As a rich person I feel obliged to assist people who are struggling to give them a chance. Everyone deserved a second

[PATCH 5/5] mt76x2: initialize fall-back rate registers

2018-12-07 Thread Stanislaw Gruszka
Initialize MT_LG_FBK_CFG{0,1} and MT_VHT_HT_FBK_CFG{0,1} registers. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/initvals.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/initvals.h

[PATCH 4/5] mt76x2: initialize fall-back rate registers

2018-12-07 Thread Stanislaw Gruszka
Initialize MT_LG_FBK_CFG{0,1} and MT_VHT_HT_FBK_CFG0 registers. MT_VHT_HT_FBK_CFG1 was already configured. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x2/init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 3/5] mt76x02: set protection according to ht operation element

2018-12-07 Thread Stanislaw Gruszka
Configure protection based on information that are provided to us either by remote AP or by hostapd via HT operation IE. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 83 +++ drivers/net/wireless/mediatek/mt76/mt76x02_mac.h | 2 +

[PATCH 1/5] mt76x02: do not set protection on set_rts_threshold callback

2018-12-07 Thread Stanislaw Gruszka
Use set_rts_threshold calback to enable/disable threshold only for legacy traffic. Protection for HT and VHT traffic is defined by HT operation element and it's provided by remote AP or by hostapd. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 16

[PATCH 2/5] mt76x02: fixup MT_PROT_RATE_* defines

2018-12-07 Thread Stanislaw Gruszka
On new mt76 chips, phy mode is configured by last 3 bits of rate value. Hence OFDM bit is marked by 0x2000 instead of 0x4000. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x02_regs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [RFC/RFT 1/4] mt76x02: configure basic rates and fallback on STA mode

2018-12-07 Thread Stanislaw Gruszka
On Thu, Nov 08, 2018 at 05:02:14PM +0100, Felix Fietkau wrote: > >> > + if (changed & BSS_CHANGED_BASIC_RATES && > >> > + vif->type == NL80211_IFTYPE_STATION) { > >> > + mt76_wr(dev, MT_LEGACY_BASIC_RATE, info->basic_rates); It's a bit hard to interpret how vendor

Can't connect to WPA(2)-EAP network (eduroam / TTLS) with iwlwifi (9260 - and some others) ~90% of the time with 4.17.16 through 4.19.7 at least

2018-12-07 Thread Ferry
Hi, I have a Dell XPS 15 9550 in which I replaced the wireless Broadcom adapter with an Intel 9260. So far I have not encountered any issues whatsoever with WPA(2)-PSK networks, but I do have issues connecting to WPA(2)-EAP networks (at least eduroam here, which uses TTLS / MSCHAPv2), which I

[PATCH 1/5] cfg80211: Parsing of Multiple BSSID information in scanning

2018-12-07 Thread Jouni Malinen
From: Peng Xu This extends cfg80211 BSS table processing to be able to parse Multiple BSSID element from Beacon and Probe Response frames and to update the BSS profiles in internal database for non-transmitted BSSs. Signed-off-by: Peng Xu Signed-off-by: Sara Sharon Signed-off-by: Johannes

[PATCH 2/5] cfg80211: Properly track transmitting and non-transmitting BSS

2018-12-07 Thread Jouni Malinen
From: Sara Sharon When holding data of the non-transmitting BSS, we need to keep the transmitting BSS data on. Otherwise it will be released, and release the non-transmitting BSS with it. Signed-off-by: Sara Sharon Signed-off-by: Johannes Berg Signed-off-by: Jouni Malinen ---

[PATCH 4/5] mac80211: Declare support for Multi-BSSID if driver supports it

2018-12-07 Thread Jouni Malinen
From: Sara Sharon Define bits and flags for indicating support of Multi-BSSID feature and indicate support for this if the driver supports it. Signed-off-by: Sara Sharon Signed-off-by: Johannes Berg Signed-off-by: Jouni Malinen --- include/linux/ieee80211.h | 6 ++

[PATCH 5/5] mac80211_hwsim: Declare support for Multi-BSSID

2018-12-07 Thread Jouni Malinen
This can be used to test cfg80211 support for Multi-BSSID scan result parsing. Signed-off-by: Jouni Malinen --- drivers/net/wireless/mac80211_hwsim.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index

[PATCH 3/5] cfg80211: Move Multiple BSS info to struct cfg80211_bss to be visible

2018-12-07 Thread Jouni Malinen
From: Sara Sharon Previously the transmitted BSS and the non-trasmitted BSS list were defined in struct cfg80211_internal_bss. Move them to struct cfg80211_bss since mac80211 needs this info. Signed-off-by: Sara Sharon Signed-off-by: Johannes Berg Signed-off-by: Jouni Malinen ---

Re: pull request: mt76 2018-11-30

2018-12-07 Thread Kalle Valo
Lorenzo Bianconi writes: >> Felix Fietkau writes: >> >> > here's my first pull request for 4.21 >> > >> > - Felix >> > >> > The following changes since commit >> > b72c51a58e6d63ef673ac96b8ab5bc98799c5f7b: >> > >> > brcmfmac: Fix out of bounds memory access during fw load (2018-11-29 >> >

Re: brcmfmac: regression using AP mode

2018-12-07 Thread Stefan Wahren
Hi, Am 26.11.18 um 11:11 schrieb Arend van Spriel: > On 11/25/2018 2:14 PM, Stefan Wahren wrote: >> Hi Rafał, >> >>> Rafał Miłecki hat am 24. November 2018 um 22:23 >>> geschrieben: >>> >>> >>> Possibly you can just update hostapd to anything more recent? I'm >>> afraid >>> the version you're

Re: [RFC PATCH v2 0/2] Extended Key ID support for linux

2018-12-07 Thread Jouni Malinen
On Wed, Dec 05, 2018 at 08:06:33PM +0100, Alexander Wetzel wrote: > >On Sun, 2018-11-11 at 12:02 +0100, Alexander Wetzel wrote: > >>IEEE 802.11-2012 added support for Extended Key ID, allowing pairwise > >>keys to also use keyID 1 and moving group keys to IDs 2 and 3. > > > >Where do you read

RE: [PATCH v2 01/13] rtw88: main files

2018-12-07 Thread Tony Chuang
Hi Kalle, This patch added a comment about our watch dog timer, please let me know if you are OK with it. Also if you have other questions about the series, just point it out and I will try to fix it. Thanks. Yan-Hsuan > -Original Message- > From: linux-wireless-ow...@vger.kernel.org

Re: Request for brcmfmac4366c-pcie.bin

2018-12-06 Thread Hubert Wiedeke
On Wed, 4 Apr 2018 09:38:32 +0200 Arend van Spriel wrote: > On 4/4/2018 4:12 AM, Hubert Wiedeke wrote: > > On Mon, 19 Feb 2018 12:51:07 +0100 > > Arend van Spriel wrote: > > > >> On 2/17/2018 9:19 AM, Hubert Wiedeke wrote: > >>> Hi, > >>> > >>> I'd like to ask about the current status of 4366c

Re: [RFC PATCH v2 2/2] mac80211: Add support for Extended Key ID

2018-12-06 Thread Alexander Wetzel
- /* PTK only using key ID 0 needs special handling on rekey */ - if (new_key && sta && ptk0rekey) { + /* PTK rekey without Extended Key ID needs special handling */ + if (new_key && pairwise && sta && + !test_sta_flag(sta, WLAN_STA_EXT_KEY_ID)) {

[PATCH] mt76: usb: avoid queue/status spinlocks while passing tx status to mac80211

2018-12-06 Thread Lorenzo Bianconi
As already done for pcie code in commit 79d1c94c9c78 ("mt76: avoid queue/status spinlocks while passing tx status to mac80211") make sure that no tx related spinlocks are taken during the ieee80211_tx_status call Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/usb.c | 10

Re: [RFC PATCH v2 1/2] nl80211/cfg80211: Add support for Extended Key ID

2018-12-06 Thread Alexander Wetzel
On Wed, 2018-12-05 at 21:54 +0100, Alexander Wetzel wrote: It started out as a flag and I switched to enum later without updating it. I'll chnage that to nl80211_key_install_mode, much much better... No, all stations using Extended Key ID will always use RX_ONLY and SET_TX for pairwise key

[PATCH] mt76: mac: run mt76x02_mac_work routine atomically

2018-12-06 Thread Lorenzo Bianconi
Grab mt76_dev mutex in mt76x02_mac_work handler since it runs concurrently with mt76x{0,2}_set_channel routines Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH] mt76: fix typo in mt76x02_check_mac_err routine

2018-12-06 Thread Lorenzo Bianconi
Reconfigure properly MT_MAC_SYS_CTRL register after mac sw-reset in mt76x02_check_mac_err routine Fixes: 73556561ab9f ("mt76x0: use mt76x02_mac_work as stats handler") Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [PATCH 2/2] mt76: dma: add rx buffer recycle support

2018-12-06 Thread Stanislaw Gruszka
On Wed, Dec 05, 2018 at 04:17:31PM +0100, Lorenzo Bianconi wrote: > > On Wed, Dec 05, 2018 at 11:37:33AM +0100, Lorenzo Bianconi wrote: > > > > > > > > Add support for recycling rx buffers if they are not forwarded > > > > to network stack instead of reallocate them from scratch > > > > > > > >

[PATCH] cfg80211: Notify all User Hints To self managed wiphys

2018-12-06 Thread Sriram R
Currently Self Managed WIPHY's are not notified on any hints other than user cell base station hints. Self Managed wiphy's basically rely on hints from firmware and its local regdb for regulatory management, so hints from wireless core can be ignored. But all user hints needs to be notified to

Re: [RFC PATCH v2 2/2] mac80211: Add support for Extended Key ID

2018-12-05 Thread Johannes Berg
> > > - /* PTK only using key ID 0 needs special handling on rekey */ > > > - if (new_key && sta && ptk0rekey) { > > > + /* PTK rekey without Extended Key ID needs special handling */ > > > + if (new_key && pairwise && sta && > > > + !test_sta_flag(sta, WLAN_STA_EXT_KEY_ID)) { > > >

Re: [RFC PATCH v2 1/2] nl80211/cfg80211: Add support for Extended Key ID

2018-12-05 Thread Johannes Berg
On Wed, 2018-12-05 at 21:54 +0100, Alexander Wetzel wrote: > > It started out as a flag and I switched to enum later without updating > it. I'll chnage that to nl80211_key_install_mode, much much better... > No, all stations using Extended Key ID will always use RX_ONLY and > SET_TX for

Re: [RFC PATCH v2 1/2] nl80211/cfg80211: Add support for Extended Key ID

2018-12-05 Thread Alexander Wetzel
On Sun, 2018-11-11 at 12:02 +0100, Alexander Wetzel wrote: Extend cfg80211 and nl80211 to allow pairwise keys to be installed for RX only, allowing to switching over TX independently, as required by IEEE-802.11-2016 to support "Extended Key ID for Individually Addressed Frames" PTK and STK keys

Re: [RFC PATCH v2 2/2] mac80211: Add support for Extended Key ID

2018-12-05 Thread Alexander Wetzel
+ * @IEEE80211_KEY_FLAG_RX_ONLY: Set by mac80211 to indicate that the key + * must not be used for TX (yet). I'm not sure that's relevant, since you have one key pointer for TX? + * @IEEE80211_KEY_FLAG_SET_TX: Set by mac80211 to indicate that a previously + * installed key with

Re: [RFC PATCH v2 0/2] Extended Key ID support for linux

2018-12-05 Thread Alexander Wetzel
Hi, Sorry for the delay. No problem. That's hardly urgent:-) On Sun, 2018-11-11 at 12:02 +0100, Alexander Wetzel wrote: IEEE 802.11-2012 added support for Extended Key ID, allowing pairwise keys to also use keyID 1 and moving group keys to IDs 2 and 3. Where do you read this? I've always

Re: [PATCH 2/2] mt76: dma: add rx buffer recycle support

2018-12-05 Thread Lorenzo Bianconi
> On Wed, Dec 05, 2018 at 11:37:33AM +0100, Lorenzo Bianconi wrote: > > > > > > Add support for recycling rx buffers if they are not forwarded > > > to network stack instead of reallocate them from scratch > > > > > > Signed-off-by: Lorenzo Bianconi > > > --- > > > > Felix, > > > > could you

Re: [RFC PATCH v2 2/2] mac80211: Add support for Extended Key ID

2018-12-05 Thread Johannes Berg
> + * @IEEE80211_KEY_FLAG_RX_ONLY: Set by mac80211 to indicate that the key > + * must not be used for TX (yet). I'm not sure that's relevant, since you have one key pointer for TX? > + * @IEEE80211_KEY_FLAG_SET_TX: Set by mac80211 to indicate that a previously > + * installed key

Re: [RFC PATCH v2 1/2] nl80211/cfg80211: Add support for Extended Key ID

2018-12-05 Thread Johannes Berg
On Sun, 2018-11-11 at 12:02 +0100, Alexander Wetzel wrote: > Extend cfg80211 and nl80211 to allow pairwise keys to be installed for > RX only, allowing to switching over TX independently, as required by > IEEE-802.11-2016 to support "Extended Key ID for Individually Addressed > Frames" > > PTK

Re: [RFC PATCH v2 0/2] Extended Key ID support for linux

2018-12-05 Thread Johannes Berg
Hi, Sorry for the delay. On Sun, 2018-11-11 at 12:02 +0100, Alexander Wetzel wrote: > IEEE 802.11-2012 added support for Extended Key ID, allowing pairwise > keys to also use keyID 1 and moving group keys to IDs 2 and 3. Where do you read this? I've always been under the impression that

Re: [PATCH 2/2] mt76: dma: add rx buffer recycle support

2018-12-05 Thread Stanislaw Gruszka
On Wed, Dec 05, 2018 at 11:37:33AM +0100, Lorenzo Bianconi wrote: > > > > Add support for recycling rx buffers if they are not forwarded > > to network stack instead of reallocate them from scratch > > > > Signed-off-by: Lorenzo Bianconi > > --- > > Felix, > > could you please drop this patch

[PATCH] cfg80211: Fix busy loop regression in ieee80211_ie_split_ric()

2018-12-05 Thread Jouni Malinen
This function was modified to support the information element extension case (WLAN_EID_EXTENSION) in a manner that would result in an infinite loop when going through set of IEs that include WLAN_EID_RIC_DATA and contain an IE that is in the after_ric array. The only place where this can currently

Re: [PATCH 2/2] mt76: dma: add rx buffer recycle support

2018-12-05 Thread Lorenzo Bianconi
> > Add support for recycling rx buffers if they are not forwarded > to network stack instead of reallocate them from scratch > > Signed-off-by: Lorenzo Bianconi > --- Felix, could you please drop this patch since it does not help to reduce pressure on page_frag_cache. Regards, Lorenzo

Re: pull request: mt76 2018-11-30

2018-12-05 Thread Lorenzo Bianconi
> Felix Fietkau writes: > > > here's my first pull request for 4.21 > > > > - Felix > > > > The following changes since commit b72c51a58e6d63ef673ac96b8ab5bc98799c5f7b: > > > > brcmfmac: Fix out of bounds memory access during fw load (2018-11-29 > > 17:33:10 +0200) > > > > are available in the

Re: [PATCH 00/29] staging: wilc1000: avoid deferring of cfg80211 operation callback

2018-12-05 Thread Greg KH
On Sun, Dec 02, 2018 at 06:02:13PM +, ajay.kat...@microchip.com wrote: > 6 files changed, 755 insertions(+), 2012 deletions(-) Nice code removal, patch series all now applied. greg k-h

NXP NFC version and ACPI

2018-12-04 Thread Daniel Lezcano
Hi, the discussion reference is on github [1]. I acquired a Lenovo x280 with a NFC chip. It is unclear what chip is it really, it is called NXP NPC300 which could be a PN7xxx chip range. A hacked version of an old deprecated out-of-tree module made the PN5xxx to work with my laptop but I

Re: pull request: mt76 2018-11-30

2018-12-04 Thread Kalle Valo
Felix Fietkau writes: > here's my first pull request for 4.21 > > - Felix > > The following changes since commit b72c51a58e6d63ef673ac96b8ab5bc98799c5f7b: > > brcmfmac: Fix out of bounds memory access during fw load (2018-11-29 > 17:33:10 +0200) > > are available in the Git repository at: > >

[PATCH wireless-drivers] brcmfmac: fix roamoff=1 modparam

2018-12-04 Thread Stijn Tintel
When the update_connect_param callback is set, nl80211 expects the flag WIPHY_FLAG_SUPPORTS_FW_ROAM to be set as well. However, this flag is only set when modparam roamoff=0, while the callback is set unconditionally. Since commit 7f9a3e150ec7 this causes a warning in wiphy_register, which breaks

Re: [PATCH] mac80211: rewrite Kconfig text for mesh

2018-12-04 Thread Steve deRosier
On Tue, Dec 4, 2018 at 7:25 AM Bob Copeland wrote: > > Lubomir Rintel recently pointed out a dead link for o11s.org, and > repointed it to a still live, but also stale website. As far as I > know, no one is updating the content at open80211s.org. > Indeed. The o11s effort more or less ended

Re: [PATCH] mac80211: rewrite Kconfig text for mesh

2018-12-04 Thread Lubomir Rintel
On Tue, 2018-12-04 at 10:22 -0500, Bob Copeland wrote: > Lubomir Rintel recently pointed out a dead link for o11s.org, and > repointed it to a still live, but also stale website. As far as I > know, no one is updating the content at open80211s.org. > > Since this Kconfig text was originally

Re: [PATCH] wireless-regdb: add URLs in README

2018-12-04 Thread Seth Forshee
On Fri, Nov 09, 2018 at 06:10:03PM +0100, Xose Vazquez Perez wrote: > Cc: Seth Forshee > Cc: WIRELESS ML > Cc: REGDB ML > Signed-off-by: Xose Vazquez Perez Applied, thanks!

Re: [PATCH] wireless-regdb: delete outdated comment for DE

2018-12-04 Thread Seth Forshee
On Fri, Nov 09, 2018 at 11:24:20AM +0100, Xose Vazquez Perez wrote: > d46d731c made it obsolete. > > Cc: Sven Eckelmann > Cc: Seth Forshee > Cc: WIRELESS ML > Cc: REGDB ML > Signed-off-by: Xose Vazquez Perez Applied, thanks!

[PATCH] mac80211: rewrite Kconfig text for mesh

2018-12-04 Thread Bob Copeland
Lubomir Rintel recently pointed out a dead link for o11s.org, and repointed it to a still live, but also stale website. As far as I know, no one is updating the content at open80211s.org. Since this Kconfig text was originally written, though, the 802.11s mesh drafts were approved and ultimately

[PATCH v2] nl80211: Add support to notify radar event info received from STA

2018-12-04 Thread Sriram R
Currently radar detection and corresponding channel switch is handled at the AP device. STA ignores these detected radar events since the radar signal can be seen mostly by the AP as well. But in scenarios where a radar signal is seen only at STA, notifying this event to the AP which can trigger a

Re: [RFC/RFT 3/4] mt76x02: do not set protection on set_rts_threshold callback

2018-12-04 Thread Stanislaw Gruszka
On Tue, Dec 04, 2018 at 11:45:09AM +0100, Stanislaw Gruszka wrote: > Only OFDM_PROT_CFG is configured there based on legacy proto > value. I'm not sure how handle CCK_PROT_CFG. > > > > - mt76_rmw(dev, MT_MM20_PROT_CFG, > > > - MT_PROT_CFG_CTRL | MT_PROT_CFG_RTS_THRESH, data); > > > -

Re: [RFC/RFT 3/4] mt76x02: do not set protection on set_rts_threshold callback

2018-12-04 Thread Stanislaw Gruszka
On Fri, Nov 09, 2018 at 10:23:56AM +0100, Lorenzo Bianconi wrote: > > Use set_rts_threshold calback to enable/disable threshold only for > > legacy traffic. RTS/CTS threshold for HT TXOP make make no sense > > to me since used protection (RTS/CTS , CTS-to-self or none) > > should be determined by

Re: rt2800 tx frame dropping issue.

2018-12-04 Thread Stanislaw Gruszka
Hi Daniel On Mon, Dec 03, 2018 at 03:44:46PM -0600, Daniel Santos wrote: > I almost managed to get that patch in a build to send to somebody who > can reproduce the error in abundance, but they have 15 different people > hammer the router to do it and we ended up sending them a few other >

Re: rt2800 tx frame dropping issue.

2018-12-03 Thread Daniel Santos
On 11/26/18 3:38 AM, Stanislaw Gruszka wrote: > On Fri, Nov 23, 2018 at 08:45:54PM +0100, Johannes Berg wrote: >> On Tue, 2018-11-20 at 15:20 -0600, Daniel Santos wrote: >> >>> I believe I have the answer as to why we're getting frames after we stop >>> the queue. I had a little chat about this

Re: rt2800 tx frame dropping issue.

2018-12-03 Thread Daniel Santos
Hello! Sorry for my delay, I got pretty sick last week. On 11/23/18 1:45 PM, Johannes Berg wrote: > On Tue, 2018-11-20 at 15:20 -0600, Daniel Santos wrote: > >> I believe I have the answer as to why we're getting frames after we stop >> the queue. I had a little chat about this in

Re: [PATCH] mac80211: allow AP_VLAN operation on crypto controlled devices

2018-12-03 Thread Alexander Wetzel
yes you just missed that ap_vlan is used for 4addr ap's / wds too so that might be related to the weired handling For my understanding ath10k is supporting 4addr mode with HW ciphers only. (As long as you do now switch it to raw mode manually and forcing SW crypto only.) The code in

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-12-03 Thread Lorenzo Bianconi
> On Mon, 2018-12-03 at 21:36 +0200, Toke Høiland-Jørgensen wrote: > > Hi Johannes > > > > I think your email can be basically summed up to: > > > > > [ ... ] but really I think it's a can of worms. > > > > ...right? :) > > Heh, yeah :) > > > I sort of had a feeling it would be, but thank you for

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-12-03 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Mon, 2018-12-03 at 21:36 +0200, Toke Høiland-Jørgensen wrote: >> Hi Johannes >> >> I think your email can be basically summed up to: >> >> > [ ... ] but really I think it's a can of worms. >> >> ...right? :) > > Heh, yeah :) > >> I sort of had a feeling it would be,

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-12-03 Thread Johannes Berg
On Mon, 2018-12-03 at 21:36 +0200, Toke Høiland-Jørgensen wrote: > Hi Johannes > > I think your email can be basically summed up to: > > > [ ... ] but really I think it's a can of worms. > > ...right? :) Heh, yeah :) > I sort of had a feeling it would be, but thank you for spelling out in >

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-12-03 Thread Toke Høiland-Jørgensen
Hi Johannes I think your email can be basically summed up to: > [ ... ] but really I think it's a can of worms. ...right? :) I sort of had a feeling it would be, but thank you for spelling out in excruciating detail why that is so. Given this, I think I agree that it's not worth it for now,

Trade Inquiry 03/12/18

2018-12-03 Thread Daniel Murray
Hi,friend, This is Daniel Murray and i am from Sinara Group Co.Ltd in Russia. We are glad to know about your company from the web and we are interested in your products. Could you kindly send us your Latest catalog and price list for our trial order. Best Regards, Daniel Murray Purchasing

[PATCH] mac80211: fix deauth TX when we disconnect

2018-12-03 Thread Emmanuel Grumbach
The iTXQs stop/wake queue mechanism involves a whole bunch of locks and this is probably why the call to ieee80211_wake_txqs is deferred to a tasklet when called from __ieee80211_wake_queue. Another advantage of that is that ieee80211_wake_txqs might call the wake_tx_queue() callback and then the

[PATCH] mac80211: ignore NullFunc frames in the duplicate detection

2018-12-03 Thread Emmanuel Grumbach
NullFunc packets should never be duplicate just like QoS-NullFunc packets. We saw a client that enters / exits power save with NullFunc frames (and not with QoS-NullFunc) despite the fact that the association supports HT. This specific client also re-uses a non-zero sequence number for different

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-12-03 Thread Johannes Berg
Hi Toke, all, Sorry I wasn't around for the discussion, I've been travelling and sick. I'm picking this as an arbitrary point in the discussion to reply to, hope you don't feel bad about that. >> [A-MPDU reordering] > In principle, all of this could be done. But we need to think carefully >

Re: mac80211_hwsim : unsigned int for signal in netlink info frames

2018-12-03 Thread Johannes Berg
On Mon, 2018-11-26 at 17:07 +0100, Benjamin Beichler wrote: > I'm working on my code base and I was surprised by the fact, that the > type of the received signal strength for frames received via Netlink is > u32, but the actual struct ieee80211_rx_status.signal uses an s8 for signal. > > I

Re: Issue with STBC capability and forcing radio to 1x1 mode.

2018-12-03 Thread Johannes Berg
On Wed, 2018-11-28 at 14:13 -0800, Ben Greear wrote: > Hello, > > I notice some weird things while debugging an issue on a 4.16+ kernel with > ath10k > radio. > > It seems that the 'iw phy info' does not remove the TX-STBC info > when changing the antenna mask _until_ some vdev is brought up. >

[PATCH 2/2] mt76: dma: add rx buffer recycle support

2018-12-03 Thread Lorenzo Bianconi
Add support for recycling rx buffers if they are not forwarded to network stack instead of reallocate them from scratch Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/dma.c | 60 +-- drivers/net/wireless/mediatek/mt76/mt76.h | 3 ++ 2 files changed,

[PATCH 0/2] add rx buffer recycle support to mt76x2e/mt76x0e drivers

2018-12-03 Thread Lorenzo Bianconi
Add the capability to recycle rx buffers if they are not consumed by networking stack. This series is based on 'mt76: add size check for additional rx fragments' series: https://patchwork.kernel.org/patch/10709453/ Lorenzo Bianconi (2): mt76: dma: do not build skb if reported len does not fit

[PATCH 1/2] mt76: dma: do not build skb if reported len does not fit in buf_size

2018-12-03 Thread Lorenzo Bianconi
Precompute data length in order to avoid to allocate the related skb data structure if reported length does not fit in queue buf_size Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/dma.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git

[PATCH 1/3] mt76: add size check for additional rx fragments

2018-12-03 Thread Felix Fietkau
So far the code only validates the buffer size of the first skb. Extend this check to cover additional fragments as well, in case the size is corrupted during a DMA reset. Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/dma.c | 8 1 file changed, 8 insertions(+)

[PATCH 2/3] mt76: throttle transmission of buffered multicast packets

2018-12-03 Thread Felix Fietkau
Avoids drowning out regular transmissions Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/mt76x02_mmio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_mmio.c

[PATCH 3/3] mt76: request tx status for powersave released EOSP packet

2018-12-03 Thread Felix Fietkau
Allows mac80211 to keep track of the service period Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/tx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/tx.c b/drivers/net/wireless/mediatek/mt76/tx.c index

[PATCH v2 05/15] iwlwifi: don't define OTP_LOW_IMAGE_SIZE per family, but per size

2018-12-03 Thread Luca Coelho
From: Luca Coelho Using OTP_LOW_IMAGE_SIZE_FAMILY_8000/9000/22000 only obfuscates the actual values, since these 3 are the same. Redefine the values per size so it's easier to understand and compare the different configurations. Signed-off-by: Luca Coelho --- In v2: fix erroneously commented

Re: [PATCH 05/15] iwlwifi: don't define OTP_LOW_IMAGE_SIZE per family, but per size

2018-12-03 Thread Luciano Coelho
On Thu, 2018-11-29 at 12:01 +0200, Kalle Valo wrote: > Luca Coelho writes: > > > From: Luca Coelho > > > > Using OTP_LOW_IMAGE_SIZE_FAMILY_8000/9000/22000 only obfuscates the > > actual values, since these 3 are the same. Redefine the values per > > size so it's easier to understand and

[PATCH] nl80211/cfg80211: Add support to send tx frames at specified rate

2018-12-03 Thread vamsi krishna
NL80211_CMD_FRAME is used to send frames from userspace. Add support to transmit the frames at a rate specified by userspace when needed. The drivers shall indicate the support to send frames at rate specified by userspace by setting %NL80211_EXT_FEATURE_CMD_FRAME_TXRATE flag in wiphy

Price Inquiry 03-12-2018

2018-12-03 Thread Daniel Murray
Hi,friend, This is Daniel Murray and i am from Sinara Group Co.Ltd in Russia. We are glad to know about your company from the web and we are interested in your products. Could you kindly send us your Latest catalog and price list for our trial order. Best Regards, Daniel Murray Purchasing

[PATCH 28/29] staging: wilc1000: avoid extra buffer copy while connect cfg ops

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Refactor the code to avoid the use of an extra buffer to store the connection related parameter. No need to call cfg80211_disconnected in case of failure to send the wid command to firmware, an error status is directly returned in cfg80211 connect callback. Signed-off-by: Ajay

[PATCH 27/29] staging: wilc1000: handle connect ops callback from cfg80211 context

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Refactor the connect related cfg callback to be called from cfg80211 context. No need to post connect command internally in case scan is in progress instead simply return the error status in connect ops callback. Signed-off-by: Ajay Singh ---

[PATCH 29/29] staging: wilc1000: handle scan operation callback from cfg80211 context

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Refactor code to handle scan operation callback from cfg80211 context. No need to maintain 'scan_attr' struct as the wid command is directly sent to firmware from cfg80211 context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 143

[PATCH 26/29] staging: wilc1000: avoid deferred handling of cfg80211 disconnect callback

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Refactor disconnect operation callback to handle from the cfg80211 context. The reason code is not required to pass as parameter to the function, so remove it. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 39 +++

[PATCH 25/29] staging: wilc1000: handle get_station() ops callback in cfg80211 context

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Refactor code to handle the get_station() callback from cfg80211 context. Provided different API's to fetch the station statistics information in sync or async call. From cfg80211 get_station() ops callback calls the sync version of API. Signed-off-by: Ajay Singh ---

[PATCH 21/29] staging: wilc1000: delete the unused code after code refactor

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh After code refactor some of the macro and variables are not required any more, so deleted the unused code. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 31 --- drivers/staging/wilc1000/host_interface.h | 27

[PATCH 23/29] staging: wilc1000: use correct 'struct remain_ch' variable in scan complete

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Use the correct reference to remain_ch variable in scan complete. Passing 'msg->body.remain_on_ch' to handle_remain_on_chan is not correct. So used the correct reference used to store roc related information during the scan. Signed-off-by: Ajay Singh ---

[PATCH 17/29] staging: wilc1000: refactor wilc_set_operation_mode() to avoid deferred handling

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Avoid handling of WID_CURRENT_CHANNEL wid command in deferred approach. Instead of posting the wid to work queue now handle directly from the caller context. Use structure to fill in the firmware specific format. Signed-off-by: Ajay Singh ---

[PATCH 22/29] staging: wilc1000: refactor wilc_get_mac_address() to avoid deferred handling

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Avoid handling of WID_MAC_ADDR wid command in deferred approach. Instead of posting the wid to workqueue now handle directly from the caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 43 ++-

[PATCH 19/29] staging: wilc1000: refactor wilc_get_inactive_time() to avoid deferred handling

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Avoid handling of inactive time related wid command in deferred manner. Instead of posting the wid to workqueue now handle directly from the caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 91 --- 1 file

[PATCH 15/29] staging: wilc1000: refactor wilc_hif_set_cfg() to avoid deferred handling

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Avoid handling configuration params wid command in deferred approach. Instead of posting to workqueue now handle directly from the caller context. Reduce the size of wid array from 32 to 4 as maximum only 4 wid used at a time. Signed-off-by: Ajay Singh ---

[PATCH 16/29] staging: wilc1000: handle station dump cfg ops from cfg80211 context

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Refactor code to handle dump_station() callback from cfg80211 context. Instead of deferring issue of wid command now send it directly from cfg context. Also making use of wilc_get_rssi() error status in case there is a failure to post the wid command to the firmware.

[PATCH 18/29] staging: wilc1000: refactor wilc_set_wfi_drv_handler() to avoid deferred handling

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Avoid handling of WID_SET_DRV_HANDLER wid command in deferred approach. Instead of posting the wid to work queue now handle directly from the caller context. Remove 'is_sync' parameter from the API as it's not required anymore. Signed-off-by: Ajay Singh ---

[PATCH 20/29] staging: wilc1000: handle key related cfg operation from cfg80211 context

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Refactor add/delete key operation to handle directly from cfg80211 context. Also, avoid an extra copy of the information in hif layer and directly fill the buffer in firmware format. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 691

[PATCH 24/29] staging: wilc1000: handle remain on channel cfg ops from cfg80211 context

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Refactor wilc_remain_on_channel() to handle remain_on_channel callback from cfg80211 context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 36 ++- 1 file changed, 11 insertions(+), 25 deletions(-) diff --git

[PATCH 10/29] staging: wilc1000: use is_zero_ether_addr() API to check mac address

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Use is_zero_ether_addr() API to check if mac address value is zero. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 3 +-- drivers/staging/wilc1000/linux_wlan.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 08/29] staging: wilc1000: use void return for wilc_hif_pack_sta_param()

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Change the return type from u32 to void for wilc_hif_pack_sta_param() as its value is not used. Also remove the use of extra pointer as it's not required now. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 14 -- 1 file changed, 4

[PATCH 13/29] staging: wilc1000: handle mgmt_frame_register ops from cfg82011 context

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Avoid handling of mgmt_frame_register operation callback in a deferred manner. Now set the wid command to firmware directly from caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 70 ++-

[PATCH 02/29] staging: wilc1000: make use of put_unaligned_le32 in handle_set_wfi_drv_handler()

2018-12-02 Thread Ajay.Kathat
From: Ajay Singh Make use of put_unaligned_le32() function to pack the wid command buffer for firmware. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 10 ++ drivers/staging/wilc1000/host_interface.h | 1 - 2 files changed, 2 insertions(+), 9 deletions(-)

  1   2   3   4   5   6   7   8   9   10   >