Re: [Intel-wired-lan] [PATCH v1 1/4] igb: Remove unnecessary include of

On Wed, Jul 25, 2018 at 12:52 PM, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > The igb driver doesn't need anything provided by pci-aspm.h, so remove > the unnecessary include of it. > > Signed-off-by: Bjorn Helgaas Looks good to me. Acked-by: Alexander Duyck > --- &g

Re: How to debug DMAR errors?

On Fri, Apr 14, 2017 at 9:19 AM, Ben Greear <gree...@candelatech.com> wrote: > > > On 04/14/2017 08:45 AM, Alexander Duyck wrote: >> >> On Thu, Apr 13, 2017 at 11:12 AM, Ben Greear <gree...@candelatech.com> >> wrote: >>> >>> Hello, >&

Re: How to debug DMAR errors?

On Thu, Apr 13, 2017 at 11:12 AM, Ben Greear wrote: > Hello, > > I have been seeing a regular occurrence of DMAR errors, looking something > like this when testing my ath10k driver/firmware under some specific loads > (maximum receive of 512 byte frames in AP mode): > >

Re: [PATCH v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

On Fri, May 6, 2016 at 11:01 AM, Larry Finger <larry.fin...@lwfinger.net> wrote: > On 05/06/2016 12:13 PM, Alexander Duyck wrote: >> >> On Fri, May 6, 2016 at 9:33 AM, Wang YanQing <udkni...@gmail.com> wrote: >>> >>> We can't use kfree_skb in irq disabl

Re: [PATCH v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

On Fri, May 6, 2016 at 9:33 AM, Wang YanQing wrote: > We can't use kfree_skb in irq disable context, because spin_lock_irqsave > make sure we are always in irq disable context, use dev_kfree_skb_irq > instead of kfree_skb is better than dev_kfree_skb_any. > > This patch fix

Re: [PATCH net-next 2/2] mac80211: Resolve sk_refcnt/sk_wmem_alloc issue in wifi ack path

On 09/11/2014 02:38 AM, Arend van Spriel wrote: On 09/11/14 09:06, Johannes Berg wrote: On Wed, 2014-09-10 at 18:05 -0400, Alexander Duyck wrote: There is a possible issue with the use, or lack thereof of sk_refcnt and sk_wmem_alloc in the wifi ack status functionality. Specifically

Re: [PATCH net-next 2/2] mac80211: Resolve sk_refcnt/sk_wmem_alloc issue in wifi ack path

On 09/11/2014 12:06 AM, Johannes Berg wrote: On Wed, 2014-09-10 at 18:05 -0400, Alexander Duyck wrote: There is a possible issue with the use, or lack thereof of sk_refcnt and sk_wmem_alloc in the wifi ack status functionality. Specifically if a socket were to request acknowledgements

[PATCH net-next] mac80211: Check correct skb for shared states before freeing original

am updating the code so that if the original is shared we free the original and use the clone. This avoids unnecessary work in the next section where we would be cloning the skb if the original is shared. Signed-off-by: Alexander Duyck alexander.h.du...@intel.com --- net/mac80211/tx.c |2 +- 1

Re: [PATCH net-next] mac80211: Check correct skb for shared states before freeing original

On 09/10/2014 01:33 PM, Johannes Berg wrote: On Wed, 2014-09-10 at 16:06 -0400, Alexander Duyck wrote: The code for cloning the skb for an acknowledgement was checking to see if the cloned skb was shared and if it was it was then freeing the original skb. Since a clone should never really

[PATCH net-next 0/2] Address reference counting issues with sock_queue_err_skb

will not provide an skb to return in the sk_error_queue. --- Alexander Duyck (2): skb: Add documentation for skb_clone_sk mac80211: Resolve sk_refcnt/sk_wmem_alloc issue in wifi ack path net/core/skbuff.c | 18 ++ net/mac80211/tx.c | 15 --- 2 files changed

[PATCH net-next v2 1/2] skb: Add documentation for skb_clone_sk

This change adds some documentation to the call skb_clone_sk. This is meant to help clarify the purpose of the function for other developers. Signed-off-by: Alexander Duyck alexander.h.du...@intel.com --- v2: Updated comments to specifically call out need for sock_hold/sock_put net/core