[PATCH] IW: Zero or Uninitialized value of keylen passing

>From b755c8ee282abbd0008e9e7241c457662c90f2c3 Mon Sep 17 00:00:00 2001 From: Amit Khatri <amit.kha...@samsung.com> Date: Thu, 2 Nov 2017 15:55:16 +0530 Subject: [PATCH] IW: Zero or Uninitialized value of keylen passing In case of hexadeciaml keydata, keylen is not gettig updated an

[PATCH] iw: Null check before accessing n_mcs variable

From: Amit Khatri <amit.kha...@samsung.com> Date: Thu, 24 Aug 2017 00:16:26 -0700 Subject: [PATCH] iw: Null check before accessing n_mcs variable If all cases will fail n_mcs variable fail to get any assignement and remain NULL. so better to check NULL before dereference. Signed-off-by

[PATCH] iw: Fix memory leak if nla_put fails

From 80c956f15edfe4f59a6c13ae8ad08bea0b78aafc Mon Sep 17 00:00:00 2001 From: Amit Khatri <amit.kha...@samsung.com> Date: Sat, 7 Nov 2015 17:00:47 +0530 Subject: [PATCH] Fix memory leak if nla_put fails Signed-off-by: Amit Khatri <amit.kha...@samsung.com> Signed-off-by: Amit Kha

[PATCH V2] iw: Avoid possible memory leak for cb

cb got memory from nl_cb_alloc() but not doing free during error case and use same lable to go out from function. Signed-off-by: Amit Khatri amit.kha...@samsung.com Signed-off-by: Rahul Jain rahul.j...@samsung.com --- iw.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[PATCH 2/3] iw: Avoid NULL attr value to pass in nla_data.

value of attr may be NULL so check before passing to function. Signed-off-by: Amit Khatri amit.kha...@samsung.com Signed-off-by: Rahul Jain rahul.j...@samsung.com --- event.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/event.c b/event.c index 5fb5afc..5d0bfde 100644

[PATCH 1/3] iw: check nlmsg_allocation

In case of memory allocation failure by nlmsg_alloc() cqm will pass to NLA_PUT_U32. it should not happen Signed-off-by: Amit Khatri amit.kha...@samsung.com Signed-off-by: Rahul Jain rahul.j...@samsung.com --- cqm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cqm.c b/cqm.c index

[PATCH 3/3] iw: Avoid possible memory leak for cb

cb got memory from nl_cb_alloc() but not doing free during error case and use same lable to go out from function. Signed-off-by: Amit Khatri amit.kha...@samsung.com Signed-off-by: Rahul Jain rahul.j...@samsung.com --- iw.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH] iw: Static analyser fixes

Hi Johannes, Subject: [PATCH] iw: Static analyser fixes Signed-off-by: Amit Khatri amit.kha...@samsung.com Signed-off-by: Rahul Jain rahul.j...@samsung.com --- cqm.c | 2 ++ event.c | 6 +- iw.c| 2 +- scan.c | 2 ++ 4 files changed, 10 insertions(+), 2 deletions(-) diff --git

Re: Re: [PATCH] iw: Static analyser fixes

hi Julian, I have modified patch according to your suggestion. Subject: [PATCH] iw: Static analyser fixes Signed-off-by: Amit Khatri amit.kha...@samsung.com Signed-off-by: Rahul Jain rahul.j...@samsung.com --- cqm.c | 2 ++ event.c | 4 +++- iw.c| 2 +- scan.c | 2 ++ 4 files changed

[PATCH 1/4] iw:Avoid resource memory leak. free ssids and freqs memory before return

Hi Johannes, Subject: [PATCH 1/4] [iw] Avoid resource memory leak. free ssids and freqs memory before return Signed-off-by: Amit Khatri amit.kha...@samsung.com Signed-off-by: Rahul Jain rahul.j...@samsung.com --- scan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scan.c b/scan.c

[PATCH 2/4] iw: Avoid possible memory leak for cb. cb got memory from nl_cb_alloc() but not doing free

Hi Johannes, Subject: [PATCH 2/4] iw: Avoid possible memory leak for cb. cb got memory from nl_cb_alloc() but not doing free Signed-off-by: Amit Khatri amit.kha...@samsung.com Signed-off-by: Rahul Jain rahul.j...@samsung.com --- iw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 4/4] iw:In case of memory allocation failure by nlmsg_alloc() cqm will pass to NLA_PUT_U32. it should not happen.

Hi Johannes, Subject: [PATCH 4/4] iw:In case of memory allocation failure by nlmsg_alloc() cqm will pass to NLA_PUT_U32. it should not happen. Signed-off-by: Amit Khatri amit.kha...@samsung.com Signed-off-by: Rahul Jain rahul.j...@samsung.com --- cqm.c | 2 ++ 1 file changed, 2 insertions

[PATCH 3/4] iw: Static analyser report that attr may be NULL so either we can remove condition check statement or add goto at end of this function.

Hi Johannes, Subject: [PATCH 3/4] iw: Static analyser report that attr may be NULL so either we can remove condition check statement or add goto at end of this function. Signed-off-by: Amit Khatri amit.kha...@samsung.com Signed-off-by: Rahul Jain rahul.j...@samsung.com --- event.c | 6