Re: [PATCH] iwlwifi: pcie: align licensing to dual GPL/BSD

2018-10-24 Thread Andy Lutomirski
On Wed, Oct 24, 2018 at 12:05 AM Johannes Berg wrote: > > From: Johannes Berg > > These files have a long history of code changes, but analysing > the remaining code leads to having only a few changes that are > not already owned by Intel, notably from > - Andy Lutomirs

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-03 Thread Andy Lutomirski
On Mon, Oct 2, 2017 at 10:26 PM, Herbert Xu wrote: > On Mon, Oct 02, 2017 at 09:18:24PM -0700, Andy Lutomirski wrote: >> > On Oct 2, 2017, at 7:25 PM, Jia-Ju Bai wrote: >> > >> > The SCTP program may sleep under a spinlock, and the function call path is: >> &

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-02 Thread Andy Lutomirski
> On Oct 2, 2017, at 7:25 PM, Jia-Ju Bai wrote: > > The SCTP program may sleep under a spinlock, and the function call path is: > sctp_generate_t3_rtx_event (acquire the spinlock) > sctp_do_sm >sctp_side_effects > sctp_cmd_interpreter >sctp_make_init_ack > sctp_pack_cook

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-13 Thread Andy Lutomirski
On Tue, Dec 13, 2016 at 3:35 AM, Kalle Valo wrote: > Andy Lutomirski writes: > >> Eric Biggers pointed out that the orinoco driver pointed scatterlists >> at the stack. >> >> Fix it by switching from ahash to shash. The result should be >> simpler, fas

[PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-12 Thread Andy Lutomirski
Eric Biggers pointed out that the orinoco driver pointed scatterlists at the stack. Fix it by switching from ahash to shash. The result should be simpler, faster, and more correct. Cc: sta...@vger.kernel.org # 4.9 only Reported-by: Eric Biggers Signed-off-by: Andy Lutomirski --- Compile

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-17 Thread Andy Lutomirski
On Mon, Oct 17, 2016 at 12:37 AM, Ard Biesheuvel wrote: > On 17 October 2016 at 08:28, Johannes Berg wrote: >> On Sat, 2016-10-15 at 18:16 +0100, Ard Biesheuvel wrote: >>> The CCM code goes out of its way to perform the CTR encryption of the >>> MAC using the subordinate CTR driver. To this end,

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Andy Lutomirski
On Oct 13, 2016 6:46 AM, "Johannes Berg" wrote: > > On Thu, 2016-10-13 at 22:42 +0900, Sergey Senozhatsky wrote: > > > > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commi > > > > t/?h=x86/vmap_stack&id=0a39cfa6fbb5d5635c85253cc7d6b44b54822afd > > > > https://git.kernel.org/cgit

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-12 Thread Andy Lutomirski
On Wed, Oct 12, 2016 at 7:22 AM, Johannes Berg wrote: > >> > Can you elaborate on how exactly it kills your system? >> >> the last time I saw it it was a NULL deref at >> ieee80211_aes_ccm_decrypt. > > Hm. I was expecting something within the crypto code would cause the > crash, this seems strange

Re: iwlwifi errors (regression?) on 4.7.0

2016-08-30 Thread Andy Lutomirski
On Thu, Aug 25, 2016 at 12:29 AM, Luca Coelho wrote: > Hi Andy, > > Sorry for the really long delay in replying. :( > > On Sun, 2016-08-07 at 01:54 -0700, Andy Lutomirski wrote: >> My Intel 7265 used to work flawlessly, but for the past week or two >> it >> has se

iwlwifi errors (regression?) on 4.7.0

2016-08-07 Thread Andy Lutomirski
My Intel 7265 used to work flawlessly, but for the past week or two it has seemed to be very unreliable. It's also throwing errors. I see problems on firmware versions 16 and 21, although I haven't gotten the warning and backtrace on firmware 16 yet. I have: iwlwifi :3a:00.0: enabling devic

Invalid SPLX

2015-12-02 Thread Andy Lutomirski
Hi- My laptop has SPLC implemented like this: Name (SPLX, Package (0x04) { Zero, Package (0x03) { 0x8000, 0x8000, 0x8000 }, Package (0x03) {

BCM4350 doesn't resume correctly

2015-11-13 Thread Andy Lutomirski
has irq: 1)! [ 1441.958506] brcmfmac: brcmf_cfg80211_reg_notifier: not a ISO3166 code I assume that's what's causing the problem. Thanks, Andy -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body

iwlwifi/iwlmvm dies on resume when rfkill is set

2015-06-01 Thread Andy Lutomirski
If I switch my laptop into airplane mode (hardware switch) and then suspend and resume, my wireless is dead on resume and it spews all over the kernel log (see below). I can rescue it by switching airplane mode off and then suspending and resuming again. This problem has existed on all kernel ver

Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-06-01 Thread Andy Lutomirski
On Mon, Jun 1, 2015 at 8:50 AM, David Howells wrote: > Andy Lutomirski wrote: > >> > You can also fudge the signature (or a hash) by adding extra data to or >> > modifying the data blob and by switching signature values between signature >> > blobs. >> >

Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-05-29 Thread Andy Lutomirski
On Fri, May 29, 2015 at 5:40 AM, David Howells wrote: > Andy Lutomirski wrote: > >> This is insecure because PKCS#7 authenticated attributes are broken (see >> RFC2315 section 9.4 note 4). You need to either require that everything have >> authenticated attributes or r

Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-05-28 Thread Andy Lutomirski
[resending with further gmane screwups fixed] On 05/28/2015 08:48 AM, David Howells wrote: Modify the sign-file program to take a "-F " parameter. The name is a utf8 string that, if given, is inserted in a PKCS#7 authenticated attribute from where it can be extracted by the kernel. Authenticat

Re: [RFD] linux-firmware key arrangement for firmware signing

2015-05-21 Thread Andy Lutomirski
On Thu, May 21, 2015 at 9:51 AM, Petko Manolov wrote: > On 15-05-21 09:39:50, Andy Lutomirski wrote: >> >> It's also a performance cost because the average user of this signature stuff >> doesn't actually want IMA, and IMA is checking the wrong think anyway. >>

Re: [RFD] linux-firmware key arrangement for firmware signing

2015-05-21 Thread Andy Lutomirski
On Thu, May 21, 2015 at 9:43 AM, Petko Manolov wrote: > On 15-05-21 16:51:49, David Howells wrote: >> >> I do have patches to parse PGP key data and add the public keys found therein >> onto the kernel keyring, but that would mean adding an extra key data parser. > > PGP is widely used so i would

Re: [RFD] linux-firmware key arrangement for firmware signing

2015-05-21 Thread Andy Lutomirski
firmware in the first place. > > > > 3. PKCS#1 v1.5, really? PKCS#1 v1.5 is known to be insecure unless > > > very cafefully validated. For example: > > > > > > https://www.imperialviolet.org/2014/09/26/pkcs1.html > > > > > > Could we please consi