Re: brcmfmac signal/interference issues

On 3/28/2018 8:43 PM, Daniel Drake wrote: On Thu, Mar 8, 2018 at 4:47 AM, Arend van Spriel <arend.vanspr...@broadcom.com> wrote: 43455c0-roml/sdio-ag-ndis-vista-pktfilter-d0c-pno-aoe-p2p-dhdoid-ndoe-gtkoe-mfp-proptxstatus-dmatxrc-keepalive-ap-ampduretry-pclose-txbf Yes, ndis. So no ea

Re: Passing uninitialised local variable

On 3/28/2018 1:20 PM, Himanshu Jha wrote: Hello everyone, You added everyone, but me :-( Not really a problem, but it would help if the driver name was mentioned in the subject. I recently found that a local variable in passed uninitialised to the function at

Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

+ Jithu, Eylon On 3/29/2018 1:16 PM, Johannes Berg wrote: Hi Arend, Picking up a somewhat old thread as I did not see a follow-up on this patch. I got queried about it over here by our FILS team. So what is needed for this patch to pass the bar? That's indeed a bit old :-) + *

Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

Hi Johannes, Picking up a somewhat old thread as I did not see a follow-up on this patch. I got queried about it over here by our FILS team. So what is needed for this patch to pass the bar? On 12/11/2017 12:12 PM, Johannes Berg wrote: On Wed, 2017-10-25 at 14:50 +0530, Vidyullatha

Re: [PATCH v3 2/3] mac80211: limit wmm params to comply with ETSI requirements

On 3/29/2018 10:35 AM, Johannes Berg wrote: On Wed, 2018-03-28 at 10:29 -0700, Peter Oh wrote: + if (sdata->vif.type == NL80211_IFTYPE_AP) + wmm_ac = >wmm_rule->ap[ac]; + else + wmm_ac = >wmm_rule->client[ac]; + qparam->cw_min = max_t(u16,

Re: [RFC 0/4] wireless: Per-sta NoAck and offload support

On 3/28/2018 8:09 AM, vthia...@codeaurora.org wrote: On 2018-03-27 22:18, Steve deRosier wrote: Hi Vasanthakumar, On Tue, Mar 27, 2018 at 1:42 AM, Vasanthakumar Thiagarajan wrote: Adds infrastructure for driver to offload NoAck functionality, driver like ath10k could

Re: [PATCH v7 00/11] EAPoL over NL80211

On 3/27/2018 4:42 PM, Denis Kenzior wrote: Hi Arend, On 03/27/2018 03:03 AM, Arend van Spriel wrote: On 3/26/2018 7:52 PM, Denis Kenzior wrote: The proposed patchset has been tested in a mac80211_hwsim based environment with hostapd and iwd. Hi Denis, Looking pretty good. Do you also have

Re: [PATCH v7 00/11] EAPoL over NL80211

On 3/26/2018 7:52 PM, Denis Kenzior wrote: The proposed patchset has been tested in a mac80211_hwsim based environment with hostapd and iwd. Hi Denis, Looking pretty good. Do you also have hostapd and iwd patches available somewhere. I would like to see if I can get brcmfmac using it.

Re: [PATCH] brcmfmac: add support for BCM4366E chipset

On 3/22/2018 4:58 PM, Dan Haab wrote: From: Dan Haab BCM4366E is a wireless chipset with a BCM43664 ChipCommon. It's supported by the same firmware as 4366c0. Thanks, Dan I have a patch for that queued up already. So let me push that instead. Regards, Arend

Re: AP6335 with mainline kernel

On 3/21/2018 4:38 PM, Vanessa Maegima wrote: Hi Arend, On Sex, 2018-01-19 at 10:02 +0100, Arend van Spriel wrote: On 1/18/2018 12:47 PM, Vanessa Maegima wrote: Hi Arend, On Ter, 2018-01-16 at 21:21 +0100, Arend van Spriel wrote: On 1/15/2018 9:08 PM, Fabio Estevam wrote: Hi Arend

Re: [PATCH 01/12] brcmfmac: do not convert linux error to firmware error string

On 3/16/2018 11:11 AM, Arend van Spriel wrote: > ... Hi Kalle, Just sent a V2 so please drop this series. Regards, Arend

[PATCH V2 08/12] brcmfmac: introduce brcmf_fw_alloc_request() function

com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/firmware.c | 58 ++

[PATCH V2 07/12] brcmfmac: pass struct in brcmf_fw_get_firmwares()

..@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- changelog V2: - brcmf_fw_request_is_valid() can be static (kbuild robot). --- .../broadcom/brcm80211/brcmfmac/firmware.c | 175 ++--- .../broadcom/brcm80211/brcmfmac/

[PATCH V2 10/12] brcmfmac: get rid of brcmf_fw_map_chip_to_name()

The function is no longer used so removing it. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.v

[PATCH V2 04/12] brcmfmac: allocate struct brcmf_pub instance using wiphy_new()

<hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- changelog V2: - keep brcmf_cfg80211_ops static

[PATCH V2 05/12] brcmfmac: use wiphy debugfs dir entry

gt; Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../wireless/broadcom/brcm80211/brcmfmac/bcdc.c| 6 .../wireless/broadcom/brcm80211/brcmfmac/common.c | 5 --- .../wireless/broadcom/brcm80211/brcmfmac/core.c|

[PATCH V2 12/12] brcmfmac: add kerneldoc for struct brcmf_bus::msgbuf

This field did not have kerneldoc description so adding it now. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bu

[PATCH V2 11/12] brcmfmac: get rid of brcmf_fw_get_full_name()

The function was pretty minimal and now it is called only from one place so just get rid of it. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../net/wireless/broadcom/brcm80211/brcmfmac/firmware.c| 14 -- 1 file changed, 4 insertions(+), 10 del

[PATCH V2 06/12] brcmfmac: derive firmware filenames from basename mapping

com.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/firmware.c | 31 ++--- .../broadcom/brcm80211/brcmfmac/firmware.h | 24 ++- .../wireless/broadcom/brcm80211/brcmfmac/pcie.c| 56 - .../wir

[PATCH V2 01/12] brcmfmac: do not convert linux error to firmware error string

<hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.c |

[PATCH V2 02/12] brcmfmac: use brcmf_chip_name() to store name in revinfo

<hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../wireless/broadcom/brcm80211/brcmfmac/chip.c| 9

[PATCH V2 00/12] brcmfmac: data structure and firmware loading rework

-drivers-next repository. Changelog: V2: - fixes for patch 4 and patch 7. Arend van Spriel (12): brcmfmac: do not convert linux error to firmware error string brcmfmac: use brcmf_chip_name() to store name in revinfo brcmfmac: use brcmf_chip_name() for consistency brcmfmac: allocate struct

[PATCH V2 03/12] brcmfmac: use brcmf_chip_name() for consistency

com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 5 ++--- drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 7 +-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/wir

[PATCH V2 09/12] brcmfmac: add extension to .get_fwname() callbacks

adcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../net/wireless/broadcom/brcm80211/brcmfmac/bus.h | 6 +-- .../wireless/broadcom/brcm80211/brcmfmac/common.c | 43 +++--- .../wireless/bro

Re: [PATCH] brcmfmac: Add timestamp to scan results report

On 3/21/2018 11:44 PM, dimitr...@google.com wrote: From 01da9ee11ce6e0973972b2ffd37eef660714f71a Mon Sep 17 00:00:00 2001 From: Dmitry Shmidt Date: Wed, 21 Mar 2018 15:35:45 -0700 Subject: [PATCH] brcmfmac: Add timestamp to scan results report Monotonic time from boot is

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

iption and these do not describe the wifi device. They are applicable to the wifi device because it is a limitation of the host controller and as such should be described in the DT binding of the host controller. Regards, Arend Regards, Alex On 20 March 2018 at 06:16, Arend van Spriel <are

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

make any difference. Are you using some chromebook. I have some lying around here so I could also look into it. What broadcom chipset do you have? Regards, Arend All the best, Alex. On 19 March 2018 at 16:31, Arend van Spriel <arend.vanspr...@broadcom.com> wrote: On 3/19/2018 2:40

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

On 3/19/2018 2:40 AM, Alexey Roslyakov wrote: In case if the host has higher align requirements for SG items, allow setting device-specific aligns for scatterlist items. Signed-off-by: Alexey Roslyakov ---

Re: [PATCH] brcmsmac: allocate ucode with GFP_KERNEL

ind that it's called solely from brcms_request_fw(), and it's obviously outside the lock. Hence we can use GFP_KERNEL there safely for avoiding such allocation errors. Bugzilla: http://bugzilla.suse.com/show_bug.cgi?id=1085174 Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> S

Re: [PATCH] brcmfmac: Add support for getting nvram contents from EFI variables

On 3/14/2018 9:43 AM, Hans de Goede wrote: Hi, On 13-03-18 21:19, Arend van Spriel wrote: On 3/12/2018 10:45 AM, Hans de Goede wrote: Actually had a Sony device with nvram in EFI. Why not just drop this optimization. Ok, do you know if that variable had the same name and guid though

Re: [PATCH 6/6] Update license for brcm firmware

On 3/16/2018 11:06 AM, Chi-Hsien Lin wrote: Upload a Cypress version of below firmware and hence update the license: brcm/brcmfmac43340-sdio.bin brcm/brcmfmac43362-sdio.bin brcm/brcmfmac43430-sdio.bin brcm/brcmfmac4354-sdio.bin brcm/brcmfmac4356-pcie.bin Hi Chi-Hsien, It would be better to

[PATCH 01/12] brcmfmac: do not convert linux error to firmware error string

<hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.c |

[PATCH 08/12] brcmfmac: introduce brcmf_fw_alloc_request() function

com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/firmware.c | 58 ++

[PATCH 04/12] brcmfmac: allocate struct brcmf_pub instance using wiphy_new()

<hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac

[PATCH 00/12] brcmfmac: data structure and firmware loading rework

-drivers-next repository. Arend van Spriel (12): brcmfmac: do not convert linux error to firmware error string brcmfmac: use brcmf_chip_name() to store name in revinfo brcmfmac: use brcmf_chip_name() for consistency brcmfmac: allocate struct brcmf_pub instance using wiphy_new() brcmfmac

[PATCH 05/12] brcmfmac: use wiphy debugfs dir entry

gt; Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../wireless/broadcom/brcm80211/brcmfmac/bcdc.c| 6 .../wireless/broadcom/brcm80211/brcmfmac/common.c | 5 --- .../wireless/broadcom/brcm80211/brcmfmac/core.c|

[PATCH 11/12] brcmfmac: get rid of brcmf_fw_get_full_name()

The function was pretty minimal and now it is called only from one place so just get rid of it. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../net/wireless/broadcom/brcm80211/brcmfmac/firmware.c| 14 -- 1 file changed, 4 insertions(+), 10 del

[PATCH 10/12] brcmfmac: get rid of brcmf_fw_map_chip_to_name()

The function is no longer used so removing it. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.v

[PATCH 02/12] brcmfmac: use brcmf_chip_name() to store name in revinfo

<hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../wireless/broadcom/brcm80211/brcmfmac/chip.c| 9

[PATCH 03/12] brcmfmac: use brcmf_chip_name() for consistency

com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 5 ++--- drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 7 +-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/wir

[PATCH 06/12] brcmfmac: derive firmware filenames from basename mapping

com.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/firmware.c | 31 ++--- .../broadcom/brcm80211/brcmfmac/firmware.h | 24 ++- .../wireless/broadcom/brcm80211/brcmfmac/pcie.c| 56 - .../wir

[PATCH 09/12] brcmfmac: add extension to .get_fwname() callbacks

adcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../net/wireless/broadcom/brcm80211/brcmfmac/bus.h | 6 +-- .../wireless/broadcom/brcm80211/brcmfmac/common.c | 43 +++--- .../wireless/bro

[PATCH 12/12] brcmfmac: add kerneldoc for struct brcmf_bus::msgbuf

This field did not have kerneldoc description so adding it now. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bu

[PATCH 07/12] brcmfmac: pass struct in brcmf_fw_get_firmwares()

..@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/firmware.c | 175 ++--- .../broadcom/brcm80211/brcmfmac/firmware.h | 43 +++-- .../wireless/broadcom/brcm80211/brcmfmac/pcie.c| 38

Re: [PATCH] wireless: brcmfmac: cfg80211: Fix check for ISO3166 code

On 3/15/2018 10:30 AM, Kalle Valo wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: On 3/15/2018 10:15 AM, Kalle Valo wrote: Stefan Wahren <stefan.wah...@i2se.com> writes: The commit "regulatory: add NUL to request alpha2" increases the length of al

Re: [PATCH] wireless: brcmfmac: cfg80211: Fix check for ISO3166 code

On 3/15/2018 10:15 AM, Kalle Valo wrote: Stefan Wahren writes: The commit "regulatory: add NUL to request alpha2" increases the length of alpha2 to 3. This causes a regression on brcmfmac, because brcmf_cfg80211_reg_notifier() expect valid ISO3166 codes in the complete

Re: [PATCH V2] brcmfmac: drop Inter-Access Point Protocol packets by default

risons (check for module param and check for Ethernet packet length) for 99.9% of packets. Its overhead should be very minimal. Hi Rafał, Thanks for this patch. Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- ...

Re: [PATCH] ath9k: introduce endian_check module parameter

+ Martin On 3/14/2018 3:34 PM, Kalle Valo wrote: Bas Vermeulen writes: --- a/drivers/net/wireless/ath/ath9k/init.c +++ b/drivers/net/wireless/ath/ath9k/init.c @@ -67,6 +67,9 @@ static int ath9k_ps_enable; module_param_named(ps_enable, ath9k_ps_enable, int, 0444);

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 3/14/2018 5:10 PM, Kalle Valo wrote: Rafał Miłecki writes: + unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN; +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) #ifndef? I followed what is used in the include/linux/etherdevice.h. Is that a good

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 3/14/2018 4:57 PM, Rafał Miłecki wrote: On 2018-03-14 16:39, Rafał Miłecki wrote: On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki <ra...@milecki.pl> Testing brcmfmac with more recent firmwares resulted in AP inte

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 3/14/2018 3:24 PM, Kalle Valo wrote: +config BRCMFMAC_IAPP >+ bool "Partial support for obsoleted Inter-Access Point Protocol" >+ depends on BRCMFMAC >+ ---help--- >+ Most of Broadcom's firmwares can send 802.11f ADD frame every >+ time new STA connects to the AP interface. Some

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

newly added Kconfig option. Thanks for taking this approach. Looks fine except for (see below) Reviewed-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- drivers/net/wireless/broadcom/brcm80211/Kconfig| 20 +++ ...

Re: [PATCH] firmware: add a function to load optional firmware v2

On 3/13/2018 5:46 PM, Kalle Valo wrote: "Luis R. Rodriguez" writes: On Tue, Mar 13, 2018 at 03:16:34PM +0200, Kalle Valo wrote: "Luis R. Rodriguez" writes: +/** + * request_firmware_optional: - request for an optional fw module + * @firmware_p:

Re: [2/3] mwifiex: support sysfs initiated device coredump

ger a need to initiate it through debugfs remove that code. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> Based on the discussion I assume this is ok to take to w-d-next. If that's not the case, please let me know ASAP. It is up to the mwifiex maintainers to decide, I guess. The A

Re: [PATCH] brcmfmac: Add support for getting nvram contents from EFI variables

On 3/12/2018 10:45 AM, Hans de Goede wrote: Hi, On 12-03-18 09:55, Arend van Spriel wrote: On 3/11/2018 10:47 PM, Hans de Goede wrote: Various models Asus laptops with a SDIO attached brcmfmac wifi chip, store the nvram contents in a special EFI variable. This commit adds support for getting

Re: [2/3] mwifiex: support sysfs initiated device coredump

On 3/13/2018 2:10 PM, Kalle Valo wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: On 3/12/2018 10:41 AM, Kalle Valo wrote: Arend Van Spriel <arend.vanspr...@broadcom.com> wrote: Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it i

Re: Support on vendor id and device id

+ Greg, +wilc1000 maintainers On 3/1/2018 11:10 AM, Harsha Rao wrote: On Wed, Feb 28, 2018 at 3:08 PM, Arend van Spriel <arend.vanspr...@broadcom.com> wrote: On 2/28/2018 12:14 AM, Harsha Rao wrote: My suspicion is that your device, is fundamentally a wilc1000 and that the existing wi

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

On 3/13/2018 8:20 AM, Felix Fietkau wrote: [resent with fixed typo in linux-wireless address] On 2018-02-27 11:08, Rafał Miłecki wrote: I've problem when using OpenWrt/LEDE on a home router with Broadcom's FullMAC WiFi chipset. First of all OpenWrt/LEDE uses bridge interface for LAN network

Re: [2/3] mwifiex: support sysfs initiated device coredump

On 3/12/2018 10:41 AM, Kalle Valo wrote: Arend Van Spriel <arend.vanspr...@broadcom.com> wrote: Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds support for it adding the .c

Re: [PATCH] brcmfmac: Add support for getting nvram contents from EFI variables

On 3/11/2018 10:47 PM, Hans de Goede wrote: Various models Asus laptops with a SDIO attached brcmfmac wifi chip, store the nvram contents in a special EFI variable. This commit adds support for getting nvram directly from this EFI variable, without the user needing to manually copy it. This

Re: [PATCH] firmware: add a function to load optional firmware v2

On 3/11/2018 5:05 PM, Andres Rodriguez wrote: Your patch series then should also have the driver callers who you want to modify to use this new API. Collect from the 802.11 folks the other drivers which I think they wanted changed as well. Arend, Kalle, would love to hear your feedback. I am

Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

On 3/9/2018 1:30 PM, Andreas Christoforou wrote: The kernel would like to have all stack VLA usage removed. I think there was a remark made earlier to give more explanation here. It should explain why we want "VLA on stack" removed. Signed-off-by: Andreas Christoforou

Re: brcmfmac signal/interference issues

On 3/8/2018 4:54 PM, Steve deRosier wrote: On Thu, Mar 8, 2018 at 2:47 AM, Arend van Spriel <arend.vanspr...@broadcom.com> wrote: On 2/23/2018 2:49 PM, Daniel Drake wrote: On Fri, Feb 23, 2018 at 12:54 PM, Arend van Spriel <arend.vanspr...@broadcom.com> wrote: Yup. Windows fi

Re: brcmfmac signal/interference issues

On 2/23/2018 2:49 PM, Daniel Drake wrote: On Fri, Feb 23, 2018 at 12:54 PM, Arend van Spriel <arend.vanspr...@broadcom.com> wrote: Yup. Windows firmware talks NDIS. If you run 'strings 4345r6rtecdc.bin | tail -1' you can see the firmware build target and it likely has 'ndis' in it. Hi

debugfs entries in cfg80211

Hi Johannes, While reworking brcmfmac I stumbled on debugfs code in cfg80211, which creates the debugfs dir for the wiphy instance. It also creates a couple of entries, ie. rts and fragmentation threshold and retry limits. How useful are these as I suspect it is pretty old cruft and iw can

Re: [PATCH 1/2] cfg80211: Add support to enable or disable btcoex

On 3/2/2018 10:59 AM, Marcel Holtmann wrote: Hi Arend, This patch introduces NL80211_CMD_SET_BTCOEX command and NL80211_ATTR_BTCOEX_OP attribute to enable or disable btcoex. What kind of btcoex are we talking about here? Is it signalling between wlan and bt to get access to the shared RF.

Re: [PATCH resend] brcmfmac: p2p and normal ap access are not always possible at the same time

On 3/1/2018 11:37 PM, Hans de Goede wrote: Hi, On 01-03-18 20:54, Arend van Spriel wrote: On 3/1/2018 9:35 AM, Hans de Goede wrote: HI, On 28-02-18 20:43, Arend van Spriel wrote: On 2/28/2018 3:52 PM, Hans de Goede wrote: Hi, On 27-02-18 00:04, Arend van Spriel wrote: On 2/26/2018 12:22

Re: [PATCH 1/2] cfg80211: Add support to enable or disable btcoex

+ Marcel On 3/2/2018 6:14 AM, Kalle Valo wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: On 3/1/2018 6:59 PM, Tamizh chelvam wrote: From: Tamizh chelvam <tami...@codeaurora.org> This patch introduces NL80211_CMD_SET_BTCOEX command and NL80211_ATTR_BTCOEX_

Re: [PATCH resend] brcmfmac: p2p and normal ap access are not always possible at the same time

On 3/1/2018 9:35 AM, Hans de Goede wrote: HI, On 28-02-18 20:43, Arend van Spriel wrote: On 2/28/2018 3:52 PM, Hans de Goede wrote: Hi, On 27-02-18 00:04, Arend van Spriel wrote: On 2/26/2018 12:22 PM, Hans de Goede wrote: Hi, On 26-02-18 12:01, Arend van Spriel wrote: On 2/26/2018 11:29

Re: [PATCH 1/2] cfg80211: Add support to enable or disable btcoex

On 3/1/2018 6:59 PM, Tamizh chelvam wrote: From: Tamizh chelvam This patch introduces NL80211_CMD_SET_BTCOEX command and NL80211_ATTR_BTCOEX_OP attribute to enable or disable btcoex. What kind of btcoex are we talking about here? Is it signalling between wlan and bt

[PATCH for-4.16 V3 2/2] brcmfmac: fix P2P_DEVICE ethernet address generation

Goede <hdego...@redhat.com> Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@bro

[PATCH for-4.16 V3 1/2] brcmfmac: add possibility to obtain firmware error

m i/o errors") Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drive

[PATCH for-4.16 V3 0/2] brcmfmac: small fixes

#170494 Arend van Spriel (2): brcmfmac: add possibility to obtain firmware error brcmfmac: fix P2P_DEVICE ethernet address generation .../wireless/broadcom/brcm80211/brcmfmac/core.h| 2 ++ .../wireless/broadcom/brcm80211/brcmfmac/feature.c | 10 + .../wireless/broadcom/brcm80211

Re: [PATCH resend] brcmfmac: p2p and normal ap access are not always possible at the same time

On 2/28/2018 3:52 PM, Hans de Goede wrote: Hi, On 27-02-18 00:04, Arend van Spriel wrote: On 2/26/2018 12:22 PM, Hans de Goede wrote: Hi, On 26-02-18 12:01, Arend van Spriel wrote: On 2/26/2018 11:29 AM, Hans de Goede wrote: Hi, On 26-02-18 11:22, Arend van Spriel wrote: On 2/25/2018 3

Re: [PATCH] mt7601u: Fix system freeze after resuming from hibernation

On 2/28/2018 7:48 PM, Luis R. Rodriguez wrote: On Wed, Feb 28, 2018 at 08:02:59PM +0200, cantabile wrote: On 27/02/18 22:42, Luis R. Rodriguez wrote: I'd be curious if someone who can trigger the situation can test what happens if you use: diff --git

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

On 2/27/2018 11:14 AM, Rafał Miłecki wrote: Sending with a fixed linux-wireless ML address. Please kindly send your replies using linux-wireless@ On 02/27/2018 11:08 AM, Rafał Miłecki wrote: I've problem when using OpenWrt/LEDE on a home router with Broadcom's FullMAC WiFi chipset. First of

[PATCH for-4.16 V2 2/2] brcmfmac: fix P2P_DEVICE ethernet address generation

-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@bro

[PATCH for-4.16 V2 1/2] brcmfmac: add possibility to obtain firmware error

m i/o errors") Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drive

[PATCH for-4.16 V2 0/2] brcmfmac: small fixes

#170494 Arend van Spriel (2): brcmfmac: add possibility to obtain firmware error brcmfmac: fix P2P_DEVICE ethernet address generation drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.h| 2 ++ drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 10 ++ drivers/net

Re: Support on vendor id and device id

On 2/28/2018 12:14 AM, Harsha Rao wrote: My suspicion is that your device, is fundamentally a wilc1000 and that >>>the existing wilc1000 driver will likely largely work for it and all >>>you really need to do is modify the existing driver to handle the >>>quirks of your particular implementation

Re: [PATCH 1/2] brcmfmac: add possibility to obtain firmware error

On 2/28/2018 12:42 AM, Arend van Spriel wrote: The feature module needs to evaluate the actual firmware error returned upon a control command. This adds a field to struct brcmf_if in which the error code is stored whenever a firmware error occurs. Hi Kalle, Can you drop this one. It was way

[PATCH for-4.16 0/2] brcmfmac: small fixes

#170494 Arend van Spriel (2): brcmfmac: add possibility to obtain firmware error brcmfmac: fix P2P_DEVICE ethernet address generation drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.h| 2 ++ drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 2 +- drivers/net/wireless

[PATCH 2/2] brcmfmac: fix P2P_DEVICE ethernet address generation

-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@bro

[PATCH 1/2] brcmfmac: add possibility to obtain firmware error

-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadco

Re: Support on vendor id and device id

On 2/27/2018 6:34 PM, Steve deRosier wrote: Hi Harsha, Part 2 - the darn cmd-enter shortcut in gmail got me again. Sorry for the premature send. As both Larry and Arend mention, while it's possible to have multiple drivers with the same IDs, for obvious reasons it's not desirable. In theory

Re: Support on vendor id and device id

On 2/27/2018 11:16 AM, Harsha Rao wrote: Hi folks, I am developing a new wifi driver for our sdio based wifi device. I see that SDIO_VENDOR_ID and SDIO_DEVICE_ID for our device (We had bought the SDIO IP from 3rd party) is already been used by some other vendor and its already into staging .

Re: [PATCH resend] brcmfmac: p2p and normal ap access are not always possible at the same time

On 2/26/2018 12:22 PM, Hans de Goede wrote: Hi, On 26-02-18 12:01, Arend van Spriel wrote: On 2/26/2018 11:29 AM, Hans de Goede wrote: Hi, On 26-02-18 11:22, Arend van Spriel wrote: On 2/25/2018 3:52 PM, Hans de Goede wrote: Hi, On 26-05-17 12:57, Hans de Goede wrote: The firmware

Re: [PATCH 2/3] mwifiex: support sysfs initiated device coredump

On 2/26/2018 11:06 PM, Brian Norris wrote: Hi, On Fri, Feb 23, 2018 at 2:51 AM, Johannes Berg <johan...@sipsolutions.net> wrote: On Fri, 2018-02-23 at 11:39 +0100, Arend van Spriel wrote: Well, that depends on the eye of the beholder I guess. From user-space perspective it is asynch

Re: [PATCH] ath9k: break out of irq handler after 5 jiffies

On 2/26/2018 10:39 PM, Ben Greear wrote: On 02/07/2018 07:39 AM, Ben Greear wrote: On 02/07/2018 02:55 AM, Johannes Berg wrote: On Wed, 2018-02-07 at 10:16 +0100, Felix Fietkau wrote: On 2018-02-07 00:05, gree...@candelatech.com wrote: From: Ben Greear In case

Re: [PATCH resend] brcmfmac: p2p and normal ap access are not always possible at the same time

On 2/26/2018 12:22 PM, Hans de Goede wrote: Hi, On 26-02-18 12:01, Arend van Spriel wrote: On 2/26/2018 11:29 AM, Hans de Goede wrote: Hi, On 26-02-18 11:22, Arend van Spriel wrote: On 2/25/2018 3:52 PM, Hans de Goede wrote: Hi, On 26-05-17 12:57, Hans de Goede wrote: The firmware

Re: [PATCH resend] brcmfmac: p2p and normal ap access are not always possible at the same time

On 2/26/2018 11:29 AM, Hans de Goede wrote: Hi, On 26-02-18 11:22, Arend van Spriel wrote: On 2/25/2018 3:52 PM, Hans de Goede wrote: Hi, On 26-05-17 12:57, Hans de Goede wrote: The firmware responding with -EBUSY when trying to add an extra virtual-if is a normal thing, do not print

Re: [PATCH resend] brcmfmac: p2p and normal ap access are not always possible at the same time

On 2/25/2018 3:52 PM, Hans de Goede wrote: Hi, On 26-05-17 12:57, Hans de Goede wrote: The firmware responding with -EBUSY when trying to add an extra virtual-if is a normal thing, do not print an error for this. Signed-off-by: Hans de Goede I'm now seeing this on

Re: [PATCH 2/3] mwifiex: support sysfs initiated device coredump

+ Johannes (for devcoredump documentation question). On 2/22/2018 8:35 PM, Brian Norris wrote: Hi Arend, On Thu, Feb 22, 2018 at 01:17:56PM +0100, Arend van Spriel wrote: On 2/21/2018 11:59 PM, Brian Norris wrote: On Wed, Feb 21, 2018 at 11:50:19AM +0100, Arend van Spriel wrote: Since

Re: brcmfmac signal/interference issues

On 2/23/2018 9:26 AM, Daniel Drake wrote: Hi, On Wed, Feb 21, 2018 at 12:39 PM, Daniel Drake wrote: Thanks for looking into this. Here is the brcmfmac43455-sdio.txt file we are using: https://gist.github.com/dsd/d7ee3caa6dfd77f0bcd16cf272b20298 This is identical to the

Re: [PATCH 2/3] mwifiex: support sysfs initiated device coredump

On 2/21/2018 11:59 PM, Brian Norris wrote: On Wed, Feb 21, 2018 at 11:50:19AM +0100, Arend van Spriel wrote: Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds support for it adding the

Re: [PATCH] cfg80211/nl80211: add DFS offload flag

On 2/21/2018 12:25 PM, Dmitrii Lebed wrote: On 21.02.2018 14:03, Arend van Spriel wrote: On 2/21/2018 11:56 AM, Sergey Matyukevich wrote: From: Dmitry Lebed <dle...@quantenna.com> Add wiphy flag to indicate that HW does all DFS actions by itself. User-space functionality already imple

Re: [PATCH 0/3] Export TXQ parameters and statistics via nl80211

On 2/21/2018 12:00 PM, Toke Høiland-Jørgensen wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: On 2/19/2018 6:02 PM, Toke Høiland-Jørgensen wrote: This series adds TXQ parameters and statistics that were previously only available through debugfs to the nl80211 use

Re: brcmfmac signal/interference issues

On 2/21/2018 10:39 AM, Daniel Drake wrote: Hi Arend, On Wed, Feb 21, 2018 at 12:07 PM, Arend van Spriel <arend.vanspr...@broadcom.com> wrote: On 2/21/2018 9:14 AM, Daniel Drake wrote: Hi, We're working with the Weibu F3C MiniPC which includes BCM43455 SDIO wifi chip 0x004345(1722

Re: [PATCH] cfg80211/nl80211: add DFS offload flag

On 2/21/2018 11:56 AM, Sergey Matyukevich wrote: From: Dmitry Lebed Add wiphy flag to indicate that HW does all DFS actions by itself. User-space functionality already implemented in hostapd using vendor-specific (QCA) OUI to advertise HW support. Need to introduce

[PATCH 2/3] mwifiex: support sysfs initiated device coredump

Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/marvell/mwifiex/debugfs.c | 31 +- drivers/net/wireless/marvell/mwifiex/pcie.c| 19 ++-- drivers/net/wireless/marvell/mwifiex/sdio.c| 13 +++ drivers/net/

<    1   2   3   4   5   6   7   8   9   10   >