On Wed, 11 Jul 2018 14:09:19 +0200
Arnd Bergmann wrote:
> On Wed, Jul 11, 2018 at 1:32 PM, Boris Brezillon
> wrote:
> > On Wed, 11 Jul 2018 13:27:53 +0200
> > Arnd Bergmann wrote:
> >
> >> On Wed, Jul 11, 2018 at 1:16 PM, Boris Brezillon
> >> wr
On Wed, 11 Jul 2018 13:27:53 +0200
Arnd Bergmann wrote:
> On Wed, Jul 11, 2018 at 1:16 PM, Boris Brezillon
> wrote:
> > On Mon, 9 Jul 2018 22:09:25 +0200
> > Boris Brezillon wrote:
> >
> >> It just makes NAND maintainers' life easier by allowing them to
On Mon, 9 Jul 2018 22:09:25 +0200
Boris Brezillon wrote:
> It just makes NAND maintainers' life easier by allowing them to
> compile-test this driver without having ARCH_S3C24XX or ARCH_S3C64XX
> enabled.
>
> We add a dependency on HAS_IOMEM to make sure the driver compile
Hi PrasannaKumar,
On Tue, 10 Jul 2018 22:16:50 +0530
PrasannaKumar Muralidharan wrote:
> Hi Boris,
>
> On 10 July 2018 at 01:39, Boris Brezillon
> wrote:
>
> > This MACH_JZ4780 dependency is taken care of by JZ4780_NEMC, no need
> > to repeat it here.
> >
&
On Mon, 9 Jul 2018 22:35:56 +0200
Arnd Bergmann wrote:
> On Mon, Jul 9, 2018 at 10:09 PM, Boris Brezillon
> wrote:
> > Fixes the following smatch warning:
> >
> > drivers/mtd/nand/raw/sunxi_nand.c:551 sunxi_nfc_read_byte() error:
> > uninitialized symbol '
gen_pool_dma_alloc() return type is void *, while internally, the
memory region exposed by the sram driver has been mapped with
ioremap().
Add a void * to void __iomem * cast to make sparse happy.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/atmel/nand-controller.c | 6 +++---
1
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having ARCH_AT91 enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 3 ++-
1
lace those
by iowrite32be() calls (or just add (__force __u32)), but I don't want
to risk a regression on this driver, so I'm just leaving it for someone
else to fix :P.
Regards,
Boris
Changes in v2:
- Fix a few problems reported by kbuild robots and Stephen Rothwell
Boris Brezillon (24):
When casting a pointer to an unsigned in, uintptr_t should be used to
cope with the pointer size differences between 32-bit and 64-bit
architectures.
This is needed if we want to allow compilation of this driver when
COMPILE_TEST=y.
Reported-by: Stephen Rothwell
Signed-off-by: Boris Brezillon
It just makes maintainers' life easier by allowing them to compile-test
this driver without having FSL_SOC, ARCH_LAYERSCAPE or SOC_LS1021A
enabled.
We also need to add a dependency on HAS_IOMEM to make sure the
driver compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nan
this architecture.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index e01b3da726c0..efc5dcd5135c 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/dr
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having PLAT_SPEAR, ARCH_NOMADIK,
ARCH_U8500 or MACH_U300 enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brez
Include linux/sizes.h instead of asm/sizes.h to make code completely
arch independent.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/orion_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/orion_nand.c
b/drivers/mtd/nand/raw/orion_nand.c
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having MACH_JZ4740 enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 3 ++-
1
This way we will be able to compile the jz4740_nand driver when
COMPILE_TEST=y.
Signed-off-by: Boris Brezillon
---
arch/mips/jz4740/board-qi_lb60.c | 3 ++-
drivers/mtd/nand/raw/jz4740_nand.c| 2 +-
.../mach-jz4740
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having SOC_TX4938 or SOC_TX4939
enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kc
It just makes maintainers' life easier by allowing them to compile-test
this driver without having FSL_SOC, ARCH_LAYERSCAPE or SOC_LS1021A
enabled.
We also need to add a dependency on HAS_IOMEM to make sure the
driver compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/m
This MACH_JZ4780 dependency is taken care of by JZ4780_NEMC, no need
to repeat it here.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having ARCH_SUNXI enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 3 ++-
1
This way we will be able to compile the ndfmc driver when
COMPILE_TEST=y.
Signed-off-by: Boris Brezillon
---
arch/mips/txx9/generic/setup.c | 2 +-
arch/mips/txx9/generic/setup_tx4938.c | 2 +-
arch/mips/txx9/generic
It just makes maintainers' life easier by allowing them to compile-test
this driver without having MACH_JZ4780 enabled.
We also need to add a dependency on HAS_IOMEM to make sure the
driver compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/memory/Kconfig | 3 ++-
1 file chang
The local eccstat_regs variable in fsl_ifc_run_command() is missing an
__iomem specifier, and sparce complains about that.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/fsl_ifc_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw
Fixes the "warning: large integer implicitly truncated to unsigned type
[-Woverflow]" warning when compiled for x86.
This is needed in order to allow compiling this driver when
COMPILE_TEST=y.
Reported-by: Stephen Rothwell
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/su
e fsmc one with FSMC_ to avoid this problem.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/fsmc_nand.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/drivers/mtd/nand/raw/fsmc_nand.c b/drivers/mtd/nand/raw/fsmc_nand.c
index f4
uintptr_t should be used when casting a pointer to an unsigned int so
that the code compiles without warnings even on 64-bit architectures.
This is needed if we want to allow selection of this driver when
COMPILE_TEST=y.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/fsmc_nand.c | 4
uintptr_t should be used when casting a pointer to an unsigned int so
that the code compiles without warnings even on 64-bit architectures.
This is needed if we want to allow selection of this driver when
COMPILE_TEST=y.
Reported-by: Stephen Rothwell
Signed-off-by: Boris Brezillon
---
drivers
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having ARCH_DAVINCI or ARCH_KEYSTONE
enabled.
We also need to add a dependency on HAS_IOMEM to make sure the
driver compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nan
e not defined for this architecture.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index 1488ad0a0199..e01b3da726c0 100644
--- a/drivers/mtd/nan
inappropriate u32 <-> void * conversions (pointers are 64bits
large on x86_64).
Reported-by: Stephen Rothwell
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/davinci_nand.c | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/drivers/mtd/na
Fixes the following smatch warning:
drivers/mtd/nand/raw/sunxi_nand.c:551 sunxi_nfc_read_byte() error:
uninitialized symbol 'ret'.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/sunxi_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mt
On Thu, 5 Jul 2018 11:45:12 +0200
Boris Brezillon wrote:
> It just makes NAND maintainers' life easier by allowing them to
> compile-test this driver without having PLAT_SPEAR, ARCH_NOMADIK,
> ARCH_U8500 or MACH_U300 enabled.
>
> We also need to add a dependency on HAS_IO
On Thu, 5 Jul 2018 11:45:00 +0200
Boris Brezillon wrote:
> It just makes NAND maintainers' life easier by allowing them to
> compile-test this driver without having ARCH_S3C24XX or ARCH_S3C64XX
> enabled.
>
> We also need to add a dependency on HAS_IOMEM to make sure t
On Fri, 06 Jul 2018 17:32:50 +0300
Kalle Valo wrote:
> Boris Brezillon writes:
>
> > This allows us to increase compile-test coverage without having to build
> > a kernel for MIPS. That's particularly interesting for subsystem
> > maintainers that want to test as
+Geert since I have a question for you
On Thu, 5 Jul 2018 11:44:55 +0200
Boris Brezillon wrote:
> Hello,
>
> This is an attempt at adding "depends || COMPILE_TEST" to all NAND
> drivers that have no compile-time dependencies on arch
> features/headers.
>
> Th
Include linux/sizes.h instead of asm/sizes.h to make code completely
arch independent.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/orion_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/orion_nand.c
b/drivers/mtd/nand/raw/orion_nand.c
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having ARCH_OMAP2PLUS or ARCH_KEYSTONE
enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nan
asm/mach/flash.h does not seem to be needed, drop this #include to make
the code completely machine and arch independent and allow one to
compile it when COMPILE_TEST=y.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/mxc_nand.c | 2 --
1 file changed, 2 deletions(-)
diff --git a
It just makes maintainers' life easier by allowing them to compile-test
this driver without having FSL_SOC, ARCH_LAYERSCAPE or SOC_LS1021A
enabled.
We also need to add a dependency on HAS_IOMEM to make sure the
driver compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nan
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having ARCH_AT91 enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 3 ++-
1
It just makes maintainers' life easier by allowing them to compile-test
this driver without having FSL_SOC, ARCH_LAYERSCAPE or SOC_LS1021A
enabled.
We also need to add a dependency on HAS_IOMEM to make sure the
driver compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/m
When COMPILE_TEST is allowed and the platform needs uses the iomem API
we need to add an explicit dependency on HAS_IOMEM to avoid selection
of these drivers when building for an arch that has no iomem support
(this is the case of arch/um).
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having PLAT_ORION enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 3 ++-
1
er is not selected when the arch does not implement IO accessors.
Signed-off-by: Boris Brezillon
---
drivers/bcma/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index cb0f1aad20b7..b9558ff20830 100644
--- a/drivers/bcma/Kc
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having ARCH_W90X900 enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 3 +
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having ARCH_QCOM enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 3 ++-
1
This way we will be able to compile the jz4740_nand driver when
COMPILE_TEST=y.
Signed-off-by: Boris Brezillon
---
arch/mips/jz4740/board-qi_lb60.c | 3 ++-
drivers/mtd/nand/raw/jz4740_nand.c| 2 +-
.../mach-jz4740
This MACH_JZ4780 dependency is taken care of by JZ4780_NEMC, no need
to repeat it here.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having ARCH_MXC enabled.
We also need to add a dependency on HAS_IOMEM to make sure the
driver compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 3 ++-
1
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having MACH_JZ4740 enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 3 ++-
1
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having PLAT_SPEAR, ARCH_NOMADIK,
ARCH_U8500 or MACH_U300 enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brez
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having ARCH_SUNXI enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 3 ++-
1
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having ARCH_DAVINCI or ARCH_KEYSTONE
enabled.
We also need to add a dependency on HAS_IOMEM to make sure the
driver compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nan
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having ARCH_PXA enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 3 ++-
1
It just makes maintainers' life easier by allowing them to compile-test
this driver without having MACH_JZ4780 enabled.
We also need to add a dependency on HAS_IOMEM to make sure the
driver compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/memory/Kconfig | 3 ++-
1 file chang
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having SOC_TX4938 or SOC_TX4939
enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kc
We don't need mach/hardware.h and sm/mach-types.h, and asm/io.h can be
replaced by linux/io.h.
Now that we removed those inclusions, we're ready to allow selection of
this driver when COMPILE_TEST=y.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/sharpsl.c | 5 +
1 file
This way we will be able to compile the ndfmc driver when
COMPILE_TEST=y.
Signed-off-by: Boris Brezillon
---
arch/mips/txx9/generic/setup.c | 2 +-
arch/mips/txx9/generic/setup_tx4938.c | 2 +-
arch/mips/txx9/generic
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having ARCH_S3C24XX or ARCH_S3C64XX
enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nan
It just makes NAND maintainers' life easier by allowing them to
compile-test these drivers without having ARCH_LPC32XX enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfi
It just makes NAND maintainers' life easier by allowing them to
compile-test this driver without having ARM, ARM64 or MIPS enabled.
We also need to add a dependency on HAS_IOMEM to make sure the driver
compiles correctly.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfi
ny problem when compiling, but that might
be because the dependencies were already selected.
I have Question for Geert. I know you worked on HAS_DMA removal when
combined with COMPILE_TEST, do you plan to do something similar with
HAS_IOMEM?
Regards,
Boris
Boris Brezillon (27):
mtd: rawn
The MTD_NAND_GPMI_NAND entry is already defined in an 'if MTD_NAND'
block, no need to add an extra "depends on MTD_NAND".
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/raw/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/r
_nvram_init_from_mem':
> include/linux/bcm47xx_nvram.h:27:10: error: 'ENOTSUPP' undeclared (first use
> in this function)
>
> Clearly we want to include linux/errno.h here.
>
> Signed-off-by: Arnd Bergmann
Acked-by: Boris Brezillon
> ---
> include/linux/bcm47x
ds.
>
> Signed-off-by: Rafał Miłecki
Acked-by: Boris Brezillon
> ---
> Kalle: This is mtd focused patch, so I guess it should go through mtd tree. Do
>you find bcma change important enough to care to Ack it? :)
> ---
> drivers/mtd/devices/bcm47xxsflash
On Fri, 18 Dec 2015 11:38:18 -0800
Brian Norris wrote:
> From: Boris BREZILLON
>
> struct nand_chip now embeds an mtd device. Make use of this mtd instance.
>
> Signed-off-by: Boris Brezillon
> Signed-off-by: Brian Norris
Looks good to me, not we can have both a SoB an
Hi Brian,
On Mon, 14 Dec 2015 09:30:11 -0800
Brian Norris wrote:
> On Mon, Dec 14, 2015 at 06:14:10PM +0100, Boris Brezillon wrote:
> > bcm47xxnflash_remove() is supposed to unregister the NAND device previously
> > registered in bcm47xxnflash_probe(), but the current impl
nfo up a bit,
> since struct bcma_sflash should be using it.
>
> Caught while inspecting other changes being made to this driver. Compile
> tested only.
>
> Signed-off-by: Brian Norris
> Cc: "Rafał Miłecki"
> Cc: linux-wireless@vger.kernel.org
Acked-by: Boris Brezi
struct bcma_nflash, and release the real
NAND device in bcm47xxnflash_remove().
Signed-off-by: Boris Brezillon
Fixes: a5401370c520 ("mtd: prepare place for BCMA NAND flash driver(s)")
Cc: Rafał Miłecki
---
drivers/mtd/nand/bcm47xxnflash/main.c | 7 ---
in
68 matches
Mail list logo