[PATCH 0/3] iwlwifi: cosmetic fixes

2017-10-04 Thread Christoph Böhmwalder
associated `static` keyword * One fix wrapping a macro in curly braces Christoph Böhmwalder (3): wireless: iwlwifi: use bool instead of int wireless: iwlwifi: function definition cosmetic fix wireless: iwlwifi: wrap macro into braces drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2

[PATCH 2/3] wireless: iwlwifi: function definition cosmetic fix

2017-10-04 Thread Christoph Böhmwalder
Separate the function from the previous definition with a newline and put the `static` keyword on the same line, as it just looks nicer. Signed-off-by: Christoph Böhmwalder <christ...@boehmwalder.at> --- drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c | 4 ++-- 1 file changed, 2 insertions

[PATCH 1/3] wireless: iwlwifi: use bool instead of int

2017-10-04 Thread Christoph Böhmwalder
Change a usage of int in a boolean context to use the bool type instead, as it makes the intent of the function clearer and helps clarify its semantics. Also eliminate the if/else and just return the boolean result directly, making the code more readable. Signed-off-by: Christoph Böhmwalder

[PATCH 3/3] wireless: iwlwifi: wrap macro into braces

2017-10-04 Thread Christoph Böhmwalder
Macros should always be wrapped in braces, so fix this instance. Signed-off-by: Christoph Böhmwalder <christ...@boehmwalder.at> --- drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-i

Re: [PATCH] ath9k: fix tx99 potential info leak

2017-09-26 Thread Christoph Böhmwalder
deliberately passing a non-null-terminated string with a specific length. >> Signed-off-by: Miaoqing Pan <miaoq...@codeaurora.org> Reviewed-by: Christoph Böhmwalder <christ...@boehmwalder.at> -- Regards, Christoph signature.asc Description: OpenPGP digital signature

Re: [PATCH] ath9k: fix tx99 potential info leak

2017-09-26 Thread Christoph Böhmwalder
Am 27. September 2017 03:13:34 MESZ schrieb miaoq...@codeaurora.org: >From: Miaoqing Pan > >When the user sets count to zero the string buffer would remain >completely uninitialized which causes the kernel to parse its >own stack data, potentially leading to an info leak.

Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues

2017-09-25 Thread Christoph Böhmwalder
> Why are you already resending this? Sorry, I guess I was too impatient. I also messed up the spelling in a "To:" line and forgot triv...@kernel.org the first time I sent it, so I figured I'd just fix it in a resend. I'll make sure to wait a little longer next time. -- Regards, Christoph

[PATCH RESEND] wireless: iwlwifi: fix minor code style issues

2017-09-25 Thread Christoph Böhmwalder
Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder <christ...@boehmwalder.at> --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 7 --- 1 file chan

[PATCH] wireless: iwlwifi: fix minor code style issues

2017-09-23 Thread Christoph Böhmwalder
Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder <christ...@boehmwalder.at> --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 7 --- 1 file chan