Re: [PATCH 15/21] rt2x00: rt2800lib: hardcode txmixer gain values to zero for RT3883

2019-04-10 Thread Daniel Golle
On Wed, Apr 10, 2019 at 10:22:42AM +0200, Stanislaw Gruszka wrote: > On Tue, Apr 09, 2019 at 05:26:46PM +0200, Tom Psyborg wrote: > > On 09/04/2019, Stanislaw Gruszka wrote: > > > From: Gabor Juhos > > > > > > Signed-off-by: Gabor Juhos > > > Signed-off-by: Stanislaw Gruszka > > > --- > > > dr

Re: [PATCH v2 3/3] rt2x00: do not print error when queue is full

2019-02-09 Thread Daniel Golle
Hi Tom, On Sat, Feb 09, 2019 at 05:29:33PM +0100, Tom Psyborg wrote: > On 09/02/2019, Daniel Golle wrote: > > Hi Tom, > > > > On Sat, Feb 09, 2019 at 01:28:32PM +0100, Tom Psyborg wrote: > >> On 09/02/2019, Stanislaw Gruszka wrote: > >> > On Sat, Feb

Re: [PATCH v2 3/3] rt2x00: do not print error when queue is full

2019-02-09 Thread Daniel Golle
Hi Tom, On Sat, Feb 09, 2019 at 01:28:32PM +0100, Tom Psyborg wrote: > On 09/02/2019, Stanislaw Gruszka wrote: > > On Sat, Feb 09, 2019 at 12:11:03PM +0100, Tom Psyborg wrote: > >> Can you reproduce interface freeze with this patch if you enable debug > >> options to print all dbg messages? > > >

Re: [PATCH v4 4/8] rt2800: fix registers init for MT7620

2018-10-16 Thread Daniel Golle
On Tue, Oct 16, 2018 at 10:11:16AM +0200, Stanislaw Gruszka wrote: > On Fri, Oct 12, 2018 at 12:48:07PM +0200, Tom Psyborg wrote: > > chip version support exist in daniel's tree since a long time ago. so > > don't disable registers initialization but try to upstream his > > changes. > > Where is t

Re: [PATCH 4/4] rt2800: comment and simplify AGC init for RT6352

2018-10-10 Thread Daniel Golle
rent than in vendor driver. > > > > Suggested-by: Daniel Golle > > Signed-off-by: Stanislaw Gruszka > > --- > > drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 9 ++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/driver

Re: [PATCH v3 4/4] rt2800: fix registers init for MT7620

2018-10-10 Thread Daniel Golle
Hi Stanislaw, On Wed, Oct 10, 2018 at 09:14:52AM +0200, Stanislaw Gruszka wrote: > On Wed, Oct 10, 2018 at 01:27:31AM +0200, Tom Psyborg wrote: > > On 09/10/2018, Stanislaw Gruszka wrote: > > > There is dupliceted 'if (rt2x00_rt(rt2x00dev, RT6352))' entry that couses > > > we do not perform prope

Re: [PATCH v3 2/4] rt2x00: remove confusing AGC register

2018-10-09 Thread Daniel Golle
On Tue, Oct 09, 2018 at 02:47:48PM +0200, Stanislaw Gruszka wrote: > Hi > > On Tue, Oct 09, 2018 at 02:27:22PM +0200, Daniel Golle wrote: > > On Tue, Oct 09, 2018 at 01:56:08PM +0200, Gruszka wrote: > > > Register 66 was causing issues on RT6352 if set to the same valu

Re: [PATCH v3 2/4] rt2x00: remove confusing AGC register

2018-10-09 Thread Daniel Golle
Hi Stanislaw, On Tue, Oct 09, 2018 at 01:56:08PM +0200, Gruszka wrote: > Register 66 was causing issues on RT6352 if set to the same value as > in MTK driver. With 1c reg value device was working fine in both HT20 > and HT40 modes. My guess is that this may change once we add proper TSSI which i

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-08-18 Thread Daniel Golle
Error - Dropping > frame due to full tx queue...? > > Hello > > On Thu, Aug 16, 2018 at 12:35:29AM +0200, Daniel Golle wrote: > > Clone the master branch of > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.openwrt.org%2Fopenwrt%2Fstaging%2Fdangol

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-08-15 Thread Daniel Golle
Hi Stanislaw, On Wed, Aug 15, 2018 at 01:40:30PM +0200, Stanislaw Gruszka wrote: > On Mon, May 28, 2018 at 02:50:39PM +0200, Stanislaw Gruszka wrote: > > I have some updates here. > > And now more updates. I have 5 patches to test here: > https://github.com/sgruszka/wireless-drivers-next/commits/

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-05-28 Thread Daniel Golle
Hi! On Mon, May 28, 2018 at 02:50:40PM +0200, Stanislaw Gruszka wrote: > I have some updates here. > > ... > Another issue is that sometimes we do not sent rate probe frames, > I posted fix for that (revert of my older change): > https://marc.info/?l=linux-wireless&m=152750671715369&w=2 > This p

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-03-27 Thread Daniel Golle
Hi Stanislaw, On Tue, Mar 27, 2018 at 07:18:16PM +0200, Stanislaw Gruszka wrote: > On Tue, Mar 27, 2018 at 09:46:36AM +0200, Mathias Kresin wrote: > > > Could you test just RX AMPDU patches, i.e. > > > > > > rt2800_change_rx_ampdu_factor.patch > > > rt2800_change_rx_ampdu_density.patch > > > > >

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-03-01 Thread Daniel Golle
eport to http://rt2x00.serialmonkey.com > > > > On 20 Dec 2017, at 06:00, Daniel Golle wrote: > > > > Hi Jamie, > > > > there was another round of discussion regarding the queue management > > problem and Stanislaw Gruszka (the main rt2x00 maintainer) sugges

Re: [PATCH v2] rt2800: fix TX_PIN_CFG setting for non MT7620 chips

2017-08-25 Thread Daniel Golle
ur > for non MT7620 chips. > > Fixes: 41977e86c984 ("rt2x00: add support for MT7620") > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1480829 > Reported-and-tested-by: Jussi Eloranta > Cc: Daniel Golle > Signed-off-by: Stanislaw Gruszka Acked-by: Daniel

Re: [PATCH] rt2800: fix TX_PIN_CFG setting for non MT7620 chips

2017-08-25 Thread Daniel Golle
Hi Stanislaw, On Fri, Aug 25, 2017 at 01:38:29PM +0200, Stanislaw Gruszka wrote: > Since commit 41977e86c984 ("rt2x00: add support for MT7620") we do not > initialize TX_PIN_CFG setting. This cause breakage at least on some > RT3573 devices. To fix the problem patch restores previous behaviour > f

Re: [PATCH] rt2x00: remove unneccesary code

2017-05-18 Thread Daniel Golle
borg wrote: > Oh, i missed that. It's fine as long as it gets merged in LEDE so it's > ready for upstreaming. > > On 18 May 2017 at 13:27, Daniel Golle wrote: > > > Hi Tom, > > > > thank you for that contribution. > > Code for ePA has not yet

Re: [PATCH] rt2x00: remove unneccesary code

2017-05-18 Thread Daniel Golle
Hi Tom, thank you for that contribution. Code for ePA has not yet been submitted upstream, I wanted to give it some more testing, so it's still a local patch in OpenWrt/LEDE. I'll merge your patch into our local patch-queue and submit it together with the ePA code once it got some more testing. C

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-15 Thread Daniel Golle
n Kconfig instead? > > Please let's not go down that route and make such facilities less > useful due to decreased coverage. Being the one to blame for submitting the patch adding most of the problem's footprint: Arnd's change looks good to me and I believe it should be merged. This is the type of feedback I was hoping for when submitting all the long-forgotten and rotting patches from OpenWrt's mac80211 driver patches! Thanks to Arnd for your efforts! Consider this as Acked-by: Daniel Golle for Arnd's original patch (and for NOT adding 'depends on !KASAN') Cheers Daniel > > Thanks.

[PATCH] rt2800: fix mt7620 E2 channel registers

2017-04-18 Thread Daniel Golle
From: Tomislav Požega update RF register 47 and 54 values according to vendor driver Signed-off-by: Tomislav Požega Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless

[PATCH] rt2800: fix mt7620 vco calibration registers

2017-04-18 Thread Daniel Golle
From: Tomislav Požega Use register values from init LNA function instead of the ones from restore LNA function. Apply register values based on rx path configuration. Signed-off-by: Tomislav Požega Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 6 +++--- 1

[PATCH 2/2] rt2800: do VCO calibration after programming ALC

2017-04-17 Thread Daniel Golle
Somehow AP doesn't come up and the first scan fails if we don't do VCO calibration every time. The vendor driver duplicates the VCO calibration function into the channel switching logic, we can do the same with less duplication. Signed-off-by: Daniel Golle --- drivers/net/wireless/ral

[PATCH 1/2] rt2800: fix LNA gain assignment for MT7620

2017-04-17 Thread Daniel Golle
The base value used for MT7620 differs from Rt5392 which resulted in quite bad RX signal quality. Fix this by using the correct base value as well as the LNA calibration values for HT20. Reported-by: Tom Psyborg Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c

[PATCH v3] rt2x00: reverse external PA capability flag logic

2017-04-10 Thread Daniel Golle
Consequently refer to external PA instead of inverting the logic and use an internal PA capability flag which is a bit confusing. Currently this is used for Rt3352 only, but MT7620A also allows for an external PA which will be supported by a follow up patch. Signed-off-by: Daniel Golle --- v3

[PATCH v2] rt2x00: reverse external PA capability flag logic

2017-04-10 Thread Daniel Golle
Consequently refer to external PA instead of inverting the logic and use an internal PA capability flag which is a bit confusing. Currently this is used for Rt3352 only, but MT7620A also allows for an external PA which will be supported by a follow up patch. Signed-off-by: Daniel Golle --- v2

[PATCH] rt2x00: invert external PA capability flag logic

2017-04-09 Thread Daniel Golle
Consequently refer to external PA instead of inverting the logic and use an internal PA capability flag which is a bit confusing. Currently this is used for Rt3352 only, but MT7620A also allows for an external PA which will be supported by a follow up patch. Signed-off-by: Daniel Golle

[PATCH v3] rt2x00: add support for MT7620

2017-03-20 Thread Daniel Golle
From: Roman Yeryomin Basic support for MT7620 built-in wireless radio was added to OpenWrt in r41441. It has seen some heavy cleaning and refactoring since in order to match the Kernel's code quality standards. Signed-off-by: Roman Yeryomin Signed-off-by: Daniel Golle Acked-by: Stan

Re: mac80211: rt2x00: add support for MT7620

2017-03-18 Thread Daniel Golle
On Thu, Mar 16, 2017 at 08:01:04AM +, Kalle Valo wrote: > Daniel Golle wrote: > > From: Roman Yeryomin > > > > Basic support for MT7620 built-in wireless radio was added to > > OpenWrt in r41441. It has seen some heavy cleaning and refactoring > > since in

Re: [PATCH] mac80211: rt2x00: add support for MT7620

2017-03-11 Thread Daniel Golle
Hi again! On Sat, Mar 11, 2017 at 08:30:23PM +0100, Daniel Golle wrote: > From: Roman Yeryomin > > Basic support for MT7620 built-in wireless radio was added to > OpenWrt in r41441. It has seen some heavy cleaning and refactoring > since in order to match the Kernel's co

[PATCH] mac80211: rt2x00: add support for MT7620

2017-03-11 Thread Daniel Golle
From: Roman Yeryomin Basic support for MT7620 built-in wireless radio was added to OpenWrt in r41441. It has seen some heavy cleaning and refactoring since in order to match the Kernel's code quality standards. Signed-off-by: Roman Yeryomin Signed-off-by: Daniel Golle --- v2: added R

[PATCH] mac80211: rt2x00: add support for MT7620

2017-03-10 Thread Daniel Golle
From: Roman Yeryomin Basic support for MT7620 built-in wireless radio was added to OpenWrt in r41441. It has seen some heavy cleaning and refactoring since in order to match the Kernel's code quality standards. Signed-off-by: Roman Yeryomin Signed-off-by: Daniel Golle --- driver

[PATCH] rt2x00: fix TX_PWR_CFG_4 register definition

2017-03-08 Thread Daniel Golle
Some of the macros used to describe the TX_PWR_CFG_4 register accidentally refer to TX_PWR_CFG_3, probably a copy&paste error. Fix that. Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --g

Re: [PATCH v4 0/3] rt2x00: RT5350 support

2017-01-20 Thread Daniel Golle
mechanism can remain a local patch in our tree until those will no longer be needed. Does everybody agree with this general direction? John, Mathias: Are you going to rework and upstream your work to support loading in-flash EEPROM yourself our would you like me to give it a shot? Cheers Daniel

Re: [PATCH v4 1/3] rt2x00: add copy of clk for soc devices

2017-01-20 Thread Daniel Golle
On Fri, Jan 20, 2017 at 02:28:24PM +0100, Stanislaw Gruszka wrote: > Since clk_get() is not trivial add copy of clk pointer to rt2x00dev > for System On Chip devices and initialize it on probe routine. > > Signed-off-by: Stanislaw Gruszka Acked-by: Daniel Golle

[PATCH v3] rt2x00: rt2800lib: add support for RT3352 with 20MHz crystal

2017-01-19 Thread Daniel Golle
: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 50 +- drivers/net/wireless/ralink/rt2x00/rt2x00.h| 2 ++ 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00

Re: [PATCH v2 13/14] rt2x00: rt2800lib: add support for RT3352 with 20MHz crystal

2017-01-19 Thread Daniel Golle
On Thu, Jan 19, 2017 at 02:30:14PM +0100, Daniel Golle wrote: > Hi Stanislaw, > > On Wed, Jan 18, 2017 at 03:30:02PM +0100, Stanislaw Gruszka wrote: > > On Mon, Jan 16, 2017 at 04:15:56AM +0100, Daniel Golle wrote: > > > Signed-off-by: Gabor Juhos > > &

Re: [PATCH v3] rt2x00: add support for RT5350 WiSoC

2017-01-19 Thread Daniel Golle
On Thu, Jan 19, 2017 at 09:08:34PM +0200, Kalle Valo wrote: > Daniel Golle writes: > > > From: Michel Stempin > > > > Support for the RT5350 WiSoC was added to OpenWrt after having a > > lengthy debate about the legality of the original submission, see > >

[PATCH v3] rt2x00: add support for RT5350 WiSoC

2017-01-19 Thread Daniel Golle
GPL. https://dev.openwrt.org/changeset/36177 Signed-off-by: Serge Vasilugin Tested-by: Michel Stempin Acked-by: John Crispin [dan...@makrotopia.org: added commit message, cleaned up code] Signed-off-by: Daniel Golle --- v2: reordered patches to breakout RT3883 from the original series v3

Re: [PATCH v2 13/14] rt2x00: rt2800lib: add support for RT3352 with 20MHz crystal

2017-01-19 Thread Daniel Golle
Hi Stanislaw, On Wed, Jan 18, 2017 at 03:30:02PM +0100, Stanislaw Gruszka wrote: > On Mon, Jan 16, 2017 at 04:15:56AM +0100, Daniel Golle wrote: > > Signed-off-by: Gabor Juhos > > Signed-off-by: Mathias Kresin > > Signed-off-by: Daniel Golle > > --- > > d

Re: [PATCH v2 09/14] rt2x00: rt2x00pci: set PCI MWI only if supported

2017-01-16 Thread Daniel Golle
On Mon, Jan 16, 2017 at 11:08:57AM +0100, Stanislaw Gruszka wrote: > On Mon, Jan 16, 2017 at 04:06:25AM +0100, Daniel Golle wrote: > > From: Claudio Mignanti > > > > This is needed for devices without support for PCI MWI. See also > > https://dev.openwrt.org/changese

Re: [PATCH v2 14/14] rt2x00: add support for RT5350 WiSoC

2017-01-16 Thread Daniel Golle
On Mon, Jan 16, 2017 at 11:17:44AM +0100, Stanislaw Gruszka wrote: > On Mon, Jan 16, 2017 at 04:17:58AM +0100, Daniel Golle wrote: > > @@ -7131,6 +7236,12 @@ static int rt2800_validate_eeprom(struct rt2x00_dev > > *rt2x00dev) > > rt2x00_set_field16(&word,

[PATCH v2 14/14] rt2x00: add support for RT5350 WiSoC

2017-01-15 Thread Daniel Golle
GPL. https://dev.openwrt.org/changeset/36177 Signed-off-by: Serge Vasilugin Tested-by: Michel Stempin Acked-by: John Crispin [dan...@makrotopia.org: added commit message, fixed code formatting] Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800.h| 1 + drivers/net

[PATCH v2 13/14] rt2x00: rt2800lib: add support for RT3352 with 20MHz crystal

2017-01-15 Thread Daniel Golle
Signed-off-by: Gabor Juhos Signed-off-by: Mathias Kresin Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 50 +- drivers/net/wireless/ralink/rt2x00/rt2x00.h| 2 ++ 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a

[PATCH v2 12/14] rt2x00: rt2800lib: support for for RT3352 with external PA

2017-01-15 Thread Daniel Golle
This is needed for WiFi to work e.g. on DIR-615 rev.H1 which got external RF power amplifiers connected to the WiSoC. Signed-off-by: Daniel Golle Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800.h| 24 drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 76

[PATCH v2 11/14] rt2x00: rt2800lib: fix rf id for RT3352

2017-01-15 Thread Daniel Golle
From: Felix Fietkau Signed-off-by: Felix Fietkau Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index

[PATCH v2 10/14] rt2x00: rt2800lib: correctly set HT20/HT40 filter

2017-01-15 Thread Daniel Golle
From: Serge Vasilugin Simple patch to correct HT20/HT40 filter setting. Tested with Rt3290, Rt3352 and Rt5350 Signed-off-by: Serge Vasilugin Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800.h| 2 ++ drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 13

[PATCH v2 09/14] rt2x00: rt2x00pci: set PCI MWI only if supported

2017-01-15 Thread Daniel Golle
From: Claudio Mignanti This is needed for devices without support for PCI MWI. See also https://dev.openwrt.org/changeset/21850 Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2x00pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ralink

[PATCH v2 08/14] rt2x00: rt2800mmio: add a workaround for spurious TX_FIFO_STATUS interrupts

2017-01-15 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800mmio.c | 72 - drivers/net/wireless/ralink/rt2x00/rt2x00.h | 5 ++ 2 files changed, 65 insertions(+), 12 deletions(-) diff --git a/drivers/net

[PATCH v2 07/14] rt2x00: rt2800lib: fix max supported beacon count for RT3593

2017-01-15 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c

[PATCH v2 06/14] rt2x00: rt2800lib: init additional beacon offset registers

2017-01-15 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800.h| 14 ++ drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 24 2 files changed, 38 insertions(+) diff --git a/drivers/net/wireless

[PATCH v2 05/14] rt2x00: rt2800lib: add hw_beacon_count field to struct rt2800_drv_data

2017-01-15 Thread Daniel Golle
hardcoded value. In order to keep the current behaviour, initialize the new field with the actually used value. Signed-off-by: Gabor Juhos Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4 +++- drivers/net/wireless/ralink/rt2x00/rt2800lib.h | 1 + 2 files

[PATCH v2 04/14] rt2x00: rt2800lib: fix beacon generation on RT3593

2017-01-15 Thread Daniel Golle
unction to return the correct values. Signed-off-by: Gabor Juhos Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800.h| 3 ++ drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 44 ++ 2 files changed, 47 insertions(+) diff --git a/drivers/net/wirel

[PATCH v2 03/14] rt2x00: rt2800: serialize shared memory access

2017-01-15 Thread Daniel Golle
. Serialize all accesses to the shared memory by a mutex, in order to avoid concurrent use of that. Signed-off-by: Gabor Juhos Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 55 - drivers/net/wireless/ralink/rt2x00/rt2800lib.h | 35

[PATCH v2 02/14] rt2x00: rt2800lib: introduce RT2800_HAS_HIGH_SHARED_MEM flag

2017-01-15 Thread Daniel Golle
also be used for other chipsets, but none of those has been tested yet. Signed-off-by: Gabor Juhos Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4 drivers/net/wireless/ralink/rt2x00/rt2800lib.h | 13 + 2 files changed, 17 insertions(+) diff

[PATCH v2 00/14] rt2x00 patches from OpenWrt.org

2017-01-15 Thread Daniel Golle
As requested the original series was devided so that everything except for Rt3883 can go first. What's left are a couple of fixes and as well as added support for some Rt3352 boards as well as the Rt5350 WiSoC. Claudio Mignanti (1): rt2x00: rt2x00pci: set PCI MWI only if supported Daniel

[PATCH v2 01/14] rt2x00: rt2800lib: move rt2800_drv_data declaration into rt2800lib.h

2017-01-15 Thread Daniel Golle
the next patch. Signed-off-by: Gabor Juhos Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800.h| 16 drivers/net/wireless/ralink/rt2x00/rt2800lib.h | 16 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/net

Re: [OpenWrt-Devel] [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

2017-01-13 Thread Daniel Golle
On Fri, Jan 13, 2017 at 05:17:23PM +0100, Daniel Golle wrote: > On Fri, Jan 13, 2017 at 04:59:59PM +0100, Johannes Berg wrote: > > > > > The advantage of pull requests is that author information can be > > > preserved more easily. Running git format-patch re

[PATCH 12/40] rt2x00: rt2800lib: add channel configuration function for RF3853

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos [dan...@makrotopia.org: replaced udelay with usleep_range] --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 208 + 1 file changed, 208 insertions(+) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/n

[PATCH 13/40] rt2x00: rt2800lib: enable RF3853 support

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index eda886648daf..7c5061d5328d 100644 --- a/driv

[PATCH 14/40] rt2x00: rt2800lib: add MAC register initialization for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 7c5061d5328

[PATCH 40/40] rt2x00: correctly set HT20/HT40 filter

2017-01-13 Thread Daniel Golle
From: Serge Vasilugin Simple patch to correct HT20/HT40 switching. Tested with Rt3290, Rt3352 and Rt5350 Signed-off-by: Serge Vasilugin [dan...@makrotopia.org: fixed code and commit message formatting] --- drivers/net/wireless/ralink/rt2x00/rt2800.h| 2 ++ drivers/net/wireless/ralink/rt2x

[PATCH 38/40] rt2x00: add support for RT5350 WiSoC

2017-01-13 Thread Daniel Golle
From: Michel Stempin Support for the RT5350 WiSoC was added to OpenWrt after having a lengthy debate about the legality of the original submission, see https://lists.openwrt.org/pipermail/openwrt-devel/2013-January/018224.html MTK/Ralink Acked replied and says we can merge this patch under the GP

[PATCH 39/40] rt2x00: fix rf id for RT3352

2017-01-13 Thread Daniel Golle
From: Felix Fietkau Signed-off-by: Felix Fietkau --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 5f49117b9035..823bdc1b

[PATCH 37/40] rt2x00: add support for RT3352 with 20MHz crystal

2017-01-13 Thread Daniel Golle
Signed-off-by: Gabor Juhos Signed-off-by: Mathias Kresin Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 50 +- drivers/net/wireless/ralink/rt2x00/rt2x00.h| 2 ++ 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a

[PATCH 36/40] rt2x00: support for for RT3352 with external PA

2017-01-13 Thread Daniel Golle
This is needed for WiFi to work e.g. on DIR-615 rev.H1 which got external RF power amplifiers connected to the WiSoC. Signed-off-by: Daniel Golle Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800.h| 24 drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 77

[PATCH 35/40] rt2x00: rt2x00pci: set PCI MWI only if supported

2017-01-13 Thread Daniel Golle
From: Claudio Mignanti This is needed for devices without support for PCI MWI. See also https://dev.openwrt.org/changeset/21850 Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2x00pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ralink

[PATCH 34/40] rt2x00: rt2800mmio: add a workaround for spurious TX_FIFO_STATUS interrupts

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos [dan...@makrotopia.org: fixed indention] --- drivers/net/wireless/ralink/rt2x00/rt2800mmio.c | 72 - drivers/net/wireless/ralink/rt2x00/rt2x00.h | 5 ++ 2 files changed, 65 insertions(+), 12 deletions(-) diff --git a/dri

[PATCH 33/40] rt2x00: rt2800lib: use high memory for beacons on RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c

[PATCH 32/40] rt2x00: rt2800lib: enable RT2800_HAS_HIGH_SHARED_MEM for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index c8a14eaafd22..55fc3ec4597b

[PATCH 31/40] rt2x00: rt2800lib: fix txpower compensation for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 81368cee6e38..c8a14eaafd22 100644 --- a/d

[PATCH 30/40] rt2x00: rt2800lib: fix EEPROM LNA validation for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index e79714b898b9..81368

[PATCH 28/40] rt2x00: rt2800lib: fix LNA gain configuration for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index bde8177c30c4..da430e30

[PATCH 29/40] rt2x00: rt2800lib: fix VGC setup for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index da430e304d1f..e7

[PATCH 27/40] rt2x00: rt2800lib: fix antenna configuration for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index ba73be7101b7..bde8177c30c4

[PATCH 26/40] rt2x00: rt2800lib: use correct beacon count for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 8f036090f320..ba73be7101b7

[PATCH 23/40] rt2x00: rt2800lib: hardcode txmixer gain values to zero for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 797c60875ac6..e406885a

[PATCH 24/40] rt2x00: rt2800lib: use correct [RT]XWI size for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index e406885a5cc3..1933dc22f1c4 100644 --- a/driv

[PATCH 25/40] rt2x00: rt2800lib: use correct beacon base for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 1933dc22f1c4..8f036090f320

[PATCH 15/40] rt2x00: rt2800soc: fix rt2800soc_disable_radio for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800soc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800soc.c b/drivers/net/wireless/ralink/rt2x00/rt2800soc.c index 871d9d331046..855750

[PATCH 22/40] rt2x00: rt2800lib: use correct txpower calculation function for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 6df2c240d756..797c60875ac6

[PATCH 21/40] rt2x00: rt2800lib: fix txpower_to_dev function for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 62ac5aa0f016..6df2c240

[PATCH 20/40] rt2x00: rt2800lib: add channel configuration code for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 72 -- 1 file changed, 69 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index

[PATCH 19/40] rt2x00: rt2800lib: force rf type to RF3853 on RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index e3b9a97b1fc2..005fd02c0226 100644 --- a/dr

[PATCH 18/40] rt2x00: rt2800lib: use the extended EEPROM map for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 870e2da20d47..e3b9a97b1fc2

[PATCH 16/40] rt2x00: rt2800lib: add BBP register initialization for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 44 ++ 1 file changed, 44 insertions(+) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index cf9a8cfd4fbc..df

[PATCH 17/40] rt2x00: rt2800lib: add RFCSR initialization for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos [dan...@makrotopia.org: use usleep_range instead of msleep, fixed comment] --- drivers/net/wireless/ralink/rt2x00/rt2800.h| 13 +++ drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 141 + 2 files changed, 154 insertions(+

[PATCH 11/40] rt2x00: rt2800lib: enable VCO calibration for RF3853

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index a1f8ca9a788b..15bcad1156d9 100644 --- a/dr

[PATCH 09/40] rt2x00: rt2800lib: enable support for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index ff653f0d43d2..efac8a320054 100644 --- a/driv

[PATCH 10/40] rt2x00: rt2800lib: add rf_vals for RF3853

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800.h| 4 +- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 65 ++ 2 files changed, 68 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800.h b/

[PATCH 08/40] rt2x00: allow to build rt2800soc module for RT3883

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/Kconfig b/drivers/net/wireless/ralink/rt2x00/Kconfig index de62f5dcb62f..3f2651dcbf37 100644 --- a/

[PATCH 07/40] rt2x00: rt2800lib: fix max supported beacon count for RT3593

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 5058494d6c27..ff653f0d43

[PATCH 06/40] rt2x00: rt2800lib: init additional beacon offset registers

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Signed-off-by: Gabor Juhos --- drivers/net/wireless/ralink/rt2x00/rt2800.h| 14 ++ drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 24 2 files changed, 38 insertions(+) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800.h b/drive

[PATCH 05/40] rt2x00: rt2800lib: add hw_beacon_count field to struct rt2800_drv_data

2017-01-13 Thread Daniel Golle
From: Gabor Juhos Some chipsets can handle more than 8 beacons at once. Add a new field to the rt2800_drv_data structure which will hold the number of supported beacons of the given chipset. Update the rt2x00_init_registers function to get the beacon count from the new field instead of using a h

[PATCH 03/40] rt2x00: rt2800: serialize shared memory access

2017-01-13 Thread Daniel Golle
From: Gabor Juhos The shared memory of the rt2800 devices is accessible through the register offset range between 0x4000 and 0x8000. The size of this range is 16KB only and on devices which have more than 16KB of shared memory either the low or the high part of the memory is accessible at a time.

[PATCH 04/40] rt2x00: rt2800lib: fix beacon generation on RT3593

2017-01-13 Thread Daniel Golle
From: Gabor Juhos On the RT3593 chipset, the beacon registers are located in the high 8KB part of the shared memory. The high part of the shared memory is only accessible if it is explicitly selected. Add a helper function in order to be able to control the SHR_MSEL bit in the PBF_SYS_CTRL regis

[PATCH 02/40] rt2x00: rt2800lib: introduce RT2800_HAS_HIGH_SHARED_MEM flag

2017-01-13 Thread Daniel Golle
also be used for other chipsets, but none of those has been tested yet. Signed-off-by: Gabor Juhos Signed-off-by: Daniel Golle --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4 drivers/net/wireless/ralink/rt2x00/rt2800lib.h | 13 + 2 files changed, 17 insertions(+) diff

[PATCH 01/40] rt2x00: rt2800lib: move rt2800_drv_data declaration into rt2800lib.h

2017-01-13 Thread Daniel Golle
From: Gabor Juhos The rt2800_drv_data structure contains driver specific information. Move the declaration into the rt2800lib.h header which is a more logical place for it. Also fix the comment style to avoid checkpatch warning. The patch contains no functional changes, it is in preparation for

[PATCH 00/40] rt2x00 patches form OpenWrt.org

2017-01-13 Thread Daniel Golle
Some of these are fixes, most importantly Serge Vasilugin fixed setting the HT20/HT40 filter which got us much closer to the expected performance when using HT40 modes. There is also a lot of new hardware support added: Gabor Juhos wrote code for the Rt3883 WiSoC. Daniel Golle implemented support

Re: [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

2017-01-13 Thread Daniel Golle
On Fri, Jan 13, 2017 at 04:59:59PM +0100, Johannes Berg wrote: > > > The advantage of pull requests is that author information can be > > preserved more easily. Running git format-patch results in most > > patches > > having wrong SMTP sender information due to the assumption that the > > patch au

Re: [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

2017-01-13 Thread Daniel Golle
Hi Kalle, On Fri, Jan 13, 2017 at 12:46:56PM +0200, Kalle Valo wrote: > Daniel Golle writes: > > ... > > Please review and comment, so we can get those patches merged! > > No pull requests, please. Instead send these as patches, easier to > review and actually also easi

[RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

2017-01-12 Thread Daniel Golle
closer to the expected performance when using HT40 modes. And also a lot of new added hardware support: Gabor Juhos wrote code for Rt3883 WiSoC. Daniel Golle implemented support for Rt3352 by designs with external PA as well as for boards using a 20MHz crystal instead of the usual 40MHz. Serge

  1   2   >