RE: [EXT] [PATCH] cfg80211: initialize on-stack chandefs

2019-09-23 Thread Dedy Lansky
From: Johannes Berg > > --- > net/wireless/nl80211.c | 4 +++- > net/wireless/reg.c | 2 +- > net/wireless/wext-compat.c | 2 +- > 3 files changed, 5 insertions(+), 3 deletions(-) We planned to upload pretty much same fix today. You beat us on this. We thought also to add memset in i

RE: [EXT] [RFC/RFT] cfg80211: decouple us from the RTNL

2019-08-05 Thread Dedy Lansky
From: linux-wireless-ow...@vger.kernel.org On Behalf Of Johannes Berg Sent: Thursday, August 1, 2019 1:09 AM > Fix that by re-adding a mutex to each wiphy/rdev as we had at > some point, so we have locking for the wireless_dev lists and > all the other things in there, and also so that drivers

[PATCH] cfg80211/mac80211: make ieee80211_send_layer2_update a public function

2018-07-29 Thread Dedy Lansky
Make ieee80211_send_layer2_update() a common function so other drivers can re-use it. Add support in wil6210 to send L2UF on behalf of newly associated station by calling the common function. Change-Id: Ic2daa1b8392122931103eb5a963e14f8270818bb Signed-off-by: Dedy Lansky --- drivers/net

[PATCH] cfg80211: fix rcu in cfg80211_unregister_wdev

2018-06-13 Thread Dedy Lansky
wards. From: Dedy Lansky Subject: [PATCH] cfg80211: fix rcu in cfg80211_unregister_wdev Callers of cfg80211_unregister_wdev can free the wdev object immediately after this function returns. This may crash the kernel because this wdev object is still in use by other threads

RE: [PATCH] nl80211: fix nlmsg allocation in cfg80211_ft_event

2018-05-21 Thread Dedy Lansky
> From: linux-wireless-ow...@vger.kernel.org > [mailto:linux-wireless-ow...@vger.kernel.org] On Behalf Of Johannes Berg > > On Thu, 2018-05-17 at 11:43 -0700, Jeff Johnson wrote: > > > > > - msg = nlmsg_new(100 + ft_event->ric_ies_len, GFP_KERNEL); > > > + msg = nlmsg_new(100 + ft_event->ies_len

[PATCH] nl80211: fix nlmsg allocation in cfg80211_ft_event

2018-05-17 Thread Dedy Lansky
From: Dedy Lansky Allocation size of nlmsg in cfg80211_ft_event is based on ric_ies_len and doesn't take into account ies_len. This leads to NL80211_CMD_FT_EVENT message construction failure in case ft_event contains large enough ies buffer. Add ies_len to the nlmsg allocation size. Signe

RE: [PATCH v5] wireless-drivers: Dynamically allocate struct station_info

2018-05-10 Thread Dedy Lansky
Hi Toke, > --- a/drivers/net/wireless/ath/wil6210/wmi.c > +++ b/drivers/net/wireless/ath/wil6210/wmi.c > @@ -824,7 +824,7 @@ static void wmi_evt_connect(struct wil6210_vif *vif, int > id, void *d, int len) > struct wireless_dev *wdev = vif_to_wdev(vif); > struct wmi_connect_event *evt

RE: [PATCH v4] wireless-drivers: Dynamically allocate struct station_info

2018-05-10 Thread Dedy Lansky
Hi Toke, Thanks for taking care of wil6210 part. See comment below. > @@ -824,7 +824,7 @@ static void wmi_evt_connect(struct wil6210_vif *vif, int > id, void *d, int len) > struct wireless_dev *wdev = vif_to_wdev(vif); > struct wmi_connect_event *evt = d; > int ch; /* channel n

RE: wil6210: low level sector API

2018-04-22 Thread Dedy Lansky
> From: linux-wireless-ow...@vger.kernel.org > [mailto:linux-wireless-ow...@vger.kernel.org] On Behalf Of David Dean Zhang > Sent: Wednesday, April 18, 2018 9:01 PM > I updated the firmware and tried to call some low level functions, like > WMI_PRIO_TX_SECTORS_NUMBER_CMDID and WMI_SET_RF_SECTOR

RE: wil6210: low level sector API

2018-03-29 Thread Dedy Lansky
From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless-ow...@vger.kernel.org] On Behalf Of David Dean Sent: Monday, March 26, 2018 9:38 PM > My question is how I can disable TXSS. One way I found in the wmi.h is > setting the number of sectors of TXSS to 0 or 1 > by using > wmi_prio_

[RFC] Add cfg80211/nl80211 support for AP mode 802.11 FT roaming

2017-09-25 Thread Dedy Lansky
From: Dedy Lansky Drivers which have integrated AP SME can use this to communicate with userspace (e.g. hostapd) for the purpose of FT roaming processing. cfg80211 API added for driver to indicate received Authentication and Reassociation frames from the roaming STA. NL80211_CMD_AUTHENTICATE

[PATCH v2 0/2] cfg80211: PBSS Basic Support

2015-02-08 Thread Dedy Lansky
cfg80211: PBSS Basic Support Dedy Lansky (2): cfg80211: add bss_type and privacy arguments in cfg80211_get_bss() cfg80211: add support for connecting to PBSS network type drivers/net/wireless/ath/ath10k/mac.c | 3 +- drivers/net/wireless/ath/ath6kl/cfg80211.c | 9 +-- drivers/net

[PATCH v2 2/2] cfg80211: add support for connecting to PBSS network type

2015-02-08 Thread Dedy Lansky
wdev (conn_bss_type). This field is used later (e.g. in __cfg80211_connect_result) when calling cfg80211_get_bss() for finding the BSS we are connecting to. Signed-off-by: Dedy Lansky --- include/net/cfg80211.h | 2 ++ net/wireless/sme.c | 12 +--- 2 files changed, 11 insertions

[PATCH v2 1/2] cfg80211: add bss_type and privacy arguments in cfg80211_get_bss()

2015-02-08 Thread Dedy Lansky
ed to decouple network type (bss_type) and handle it separately. Remaining bits in "capa_mask" and "capa_val" are used only for PRIVACY matching so replace those two with privacy enum. Signed-off-by: Dedy Lansky --- drivers/net/wireless/ath/ath10k/mac.c | 3 +- dr

RE: [PATCH] nl80211: add new scan flag to indicate P2P search

2015-01-28 Thread Dedy Lansky
Hi Johannes, Following Jouni's comment, would you please re-consider? Thanks, Dedy. From: Jouni Malinen [mailto:j...@w1.fi] Sent: Monday, January 26, 2015 11:58 AM > On Mon, Jan 26, 2015 at 09:27:20AM +0100, Johannes Berg wrote: > > On Sun, 2015-01-25 at 14:30 +0200, Ded

RE: [PATCH] cfg80211: PBSS basic support

2015-01-27 Thread Dedy Lansky
From: Johannes Berg [mailto:johan...@sipsolutions.net] Sent: Tuesday, January 27, 2015 1:01 PM > On Tue, 2015-01-27 at 12:50 +0200, Dedy Lansky wrote: > > > > > @@ -896,6 +949,7 @@ cfg80211_inform_bss_width(struct wiphy *wiphy, > > > >

RE: [PATCH] cfg80211: PBSS basic support

2015-01-27 Thread Dedy Lansky
From: Johannes Berg [mailto:johan...@sipsolutions.net] Sent: Tuesday, January 27, 2015 10:24 AM > On Tue, 2015-01-27 at 09:55 +0200, Dedy Lansky wrote: > > > --- a/include/linux/ieee80211.h > > +++ b/include/linux/ieee80211.h > > @@ -1602,6 +1602,15 @@ enum { > >

[PATCH] cfg80211: PBSS basic support

2015-01-26 Thread Dedy Lansky
would not work due to difference described above. Thus, need to decouple network type and handle it separately. "capa_mask" and "capa_val" are kept for masking common capability bits like PRIVACY. Signed-off-by: Dedy Lansky --- drivers/net/wireless/ath/ath10k/mac.c | 3

[PATCH] nl80211: add new scan flag to indicate P2P search

2015-01-25 Thread Dedy Lansky
search. Signed-off-by: Dedy Lansky --- include/uapi/linux/nl80211.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h index f52797a..d7d07d6 100644 --- a/include/uapi/linux/nl80211.h +++ b/include/uapi/linux/nl80211.h @@ -4383,12