On Thu, Nov 19, 2015 at 11:05:58AM +0900, Glen Lee wrote:
> This patch removes define COMPLEMENT_BOOT in Makefile. The feature was removed
> by the following commit but the define was not removed. So remove completely.
>
> b46d68825c2d3af70ad18b53dfed6516e393b7fa
Please fix this up and resend the
On Thu, Nov 19, 2015 at 03:53:34PM +0900, glen lee wrote:
>
>
> On 2015년 11월 19일 15:23, Dan Carpenter wrote:
> >On Thu, Nov 19, 2015 at 11:06:00AM +0900, Glen Lee wrote:
> >>This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx
> >>since
> >>this name could be confused index of
On Sat, Nov 07, 2015 at 10:43:52AM +0200, Kalle Valo wrote:
> Hi Greg,
>
> writes:
>
> > This is a note to let you know that I've just added the patch titled
> >
> > ath10k: drop probe responses when too many are queued
> >
> > to my staging git tree which can be found at
> > git://git.k
On Sat, Nov 07, 2015 at 03:29:23AM +0530, Punit Vara wrote:
> This patch is to the linux_wlan.c file that fixes declaration of *wilc
> to remove following error while building it.
>
> make drivers/staging/wilc1000/linux_wlan.o
> drivers/staging/wilc1000/linux_wlan.c:1824:24: error: ‘wilc’ undeclar
On Fri, Nov 06, 2015 at 02:45:22PM -0800, Greg KH wrote:
> On Fri, Nov 06, 2015 at 06:39:58PM +0900, Glen Lee wrote:
> > hif_sdio and hif_spi objects are compiled all the time even though one of
> > SPI
> > or SDIO is selected. This patch separates hif_sdio and hif_sp
On Fri, Nov 06, 2015 at 06:39:58PM +0900, Glen Lee wrote:
> hif_sdio and hif_spi objects are compiled all the time even though one of SPI
> or SDIO is selected. This patch separates hif_sdio and hif_spi into different
> modules using ifdef define.
> After rework SPI and SDIO modules with only one h
On Thu, Nov 05, 2015 at 11:22:47AM +0900, glen lee wrote:
>
> On 2015년 11월 05일 05:41, Greg KH wrote:
> >On Thu, Oct 29, 2015 at 12:18:52PM +0900, Glen Lee wrote:
> >>This patch adds new argument wilc to linux_sdio_cmd53 and linux_sdio_cmd52
> >>, and use it instead
On Thu, Nov 05, 2015 at 10:39:59AM +0900, glen lee wrote:
> >>+int wilc_wlan_cfg_set(struct net_device *dev, int start, u32 wid, u8
> >>*buffer,
> >>+ u32 buffer_size, int commit, u32 drvHandler)
> >> {
> >>wilc_wlan_dev_t *p = &g_wlan;
> >>u32 offset;
> >>int ret_size
On Fri, Oct 30, 2015 at 08:17:37AM +0900, Chaehyun Lim wrote:
> This patch changes return type of host_int_del_beacon from s32 to int.
> The result variable gets return value from wilc_mq_send that has return
> type of int. It should be changed return type of this function as well
> as data type of
On Tue, Nov 03, 2015 at 04:20:58PM +0900, Glen Lee wrote:
> This patch changes WID_TYPE with wid_type which is preferred style.
>
> Signed-off-by: Glen Lee
> ---
> drivers/staging/wilc1000/coreconfigurator.h | 2 +-
> drivers/staging/wilc1000/wilc_wlan_if.h | 2 +-
> 2 files changed, 2 inser
On Mon, Nov 02, 2015 at 05:50:44PM +0900, Glen Lee wrote:
> From: Leo Kim
>
> This patch renames pu8IPAddr of fuction Handle_set_IPAddress to ip_addr
> to avoid CamelCase naming convention.
>
> Signed-off-by: Leo Kim
> Signed-off-by: Glen Lee
> ---
> drivers/staging/wilc1000/host_interface.c
On Fri, Oct 30, 2015 at 06:47:10PM +0900, Glen Lee wrote:
> This patch adds new argument net_device and use netdev private data member
> wilc instead of g_linux_wlan, pass dev to the functions also.
>
> Signed-off-by: Glen Lee
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 3 +-
> driver
On Fri, Oct 30, 2015 at 06:47:09PM +0900, Glen Lee wrote:
> Adds argument struct net_device and use netdev private data member wilc
> instead of g_linux_wlan, pass dev to the functions as well.
>
> Signed-off-by: Glen Lee
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 3 ++-
> drivers/sta
On Fri, Oct 30, 2015 at 06:47:08PM +0900, Glen Lee wrote:
> This patch adds new argument struct net_device and pass dev to the function
> as well.
>
> Signed-off-by: Glen Lee
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 3 +-
> drivers/staging/wilc1000/coreconfigurator.h | 3 +-
> d
On Thu, Oct 29, 2015 at 12:18:52PM +0900, Glen Lee wrote:
> This patch adds new argument wilc to linux_sdio_cmd53 and linux_sdio_cmd52
> , and use it instead of g_linux_wlan. Pass wilc to the functions as well.
> The void type wilc will be changed with struct wilc when SDIO and SPI
> modules are re
On Thu, Oct 29, 2015 at 12:18:51PM +0900, Glen Lee wrote:
> This patch rename os_context to wilc because it is used as struct wilc and
> move os_private from struct wilc_wlan_os_context_t to struct wilc_wlan_inp_t.
> Finally, delete wilc_wlan_os_context_t.
>
> Signed-off-by: Glen Lee
> ---
> dri
On Tue, Nov 03, 2015 at 07:05:11PM +0900, Glen Lee wrote:
> The addresses are not properly aglined for using ether_addr_copy function.
> I revert this as author agree to drop this patch.
>
> This reverts commit d4622f68db8095dd54179e3134e97812727f6b89.
> ---
> drivers/staging/wilc1000/coreconfigu
On Wed, Oct 28, 2015 at 04:48:20PM +0900, Glen Lee wrote:
> This patch adds new argument struct net_device *dev and pass argument
> struct net_device to the function.
>
> Signed-off-by: Glen Lee
> ---
> drivers/staging/wilc1000/linux_mon.c | 2 +-
> drivers/staging/wilc1000/wilc_wfi
On Wed, Oct 28, 2015 at 03:59:38PM +0900, Glen Lee wrote:
> From: Leo Kim
>
> This patch renames au8AssociatedBSSID of struct host_if_drv to assoc_bssid
> to avoid CamelCase naming convention.
>
> Signed-off-by: Leo Kim
> Signed-off-by: Glen Lee
> ---
> drivers/staging/wilc1000/host_interface
On Tue, Oct 27, 2015 at 10:51:39PM +0530, Punit Vara wrote:
> This patch is to the host_interface.c that fixes up following
> warning by checkpatch:
>
> -prefer eth_broadcast_addr() over memset()
>
> Signed-off-by: Punit Vara
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file ch
On Tue, Oct 27, 2015 at 01:21:46AM +0530, Punit Vara wrote:
> This patch is to the host_interface.c that fixes up following
> warning by checkpatch.pl:
>
> -Prefer eth_broadcast_addr() over memset()
>
> Signed-off-by: Punit Vara
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file
On Mon, Oct 26, 2015 at 11:08:43AM +0900, glen lee wrote:
>
>
> On 2015년 10월 25일 10:29, Greg KH wrote:
> >On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote:
> >>Use netdev private member wilc instead of g_linux_wlan and Change argument
> >>
On Mon, Oct 26, 2015 at 01:29:42AM +0530, punit vara wrote:
> On Mon, Oct 26, 2015 at 1:01 AM, punit vara wrote:
> > On Mon, Oct 26, 2015 at 12:42 AM, Greg KH
> > wrote:
> >> On Sun, Oct 25, 2015 at 04:01:23AM +0530, Punit Vara wrote:
> >>> This patch is
On Sun, Oct 25, 2015 at 04:01:23AM +0530, Punit Vara wrote:
> This patch is to the wilc_wfi_cfgoperations.c file that fixes up
> following error reported by coccicheck:
>
> ERROR: reference preceded by free on line 1219
>
> For (params->seq_len) <= 0 memory is already freed when
> (params->seq_le
On Sun, Oct 25, 2015 at 04:01:24AM +0530, Punit Vara wrote:
> This is patch to the linux_wlan file that fixes up following error
> reported by coccicheck :
>
> ERROR: test of a variable/field address
>
> Signed-off-by: Punit Vara
> ---
> drivers/staging/wilc1000/linux_wlan.c | 8
> 1 f
On Thu, Oct 22, 2015 at 12:07:36AM +0100, Luis de Bethencourt wrote:
> The driver is using -1 instead of the -ENOMEM defined macro to specify that
> a buffer allocation failed.
>
> Fixes smatch warning and similars:
> drivers/staging/wilc1000/host_interface.c:1782 Handle_Key() warn:
> returning -1
On Wed, Oct 21, 2015 at 12:47:20AM +0200, Arnd Bergmann wrote:
> A number of symbols in the wilc1000 driver are completely unused
> and can be removed.
> This includes two variables that are only written but not read.
>
> Signed-off-by: Arnd Bergmann
Due to other patches that were sent before yo
On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote:
> Use netdev private member wilc instead of g_linux_wlan and Change argument
> wilc
> with dev in the function request_threaded_irq to pass back to handler
> the function isr_uh_routine.
>
> Signed-off-by: Glen Lee
> ---
> drivers/stagin
On Sun, Oct 18, 2015 at 07:58:30PM +0200, Frans van de Wiel wrote:
> The staging driver rtl8712 lacks support for dongles based on sitecom
> WLA2100.
> The current driver doesn't contain the usb id for this device, this patch
> add it.
>
> reported by: Frans van de Wiel
> Signed-off-by: Frans va
On Sun, Oct 18, 2015 at 04:34:51PM +0200, Frans van de Wiel wrote:
> dear sirs, please find attached a patch for the rtl8712 driver (staging)
> The patch add support for sitecom WLA2100, seems this device id is missing.
> Many dongles use it.
>
> Kind regards
> Frans
Can you reformat this in
On Fri, Oct 16, 2015 at 06:22:57PM +0900, Tony Cho wrote:
> From: Glen Lee
>
> This patch adds struct wilc to struct perInterface_wlan_t which is netdev
> private data to access wilc via netdev_priv function and assigns wilc to
> nic->wilc. The global variable wl will be replaced with netdev priv
On Fri, Oct 16, 2015 at 01:37:31PM +0900, Tony Cho wrote:
> From: Leo Kim
>
> This patch renames ssidLen of struct join_bss_param to ssid_len
> to avoid CamelCase naming convention.
>
> Signed-off-by: Leo Kim
> Signed-off-by: Tony Cho
> ---
> drivers/staging/wilc1000/host_interface.c | 4 ++--
On Thu, Oct 15, 2015 at 01:25:16PM +0900, Tony Cho wrote:
> From: Leo Kim
>
> This patch renames variable s32Error to result
> to avoid CamelCase naming convention.
>
> Signed-off-by: Leo Kim
> Signed-off-by: Tony Cho
> ---
> drivers/staging/wilc1000/host_interface.c | 784
> ++--
On Wed, Oct 14, 2015 at 08:46:33PM +0900, Tony Cho wrote:
> This patch changes the type of wilc1000_initialized in the struct wilc from
> int to bool and renames it to the initialized. In addition, the unncessary
> wilc1000_initialized codes are removed in this patch.
because I didn't take the ren
On Wed, Oct 14, 2015 at 08:46:31PM +0900, Tony Cho wrote:
> This patch renames g_linux_wlan to wl.
Why? What's wrong with g_linux_wlan? You will need to delete this
entire variable soon anyway, might as well leave it alone until then.
thanks,
greg k-h
--
To unsubscribe from this list: send the
On Wed, Oct 14, 2015 at 05:52:55PM +0900, Tony Cho wrote:
>
>
> On 2015년 10월 14일 17:32, Mike Rapoport wrote:
> >On Wed, Oct 14, 2015 at 02:55:43PM +0900, Tony Cho wrote:
> >>From: Leo Kim
> >>
> >>This patch removes goto ERRORHANDER and the result variable in wilc_mq_send.
> >>Then, the error ty
On Sat, Oct 10, 2015 at 03:41:54PM +0300, Stanislav Kholmanskikh wrote:
> The config option in the subject may be removed, because,
> indeed, it only serves as the 'n' value for
> CONFIG_WILC1000_PREALLOCATE_AT_LOADING_DRIVER
>
> Signed-off-by: Stanislav Kholmanskikh
> ---
> drivers/staging/wilc
On Thu, Oct 08, 2015 at 09:29:35PM +0300, Stanislav Kholmanskikh wrote:
> Hi!
>
> I noticed that drivers/staging/wilc1000/Kconfic defines:
>
> config WILC1000_DYNAMICALLY_ALLOCATE_MEMROY
> bool "Dynamically allocate memory in real time"
> ---help---
> This choice support
On Thu, Oct 08, 2015 at 06:10:46PM +0900, Tony Cho wrote:
> This patch replaces the variable names of struct host_if_drv used as the
> functions' input parameter, drvHandler and hWFIDrv with hif_drv. In
> addition, the local variable declared in many functions, pstrWFIDrv is
> removed and hif_drv i
On Thu, Oct 08, 2015 at 10:49:08AM +0900, Tony Cho wrote:
> From: Leo Kim
>
> This patch removes typedef from the struct tstrWILC_UsrScanReq with
> related comments and renames it to user_scan_req.
>
> Signed-off-by: Leo Kim
> Signed-off-by: Tony Cho
> ---
> drivers/staging/wilc1000/host_inte
On Tue, Oct 06, 2015 at 06:42:12PM +0900, Tony Cho wrote:
> From: Leo Kim
>
> This patch removes typedef from the struct tstrWID and
> rename it to wid.
>
> Signed-off-by: Leo Kim
> Signed-off-by: Tony Cho
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 2 +-
> drivers/staging/wilc1000
On Mon, Oct 05, 2015 at 07:28:09PM +0900, Tony Cho wrote:
> From: Leo Kim
>
> This patch removes typedef from the struct tstrWILC_WFIDrv and
> rename it to host_if_drv.
> This patch includes the removal of the comment for tstrWILC_WFIDrv as well.
>
> Signed-off-by: Leo Kim
> Signed-off-by: Tony
On Sun, Oct 04, 2015 at 03:37:13PM +0530, Chandra Gorentla wrote:
> On Sun, Oct 04, 2015 at 09:43:35AM +0100, Greg KH wrote:
> > On Sat, Oct 03, 2015 at 02:57:29PM +0530, Chandra S Gorentla wrote:
> > > The spin_lock_irqsave is moved to just beginning of critical section.
> &g
On Sun, Oct 04, 2015 at 12:16:31PM +0300, Dan Carpenter wrote:
> On Sun, Oct 04, 2015 at 09:44:57AM +0100, Greg KH wrote:
> > Aren't you now leaking memory as you aren't freeing pstrMessage and the
> > buffer on the "normal" return path?
>
> It's sup
On Sat, Oct 03, 2015 at 02:57:30PM +0530, Chandra S Gorentla wrote:
> - kfree is being called for the members of the queue without
>de-queuing them; they are just inserted within this function;
>they are supposed to be de-queued and freed in a function
>for receiving the queue items
>
On Sat, Oct 03, 2015 at 02:57:29PM +0530, Chandra S Gorentla wrote:
> The spin_lock_irqsave is moved to just beginning of critical section.
> This change moves a couple of return statements out of the lock.
>
> Signed-off-by: Chandra S Gorentla
> ---
> drivers/staging/wilc1000/wilc_msgqueue.c |
On Fri, Oct 02, 2015 at 09:44:55PM +0900, Chaehyun Lim wrote:
> This patch changes PRINT_ER by pr_err.
> It would be better to use netdev_err, but it cannot use it in this
> function, so just use pr_err.
>
> Signed-off-by: Chaehyun Lim
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
>
On Fri, Oct 02, 2015 at 09:44:52PM +0900, Chaehyun Lim wrote:
> This patch replaces hWFIDrv with wfi_drv that is first argument of
> host_int_set_mac_chnl_num to avoid camelcase.
>
> Signed-off-by: Chaehyun Lim
> ---
> drivers/staging/wilc1000/host_interface.c | 6 +++---
> drivers/staging/wilc1
On Fri, Oct 02, 2015 at 09:44:50PM +0900, Chaehyun Lim wrote:
> This patch replaces PRINT_ER with pr_err.
> It would be better to use netdev_err, but it cannot use it in this
> function, so just use pr_err.
>
> Signed-off-by: Chaehyun Lim
> ---
> drivers/staging/wilc1000/host_interface.c | 4 ++-
On Wed, Sep 30, 2015 at 05:52:14PM +0900, Chaehyun Lim wrote:
> The kbuild test robot reports the following build error for
> openrisc-allmodconfig.
>
> >> drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit
> >> declaration of function 'memset'
>
> The error occurs due to missing a stand
On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote:
> - The message queue is replaced with standard Linux linked list
> - kmem_cache is used for list members
Why?
> - A check for return value of receive method is added
> - GFP_ATOMIC is changed to GFP_KERNEL
Why? Are you sur
On Tue, Sep 29, 2015 at 12:07:43AM +0530, Chandra Gorentla wrote:
> Please do not review this. This is duplicate to -
> [PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove ineffective
> code
I don't understand, you sent 2 2/2 patches, which one do I look at?
Please just resend the w
On Wed, Sep 23, 2015 at 06:03:49PM +0900, Chaehyun Lim wrote:
> This patch removes wilc_platform.h include file in wilc_oswrapper.h
> Because wilc_platform.h have several standard header files so that some
> header file should be included .c file to avoid compilation errors.
>
> Signed-off-by: Cha
and the 4/4 patch does not apply to my tree, please rebase and
resend.
thanks,
greg kh
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Sep 27, 2015 at 01:59:17PM +0530, Pinkesh Jain wrote:
> There were many warnings and error given by checkpatch.pl and most of them
> were
> almost of the same type so i believed a single patch is enough to do the
> cleanup.
>
> 1. Remove errors of the struct declaration (foo*bar to foo *b
On Sun, Sep 20, 2015 at 03:51:18PM +0900, Chaehyun Lim wrote:
> This patch replaces WILC_WFI_set_cqm_rssi_config with
> set_cqm_rssi_config to avoid CamelCase.
>
> Signed-off-by: Chaehyun Lim
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8
> 1 file changed, 4 insertions(+
On Mon, Sep 21, 2015 at 03:20:12PM +0900, Tony Cho wrote:
>
>
> On 2015년 09월 21일 15:07, Greg KH wrote:
> >On Mon, Sep 21, 2015 at 02:54:28PM +0900, Tony Cho wrote:
> >>
> >>On 2015년 09월 21일 11:01, Greg KH wrote:
> >>>On Sun, Sep 20, 2015 at 03:51:15P
On Mon, Sep 21, 2015 at 02:54:28PM +0900, Tony Cho wrote:
>
>
> On 2015년 09월 21일 11:01, Greg KH wrote:
> >On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote:
> >>This patch removes function declaration of WILC_WFI_frame_register in
> >>l
On Mon, Sep 21, 2015 at 09:25:31AM +0900, Chaehyun Lim wrote:
> Most of functions use s32Error variable to check error and return its value.
> This patch replaces s32Error with result to avoid CamelCase.
>
> Signed-off-by: Chaehyun Lim
This doesn't apply at all anymore.
I suggest doing as Julia
On Mon, Sep 21, 2015 at 12:16:31PM +0900, Tony Cho wrote:
> The Linux kernel coding style does not recommend to use typedef for the
> structure. This patch removes typedef from the host_if_msg structure.
>
> Signed-off-by: Tony Cho
> Signed-off-by: Greg Kroah-Hartman
This too is already in my t
On Mon, Sep 21, 2015 at 12:16:30PM +0900, Tony Cho wrote:
> This patch changes the name, tstrHostIFmsg to host_if_msg not to use
> camelcase notation in the Linux.
>
> Signed-off-by: Tony Cho
> Signed-off-by: Greg Kroah-Hartman
Is this already in my tree? Why send it to me again?
confused,
g
On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote:
> This patch removes function declaration of WILC_WFI_frame_register in
> linux_wlan.c file, then adds it in wilc_wfi_cfgoperations.h file.
>
> The compilation warning occurs because it is assigned to incorrect
> pointer type of second
On Sun, Sep 20, 2015 at 03:51:13PM +0900, Chaehyun Lim wrote:
> This patch replaces PRINT_D with netdev_info in wilc_free_wiphy function.
>
> Signed-off-by: Chaehyun Lim
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> dif
On Sun, Sep 20, 2015 at 03:51:17PM +0900, Chaehyun Lim wrote:
> This patch replaces WILC_WFI_set_power_mgmt with set_power_mgmt to avoid
> CamelCase.
>
> Signed-off-by: Chaehyun Lim
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8
> 1 file changed, 4 insertions(+), 4 delet
On Sun, Sep 20, 2015 at 03:51:14PM +0900, Chaehyun Lim wrote:
> This patch replaces PRINT_D with netdev_err which is used at error
> checking.
>
> Signed-off-by: Chaehyun Lim
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote:
> This patch removes function declaration of WILC_WFI_frame_register in
> linux_wlan.c file, then adds it in wilc_wfi_cfgoperations.h file.
>
> The compilation warning occurs because it is assigned to incorrect
> pointer type of second
On Fri, Sep 18, 2015 at 06:11:05PM +0900, Tony Cho wrote:
> This patch changes the name, strHostIFmsg simply to msg because the
> camelcase notation is not recommended in Linux.
>
> Signed-off-by: Tony Cho
Because of the other patches I didn't accept, and I think because of
patches that communit
On Thu, Sep 17, 2015 at 07:02:17PM +0900, Tony Cho wrote:
> From: Leo Kim
>
> This patch removes the potential faults which may happen when unexpectedly
> getting access to invalid pointer. The pointer of pstrWFIDrv is unlikely
> to be invalid. However, it is safer to return error when the invali
On Thu, Sep 17, 2015 at 07:02:18PM +0900, Tony Cho wrote:
> From: Leo Kim
>
> This patch removes the warnings reported by checkpatch.pl
> for using multiple blank lines.
>
> Signed-off-by: Leo Kim
> Signed-off-by: Tony Cho
> ---
> drivers/staging/wilc1000/wilc_wlan_if.h | 12
> 1
On Thu, Sep 17, 2015 at 09:03:14PM +0900, Chaehyun Lim wrote:
> On Thu, Sep 17, 2015 at 7:34 PM, Sudip Mukherjee
> wrote:
> > On Thu, Sep 17, 2015 at 04:48:44PM +0900, Chaehyun Lim wrote:
> >> This patch replaces int8_t with int. just use return type as int.
> >>
> >> Signed-off-by: Chaehyun Lim
On Thu, Sep 17, 2015 at 12:12:50AM +0530, Aparna Karuthodi wrote:
> Added spaces around '=' to remove coding style errors detected by
> checkpatch.The errors are given below:
> drivers/staging/wilc1000/host_interface.c:7951: ERROR: spaces required
> around that '=' (ctx:VxV)
> drivers/staging/wilc1
On Wed, Sep 16, 2015 at 05:42:42PM +0530, Aparna Karuthodi wrote:
> Added new lines after declarations for removing coding style warnings
> detected by checkpatch.The warnings are given below:
>
> 1561: WARNING: Missing a blank line after declarations
> 1551: WARNING: Missing a blank line after de
On Wed, Sep 16, 2015 at 08:11:28PM +0900, Chaehyun Lim wrote:
> This patch removes INLINE macro that is used anymore.
>
> Signed-off-by: Chaehyun Lim
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 1 -
> drivers/staging/wilc1000/wilc_wlan.c| 1 -
> 2 files changed, 2 deletions(-)
On Thu, Sep 17, 2015 at 08:28:52AM +0530, roni wrote:
> Sorry for the ambiguity.
> I am talking about my second patch in the series.
> https://lkml.org/lkml/2015/9/15/293
>
> > > None of the line edited in first patch haven't changed after that.
>
> You applied the version 1 of the first patch in
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Sep 17, 2015 at 07:13:39AM +0530, Ronit Halder wrote:
> Why not the second one?
Second what?
> None of the line edited in first patch haven't changed after that.
I don't understand what you
On Tue, Sep 15, 2015 at 03:04:58PM +0530, Ronit Halder wrote:
> This patch fixes the warning generated by sparse
> "Using plain integer as NULL pointer" by using NULL
> instead of zero.
>
> Signed-off-by: Ronit halder
> ---
>
> v2: added a new patch in this patch series to fix the NULL compariso
On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote:
>
>
> On 2015년 09월 15일 16:13, Sudip Mukherjee wrote:
> >On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
> >>From: Glen Lee
> >>
> >>g_num_total_switches is never used so just delete it.
> >>
> >>Signed-off-by: Glen Lee
> >>Sign
On Tue, Sep 15, 2015 at 11:53:36AM +0900, Tony Cho wrote:
> From: Leo Kim
>
> This patch removes the definition WILC_NULLCHECK which is not used anymore.
No, it is used, you just remove all usages of it in this patch as well
:)
Also, your fixes are not correct, you are not keeping the same code
On Tue, Sep 15, 2015 at 10:17:41AM +0900, Tony Cho wrote:
> Hi Greg,
>
> I am sorry but please ignore this patch in this time.
It's already in my tree, right? I can revert it if you want me to, but
I can't ignore it anymore, sorry.
greg k-h
--
To unsubscribe from this list: send the line "unsub
On Mon, Sep 14, 2015 at 12:24:29PM +0900, Chaehyun Lim wrote:
> This patch replaces WILC_WFI_frame_register with mgmt_frame_register to
> avoid CamelCase.
>
> Signed-off-by: Chaehyun Lim
> ---
> V3: remove "wilc_" prefix
>
> drivers/staging/wilc1000/linux_wlan.c | 12 ++--
>
On Sun, Sep 13, 2015 at 04:31:33PM +0530, Aparna Karuthodi wrote:
> Added a new line after declaration to remove a coding style warning
> detected by checkpatch. The warning is given below
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Aparna Karuthodi
> ---
> drivers/stag
On Mon, Sep 14, 2015 at 10:29:26AM +0900, Tony Cho wrote:
>
>
> On 2015년 09월 12일 11:35, Greg KH wrote:
> >On Fri, Sep 11, 2015 at 12:04:19PM +0900, Tony Cho wrote:
> >>From: Glen Lee
> >>
> >>This patch removes a unused enum tenuFrameClass.
> >
On Fri, Sep 11, 2015 at 04:14:00AM +0900, Chaehyun Lim wrote:
> This patch replaces WILC_WFI_CfgSetChannel with
> wilc_set_channel to avoid CamelCase.
>
> Signed-off-by: Chaehyun Lim
> ---
> V2: to make function name simple
>
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +-
>
On Fri, Sep 11, 2015 at 12:04:19PM +0900, Tony Cho wrote:
> From: Glen Lee
>
> This patch removes a unused enum tenuFrameClass.
>
> Signed-off-by: Glen Lee
> Signed-off-by: Tony Cho
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 8
> 1 file changed, 8 deletions(-)
I already a
On Thu, Sep 10, 2015 at 11:08:25AM +0900, Tony Cho wrote:
> Hi Greg,
>
> I want to make sure one thing before moving further. Are you saying
> the errorsupport.h file as the os wrapper remaining in the oswrapper.h
> file? If not, can you let me know what you point out as remaining os
> wrapper in
On Wed, Sep 09, 2015 at 12:55:38AM +0900, Chaehyun Lim wrote:
> This patch replaces WILC_WFI_CfgSetChannel with
> wilc_cfg80211_set_monitor_channel to avoid CamelCase.
Like was said, this is now longer, how about something "simple" like
wilc_set_channel()?
Actually, as this is a static function,
On Wed, Sep 09, 2015 at 04:08:10PM +0900, Tony Cho wrote:
> From: Glen Lee
>
> Call kmalloc directly. No need to wrap kmalloc.
> Only one function, wilc_mq_send which use WILC_MALLOC, can be running in
> interrupt context or process context. In this case, We call in_interrupt to
> decide the flag
On Tue, Sep 08, 2015 at 05:07:59PM +0900, Tony Cho wrote:
> From: Johnny Kim
>
> This patch adds new define, IDLE_MODE to change comparison statement which
> is wrong due to typecasting to null.
>
> Signed-off-by: Johnny Kim
> Signed-off-by: Tony Cho
> ---
> drivers/staging/wilc1000/host_inte
On Wed, Sep 09, 2015 at 04:08:12PM +0900, Tony Cho wrote:
> From: Glen Lee
>
> wilc1000 driver runs on Linux. No need to have oswrapper or platform
> dependent files.
> Before delete two header files, move two structures in wilc_platform.h to
> wilc_msgqueue.h where it is used. Include linux head
On Tue, Sep 08, 2015 at 11:23:07AM +0900, Tony Cho wrote:
>
>
> On 2015년 09월 08일 00:36, Chaehyun Lim wrote:
> >This patch use kmalloc with GFP_ATOMIC instead of WILC_MALLOC.
> >It is inside the spin lock region.
> >
> >Signed-off-by: Chaehyun Lim
> >---
> > drivers/staging/wilc1000/wilc_msgqueu
On Fri, Sep 04, 2015 at 03:01:55PM +0900, johnny.kim wrote:
>
>
> On 2015년 09월 04일 12:51, Greg KH wrote:
> >On Fri, Sep 04, 2015 at 12:24:29PM +0900, johnny.kim wrote:
> >>
> >>On 2015년 09월 04일 00:47, Greg KH wrote:
> >>>On Thu, Sep 03, 2015 at 04
On Fri, Sep 04, 2015 at 12:24:29PM +0900, johnny.kim wrote:
>
>
> On 2015년 09월 04일 00:47, Greg KH wrote:
> >On Thu, Sep 03, 2015 at 04:00:08PM +0900, johnny.kim wrote:
> >>Hello Greg.
> >>
> >>On 2015년 09월 03일 10:33, Greg KH wrote:
> >>>On
On Thu, Sep 03, 2015 at 04:00:08PM +0900, johnny.kim wrote:
> Hello Greg.
>
> On 2015년 09월 03일 10:33, Greg KH wrote:
> >On Thu, Aug 20, 2015 at 04:32:52PM +0900, Tony Cho wrote:
> >>From: Johnny Kim
> >>
> >>The driver communicates with the chipset via
On Thu, Aug 20, 2015 at 04:32:52PM +0900, Tony Cho wrote:
> From: Johnny Kim
>
> The driver communicates with the chipset via the address of handlers
> to distinguish async data frame. The SendConfigPkt function gets the
> pointer address indicating the handlers as the last argument, but this
> r
On Wed, Aug 19, 2015 at 06:00:12PM +0530, Chandra Gorentla wrote:
> On Tue, Aug 18, 2015 at 08:01:00PM -0700, Greg KH wrote:
> > On Tue, Aug 18, 2015 at 10:32:17PM +0530, Chandra S Gorentla wrote:
> > > This patch allows setting all options in the module's debug re
On Tue, Aug 18, 2015 at 10:32:17PM +0530, Chandra S Gorentla wrote:
> This patch allows setting all options in the module's debug region
> options file 'wilc_debug_region'. This functionality allows the user
> to enable logging from all regions (initialization, locks, firmware
> etc.) of the drive
On Mon, Aug 17, 2015 at 10:44:31PM +0900, Chaehyun Lim wrote:
> This patch uses -EINVAL for invalid argument checking instead of using
> WILC_ERRORREPORT with WILC_INVALID_ARGUMENT.
>
> Signed-off-by: Chaehyun Lim
> ---
> drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
> 1 file changed, 2 ins
On Mon, Aug 17, 2015 at 10:44:29PM +0900, Chaehyun Lim wrote:
> The macros inside wilc_osconfig.h are not referenced anywhere,
> so just delete it.
>
> Signed-off-by: Chaehyun Lim
And I did this one also, again, sorry, I hadn't seen your email yet.
greg k-h
--
To unsubscribe from this list: sen
On Mon, Aug 17, 2015 at 10:44:28PM +0900, Chaehyun Lim wrote:
> The macros in wilc_log.h are not referenced anywhere, so just delete it.
Oops, I just did this same thing before I saw your email, sorry about
that.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless
On Fri, Aug 14, 2015 at 10:50:07PM +0530, Chandra S Gorentla wrote:
> This patch enables setting the module's debug options WARN and INFO in the
> debugfs file 'wilc_debug_level'. This enables the user to enable logging
> of warning and other information. Before this change writes to this
> debug
201 - 300 of 389 matches
Mail list logo
