Re: [PATCH 1/4] staging: wilc1000: modify data type

2015-06-10 Thread Greg KH
On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote: -static int wilc_wlan_cfg_commit(int type, uint32_t drvHandler) +static int wilc_wlan_cfg_commit(int type, size_t drvHandler) Shouldn't this just be a void *? And if so, why not the real function pointer instead? Also, lots of these

Re: [PATCH 3/4] staging: wilc1000: modify printk format

2015-06-10 Thread Greg KH
On Wed, Jun 10, 2015 at 05:06:46PM +0900, Johnny Kim wrote: This remove compile warnings about printk format. Signed-off-by: Johnny Kim johnny@atmel.com --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/linux_wlan.c | 2 +-

Re: [PATCH] staging: wilc1000: modify odd print message

2015-06-10 Thread Greg KH
On Thu, Jun 11, 2015 at 12:44:24PM +0900, Dean Lee wrote: This driver has odd message in print string. So this patch removes the data type. Signed-off-by: Dean Lee dean@atmel.com --- drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH v4 2/2] staging: wilc1000: Align enum members in coreconfigurator

2015-06-09 Thread Greg KH
On Mon, Jun 08, 2015 at 11:54:29PM +0300, Stanislav Kholmanskikh wrote: Aligned enum members to follow a common style per enum. You also reformatted defines, which you didn't mention here :( -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to

Re: [PATCH v4 1/2] staging: wilc1000: Cleanup to coreconfigurator

2015-06-09 Thread Greg KH
On Mon, Jun 08, 2015 at 11:54:28PM +0300, Stanislav Kholmanskikh wrote: Fixed the following issues found with checkpatch.pl: * Multiple debug strings contained \n. Changed it to \n. * Changed 'return(X)' to 'return X'. * Aligned TAG_PARAM_OFFSET to fit 80 columns That is 3 different

Re: [PATCH v3 1/2] staging: wilc1000: Cleanup to coreconfigurator

2015-06-08 Thread Greg KH
On Tue, Jun 02, 2015 at 12:55:06PM +0400, Stanislav Kholmanskikh wrote: Fixed several syntax/style issues found with checkpatch.pl. What exactly is several? Please be specific as to what type of changes you are making. Please fix and resend both of these. thanks, greg k-h -- To unsubscribe

Re: [PATCH v2 1/4] staging: wilc1000: Fix some compile time warnings

2015-06-01 Thread Greg KH
On Mon, Jun 01, 2015 at 09:56:18PM +0300, Stanislav Kholmanskikh wrote: Signed-off-by: Stanislav Kholmanskikh kholmanskikh@gmail.com --- Changes since V1: Split the V1 series into more logically unrelated patches and updated patch descriptions accordingly. This series doesn't apply on

Re: [PATCH] ath9k: Prevent radard detection and spectral scan to be used concurrently

2015-06-01 Thread Greg KH
On Mon, Jun 01, 2015 at 08:12:37PM +0200, Benjamin Berg wrote: In the case that a spectral scan is enabled the PHY errors sent by the hardware as part of the scanning might trigger the radar detection and channels might be marked as 'unusable' incorrectly. This patch fixes the issue by

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-30 Thread Greg KH
On Mon, May 25, 2015 at 11:02:27AM -0500, Larry Finger wrote: On 05/23/2015 04:16 PM, Larry Finger wrote: The driver is reporting a warning at kernel/time/timer.c:1096 due to calling del_timer_sync() while in interrupt mode. Such warnings are fixed by calling del_timer() instead.

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Greg KH
On Tue, May 26, 2015 at 10:06:17AM -0700, Joe Perches wrote: On Tue, 2015-05-26 at 09:35 -0700, Greg KH wrote: On Tue, May 26, 2015 at 07:48:59AM -0700, Joe Perches wrote: The main point is that patches shouldn't be applied without being submitted to a more widely read list

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Greg KH
On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote: On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote: On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote: On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote: On Mon, May 25, 2015 at 10:37:28AM -0700, Joe

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Greg KH
On Tue, May 26, 2015 at 07:48:59AM -0700, Joe Perches wrote: On Tue, 2015-05-26 at 07:14 -0700, Greg KH wrote: On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote: As far as I understand, the Eudyptula Challenge list has internal mechanisms to nominally review patches before some

Re: [PATCH v3 1/2] staging: wilc1000: Add SDIO/SPI 802.11 driver

2015-05-24 Thread Greg KH
On Mon, May 11, 2015 at 02:30:56PM +0900, Johnny Kim wrote: This driver is for the wilc1000 which is a single chip IEEE 802.11 b/g/n device. The driver works together with cfg80211, which is the kernel side of configuration management for wireless devices because the wilc1000 chipset is

Re: [PATCH 1/2] staging: wilc1000: Add SDIO/SPI 802.11 driver

2015-04-24 Thread Greg KH
On Fri, Apr 24, 2015 at 07:20:00PM +0900, Johnny Kim wrote: This driver is for the wilc1000 which is a single chip IEEE 802.11 b/g/n device. The driver works together with cfg80211, which is the kernel side of configuration management for wireless devices because the wilc1000 chipset is

Re: [PATCH v3 01/15] staging: rtl8723au: Reformat whitespace to increase readability

2015-03-26 Thread Greg KH
On Thu, Mar 19, 2015 at 12:39:04AM -0400, M. Vefa Bicakci wrote: Adjust the whitespace in the signature, local variable declaration and initialization parts of a number of functions to increase readability in rtl8723au's rtw_security.c. v2: Make sure that the arcfour_encrypt function's

Re: [PATCH] Staging: rtl8723au: fix space coding style issue in os_intfs.c

2015-01-17 Thread Greg KH
On Sat, Jan 17, 2015 at 03:52:45PM +0100, Peter Poklop wrote: From: Peter peter.pok...@gmail.com This name doesn't match up with: This patch fixes the checkpatch.pl warning: WARNING: space prohibited before semicolon Signed-off-by: Peter Poklop peter.pok...@gmail.com this name, why?

Re: [PATCH 1/6] staging: vt6655: set_channel replace parameter with ieee80211_channel

2015-01-12 Thread Greg KH
On Wed, Dec 17, 2014 at 11:16:44PM +, Malcolm Priestley wrote: On 04/12/14 22:12, Malcolm Priestley wrote: replacing uConnectionChannel for hw_value as set in vnt_init_bands. This allows other signaling of ieee80211_channel to move deeper into driver. Signed-off-by: Malcolm

Re: [PATCH] Staging: rtl8723au: core: rtw_ap: checkpatch.pl fixes

2014-12-15 Thread Greg KH
On Mon, Dec 15, 2014 at 06:26:09PM -0500, Joe Borg wrote: Fixing errors found with checkpatch.pl. What exact errors? Please be specific here and describe what you are doing. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to

Re: [PATCH] staging:rtl8723au: core: fix checkpatch error: that open brace { should be on the previous line

2014-11-26 Thread Greg KH
On Tue, Nov 11, 2014 at 03:28:57PM +0530, Sanjeev Sharma wrote: This is a patch to the rtw_cmd.c file that fixes following Error. ERROR: that open brace { should be on the previous line This patch does much more than that :( -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] staging:rtl8723au: Fix sparse warning cast to restricted __le16

2014-11-17 Thread Greg KH
On Tue, Nov 18, 2014 at 01:45:41AM +, Tobenna P. Igwe wrote: This patch fixes the following sparse warning: drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:343:36: warning: cast to restricted __le16 by using the le16_to_cpus function. Signed-off-by: Tobenna P. Igwe

Re: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.

2014-11-06 Thread Greg KH
Please specify the error in the subject in some way. On Thu, Nov 06, 2014 at 11:46:13AM +0530, Sanjeev Sharma wrote: This is a patch to the rtw_cmd.c file that fixes following error. ERROR: spaces required around that '' (ctx:WxV) ERROR: that open brace { should be on the previous line

Re: [PATCH] staging:rtl8723au: core: Fix Warning reported by checkpatch.

2014-11-06 Thread Greg KH
On Thu, Nov 06, 2014 at 12:06:36PM +0530, Sanjeev Sharma wrote: This is a patch to the rtw_cmd.c file that fixes following Warning by introducing temporary structure. WARNING: line over 80 characters Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com ---

Re: [PATCH v2] staging:rtl8723au: core: Fix error reported by checkpatch.

2014-11-05 Thread Greg KH
On Wed, Nov 05, 2014 at 05:05:03PM +0530, Sanjeev Sharma wrote: This is a patch to the rtw_cmd.c file that fixes Error reported by checkpatch. What error are you fixing? Please be specific. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the

Re: [PATCH 01/11] staging: vt6655: mac remove dead variable TxRate_iwconfig

2014-11-05 Thread Greg KH
On Wed, Nov 05, 2014 at 10:17:59PM +0100, Sedat Dilek wrote: On Wed, Nov 5, 2014 at 10:08 PM, Malcolm Priestley tvbox...@gmail.com wrote: Signed-off-by: Malcolm Priestley tvbox...@gmail.com No need for staging in the subject line of your patches? Why not? It helps me sort emails better :)

Re: [PATCH 1/2] staging: rtl8723au: core: pointer issue

2014-10-29 Thread Greg KH
On Sun, Oct 26, 2014 at 04:17:46PM +, Paul McQuade wrote: ERROR: foo * bar should be foo *bar Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_efuse.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Again with the odd subject

Re: [PATCH 2/2] staging: rtl8723au: core style issue

2014-10-29 Thread Greg KH
On Mon, Oct 27, 2014 at 12:16:08AM +, Paul McQuade wrote: spaces required around % Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Your subject does not make sense :( -- To

Re: [PATCH][V2] Staging:rtl8723au: open/closed brace issue

2014-10-29 Thread Greg KH
On Sun, Oct 26, 2014 at 03:10:22PM +, Paul McQuade wrote: ERROR: that open brace { should be on the previous line Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 130 ++-- 1 file changed, 40 insertions(+), 90

Re: [PATCH 01/48] staging: vt6655: s_cbFillTxBufHead remove unused parameters

2014-10-29 Thread Greg KH
On Sat, Oct 25, 2014 at 09:39:39AM +0100, Malcolm Priestley wrote: Remove the following parameters PSEthernetHeader psEthHeader PSKeyItem pTransmitKey bool bNeedEncrypt Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/rxtx.c | 14 ++ 1 file

Re: [PATCH 00/31] staging: vt6655: Conversion to mac80211

2014-10-29 Thread Greg KH
On Sat, Oct 25, 2014 at 09:20:10AM +0100, Malcolm Priestley wrote: The patches in this series convert the driver to mac80211. As well as infrastructure mode the driver now operates in IBSS and access point modes. Host access point is now working with hostapd in nl80211 mode. The driver

Re: [PATCH v2 00/34] staging: vt6655: Conversion to mac80211

2014-10-29 Thread Greg KH
On Wed, Oct 29, 2014 at 05:43:35PM +, Malcolm Priestley wrote: The patches in this series convert the driver to mac80211. As well as infrastructure mode the driver now operates in IBSS and access point modes. Host access point is now working with hostapd in nl80211 mode. The driver

Re: [PATCH v2 00/48] staging: vt6655: remove dead code.

2014-10-29 Thread Greg KH
On Wed, Oct 29, 2014 at 05:55:18PM +, Malcolm Priestley wrote: Following conversion to mac80211 the following patches remove dead code. Changes from v1 corrected the order patches and rebased on staging-testing. All now applied, thanks. greg k-h -- To unsubscribe from this list: send the

Re: [PATCH 3.16 0/7] Backort firmware monitor to 3.16

2014-10-28 Thread Greg KH
On Tue, Oct 28, 2014 at 08:11:19AM +0200, Emmanuel Grumbach wrote: This patch series allows to use the firmware debugging features of iwlwifi on 3.16. These features are already in 3.17. I know that this patch series is not compliant with Greg's rules for stable patches. It is unlikely that

Re: [PATCH for-3.12] brcmfmac: handle IF event for P2P_DEVICE interface

2014-09-23 Thread Greg KH
On Tue, Sep 23, 2014 at 03:42:42PM +0200, Arend van Spriel wrote: On 09/23/14 15:22, Greg KH wrote: On Tue, Sep 23, 2014 at 11:52:26AM +0200, Arend van Spriel wrote: upstream: 87c4790330810fe5caf0172d9320cf24ef19cebe That commit id doesn't match anything in Linus's tree :( Hmmm

<    1   2   3   4