Re: [PATCH] rsi: fix memory leak in debugfs entry and supported bands

On 09/19/2016 12:51 PM, Prameela Rani Garnepudi wrote: > From: Prameela Rani Garnepudi > > Signed-off-by: Prameela Rani Garnepudi > --- > drivers/net/wireless/rsi/rsi_91x_mac80211.c | 10 ++ > 1 file changed,

[PATCH 1/1 v2] rtlwifi: remove superfluous condition

If sta == NULL, the changed line will not be reached. So no need to check that sta != NULL here. v2: fix typo Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> Acked-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- 1

[PATCH 1/1] mwifiex: key_material_v2 remove superfluous condition

We are using mac as source address in a memcpy. In the lines below we can assume mac is not NULL. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drive

[PATCH 1/1] mwifiex: remove superfluous condition (2)

We are using mac as source address in a memcpy. In the lines below we can assume mac is not NULL. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drive

[PATCH 1/1] mwifiex: remove superfluous condition

for_each_property_of_node is only executed if the property prop is not NULL. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/m

[PATCH 1/1] rtlwifi: remove superfluous condition

If sta == NULL, the changed line will not be reached. So no need to check if stat == NULL here. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/r

[PATCH 1/1] brcm80211: simplify assignment

Simplify assignment in wlc_phy_rxcal_gainctrl_nphy_rev5. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/br

[PATCH 1/1] rtlwifi: rtl8192ee: simplify coding

Simplify _rtl92ee_phy_path_adda_on. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c b/d

[PATCH] wifi: ath6kl: simplify logical condition

x <= 7 implies x < 8. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/net/wireless/ath/ath6kl/wmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index 631c

[PATCH 1/1] iwlwifi: rs: remove superfluous check

If we dereference a variable anyway in other parts of the code, there is no need to check against NULL in a single place. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 1/1] mwiflex: avoid possible null pointer dereference

Do not dereference card before checking against NULL value. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/net/wireless/marvell/mwifiex/pcie.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drive

[PATCH 1/1] mwifiex: illegal assignment

Variable adapter is incorrectly initialized. Fixes: bf00dc22bc7a ("mwifiex: AMSDU Rx frame handling in AP mode") Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/net/wireless/marvell/mwifiex/uap_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 1/1] net: rsi: eliminate superfluous NULL check

msg is dereferenced before checking against NULL, e.g. when assigning pad_bytes. Remove the superfluous check in function rsi_mgmt_pkt_to_core. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> --- drivers/net/wireless/rsi/rsi_91x_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 de