Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-24 Thread Jason Cooper
All, On Wed, Nov 23, 2016 at 09:40:53PM +, Jason Cooper wrote: > I'm running with ATH9K_DEBUGFS=y now. If it goes a couple of days > without crashing, I'll gin up a patch. Well, it survived overnight, which it's never done before. :-) I'm testing the relay_o

Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-24 Thread Jason Cooper
On Thu, Nov 24, 2016 at 02:06:57PM +0800, miaoq...@codeaurora.org wrote: > > >>Okay, so i was 0, so running UP probably isn't going to help. r7 is > >>also spec_priv->rfs_chan_spec_scan. > >> > >>So, I think the question is... how is this NULL - and has it always > >>been NULL... > > > >The probl

Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Jason Cooper
On Wed, Nov 23, 2016 at 09:17:45PM +, Russell King - ARM Linux wrote: > On Wed, Nov 23, 2016 at 08:59:17PM +0000, Jason Cooper wrote: > > As requested on irc: > > Thanks. > > > 7f0: ea02b 800 > > 7f4: e7970102ldr r0,

Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Jason Cooper
On Wed, Nov 23, 2016 at 07:51:20PM +, Russell King - ARM Linux wrote: > On Wed, Nov 23, 2016 at 07:15:39PM +0000, Jason Cooper wrote: > > --- oops from v4.8.6 #2 -- > > [42059.303625] Unable to handle kernel NULL pointer derefer

Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Jason Cooper
Hi Russell, On Wed, Nov 23, 2016 at 07:51:20PM +, Russell King - ARM Linux wrote: > On Wed, Nov 23, 2016 at 07:15:39PM +0000, Jason Cooper wrote: > > --- oops from v4.8.6 #2 -- > > [42059.303625] Unable to handle kernel NULL pointer

Re: ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Jason Cooper
Hi Kalle, On Wed, Nov 23, 2016 at 09:26:42PM +0200, Kalle Valo wrote: > Jason Cooper writes: > > I have a Ubiquiti SR-71 mini-pcie ath9k card in a Globalscale Mirabox > > board (Marvell Armada 370 SoC). Every day or so I get a consistent > > crash that brings down t

ath9k ARMv7 OOPS in v4.8.6, v4.2.8

2016-11-23 Thread Jason Cooper
All, I have a Ubiquiti SR-71 mini-pcie ath9k card in a Globalscale Mirabox board (Marvell Armada 370 SoC). Every day or so I get a consistent crash that brings down the whole board. I've attached three oops I captured on the serial port. I looked at the commits from v4.8.6 to v4.9-rc6, and noth

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-14 Thread Jason Cooper
Hey Ted, On Wed, Aug 10, 2016 at 07:44:25PM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 02:04:44PM +0000, Jason Cooper wrote: > > iiuc, Ted, you're saying using the hw_random framework would be > > disasterous because despite most drivers having a default quali

Re: [PATCH 2/2] ath9k: disable RNG by default

2016-08-11 Thread Jason Cooper
On Thu, Aug 11, 2016 at 10:54:11AM +0800, miaoq...@codeaurora.org wrote: > On 2016-08-10 21:24, Jason Cooper wrote: > >The fact is, barring userspace expectations of /dev/hwrng, hw_random is > >the appropriate place for it. It's not a devicetree blob, mac address, > >o

Re: [PATCH 2/2] ath9k: disable RNG by default

2016-08-10 Thread Jason Cooper
Hi Miaoqing Pan, Stephen, *gentle reminder: others are reading which may not be directly included in the conversation. Including the archives. Please avoid top posting. :) On Wed, Aug 10, 2016 at 07:43:45AM +, Pan, Miaoqing wrote: > The problem with using the add_device_randomness is that w

Re: [PATCH 2/2] ath9k: disable RNG by default

2016-08-09 Thread Jason Cooper
Hi Henrique, On Tue, Aug 09, 2016 at 07:24:58AM -0300, Henrique de Moraes Holschuh wrote: > On Tue, 09 Aug 2016, Stephan Mueller wrote: > > RHEL 7 and Fedora do not adjust it. So, shall we consider those rng-tools > > then > > broken (at least in those large distros)? > > Might I humbly suggest

Re: [PATCH 2/2] ath9k: disable RNG by default

2016-08-09 Thread Jason Cooper
mbedded systems. > > Signed-off-by: Miaoqing Pan Until we get the hw_random/get_device_randomness question sorted... Reviewed-by: Jason Cooper thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.ke

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-09 Thread Jason Cooper
Hi Ted, On Tue, Aug 09, 2016 at 07:56:22AM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 06:30:03AM +, Pan, Miaoqing wrote: > > Agree with Jason's point, also understand Stephan's concern. The > > date rate can be roughly estimated by 'cat /dev/random |rngtest -c > > 1000', the averag

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-08 Thread Jason Cooper
Hi Stephan, On Mon, Aug 08, 2016 at 05:29:30PM +, Jason Cooper wrote: > On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: ... > > If you think that this patch is a challenge because your driver starts to > > spin, please help and offer another solution. > &

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-08 Thread Jason Cooper
Hi Stephan, Miaoqing Pan, On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: > Am Montag, 8. August 2016, 02:03:36 CEST schrieb Pan, Miaoqing: > > The entropy was evaluated by crypto expert, the analysis report show the > > ADC with at least 10bits and up to 22 bits of min-entropy f

Re: [RFC][PATCH] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-06 Thread Jason Cooper
Hi Stephan, On Sat, Aug 06, 2016 at 10:03:58PM +0200, Stephan Mueller wrote: > Am Samstag, 6. August 2016, 19:45:51 CEST schrieb Jason Cooper: > > On Fri, Aug 05, 2016 at 05:08:14PM +0200, Stephan Mueller wrote: ... > > > diff --git a/drivers/net/wireless/ath/ath9k/rng.c &

Re: [RFC][PATCH] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-06 Thread Jason Cooper
> -ATH9K_RNG_ENTROPY(bytes_read)); This is the only use of this macro. I'd remove the #define on line 25 as well. > + add_hwgenerator_randomness((void *)rng_buf, bytes_read, 0); > } > > kfree(rng_buf); Other