Re: [PATCH 5/5] staging: wilc1000: use id value as argument

2015-08-19 Thread Johnny Kim
Hello Dan. On 2015년 08월 18일 18:12, Dan Carpenter wrote: On Tue, Aug 18, 2015 at 12:10:53PM +0900, Johnny Kim wrote: Hello Dan. On 2015년 08월 13일 23:49, Dan Carpenter wrote: On Thu, Aug 13, 2015 at 01:41:23PM +0900, Tony Cho wrote: +static u32 get_id_from_handler(tstrWILC_WFIDrv *handler

Re: [PATCH 5/5] staging: wilc1000: use id value as argument

2015-08-17 Thread Johnny Kim
| id >= NUM_CONCURRENT_IFC) return NULL; return wfidrv_list[id]; } regards, dan carpenter Regards. Johnny Kim. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: [PATCH 5/5] staging: wilc1000: use id value as argument

2015-08-10 Thread Johnny Kim
Hello Julian. On 2015년 08월 10일 15:47, Julian Calaby wrote: Hi Tony and Johnny, On Mon, Aug 10, 2015 at 3:58 PM, Tony Cho wrote: From: Johnny Kim The driver communicates with the chipset via the address of handlers to distinguish async data frame. The SendConfigPkt function gets the pointer

Re: [PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-30 Thread Johnny Kim
Your patch has wrong sentence. Please remove "---" ASCHI Loot at below line. On 2015년 07월 30일 18:10, Tony Cho wrote: This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out the entire functions is preferred rather than p

Re: [PATCH 2/3] staging: wilc1000: wilc_wlan_cfg_get(): replace integer with void pointer

2015-07-10 Thread Johnny Kim
On 2015년 07월 10일 15:25, Julian Calaby wrote: Hi Johnny, On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote: Last argument of wilc_wlan_cfg_get function is actually structure's address. This should be changed to be compatible with 64bit machine. Because wilc_wlan_cfg_get function is mapp

Re: [PATCH 1/3] staging: wilc1000: wilc_wlan_cfg_commit(): replace integer with pointer

2015-07-10 Thread Johnny Kim
On 2015년 07월 10일 15:20, Julian Calaby wrote: Hi Johnny, On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote: A argument of wilc_wlan_cfg_commit() is address of structure. But because the size is restricted to 32bit, it is not correct for 64bit machine. So, this changes the interger value to

[PATCH 4/5] staging: wilc1000: SendConfigPkt(): replace integer with void pointer

2015-07-09 Thread Johnny Kim
argument to void type pointer. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/coreconfigurator.c | 4 +- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/host_interface.c | 102 ++-- 3 files changed, 54 insertions(+), 54 deletions

[PATCH 5/5] staging: wilc1000: change variable of limited 32bit size to pointer

2015-07-09 Thread Johnny Kim
gu8FlushedJoinReqDrvHandler variable is be using to save structure pointer. But because that is restricted to 32bit and has needless casting, the varibale should be changed to pointer of same type. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/host_interface.c | 16 1

[PATCH 2/3] staging: wilc1000: wilc_wlan_cfg_get(): replace integer with void pointer

2015-07-09 Thread Johnny Kim
re is defined after wilc_wlan_oup_t.wlan_cfg_get is defined. So, this patch changes the argument to void type pointer. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/wilc_wlan.c| 2 +- drivers/staging/wilc1000/wilc_wlan_if.h

[PATCH 3/3] staging: wilc1000: wilc_wlan_cfg_set(): replace integer with void pointer

2015-07-09 Thread Johnny Kim
re is defined after wilc_wlan_oup_t.wlan_cfg_set is defined. So, this patch changes the argument to void type pointer. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wlan.c

[PATCH 0/3] staging: wilc1000: rework integer value for x64

2015-07-09 Thread Johnny Kim
patches related with this patch. Best regards. Johnny. Johnny Kim (3): staging: wilc1000: wilc_wlan_cfg_commit(): replace integer with pointer staging: wilc1000: wilc_wlan_cfg_get(): replace integer with void pointer staging: wilc1000: wilc_wlan_cfg_set(): replace integer with void

[PATCH 1/3] staging: wilc1000: wilc_wlan_cfg_commit(): replace integer with pointer

2015-07-09 Thread Johnny Kim
A argument of wilc_wlan_cfg_commit() is address of structure. But because the size is restricted to 32bit, it is not correct for 64bit machine. So, this changes the interger value to obvious structure pointer. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/wilc_wlan.c | 8 1

Re: [PATCH 1/4] staging: wilc1000: modify data type

2015-06-10 Thread Johnny Kim
On 2015년 06월 11일 09:40, Greg KH wrote: On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote: -static int wilc_wlan_cfg_commit(int type, uint32_t drvHandler) +static int wilc_wlan_cfg_commit(int type, size_t drvHandler) Shouldn't this just be a void *? And if so, why not the

[PATCH 4/4] staging: wilc1000: remove uninitialized warnings

2015-06-10 Thread Johnny Kim
This patch is for the initialization of the local variables. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 0/4] staging: wilc1000: fix compile warnings and clean other

2015-06-10 Thread Johnny Kim
, the others will be sent soon. Johnny. Johnny Kim (4): staging: wilc1000: modify data type staging: wilc1000: add syntax for 64-bit machine staging: wilc1000: modify printk format staging: wilc1000: remove uninitialized warnings drivers/staging/wilc1000/coreconfigurator.c | 4

[PATCH 3/4] staging: wilc1000: modify printk format

2015-06-10 Thread Johnny Kim
This remove compile warnings about printk format. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 3 files changed, 9 insertions

[PATCH 2/4] staging: wilc1000: add syntax for 64-bit machine

2015-06-10 Thread Johnny Kim
The driver take pointer value to integer value for message packet. So, The driver was fixed to save and load the address on 64-bit machine. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/host_interface.c | 24 drivers/staging/wilc1000/wilc_wlan.c | 19

[PATCH 1/4] staging: wilc1000: modify data type

2015-06-10 Thread Johnny Kim
This replace the argument of the function to the independent data type in system. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/coreconfigurator.c | 4 +- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/host_interface.c | 132

[PATCH v3 2/2] staging: MAINTAINERS: add maintainer for wilc1000 device

2015-05-10 Thread Johnny Kim
Add myself as maintainer for atmel wilc1000 Signed-off-by: Johnny Kim Signed-off-by: Rachel Kim Signed-off-by: Dean Lee Signed-off-by: Chris Park Acked-by: Nicolas Ferre --- Changes in v3: - fix the permissions. - fix the folder tree. - forget to add the mailing-list during the previous

[PATCH 2/2] staging: MAINTAINERS: add maintainer for wilc1000 device

2015-04-24 Thread Johnny Kim
Add myself as maintainer for atmel wilc1000 Signed-off-by: Johnny Kim Signed-off-by: Rachel Kim Signed-off-by: Dean Lee Signed-off-by: Chris Park --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1b8263c..e4252b5 100644 --- a