RE: [PATCH] staging: wilc1000: fix check of kthread_run() return value

2016-03-09 Thread Kim, Leo
:36 AM To: Julian Calaby Cc: Lee, Glen ; Greg Kroah-Hartman ; Kim, Johnny ; Shin, Austin ; Park, Chris ; Cho, Tony ; Kim, Leo ; linux-wireless ; de...@driverdev.osuosl.org Subject: Re: [PATCH] staging: wilc1000: fix check of kthread_run() return value Hi Julian, On 10.03.2016 02:24, Julian Cal

RE: [PATCH RESEND 04/10] staging: wilc1000: removes unnecessary wilc_debug print log

2016-02-22 Thread Kim, Leo
1:42:42AM +0000, Kim, Leo wrote: > Dear Dan, > > This patch is subject "removes unnecessary wilc_debug print log". I'm fine with you fixing it up in a later patch, but you should not be defending this patch as valid way to do things. The rule is "do one thing at a

RE: [PATCH RESEND 04/10] staging: wilc1000: removes unnecessary wilc_debug print log

2016-02-22 Thread Kim, Leo
.  Thanks, BR  Leo -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Monday, February 22, 2016 7:45 PM To: Kim, Leo Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; Park, Chris ; Shin, Austin ; linux-wireless@vger.kernel.org; Ferre, Nicolas ; Cho, Ton

RE: [PATCH V2 18/24] staging: wilc1000: linux_wlan.c: removes unnecessary log messages

2016-02-18 Thread Kim, Leo
Hi Julian, Yes, ongoing remove this function. I will be removing this function for next patch. Thank you in your advice.  Thanks, BR  Leo -Original Message- From: Julian Calaby [mailto:julian.cal...@gmail.com] Sent: Friday, February 19, 2016 9:41 AM To: Kim, Leo Cc: Greg KH ; de

RE: drivers/staging/wilc1000/wilc_spi.c won't compile ?

2016-02-15 Thread Kim, Leo
onday, February 08, 2016 9:18 PM To: Kim, Johnny ; Shin, Austin ; Park, Chris ; Cho, Tony ; Lee, Glen ; Kim, Leo ; linux-wireless@vger.kernel.org Subject: drivers/staging/wilc1000/wilc_spi.c won't compile ? Hello there, drivers/staging/wilc1000/wilc_spi.c:123:34: error: stora

RE: [PATCH 08/12] staging: wilc1000: rename variable s32Error

2016-01-28 Thread Kim, Leo
y, January 29, 2016 9:55 AM To: Kim, Leo Cc: Greg KH ; de...@driverdev.osuosl.org; linux-wireless ; Cho, Tony ; Lee, Glen ; Shin, Austin ; Park, Chris ; Abozaeid, Adham ; Ferre, Nicolas Subject: Re: [PATCH 08/12] staging: wilc1000: rename variable s32Error Hi Leo, On Thu, Jan 28, 2016 at 6:

RE: [PATCH RESEND 01/38] staging: wilc1000: rename pu8IPAddr of fuction Handle_set_IPAddress

2015-11-04 Thread Kim, Leo
..@oracle.com] Sent: Thursday, November 05, 2015 4:17 PM To: Lee, Glen Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; Shin, Austin; linux-wireless@vger.kernel.org; Ferre, Nicolas; Noureldin, Adel; Cho, Tony; Kim, Leo; Abozaeid, Adham Subject: Re: [PATCH RESEND 01/38] staging: wilc1000:

RE: [PATCH 32/32] staging: wilc1000: fix kernel fail after ifconfig wlan0 up

2015-09-30 Thread Kim, Leo
...@driverdev.osuosl.org; Kim, Rachel; Park, Chris; Shin, Austin; linux-wireless@vger.kernel.org; Kim, Johnny; Ferre, Nicolas; Noureldin, Adel; Kim, Leo; Abozaeid, Adham Subject: Re: [PATCH 32/32] staging: wilc1000: fix kernel fail after ifconfig wlan0 up Ugh... No. Just do this: diff --git a/drivers