ki
> - Joonwoo Park
> - Kirtika Ruchandani
> - Rajat Jain
> - Stanislaw Gruszka
> remaining in the code today.
>
> Note that
> - I myself was working for Intel and for any possibly code
>that might be before my employment there give permission
> - Wizery emp
This patchset is part of the effort led by Arnd Bergmann to clean up
warnings in the kernel. This and following patchsets will focus on
"-Wunused-but-set-variable" as it among the noisier ones. These were
found compiling with W=1.
Kirtika Ruchandani (5):
ath10k: Remove unused 'buf_len
: Kalle Valo <kv...@qca.qualcomm.com>
Signed-off-by: Kirtika Ruchandani <kirt...@chromium.org>
---
drivers/net/wireless/ath/ath10k/ahb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/ahb.c
b/drivers/net/wireless/ath/ath10k/ahb.c
index 8078d64..
lt;michal.kaz...@tieto.com>
Cc: Kalle Valo <kv...@qca.qualcomm.com>
Signed-off-by: Kirtika Ruchandani <kirt...@chromium.org>
---
drivers/net/wireless/ath/ath10k/wmi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c
b/drivers/net/wireless/ath/ath10k/
: Kalle Valo <kv...@qca.qualcomm.com>
Signed-off-by: Kirtika Ruchandani <kirt...@chromium.org>
---
drivers/net/wireless/ath/ath10k/ahb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/ahb.c
b/drivers/net/wireless/ath/ath10k/ahb.c
index 766c63b..
warnings and are only being fixed to reduce the
noise with W=1 in the kernel.
Fixes: d15fb5200664 ("ath10k: split wmi stats parsing")
Fixes: 20de2229c634 ("ath10k: fix 10.2 fw stats parsing")
Cc: Michal Kazior <michal.kaz...@tieto.com>
Cc: Kalle Valo <kv...@qca.qualcom
ualcomm.com>
Signed-off-by: Kirtika Ruchandani <kirt...@chromium.org>
---
drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
index e64f593..0e4bd29 100644
--
")
Cc: Michael Wu <flaming...@sourmilk.net>
Cc: John W. Linville <linvi...@tuxdriver.com>
Signed-off-by: Kirtika Ruchandani <kirt...@chromium.org>
---
drivers/net/wireless/admtek/adm8211.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless
the
noise with W=1 in the kernel.
Fixes: b1bce14a7954 ("mac80211: update opmode when adding new station")
Cc: Marek Kwaczynski <marek.kwaczyn...@tieto.com>
Cc: Johannes Berg <johannes.b...@intel.com>
Signed-off-by: Kirtika Ruchandani <kirt...@chromium.org>
---
net/mac
: variable ‘beaconint_us’ set but not used
[-Wunused-but-set-variable]
iee80211_tu_to_usec has no side-effects and is safe to remove.
Fixes: 4a733ef1bea7 ("mac80211: remove PM-QoS listener")
Cc: Johannes Berg <johannes.b...@intel.com>
Signed-off-by: Kirtika Ruchandani <kirt...@chr
hal Kazior <michal.kaz...@tieto.com>
Cc: Johannes Berg <johannes.b...@intel.com>
Signed-off-by: Kirtika Ruchandani <kirt...@chromium.org>
---
net/mac80211/chan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/mac80211/chan.c b/net/mac80211/chan.c
index e75cb
intel.com>
Cc: Alexander Bondar <alexander.bon...@intel.com>
Cc: Johannes Berg <johannes.b...@intel.com>
Signed-off-by: Kirtika Ruchandani <kirt...@chromium.org>
---
net/mac80211/scan.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/net/mac80211/scan.c b
This patchset is part of the effort led by Arnd Bergmann to clean up
warnings in the kernel. This and following patchsets will focus on
"-Wunused-but-set-variable" as it among the noisier ones. These were
found compiling with W=1.
Kirtika Ruchandani (4):
mac80211: Removed unused 'i
to be present since 4daffe354366 which introduced
mwifiex_usb_probe().
Fixes: 4daffe354366 ("mwifiex: add support for Marvell USB8797 chipset")
Cc: Amitkumar Karwar <akar...@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
drivers/net/wireless/marvell/mw
g Zhao <bz...@marvell.com>
Cc: Amitkumar Karwar <akar...@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c
b/drivers/net/wir
[-Wunused-but-set-variable]
Fixes: 92263a841b15 ("mwifiex: add SDIO rx single port aggregation")
Cc: Zhaoyang Liu <li...@marvell.com>
Cc: Amitkumar Karwar <akar...@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
drivers/net/wireless/marvell/mwifiex/sd
but not used
[-Wunused-but-set-variable]
Fixes: 429d90d2212b ("mwifiex: add cfg80211 tdls_oper handler support")
Cc: Avinash Patil <pat...@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 2 --
1 fil
[-Wunused-but-set-variable]
Fixes: 3935ccc14d2c ("mwifiex: add cfg80211 testmode support")
Cc: Xinming Hu <h...@marvell.com>
Cc: Amitkumar Karwar <akar...@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
drivers/net/wireless/marvell/mwifiex/cfg80
: b5413e6b2228 ("mwifiex: increase the number of nodes in command pool")
Cc: Amitkumar Karwar <akar...@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
drivers/net/wireless/marvell/mwifiex/scan.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
: warning: variable ‘priv’ set but not used
[-Wunused-but-set-variable]
Fixes: bec568ff5107 ("mwifiex: failure path handling in
mwifiex_add_virtual_intf()")
Cc: Amitkumar Karwar <akar...@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
drivers/net/wireless/
but not used
[-Wunused-but-set-variable]
Fixes: 3b17fbf87d5d ("mac80211: mesh: Add support for HW RC implementation")
Cc: Johannes Berg <johannes.b...@intel.com>
Cc: Maxim Altshul <maxim.alts...@ti.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
net/mac
-but-set-variable]
This is a harmless warning, and is only being fixed to reduce the
noise generated with W=1.
Fixes: f027c2aca0cf ("mac80211: add ieee80211_tx_status_noskb")
Cc: Johannes Berg <johannes.b...@intel.com>
Cc: Felix Fietkau <n...@openwrt.org>
Signed-off-by: Ki
[-Wunused-but-set-variable]
Fixes: 554891e63a29 ("mac80211: move packet flags into packet")
Cc: Johannes Berg <johannes.b...@intel.com>
Cc: John W. Linville <linvi...@tuxdriver.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
net/mac80211/rx.c | 4
[-Wunused-but-set-variable]
Fixes: 92263a841b15 ("mwifiex: add SDIO rx single port aggregation")
Cc: Zhaoyang Liu <li...@marvell.com>
Cc: Amitkumar Karwar <akar...@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
drivers/net/wireless/marvell/mwifiex/sd
to be present since 4daffe354366 which introduced
mwifiex_usb_probe().
Fixes: 4daffe354366 ("mwifiex: add support for Marvell USB8797 chipset")
Cc: Amitkumar Karwar <akar...@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
drivers/net/wireless/marvell/mw
g Zhao <bz...@marvell.com>
Cc: Amitkumar Karwar <akar...@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c
b/drivers/net/wir
[-Wunused-but-set-variable]
Fixes: 3935ccc14d2c ("mwifiex: add cfg80211 testmode support")
Cc: Xinming Hu <h...@marvell.com>
Cc: Amitkumar Karwar <akar...@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
drivers/net/wireless/marvell/mwifiex/cfg80
: warning: variable ‘priv’ set but not used
[-Wunused-but-set-variable]
Fixes: bec568ff5107 ("mwifiex: failure path handling in
mwifiex_add_virtual_intf()")
Cc: Amitkumar Karwar <akar...@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
drivers/net/wireless/
: b5413e6b2228 ("mwifiex: increase the number of nodes in command pool")
Cc: Amitkumar Karwar <akar...@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
---
drivers/net/wireless/marvell/mwifiex/scan.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
This patchset is part of the effort led by Arnd Bergmann to clean up
warnings in the kernel. This and following patchsets will focus on
"-Wunused-but-set-variable" as it among the noisier ones. These were
found compiling with W=1.
Kirtika Ruchandani (7):
mwifiex: Removed unused mwifi
for family_8000 B0 only)
Fixes: 76f8c0e17edc (iwlwifi: pcie: remove dead code)
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
Cc: Sara Sharon <sara.sha...@intel.com>
Cc: Luca Coelho <luciano.coe...@intel.com>
Cc: Eran Harary <eran.har...@intel.com>
Cc: Liad Kaufman <
ixes: e621c2282e31 ("iwlwifi: rs: Remove workaround that disables MIMO on P2P")
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
Cc: Alexander Bondar <alexander.bon...@intel.com>
Cc: Emmanuel Grumbach <emmmanuel.grumb...@intel.com>
---
drivers/net/wireless/intel/iwl
: variable ‘mcs’ set but not used
[-Wunused-but-set-variable]
Fixes: 5fc0f76c43bd (iwlwifi: mvm: add Rx frames statistics via debugfs)
Signed-off-by: Kirtika Ruchandani <kirt...@google.com>
Cc: Eyal Shapira <e...@wizery.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 4 +---
1 fil
ed by Arnd in all 3 patches
1. Each patch has a unique subject line.
2. Add the commit that introduced/led to the warning with the "Fixes:" line.
3. cc linux-wireles, cc commit authors.
Kirtika Ruchandani (3):
iwlwifi: mvm: rs: Remove unused 'mvmvif'/'mvmsta' variables
iwlw
This patch fixes the checkpatch.pl check "Please don't use multiple
blank lines" for all files in net/wireless, except nl80211.c which
is covered in a separated patch.
Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
---
net/wireless/ap.c | 1 -
net
> This looks right to me, but doesn't ether_addr_copy() have alignment
> requirements? Could someone more familiar with that review these
> changes to ensure they're met?
Thanks for catching this.
The requirement is to be __aligned(2). I've added 4 instances of
ether_addr_copy with 8 addresses as
> Adding the brackets around the & expression doesn't look spacing
> related to me. What's the exact warning this is fixing?
>From the commit message - "This patch also contains two hunks to fix
'line over 80 characters',
that are spacing related". This is the second hunk, the first being
the
This patch fixes the checkpatch.pl warning "foo * bar should be
foo *bar"
Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
---
net/wireless/nl80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/wireless/nl80211.c b/net/wireless
Fix 'implementation' spelling, reported by checkpatch.pl
Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
---
net/wireless/nl80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 6f8e2a7..c6d870e
hunks to fix 'line over 80 characters',
that are spacing related.
All other instances of that warning have been ignored.
Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
---
net/wireless/nl80211.c | 103 ++---
1 file changed, 54 inse
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
---
net/wireless/nl80211.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/wireless/nl80211.c b/net/wi
This patch fixes the warning - "comparison to NULL (foo == NULL)
could be written as (!foo)"
Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
---
net/wireless/nl80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/wireless/nl80211.
This patch fixes the checkpatch,pl to prefer ether_addr_copy
over memcpy.
Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
---
net/wireless/nl80211.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
This patch fixes the following checkpatch,pl warning -
- braces {} should be used on all arms of this statement.
Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
---
net/wireless/nl80211.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff
This patch fixes the following checkpatch.pl warnings about
comments in nl80211.c :
- networking block comments don't use an empty '/*' line
- block comments use a trailing '*/' on a separate line
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Signed-off-by: Kirtika Ruch
parenthesis'. Some of them do not display correctly with git diff.
This patch-set removes 3 errors, 66 warnings and 46 checks.
Kirtika Ruchandani (10):
nl80211: Fix checkpatch warnings
nl80211: Fix checkpatch warnings about blank lines
nl80211: Prefer ether_addr_copy
nl80211: Fix checkpatch.pl
>> There's too much stuff here to quickly review, it'd be nice if you
>> could split this up into patches that do the following:
Is it preferable to resend the whole patch-set or just patch 3/3 in
this one as a separate set?
--
To unsubscribe from this list: send the line "unsubscribe
> There's too much stuff here to quickly review, it'd be nice if you
> could split this up into patches that do the following:
Thanks, I will send out a v2 with the split you suggested.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to
on a tabstop
- multiple assignments should be avoided
- prefer ether_addr_copy over memcpy
- correct spelling - 'implementation'
- comparison to NULL could be written as !foo
- prefer kcalloc over kzalloc with multiply
Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
---
net/wi
This patch fixes the following checkpatch.pl issues -
- Please don't use multiple blank lines
- Blank lines aren't necessary before a close brace
- Missing a blank line after declarations
Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
---
net/wireless/nl80211.
This patch fixes the following checkpatch.pl warnings about
comments in nl80211.c :
- networking block comments don't use an empty '/*' line
- block comments use a trailing '*/' on a separate line
Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
---
net/wireless/nl80211.c
of them do not display correctly with git diff.
This patch-set removes 3 errors, 66 warnings and 46 checks.
Kirtika Ruchandani (3):
nl80211: Fix checkpatch warnings
nl80211: Fix checkpatch warnings about blank lines
nl80211: Various checkpatch.pl fixes
net/wireless/nl80211.c | 303
- fix line over 80 chars
- match alignment of function arguments to open parentheses
Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
---
net/wireless/core.c | 73 +++--
net/wireless/core.h | 33 +---
2 files c
- fix line over 80 chars
- match alignment of function arguments to open parentheses
Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
---
net/wireless/core.c | 73 +++--
net/wireless/core.h | 33 +---
2 files c
54 matches
Mail list logo
