ror
and dropping them. The test is now annotated as likely.
Cc: Stable # v5.0+
Signed-off-by: Larry Finger
---
V2 - content dropped
V3 - changed fix to drop packet rather than arbitrarily increasing the length.
---
Material for 5.4.
---
drivers/net/wireless/realtek/rtlwifi/pci.c | 3 ++-
1
On 10/20/19 3:28 AM, Kalle Valo wrote:
Larry Finger writes:
In commit 8020919a9b99 ("mac80211: Properly handle SKB with radiotap
only"), buffers whose length is too short cause a WARN_ON(1) to be
executed. This change exposed a fault in rtlwifi drivers, which is fixed
by increasing
On 10/19/19 5:23 PM, ian.schram wrote:
Hi,
This patch doesn't appear to do anything? The increased length is not actually
used, is a part of the patch missing?
ps: superficial reading, i am not hampered by any specific knowledge of this
driver.
On 2019-10-19 21:02, Larry Finger wrote
80211.
Cc: Stable # v5.0+
Signed-off-by: Larry Finger
---
V2 - added missing usage of new len
---
Please Apply to 5.4
---
drivers/net/wireless/realtek/rtlwifi/pci.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c
b/drivers/net/wirele
80211.
Cc: Stable # v5.0+
Signed-off-by: Larry Finger
---
Kalle,
Please send to v5.4.
Larry
---
drivers/net/wireless/realtek/rtlwifi/pci.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c
b/drivers/net/wireless/realtek/rtlwifi/pci.c
index 60
should be a little-endian word array (__le32 *).
That will be changed in the next patch.
Several places where checkpatch.pl complains about a space after a cast
and other warnings are fixed.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8192se/def.h | 374
In this step, the read/write routines for the descriptors are converted
to use __le32 quantities, thus a lot of casts can be removed. Callback
routines still use the 8-bit arrays, but these are changed within the
specified routine.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi
direct read or replacement is used.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8192se/def.h | 130 --
.../wireless/realtek/rtlwifi/rtl8192se/fw.c | 31 +++--
.../wireless/realtek/rtlwifi/rtl8192se/trx.c | 4 +-
3 files changed, 74 insertions(+), 91
As the first step in converting from macros that get/set information
in the RX and TX descriptors, unused macros are being removed.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8192se/def.h | 223 --
1 file changed, 223 deletions(-)
diff --git a/drivers/net
These patches are part of a series intended to replace the bit-manipulation
macros used to set and read the various descriptors with a set of inline
routines.
Signed-off-by: Larry Finger
Larry Finger (4):
rtlwifi: rtl8192se: Remove unused GET_XXX and SET_XXX
rtlwifi: rtl8192se: Replace
On 10/1/19 12:46 PM, Sebastian Andrzej Siewior wrote:
On 2019-10-01 11:47:44 [-0500], Larry Finger wrote:
A quick Internet search shows me that the RTL8188FU is a low-cost chip used
on Raspberry PI and other similar low-cost systems.
The USB group at Realtek is notorious for their lack of
On 10/1/19 11:03 AM, Sebastian Andrzej Siewior wrote:
Hi,
I'm looking into support for RTL8188FU with the vendor driver next to
me. There is a driver called rtl8188eu in staging. Is there a way to
figure out the difference between E and F?
Then there is rtl8xxxu outside of staging claiming to su
On 9/28/19 6:51 AM, Sergey Kharitonov wrote:
Dear Mr. Finger!
Today's upgrade to linux 5.3.1 made the OEM Realtek driver (from
rtl8192ee_revised_5.x.tar.xz) unusable.
Current rtlwifi_new master and extended branches still contain old
code which results in a high ping.
Can you please somehow add y
When rtlwifi debugging is disabled, missing globals occur due to the
attempt execution of code that is never generated.
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/pci.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c
On 9/9/19 11:00 AM, Joerg Kampmann wrote:
This seems to be very strange. Does anybody have an explanation for this strange
behaviour?
I tried booting a Debian Buster LXFE live iso. It has NO wireless firmware at
all, and is completely useless unless you have a wired network!
What files are i
On 9/9/19 11:00 AM, Joerg Kampmann wrote:
This seems to be very strange. Does anybody have an explanation for this strange
behaviour?
I just searched the entire kernel source for the message "firmware is too big".
The only place it was found was "drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c:
On 9/9/19 9:32 AM, Joerg Kampmann wrote:
Hallo I just posted a remark on Github concerning the above firmware! I applied
it on Debian 10 (buster) Linux ... Any idea on the causes of the fault?
*firmware is too big*
The machine is a notebook from ASUS: X540M - this notebook has only 3 USB-slots
an inline
routine.
Signed-off-by: Larry Finger
---
V2 - Add a missing inline direective in rtl8723be/trx.h
---
.../wireless/realtek/rtlwifi/rtl8723be/trx.c | 34 +-
.../wireless/realtek/rtlwifi/rtl8723be/trx.h | 310 +-
2 files changed, 175 insertions(+), 169 deletions(-)
diff
should be a little-endian word array (__le32 *).
That will be changed in the next patch.
Several places where checkpatch.pl complains about a space after a cast
are fixed.
Signed-off-by: Larry Finger
---
v2 - no changes
---
.../wireless/realtek/rtlwifi/rtl8723be/trx.c | 204
Each of these drivers defines some device to host macros that are never
used, thus they can be removed.
Signed-off-by: Larry Finger
---
v2 - no changes
---
drivers/net/wireless/realtek/rtlwifi/base.h | 27 ---
.../wireless/realtek/rtlwifi/rtl8188ee/def.h | 29
should be a little-endian word array (__le32 *).
That will be changed in the next patch.
Several places where checkpatch.pl reports lines too long are fixed.
Signed-off-by: Larry Finger
---
v2 - no changes
---
.../wireless/realtek/rtlwifi/rtl8723ae/trx.c | 190 +++
.../wireless/realtek
direct read or replacement is used.
Signed-off-by: Larry Finger
---
v2 - no changes
---
.../wireless/realtek/rtlwifi/rtl8723be/trx.h | 149 +-
1 file changed, 74 insertions(+), 75 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.h
b/drivers/net/wireless
iAs the first step in converting from macros that get/set information
in the RX and TX descriptors, unused macros are being removed.
Signed-off-by: Larry Finger
---
v2 - no changes
---
.../wireless/realtek/rtlwifi/rtl8723be/trx.h | 167 +-
1 file changed, 2 insertions(+), 165
an inline
routine.
Signed-off-by: Larry Finger
---
v2 - no changes
---
.../wireless/realtek/rtlwifi/rtl8723ae/trx.c | 24 +-
.../wireless/realtek/rtlwifi/rtl8723ae/trx.h | 250 +-
2 files changed, 140 insertions(+), 134 deletions(-)
diff --git a/drivers/net/wireless/realtek
These patches continue the set of changes that remove the special macros
to read or write the RX and TX descriptors. The bit manipulations in the
__le32 words use GENMASK() and BIT() operations.
The final patch removes unused macros for C2H operations.
Signed-off-by: Larry Finger
---
V2 - Add
direct read or replacement is used.
Signed-off-by: Larry Finger
---
v2 - no changes
---
.../wireless/realtek/rtlwifi/rtl8723ae/trx.h | 124 +-
1 file changed, 62 insertions(+), 62 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.h
b/drivers/net/wireless
As the first step in converting from macros that get/set information
in the RX and TX descriptors, unused macros are being removed.
Signed-off-by: Larry Finger
---
v2 - no changes
---
.../wireless/realtek/rtlwifi/rtl8723ae/trx.h | 336 +-
1 file changed, 4 insertions(+), 332
should be a little-endian word array (__le32 *).
That will be changed in the next patch.
Several places where checkpatch.pl reports lines too long are fixed.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8723ae/trx.c | 190 +++
.../wireless/realtek/rtlwifi/rtl8723ae/trx.h
iAs the first step in converting from macros that get/set information
in the RX and TX descriptors, unused macros are being removed.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8723be/trx.h | 167 +-
1 file changed, 2 insertions(+), 165 deletions(-)
diff
These patches continue the set of changes that remove the special macros
to read or write the RX and TX descriptors. The bit manipulations in the
__le32 words use GENMASK() and BIT() operations.
The final patch removes unused macros for C2H operations.
Signed-off-by: Larry Finger
Larry Finger
direct read or replacement is used.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8723ae/trx.h | 124 +-
1 file changed, 62 insertions(+), 62 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.h
b/drivers/net/wireless/realtek/rtlwifi
an inline
routine.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8723ae/trx.c | 24 +-
.../wireless/realtek/rtlwifi/rtl8723ae/trx.h | 250 +-
2 files changed, 140 insertions(+), 134 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
should be a little-endian word array (__le32 *).
That will be changed in the next patch.
Several places where checkpatch.pl complains about a space after a cast
are fixed.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8723be/trx.c | 204 +++
.../wireless/realtek/rtlwifi
direct read or replacement is used.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8723be/trx.h | 149 +-
1 file changed, 74 insertions(+), 75 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.h
b/drivers/net/wireless/realtek/rtlwifi
As the first step in converting from macros that get/set information
in the RX and TX descriptors, unused macros are being removed.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8723ae/trx.h | 336 +-
1 file changed, 4 insertions(+), 332 deletions(-)
diff
an inline
routine.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8723be/trx.c | 34 +-
.../wireless/realtek/rtlwifi/rtl8723be/trx.h | 310 +-
2 files changed, 175 insertions(+), 169 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.c
Each of these drivers defines some device to host macros that are never
used, thus they can be removed.
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/base.h | 27 ---
.../wireless/realtek/rtlwifi/rtl8188ee/def.h | 29
.../wireless/realtek
s required.
Fixes: bd421dab7515 ("rtlwifi: rtl8821ae: Convert macros that set descriptor")
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/trx.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwif
Although I have submitted fixes for several drivers, only 3 are affected
as the problem caused failures that led me to the problem.
Fortunately, none of these faulty changes will reach mainline until 5.4,
thus most users will not be affected until 5.4-rc1.
Signed-off-by: Larry Finger
Larry
s required.
Fixes: 36eda7568f2e ("rtlwifi: rtl8188ee: Convert macros that set descriptor")
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtl
s required.
Fixes: 98fd8db59a00 ("rtlwifi: rtl8192ce: Convert macros that set descriptor")
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwif
In this step, the read/write routines for the descriptors are converted
to use __le32 quantities, thus a lot of casts can be removed. Callback
routines still use the 8-bit arrays, but these are changed within the
specified routine.
Signed-off-by: Larry Finger
---
.../net/wireless/realtek
As the first step in converting from macros that get/set information
in the RX and TX descriptors, unused macros are being removed.
Signed-off-by: Larry Finger
---
.../net/wireless/realtek/rtlwifi/rtl8192cu/trx.h | 150 +
1 file changed, 3 insertions(+), 147 deletions
should be a little-endian word array (__le32 *).
That will be changed in the next patch.
Several places where checkpatch.pl complains about a space after a cast
and other warnings are fixed.
Signed-off-by: Larry Finger
---
.../net/wireless/realtek/rtlwifi/rtl8192cu/mac.c | 6 +-
.../net
direct read or replacement is used.
Signed-off-by: Larry Finger
---
.../net/wireless/realtek/rtlwifi/rtl8192cu/trx.h | 110 ++---
1 file changed, 55 insertions(+), 55 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h
b/drivers/net/wireless/realtek
These patches are part of a series intended to replace the bit-manipulation
macros used to set and read the various descriptors with a set of inline
routines.
Signed-off-by: Larry Finger
Larry Finger (4):
rtlwifi: rtl8192cu: Remove unused GET_XXX and SET_XXX
rtlwifi: rtl8192cu: Replace
As the first step in converting from macros that get/set information
in the RX and TX descriptors, unused macros are being removed.
Signed-off-by: Larry Finger
---
.../net/wireless/realtek/rtlwifi/rtl8192ee/trx.h | 243 +
1 file changed, 2 insertions(+), 241 deletions
an inline
routine.
Signed-off-by: Larry Finger
---
.../net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 38 ++-
.../net/wireless/realtek/rtlwifi/rtl8192ee/trx.h | 359 +++--
2 files changed, 203 insertions(+), 194 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi
should be a little-endian word array (__le32 *).
That will be changed in the next patch.
Several places where checkpatch.pl reports lines too long are fixed.
Signed-off-by: Larry Finger
---
.../net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 252 -
.../net/wireless/realtek/rtlwifi
A number of variables are initialized when declared that set later in the
routine, thus the initialization can be removed.
Signed-off-by: Larry Finger
---
.../net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 26 --
1 file changed, 14 insertions(+), 12 deletions(-)
diff
These patches are part of a series intended to replace the bit-manipulation
macros used to set and read the various descriptors with a set of inline
routines.
The final patch removes some variable initializations that are not needed.
Signed-off-by: Larry Finger
Larry Finger (5):
rtlwifi
direct read or replacement is used.
Signed-off-by: Larry Finger
---
.../net/wireless/realtek/rtlwifi/rtl8192ee/trx.h | 168 ++---
1 file changed, 84 insertions(+), 84 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.h
b/drivers/net/wireless/realtek
On 8/30/19 4:45 PM, Sergey Kharitonov wrote:
Sounds good!
I made a little change to compile that old rtl8192ee_revised.tar.bz2
driver on Linux 5.2.X and I get <1ms overall ping to the router with
rare spikes to 1-2ms.
I'm excited to know the right driver can provide the same performance,
it's sta
On 8/10/19 1:13 PM, Sergey Kharitonov wrote:
Dear Mr. Finger!
Thank you for paying attention to the problem. I've just posted an
updated information to that bug before receiving this message.
I get these results
~]$ ping 192.168.88.1
PING 192.168.88.1 (192.168.88.1) 56(84) bytes of data.
64 byte
If the call to hw_init() fails for any of the drivers, the driver will
leak memory that was allocated in BT coexistence setup. Technically, each
of the drivers should have done this free; however placing it in rtl_pci
fixes all the drivers with only a single patch.
Signed-off-by: Larry Finger
If the call to hw_init() fails for any of the drivers, the driver will
leak memory that was allocated in BT coexistence setup. Technically, each
of the drivers should have done this free; however placing it in rtl_pci
fixes all the drivers with only a single patch.
Signed-off-by: Larry Finger
On 8/20/19 9:08 AM, Kalle Valo wrote:
Larry Finger wrote:
In the process of converting the bit manipulation macros were converted
to use GENMASK(), the compiler reported a value too big for the field.
The offending statement was trying to write 0x100 into a 5-bit field.
An accompaning comment
Hi,
Prior to now, openSUSE has been packaging kernel firmware as a single entity;
however, that package has reached a size that has a negative impact on small
systems. Takashi Iwai has undertaken to split the firmware into a number of
sub-packages. In a discussion on the developer's mailing li
.
This error has been in the driver since its initial submission.
Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx")
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ne
On 8/10/19 1:13 PM, Sergey Kharitonov wrote:
Dear Mr. Finger!
Thank you for paying attention to the problem. I've just posted an
updated information to that bug before receiving this message.
I get these results
~]$ ping 192.168.88.1
PING 192.168.88.1 (192.168.88.1) 56(84) bytes of data.
64 byte
On 8/9/19 12:25 AM, Sergey Kharitonov wrote:
Dear Linux-Wireless,
Some time ago a bug was reported
https://bugzilla.kernel.org/show_bug.cgi?id=202943 related to
rtl8192ee, the essence of which is high ping latency (even to the
access point) without downloading something. If you generate a network
As the first step in converting from macros that get/set information
in the RX and TX descriptors, unused macros are being removed.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8192ce/trx.h | 330 +-
1 file changed, 4 insertions(+), 326 deletions(-)
diff
should be a little-endian word array (__le32 *).
That will be changed in the next patch.
Several places where checkpatch.pl complains about a space after a cast
are fixed.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8192ce/trx.c | 192
.../wireless/realtek/rtlwifi
an inline
routine.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8192ce/trx.c | 23 +-
.../wireless/realtek/rtlwifi/rtl8192ce/trx.h | 254 +-
2 files changed, 142 insertions(+), 135 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c
direct read or replacement is used.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8192ce/trx.h | 146 --
1 file changed, 62 insertions(+), 84 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.h
b/drivers/net/wireless/realtek/rtlwifi
These patches are part of a series intended to replace the bit-manipulation
macros used to set and read the various descriptors with a set of inline
routines.
The final patch removes a local configuration variable.
Signed-off-by: Larry Finger
Larry Finger (4):
rtlwifi: rtl8192ce: Remove
As the first step in converting from macros that get/set information
in the RX and TX descriptors, unused macros are being removed.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8188ee/trx.h | 267 +-
1 file changed, 6 insertions(+), 261 deletions(-)
diff
direct read or replacement is used.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8188ee/trx.h | 213 +-
1 file changed, 106 insertions(+), 107 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h
b/drivers/net/wireless/realtek/rtlwifi
These patches are part of a series intended to replace the bit-manipulation
macros used to set and read the various descriptors with a set of inline
routines.
The final patch removes a local configuration variable.
Signed-off-by: Larry Finger
Larry Finger (5):
rtlwifi: rtl8i188ee: Remove
should be a little-endian word array (__le32 *).
That will be changed in the next patch.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8188ee/dm.c | 6 +-
.../wireless/realtek/rtlwifi/rtl8188ee/trx.c | 222 ++---
.../wireless/realtek/rtlwifi/rtl8188ee/trx.h | 760
an inline
routine.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8188ee/dm.c | 7 +-
.../wireless/realtek/rtlwifi/rtl8188ee/trx.c | 35 +-
.../wireless/realtek/rtlwifi/rtl8188ee/trx.h | 438 +-
3 files changed, 243 insertions(+), 237 deletions(-)
diff
The configuration variable IS_LITTLE_ENDIAN is replaced by the standard
__LITTLE_ENDIAN. In addition, an unused struct is removed.
Signed-off-by: Larry Finger
---
.../net/wireless/realtek/rtlwifi/rtl8188ee/trx.h | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git
On 7/17/19 1:06 AM, Anton Sviridenko wrote:
Hello
we are using FN-8112MET PCB module having RTL8188ETV chip on it.
Device is running customized Linux version based on Linux 4.19 release.
Driver module "r8188eu" is not modified, taken from vanilla sources as
is.
Wi-Fi connection is used occasion
On 7/17/19 2:35 PM, mysec...@gmail.com wrote:
Dear !
RTL8191Su worked on ArchLinux, linux 5.2.0
Normal use of connecting wifi is no problem. But I want to switch it
to promiscuous mode, can't switch.
I want to ask if there will be an update to solve this problem?
On 6/10/19 1:49 PM, Michael Büsch wrote:
The WARN_ON triggers on older BCM4401-B0 100Base-TX ethernet controllers.
The warning serves no purpose. So let's just remove it.
Reported-by: H Buus
Signed-off-by: Michael Büsch
---
Acked-by: Larry Finger
Larry
diff --git a/driver
On 6/9/19 4:57 PM, Michael Büsch wrote:
On Sun, 9 Jun 2019 17:44:10 -0400
H Buus wrote:
I have an old 32 bit laptop with a BCM4401-B0 100Base-TX ethernet
controller. For every kernel from 4.19-rc1 going forward, I get a
warning and call trace within a few seconds of start up (see dmesg
snippet
On 5/29/19 9:29 PM, Tony Chuang wrote:
-Original Message-
From: Larry Finger [mailto:larry.fin...@gmail.com] On Behalf Of Larry Finger
Sent: Wednesday, May 29, 2019 11:17 PM
To: Tony Chuang; kv...@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 01/11] rtw88
On 5/29/19 2:54 AM, yhchu...@realtek.com wrote:
From: Yan-Hsuan Chuang
Some functions that should be static are unnecessarily exposed, remove
their declaration in header file phy.h.
After resolving their declaration order, they can be declared as static.
So this commit changes nothing except t
/workqueue.c:2415
| kthread+0x313/0x420 kernel/kthread.c:253
| ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352
Reported-by: syzbot+1fcc5ef45175fc774...@syzkaller.appspotmail.com
Signed-off-by: Ping-Ke Shih
I agree that this is a good fix.
Acked-by: Larry Finger
Larry
---
drivers/net
direct read or replacement is used.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8821ae/trx.h | 252 +-
drivers/net/wireless/realtek/rtlwifi/wifi.h | 1 +
2 files changed, 127 insertions(+), 126 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi
an inline
routine.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8821ae/dm.c | 3 +-
.../wireless/realtek/rtlwifi/rtl8821ae/trx.c | 51 +--
.../wireless/realtek/rtlwifi/rtl8821ae/trx.h | 310 +-
3 files changed, 185 insertions(+), 179 deletions(-)
diff
should be a little-endian word array (__le32 *).
That will be changed later.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8821ae/dm.c | 2 +-
.../wireless/realtek/rtlwifi/rtl8821ae/trx.c | 208 +++
.../wireless/realtek/rtlwifi/rtl8821ae/trx.h | 539
is to convert all drivers in rtlwifi. Once that is complete, most
of the remaining casts from u8 * to __le32 * will be eliminated.
Signed-off-by: Larry Finger
Larry Finger (4):
rtlwifi: rtl8821ae: Remove unused GET_XXX and SET_XXX descriptor
macros
rtlwifi: rtl8821ae: Replace local bit
As the first step in converting from macros that get/set information
in the RX and TX descriptors, unused macros are being removed.
Signed-off-by: Larry Finger
---
.../wireless/realtek/rtlwifi/rtl8821ae/trx.h | 157 +-
1 file changed, 2 insertions(+), 155 deletions(-)
diff
The driver uses complicated macros to set parts of word 0 of the TX and RX
descriptors. These are changed into inline routines.
Signed-off-by: Larry Finger
---
Kalle,
Based on your comment on how much you dislike those "byte macros", I have
converted a few of them from rtl8821ae i
On 5/1/19 1:30 PM, Kalle Valo wrote:
Larry Finger writes:
On 4/30/19 7:45 AM, Kalle Valo wrote:
I'm not really fond of these "byte macros" or whatever they should be
called, you use these a lot in rtw88 but I have seen the same usage also
other drivers. The upstream way of d
On 4/30/19 7:45 AM, Kalle Valo wrote:
I'm not really fond of these "byte macros" or whatever they should be
called, you use these a lot in rtw88 but I have seen the same usage also
other drivers. The upstream way of doing this is to create a struct,
which also acts as a documentation, and you can
On 4/16/19 8:34 PM, Pkshih wrote:
On Tue, 2019-04-16 at 19:35 -0500, Larry Finger wrote:
Somehow file drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c.rej was
incorporated into the sources. Obviously, it can be removed.
Signed-off-by: Larry Finger
Reported-by: Andrew Morton
Cc: Andrew
On 4/16/19 9:55 PM, Kalle Valo wrote:
Larry Finger writes:
Somehow file drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c.rej was
incorporated into the sources. Obviously, it can be removed.
Signed-off-by: Larry Finger
Reported-by: Andrew Morton
Cc: Andrew Morton
---
Andrew,
Thanks
Somehow file drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c.rej was
incorporated into the sources. Obviously, it can be removed.
Signed-off-by: Larry Finger
Reported-by: Andrew Morton
Cc: Andrew Morton
---
Andrew,
Thanks.
Larry
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee
active for some time, it is safe to remove this empty
function.
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
drivers/net/wireless/broadcom/b43/phy_lp.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/net/wireless/broadcom/b43/phy_lp.c
b/drivers/net/wireless/broadcom/b4
available in other routines. This variable is changed to be
local.
Signed-off-by: Larry Finger
---
V2 - Fixed Merge problem
---
.../net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 15 ---
.../wireless/realtek/rtlwifi/rtl8188ee/trx.c.rej | 10 ++
.../net/wireless/realtek/rtlwifi
Some of the drivers test the wrong bit in an RX descriptor. That is
fixed. In a second patch, that variable is moved out of a struct and
made local to the routine that uses it.
Signed-off-by: Larry Finger
---
V2 - Fixed Merge problem
Larry Finger (2):
rtlwifi: Fix duplicate tests of one of
in
the output of an optional debugging statement.
Signed-off-by: Larry Finger
---
V2 - Fixed Merge problem
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +-
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 2 +-
drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.c | 2 +-
3
On 3/8/19 7:55 AM, yhchu...@realtek.com wrote:
From: Yan-Hsuan Chuang
This is a new mac80211 driver for Realtek 802.11ac wireless network chips.
rtw88 now supports RTL8822BE/RTL8822CE now, with basic station mode
functionalities. The firmware for both can be found at linux-fimware.
https://git
On 3/8/19 8:06 AM, Greg KH wrote:
On Fri, Mar 08, 2019 at 09:55:43PM +0800, yhchu...@realtek.com wrote:
From: Yan-Hsuan Chuang
The rtlwifi driver is conflicting with Realtek's new 802.11ac chip
series driver rtw88, remove it to avoid racing with the same ID.
The rtw88 driver can be found at d
available in other routines. This variable is changed to be
local.
Signed-off-by: Larry Finger
---
.../net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 13 +++--
.../net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 13 +++--
.../net/wireless/realtek/rtlwifi/rtl8723be/trx.c | 14
in
a quantity output in an optional debugging statement.
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +-
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 2 +-
drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.c | 2 +-
3 files changed, 3
Some of the drivers test the wrong bit in an RX descriptor. That is
fixed. In a second patch, that variable is moved out of a struct and
made local to the routine that uses it.
Signed-off-by: Larry Finger
---
Larry Finger (2):
rtlwifi: Fix duplicate tests of one of the RX descriptors
rtlwifi
On 3/2/19 12:09 PM, David R. Bergstein wrote:
Larry,
I tried using iw but it gives the same reading for bit rate. In regard
to the firmware, it was not installed via "make install" so I did it
manually.
David,
There was a typo in the Makefile. 'make install' now installs the firmware
correc
1 - 100 of 1628 matches
Mail list logo
