Re: [linuxwifi] Slow performance (~30mbps) with Intel 9260 (and 8265, 3168) using 5G

2019-09-08 Thread Luciano Coelho
On Mon, 2019-09-09 at 14:09 +0800, Qu Wenruo wrote: > > On 2019/9/9 下午2:00, Luciano Coelho wrote: > > Hi, > > > > On Sun, 2019-09-08 at 06:45 +0800, Qu Wenruo wrote: > > > Hi, > > > > [...] > > > Any ideas how this could happen to

Re: [linuxwifi] Slow performance (~30mbps) with Intel 9260 (and 8265, 3168) using 5G

2019-09-08 Thread Luciano Coelho
Hi, On Sun, 2019-09-08 at 06:45 +0800, Qu Wenruo wrote: > Hi, > > Recent upgraded my wifi adapter from 8265 to 9260 of my ThinkPad X1C 6th > gen. > > However the initial test is producing some unacceptable results: > > Furthermore, my desktop (intel 3168), and the original 8265 of my laptop > a

Re: [linuxwifi] Issue with Intel(R) Wireless-AC 9260 in wifi direct in 5GHz

2019-09-04 Thread Luciano Coelho
Hi, Sorry for the delay. This bug was already reported[1] and fixed[2]. But it seems that you are unfortunately using an old kernel (v4.18) that hasn't been maintained for about 10 months... Please update your kernel or try to cherry-pick the patch on top of your tree. [1] https://bugzilla.kern

Re: [bug report] iwlwifi: Add support for SAR South Korea limitation

2019-08-23 Thread Luciano Coelho
Hi Dan, On Tue, 2019-08-06 at 17:24 +0300, Dan Carpenter wrote: > Hello Haim Dreyfuss, > > The patch 0c3d7282233c: "iwlwifi: Add support for SAR South Korea > limitation" from Feb 27, 2019, leads to the following static checker > warning: > > drivers/net/wireless/intel/iwlwifi/fw/acpi.c:16

Re: [PATCH] iwlwifi: mvm: fix old-style declaration

2019-08-22 Thread Luciano Coelho
On Fri, 2019-07-26 at 22:18 +0800, YueHaibing wrote: > There expect the 'static' keyword to come first in a > declaration, and we get a warning for this with "make W=1": > > drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:427:1: warning: > 'static' is not at beginning of declaration [-Wold-styl

Re: [PATCH net-next 07/10] iwlwifi: Use dev_get_drvdata where possible

2019-08-22 Thread Luciano Coelho
On Wed, 2019-07-24 at 19:27 +0800, Chuhong Yuan wrote: > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > > Signed-off-by: Chuhong Yuan > --- This patch is not relevant anymore because we have removed all D0i3/runtime PM code. Thanks anyway! -- Cheer

Re: Regression with the latest iwlwifi 9260 and Canon Point firmware

2019-08-21 Thread Luciano Coelho
On Thu, 2019-08-22 at 09:50 +0300, Luciano Coelho wrote: > On Mon, 2019-07-29 at 19:49 +0100, Peter Robinson wrote: > > Hi Luca, > > > > Similar to the issues seen in the thread on [1] thje 9260 we're seeing > > the same reports in Fedora on both versions of the fi

Re: Regression with the latest iwlwifi 9260 and Canon Point firmware

2019-08-21 Thread Luciano Coelho
On Mon, 2019-07-29 at 19:49 +0100, Peter Robinson wrote: > Hi Luca, > > Similar to the issues seen in the thread on [1] thje 9260 we're seeing > the same reports in Fedora on both versions of the firmware [2], on > both the 9260 series but also the Cannon Point-LP CNVi wifi devices as > well. Ther

Re: [PATCH 4/5] iwlwifi: mvm: remove unused .remove_sta_debugfs callback

2019-07-05 Thread Luciano Coelho
On Wed, 2019-06-12 at 16:26 +0200, Greg Kroah-Hartman wrote: > The .remove_sta_debugfs callback was not doing anything in this driver, > so remove it as it is not needed. > > Cc: Johannes Berg > Cc: Emmanuel Grumbach > Cc: Luca Coelho > Cc: Intel Linux Wireless > Cc: Kalle Valo > Cc: "David S

Re: [PATCH 3/5] iwlwifi: dvm: no need to check return value of debugfs_create functions

2019-07-05 Thread Luciano Coelho
On Wed, 2019-06-12 at 16:26 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. This driver was saving the debugfs file away to be > removed at a later time. However, the 80211 core would delete the whole > directory that the debug

Re: [PATCH 3/3] iwlwifi: add support for quz firmwares

2019-07-02 Thread Luciano Coelho
On Mon, 2019-05-20 at 10:42 +0200, Bjørn Mork wrote: > Luca Coelho writes: > > > --- a/drivers/net/wireless/intel/iwlwifi/iwl-config.h > > +++ b/drivers/net/wireless/intel/iwlwifi/iwl-config.h > > @@ -549,6 +549,7 @@ extern const struct iwl_cfg iwl22000_2ac_cfg_hr; > > extern const struct iwl_cf

Re: [PATCH] iwlwifi: add support for hr1 RF ID

2019-06-20 Thread Luciano Coelho
On Thu, 2019-06-20 at 13:30 +0300, Luciano Coelho wrote: > Hi Kalle, > > Please take this to 5.1-rc* as well. I obviously meant 5.2-rc*. Thanks! -- Luca.

Re: [PATCH] iwlwifi: add support for hr1 RF ID

2019-06-20 Thread Luciano Coelho
load the hr FW when hr1 RF ID is detected. > > Cc: sta...@vger.kernel.org # 5.1+ > Signed-off-by: Oren Givon > Signed-off-by: Luciano Coelho > --- > drivers/net/wireless/intel/iwlwifi/iwl-csr.h| 1 + > drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 8 +--- &g

Re: [PATCH 0/8] iwlwifi: updates intended for v5.2 2019-04-23

2019-04-23 Thread Luciano Coelho
On Tue, 2019-04-23 at 11:50 +0300, Luca Coelho wrote: > From: Luca Coelho > > Hi, > > Here's the fifth set of patches intended for v5.2. It's the usual > development, new features, cleanups and bugfixes. > > The changes are: > > * Fix a bug we introduced in the RX path in a previous patch; >

Re: [PATCH 06/16] mac80211_hwsim: make copying of ciphers safer by checking the length

2019-03-15 Thread Luciano Coelho
On Fri, 2019-03-15 at 18:36 +0200, Luca Coelho wrote: > From: Luca Coelho > > Make sure the length of the ciphers we are copying never exceeds the > space we have for storing them. There is no risk of overcopying at > the moment, because we check n_params before, but this makes this > function s

Re: [linuxwifi] [RFC] iwlwifi: enable TX AMPDU for some iwldvm

2019-03-12 Thread Luciano Coelho
Hi Kevin, Johannes (johill) is also in this list. :) If this feature was explicitly disabled, it certainly means that something was causing problems with it, so I'd be wary to enable it for all DVM devices. I guess we could enable it by default for devices that work fine, but we would have to ru

Re: [PATCH v2] cfg80211: Include the PMK and PMKID in NL80211_CMD_EXTERNAL_AUTH

2019-03-08 Thread Luciano Coelho
On Fri, 2019-02-22 at 13:41 +0100, Johannes Berg wrote: > > +++ b/net/wireless/nl80211.c > > @@ -13098,6 +13098,12 @@ static int nl80211_external_auth(struct > > sk_buff *skb, struct genl_info *info) > > if (!info->attrs[NL80211_ATTR_STATUS_CODE]) > > return -EINVAL; > > > > + i

Re: [PATCH] iwlwifi: fix 64-bit division

2019-03-05 Thread Luciano Coelho
On Tue, 2019-03-05 at 09:37 +0100, Arnd Bergmann wrote: > On Tue, Mar 5, 2019 at 7:44 AM Luciano Coelho < > luciano.coe...@intel.com> wrote: > > On Mon, 2019-03-04 at 21:38 +0100, Arnd Bergmann wrote: > > This was already fixed with this patch: > > > > https:/

Re: [PATCH] iwlwifi: fix 64-bit division

2019-03-04 Thread Luciano Coelho
Hi Arnd, On Mon, 2019-03-04 at 21:38 +0100, Arnd Bergmann wrote: > do_div() expects unsigned operands and otherwise triggers a warning > like: > > drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c:465:2: error: > comparison of distinct pointer types ('typeof ((rtt_avg)) *' (aka > 'long long

Re: [PATCH v2] iwlwifi: mvm: Use div_s64 instead of do_div in iwl_mvm_debug_range_resp

2019-02-21 Thread Luciano Coelho
On Thu, 2019-02-21 at 16:13 -0800, Nick Desaulniers wrote: > On Thu, Feb 21, 2019 at 12:08 AM Nathan Chancellor > wrote: > > Clang warns: > > > > drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c:465:2: > > warning: > > comparison of distinct pointer types ('typeof ((rtt_avg)) *' (aka > > 'l

Re: [PATCH] iwlwifi: mvm: Use div64_s64 instead of do_div in iwl_mvm_debug_range_resp

2019-02-20 Thread Luciano Coelho
On Wed, 2019-02-20 at 10:56 -0700, Nathan Chancellor wrote: > On Wed, Feb 20, 2019 at 11:51:34AM +0100, Arnd Bergmann wrote: > > On Tue, Feb 19, 2019 at 7:22 PM Nathan Chancellor > > wrote: > > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ftm- > > > initiator.c b/drivers/net/wireless/inte

Re: [PATCH v2 2/2] iwlwifi: Use struct_size() in kzalloc

2019-02-13 Thread Luciano Coelho
On Tue, 2019-01-29 at 11:21 +0800, YueHaibing wrote: > Use struct_size() in kzalloc instead of the 'regd_to_copy' > > Signed-off-by: YueHaibing > --- Applied to our internal tree and it will reach the mainline following our normal upstreaming process. Thanks! -- Luca.

Re: [PATCH v2 1/2] iwlwifi: Use kmemdup instead of duplicating its function

2019-02-13 Thread Luciano Coelho
On Tue, 2019-01-29 at 11:21 +0800, YueHaibing wrote: > Use kmemdup rather than duplicating its implementation > > Signed-off-by: YueHaibing > --- > drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/wir

Re: [PATCH 14/17] iwlwifi: fix fallthrough comment in iwl-dnt-cfg.c

2019-01-31 Thread Luciano Coelho
On Wed, 2019-01-30 at 13:55 +0200, Luca Coelho wrote: > From: Shahar S Matityahu > > I placed the fall through comment in the wrong case. Move it to the > right place. > > Signed-off-by: Luca Coelho > --- Oops, this came out with the wrong commit message, I'll replace it with the proper one.

Re: [PATCH] iwlwifi: pcie: no need to check return value of debugfs_create functions

2019-01-25 Thread Luciano Coelho
On Tue, 2019-01-22 at 16:21 +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic > should > never do something different based on this. > > Cc: Johannes Berg > Cc: Emmanuel Grumbach

Re: [PATCH] iwlwifi: dvm: no need to check return value of debugfs_create functions

2019-01-25 Thread Luciano Coelho
On Tue, 2019-01-22 at 16:21 +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic > should > never do something different based on this. > > Cc: Johannes Berg > Cc: Emmanuel Grumbach

Re: [PATCH] iwlwifi: mvm: no need to check return value of debugfs_create functions

2019-01-25 Thread Luciano Coelho
On Tue, 2019-01-22 at 16:21 +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic > should > never do something different based on this. > > Cc: Johannes Berg > Cc: Emmanuel Grumbach

Re: [PATCH] iwlwifi: fw: no need to check return value of debugfs_create functions

2019-01-25 Thread Luciano Coelho
On Tue, 2019-01-22 at 16:21 +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic > should > never do something different based on this. > > Cc: Johannes Berg > Cc: Emmanuel Grumbach

Re: [PATCH] iwlwifi: iwl-drv: no need to check return value of debugfs_create functions

2019-01-25 Thread Luciano Coelho
On Tue, 2019-01-22 at 16:21 +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic > should > never do something different based on this. > > Cc: Johannes Berg > Cc: Emmanuel Grumbach

Re: [PATCH] iwlwifi: mvm: remove duplicated include from ops.c

2019-01-22 Thread Luciano Coelho
On Thu, 2019-01-17 at 15:00 +0800, YueHaibing wrote: > Remove duplicated include. > > Signed-off-by: YueHaibing > --- Dropped, this is a duplicate. -- Cheers, Luca.

Re: [PATCH] iwlwifi: eeprom-parse: use struct_size() in kzalloc()

2019-01-22 Thread Luciano Coelho
On Tue, 2019-01-08 at 11:17 -0600, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is > finding the > size of a structure that has a zero-sized array at the end, along > with memory > for some number of elements for that array. For example: > > struct foo

Re: [PATCH][next] iwlwifi: mvm: use struct_size() in kzalloc()

2019-01-22 Thread Luciano Coelho
On Tue, 2019-01-15 at 16:02 -0600, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is > finding the > size of a structure that has a zero-sized array at the end, along > with memory > for some number of elements for that array. For example: > > struct foo

Re: [PATCH] iwlwifi: nvm-parse: use struct_size() in kzalloc()

2019-01-22 Thread Luciano Coelho
On Tue, 2019-01-08 at 11:55 -0600, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is > finding the > size of a structure that has a zero-sized array at the end, along > with memory > for some number of elements for that array. For example: > > struct foo

Re: [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS

2019-01-22 Thread Luciano Coelho
On Mon, 2019-01-21 at 23:31 +, Sinan Kaya wrote: > There is an unresolved dependency as follows: > > IWLWIFI_LEDS selects MAC80211_LEDS. > MAC80211_LEDS depends on MAC80211. > > It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 > (n) > > WARNING: unmet direct dependencies de

Re: linux-next: build warnings after merge of the wireless-drivers-next tree

2018-12-03 Thread Luciano Coelho
On Fri, 2018-11-30 at 09:43 +0200, Kalle Valo wrote: > Stephen Rothwell writes: > > > Hi Kalle, > > > > On Fri, 30 Nov 2018 06:33:47 +0200 Kalle Valo > > wrote: > > > I take it that -Wimplict-fallthrough is not enabled by default > > > yet? So > > > Dave and Linus won't see these warnings? > >

Re: [PATCH 05/15] iwlwifi: don't define OTP_LOW_IMAGE_SIZE per family, but per size

2018-12-03 Thread Luciano Coelho
On Thu, 2018-11-29 at 12:01 +0200, Kalle Valo wrote: > Luca Coelho writes: > > > From: Luca Coelho > > > > Using OTP_LOW_IMAGE_SIZE_FAMILY_8000/9000/22000 only obfuscates the > > actual values, since these 3 are the same. Redefine the values per > > size so it's easier to understand and compar

Re: [PATCH] iwlwifi: mvm: remove duplicated include from ops.c

2018-12-03 Thread Luciano Coelho
On Fri, 2018-11-30 at 19:24 +0800, YueHaibing wrote: > Remove duplicated include. > > Signed-off-by: YueHaibing > --- Thanks! I applied this to our internal tree and it will reach the mainline following our normal upstreaming process. -- Cheers, Luca.

Re: [PATCH] iwlwifi: fix spelling mistake "registrating" -> "registering"

2018-10-17 Thread Luciano Coelho
On Thu, 2018-10-11 at 10:57 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in IWL_ERR error message > > Signed-off-by: Colin Ian King > --- Thanks Colin. I've applied this in our internal tree and it will eventually reach the mainline, following our normal

Re: [PATCH] iwlwifi: mvm: fix spelling mistake "Recieved" -> "Received"

2018-10-17 Thread Luciano Coelho
On Tue, 2018-10-16 at 18:22 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in IWL_DEBUG_TE message text. > > Signed-off-by: Colin Ian King > --- Hi Colin, You already sent this patch before and it has already been applied in our internal tree and will reac

Re: [PATCH] iwlwifi: acpi: Use kmemdup rather than duplicating its implementation in iwl_parse_nvm_mcc_info

2018-10-17 Thread Luciano Coelho
On Fri, 2018-10-05 at 09:02 +, YueHaibing wrote: > Use kmemdup rather than duplicating its implementation > > Signed-off-by: YueHaibing > --- Thanks, YueHaibing. I have applied this in our internal tree and it will eventually reach the mainline, following our normal upstreaming process. I

Re: [PATCH] iwlwifi: mvm: remove set but not used variable 'he_phy_data'

2018-10-17 Thread Luciano Coelho
On Fri, 2018-10-05 at 10:47 +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c: In function > 'iwl_mvm_rx_mpdu_mq': > drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c:1386:7: warning: > variable 'he_phy_data' set but not used [

Re: [PATCH] iwlwifi: mvm: check return value of rs_rate_from_ucode_rate()

2018-10-12 Thread Luciano Coelho
On Sat, 2018-10-13 at 09:46 +0300, Luca Coelho wrote: > From: Luca Coelho > > The rs_rate_from_ucode_rate() function may return -EINVAL if the rate > is invalid, but none of the callsites check for the error, > potentially > making us access arrays with index IWL_RATE_INVALID, which is larger > t

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Luciano Coelho
On Wed, 2018-10-03 at 15:15 +0800, Kai-Heng Feng wrote: > To avoid the firmware loading race between Bluetooth and WiFi on Intel > 8260, load firmware exclusively when BT_INTEL is enabled. > > Signed-off-by: Kai-Heng Feng > --- Where is this coming from? Can you explain what "the firmware loadin

Re: [PATCH v2] iwlwifi: mvm: enable sending HE_AIR_SNIFFER command via debugfs

2018-09-27 Thread Luciano Coelho
On Fri, 2018-09-28 at 08:23 +0300, Luca Coelho wrote: > From: Shaul Triebitz > > In order to receive TB (Trigger Based) PPDU in monitor mode, > the Driver must send the HE_AIR_SNIFFER_CONFIG_CMD host command. > Enable that via debugfs. > > Signed-off-by: Liad Kaufman > Signed-off-by: Ido Yariv

Re: [linuxwifi] iwlwifi crash with Linux 4.18.9

2018-09-25 Thread Luciano Coelho
On Wed, 2018-09-26 at 06:50 +0200, Udo Steinberg wrote: > Hello all, Hi Udo, > I'm experiencing an iwlwifi crash with Linux 4.18.9 in the following > situation: > 1) I'm suspending the laptop (into S3 sleep state) > 2) Sometimes the laptop immediately wakes up again (as if a wake > event fir

Re: acpi/iwlwifi: thermal thermal_zone3: failed to read out thermal zone (-61)

2018-09-20 Thread Luciano Coelho
On Thu, 2018-09-20 at 16:45 +0200, Sedat Dilek wrote: > On Thu, Sep 20, 2018 at 4:34 PM, Luciano Coelho > wrote: > > On Thu, 2018-09-20 at 15:42 +0200, Sedat Dilek wrote: > > > Hi, > > > > Hi, > > > > > > > I am seeing this with L

Re: acpi/iwlwifi: thermal thermal_zone3: failed to read out thermal zone (-61)

2018-09-20 Thread Luciano Coelho
On Thu, 2018-09-20 at 15:42 +0200, Sedat Dilek wrote: > Hi, Hi, > I am seeing this with Linux v4.18.y and v4.19-rc4. > > Investigating thermal_zone3... > > # cat /sys/devices/virtual/thermal/thermal_zone3/type > iwlwifi > > I have the following iwlwifi device and firmware installed... > > [

Re: [PATCH] Fix Bug 199967 - change WARN_ON(1) to IWL_ERR()

2018-08-18 Thread Luciano Coelho
On Sat, 2018-08-18 at 09:52 -0700, Joe Perches wrote: > On Sat, 2018-08-18 at 09:11 -0700, Nye Liu wrote: > > On 8/18/2018 1:41 AM, Luciano Coelho wrote: > > > > > On Fri, 2018-08-17 at 20:35 -0700, Nye Liu wrote: > > > > The TX_STATUS_FAIL_DEST_PS case fil

Re: [PATCH] Fix Bug 199967 - change WARN_ON(1) to IWL_ERR()

2018-08-18 Thread Luciano Coelho
On Fri, 2018-08-17 at 20:35 -0700, Nye Liu wrote: > The TX_STATUS_FAIL_DEST_PS case fills logs with full backtraces, which > are pretty useless. Just do IWL_ERR() printk. > > Signed-off-by: Nye Liu > --- > drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [PATCH 00/16] iwlwifi: updates intended for v4.19 2018-07-27

2018-08-01 Thread Luciano Coelho
On Wed, 2018-08-01 at 11:17 +0300, Kalle Valo wrote: > Luciano Coelho writes: > > > On Wed, 2018-08-01 at 10:56 +0300, Kalle Valo wrote: > > > Luca Coelho writes: > > > > > > > From: Luca Coelho > > > > > > > > Hi, >

Re: [PATCH 00/16] iwlwifi: updates intended for v4.19 2018-07-27

2018-08-01 Thread Luciano Coelho
On Wed, 2018-08-01 at 10:56 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: Luca Coelho > > > > Hi, > > > > Here's one more set of patches intended for v4.19. It contains > > some > > bugfixes, cleanups and more work on supporting the 22560 family of > > devices. > > > > The chang

Re: [linuxwifi] pull-request: iwlwifi-next 2018-07-26

2018-07-26 Thread Luciano Coelho
Oops, wrong subject. Fixed now, it should obviously have been 2018-07- 26. -- Luca. On Thu, 2018-07-26 at 15:38 +0300, Luca Coelho wrote: > Hi Kalle, > > This is the first batch of patches intended for v4.19. It includes > the > two patches sets I sent a few weeks ago, with HE support and new

Re: [PATCH v1 3/4] iwlwifi: Remove unnecessary include of

2018-07-25 Thread Luciano Coelho
On Wed, 2018-07-25 at 14:52 -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > This part of the iwlwifi driver doesn't need anything provided by > pci-aspm.h, so remove the unnecessary include of it. > > Signed-off-by: Bjorn Helgaas > --- Acked-by: Luca Coelho Thanks! -- Cheers, Luca.

Re: [PATCH] WHENCE: Fix typo Version v3

2018-07-06 Thread Luciano Coelho
Hi, On Thu, 2018-05-17 at 17:20 +0200, Sedat Dilek wrote: > I have seen that in the WHENCE file there is "Version" with and > without ":", mostly iwlwifi ucodes. > > As an example: > > File: iwlwifi-8265-36.ucode > -Version 36.e91976c0.0 > +Version: 36.e91976c0.0 > > The usual case is "Version

Re: [linuxwifi] iwlwifi is not working after doing the reboot by pressing RESET button

2018-07-06 Thread Luciano Coelho
HTML emails don't go through to the mailing lists at vger.kernel.org, so please don't use HTML. On Fri, 2018-07-06 at 08:40 +, Palanisamy, Rameshbabu wrote: > Hi Team, > > > I am using intel 8265 NGW wifi card in intel leafhill board. > > We have enabled the Intel -wifi card in the Leaf_

Re: [PATCH v2 0/4] iwlwifi: updates intended for v4.19 2018-06-26

2018-06-30 Thread Luciano Coelho
On Sat, 2018-06-30 at 11:42 +0300, Luca Coelho wrote: > Here's v2 of the patches I sent out Tuesday. It fixes some > bitfield.h > warnings reported by kbuildbot in .../iwlwifi/fw/api/rx.h. > > There is still one compiler warning in this series, but that's > actually a bug in bitfield.h itself. J

Re: [PATCH 3/3] mac80211: add support for HE

2018-06-08 Thread Luciano Coelho
On Fri, 2018-06-08 at 10:12 +0300, Luca Coelho wrote: > From: Luca Coelho > > Add support for HE in mac80211 conforming with P802.11ax_D1.4. > > Signed-off-by: Liad Kaufman > Signed-off-by: Johannes Berg > Signed-off-by: Ilan Peer > Signed-off-by: Ido Yariv > Signed-off-by: Luca Coelho > --

Re: [linux-firmware] Version in WHENCE file

2018-05-16 Thread Luciano Coelho
On Mon, 2018-05-07 at 09:47 +0200, Sedat Dilek wrote: > On Sun, May 6, 2018 at 3:07 PM, Luciano Coelho com> wrote: > > On Sun, 2018-05-06 at 14:46 +0200, Sedat Dilek wrote: > > > Hi Luca, > > > > > > I hope I catched the correct MLs (not sure if linux-fir

Re: [linux-firmware] Version in WHENCE file

2018-05-06 Thread Luciano Coelho
On Sun, 2018-05-06 at 14:46 +0200, Sedat Dilek wrote: > Hi Luca, > > I hope I catched the correct MLs (not sure if linux-firmware has a > ML, > I did not found any in the MAINTAINERS file). > > I have seen that in the WHENCE file there is "Version" with and > without ":", mostly iwlwifi ucodes. >

Re: linux-next: manual merge of the wireless-drivers-next tree with the wireless-drivers tree

2018-04-26 Thread Luciano Coelho
On Thu, 2018-04-26 at 13:33 +0300, Kalle Valo wrote: > Luciano Coelho writes: > > > On Thu, 2018-04-26 at 11:09 +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > Today's linux-next merge of the wireless-drivers-next tree got a > > > c

Re: [PATCH v2 12/12] iwlwifi: pcie: remove non-responsive device

2018-04-26 Thread Luciano Coelho
Ooops, I obviously meant "PATCH v2 09/12" in the subject. -- Luca. On Thu, 2018-04-26 at 10:53 +0300, Luca Coelho wrote: > From: Luca Coelho > > If we fail to to grab NIC access because the device is not responding > (i.e. CSR_GP_CNTRL returns 0x), remove the device from the > PCI > bu

Re: linux-next: manual merge of the wireless-drivers-next tree with the wireless-drivers tree

2018-04-26 Thread Luciano Coelho
On Thu, 2018-04-26 at 11:09 +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the wireless-drivers-next tree got a > conflict in: > > drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c > > between commit: > > 77e30e10ee28 ("iwlwifi: mvm: query regdb for wmm rule if ne

Re: linux-next: Signed-off-by missing for commit in the wireless-drivers-next tree

2018-04-24 Thread Luciano Coelho
Hi, On Wed, 2018-04-25 at 10:56 +1000, Stephen Rothwell wrote: > Hi all, > > Commit > > 84226ca1c5d3 ("iwlwifi: mvm: support offload of AMSDU rate > control") > > is missing a Signed-off-by from its author. I checked this and it should be fine. The author is actually wrong in the commit. S

Re: [BUG] iwlwifi: Microcode SW error detected. Restarting 0x2000000.

2018-04-23 Thread Luciano Coelho
On Mon, 2018-04-23 at 15:05 +0300, Mika Westerberg wrote: > Hi, Hi Mika, > On my Lenovo X1 Carbon gen 5 system,after I upgraded to v4.17-rc1 > iwlwifi started to fail with following splats on dmesg: > > iwlwifi :04:00.0: Microcode SW error detected. Restarting > 0x200. > iwlwifi 00

Re: New sparse warning from min_t(): expression using sizeof(void)

2018-04-22 Thread Luciano Coelho
On Sat, 2018-04-21 at 11:54 +0300, Kalle Valo wrote: > Joey Pabalinas writes: > > > On Sat, Apr 21, 2018 at 10:50:51AM +0300, Kalle Valo wrote: > > > Is there any way to fix it? With ath10k I use sparse a lot and > > > because > > > of these warnings sparse is now very annoying to use. > > > > I

Re: [PATCH 01/25] iwlwifi: mvm: add traffic condition monitoring (TCM)

2018-04-13 Thread Luciano Coelho
On Fri, 2018-04-13 at 15:42 +0300, Luca Coelho wrote: > From: Luca Coelho > > Traffic condition monitor gathers data about the traffic load and > other conditions and can be used to make decisions regarding latency, > throughput etc. This patch introduces the code and data structures > to > coll

Re: iwlwifi: FW error in SYNC CMD TIME_QUOTA_CMD

2018-04-09 Thread Luciano Coelho
On Mon, 2018-04-09 at 15:37 +0200, Daniel Borkmann wrote: > On 04/09/2018 12:13 AM, Daniel Borkmann wrote: > > Hi Luciano, > > > > On 04/07/2018 08:54 AM, Luciano Coelho wrote: > > > On Thu, 2018-04-05 at 16:55 +0200, Daniel Borkmann wrote: > > > > [..

Re: iwlwifi: FW error in SYNC CMD TIME_QUOTA_CMD

2018-04-07 Thread Luciano Coelho
On Sat, 2018-04-07 at 09:54 +0300, Luciano Coelho wrote: > On Thu, 2018-04-05 at 16:55 +0200, Daniel Borkmann wrote: > > Hey guys, > > Hi Daniel, > > > > after upgrading to 4608f064532c ("Merge > > git://git.kernel.org/pub/scm/linux/kernel/git/dav

Re: iwlwifi: FW error in SYNC CMD TIME_QUOTA_CMD

2018-04-06 Thread Luciano Coelho
On Thu, 2018-04-05 at 16:55 +0200, Daniel Borkmann wrote: > Hey guys, Hi Daniel, > after upgrading to 4608f064532c ("Merge > git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next") > my kernel log gets constantly flooded with the below message and > wireless stops > working ... just in

Re: [PATCH 14/14] iwlwifi: wrt: add fw force restart via triggers

2018-03-28 Thread Luciano Coelho
On Wed, 2018-03-28 at 19:23 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: Shahar S Matityahu > > > > Add support to wrt force restart capability. > > > > Signed-off-by: Shahar S Matityahu > > Signed-off-by: Luca Coelho > > The commit log is not telling much. Right, I'll expand

Re: [PATCH 07/14] iwlwifi: mvm: add support for oce

2018-03-28 Thread Luciano Coelho
On Wed, 2018-03-28 at 19:20 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: "Zamir, Roee" > > > > Get capabilities from the fw, expose them with nl80211, and enable > > them > > in UMAC scan if the relevant nl80211 flags are set by the > > userspace. > > > > Signed-off-by: Roee Zami

Re: [PATCH 06/14] iwlwifi: mvm: add adaptive dwell support

2018-03-28 Thread Luciano Coelho
On Wed, 2018-03-28 at 19:18 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: "Zamir, Roee" > > > > Update the scan command API with support for adaptive dwell > > and add a debugfs entry to configure max budget parameter. > > > > Signed-off-by: Roee Zamir > > Signed-off-by: Beni Lev

Re: [PATCH] iwlwifi: add device ID for Rivet Networks Killer Wireless-AC 1550

2018-03-27 Thread Luciano Coelho
On Tue, 2018-03-27 at 14:48 +0200, Izzy Kulbe wrote: > On Tue, 2018-03-27 at 15:38 +0300, Luciano Coelho wrote: > > On Tue, 2018-03-27 at 15:37 +0300, Luciano Coelho wrote: > > > On Tue, 2018-03-27 at 14:03 +0200, Izzy Kulbe wrote: > > > Wait a bit. This ID looks str

Re: [PATCH] iwlwifi: add device ID for Rivet Networks Killer Wireless-AC 1550

2018-03-27 Thread Luciano Coelho
On Tue, 2018-03-27 at 15:37 +0300, Luciano Coelho wrote: > On Tue, 2018-03-27 at 14:03 +0200, Izzy Kulbe wrote: > > On Tue, 2018-03-27 at 14:48 +0300, Kalle Valo wrote: > > > Izzy Kulbe writes: > > > > > > > nvm the last message, attached the wrong file usi

Re: [PATCH] iwlwifi: add device ID for Rivet Networks Killer Wireless-AC 1550

2018-03-27 Thread Luciano Coelho
On Tue, 2018-03-27 at 14:03 +0200, Izzy Kulbe wrote: > On Tue, 2018-03-27 at 14:48 +0300, Kalle Valo wrote: > > Izzy Kulbe writes: > > > > > nvm the last message, attached the wrong file using the 9270 > > > instead of the 9260 firmware, which obviously wouldn't work. > > > Here's the working pat

Re: [PATCH 12/13] mac80211: limit wmm params to comply with ETSI requirements

2018-02-18 Thread Luciano Coelho
On Mon, 2018-02-19 at 07:54 +0200, Kalle Valo wrote: > Luca Coelho writes: > > > From: Haim Dreyfuss > > > > ETSI has recently restricted the WMM parameters values for > > 5GHz frequencies. There are two scenarios which may cause > > to violate ETSI requirements. > > 1. Using mac80211 default v

Re: [PATCH 18/20] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE_RTPM default

2018-02-14 Thread Luciano Coelho
On Mon, 2018-02-05 at 02:21 +0100, Ulf Magnusson wrote: > 'default false' should be 'default n', though they happen to have the > same effect here, due to undefined symbols ('false' in this case) > evaluating to n in a tristate sense. > > Remove the default instead of changing it. bool and tristat

Re: iwlegacy: Please change led_mode default to _LED_RF_STATE

2018-01-23 Thread Luciano Coelho
On Tue, 2018-01-23 at 12:55 +0100, c...@abwesend.de wrote: > Good morning, :-) > > In iwlegacy/common.c, when module_param(led_mode) is not set by the > user (i.e. it is 0=IL_LED_DEFAULT), then il_leds_init() uses the > device's cfg->led_mode as the default. That inheritance is ok for > devices th

Re: UBSAN: Undefined behaviour in drivers/net/wireless/intel/iwlwifi/mvm/utils.c:838:5

2017-12-13 Thread Luciano Coelho
On Wed, 2017-12-13 at 14:25 +0100, Paul Menzel wrote: > Dear Linux folks, > > > I enabled the undefined behavior sanitizer, and built Linus’ master > branch under Ubuntu 17.10 with gcc (Ubuntu 7.2.0-8ubuntu3) 7.2.0. > > ``` > $ grep UBSAN /boot/config-4.15.0-rc3+ > CONFIG_ARCH_HAS_UBSAN_SANITIZ

Re: [PATCH v2 06/15] iwlwifi: mvm: rs: add ops for the new rate scaling in the FW

2017-12-08 Thread Luciano Coelho
On Fri, 2017-12-08 at 14:38 +0200, Kalle Valo wrote: > Luca Coelho writes: > > > From: Gregory Greenman > > > > This patch introduces a new instance of rate_control_ops for > > the new API (adding only empty stubs here and the subsequent > > patches in the series will fill in the implementation

Re: [PATCH 13/15] iwlwifi: mvm: mark MIC stripped MPDUs

2017-12-04 Thread Luciano Coelho
On Sat, 2017-12-02 at 18:28 +0200, Luca Coelho wrote: > From: Sara Sharon > > When RADA is active, the hardware decrypts the packets and strips off > the MIC as it is useless after decryption. Indicate that to mac80211. > > Signed-off-by: Sara Sharon > Signed-off-by: Luca Coelho > --- > drive

Re: [PATCH 12/15] iwlwifi: mvm: enable RX offloading with TKIP and WEP

2017-12-04 Thread Luciano Coelho
On Sat, 2017-12-02 at 18:28 +0200, Luca Coelho wrote: > From: David Spinadel > > Set the flag that indicates that ICV was stripped on if > this option was enabled in the HW. > > Signed-off-by: David Spinadel > Signed-off-by: Luca Coelho > --- I'll move this to my fixes series, because it's ne

Re: [PATCH 1/5] mac80211: always update the PM state of a peer on MGMT / DATA frames

2017-12-01 Thread Luciano Coelho
On Fri, 2017-12-01 at 13:09 +0100, Johannes Berg wrote: > On Fri, 2017-12-01 at 13:48 +0200, Luciano Coelho wrote: > > > > FTR, I'm sending a separate patch with the hwsim fix, as we agreed, > > as > > part of the patchset I'm sending today. > > >

Re: [PATCH 1/5] mac80211: always update the PM state of a peer on MGMT / DATA frames

2017-12-01 Thread Luciano Coelho
On Mon, 2017-10-30 at 09:48 +0100, Johannes Berg wrote: > On Sun, 2017-10-29 at 11:51 +0200, Luca Coelho wrote: > > From: Emmanuel Grumbach > > > > The 2016 version of the spec is more generic about when the > > AP should update the power management state of the peer: > > the AP shall update the

Re: [PATCH 08/11] iwlwifi: mvm: Add debugfs support for FTM initiator fields

2017-11-28 Thread Luciano Coelho
On Tue, 2017-11-28 at 21:34 +0800, kbuild test robot wrote: > Hi Adiel, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on wireless-drivers-next/master] > [also build test ERROR on v4.15-rc1 next-20171128] > [if your patch is applied to the wrong git tree, please

Re: iwlwifi 8265 firmware crash vith v34 on linux 4.14

2017-11-14 Thread Luciano Coelho
Hi Thomas, On Tue, 2017-11-14 at 21:49 +0200, Thomas Backlund wrote: > Running a Lenovo Yoga 720 with kernel 4.14, I pulled the: > git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/linux- > firmware.git > tags/iwlwifi-fw-2017-11-03 > > to try the new fw version 34 on my: > 3f:00.0 Network co

Re: [PATCH] iwlwifi: fix firmware names for 9xxx and a0 series hw

2017-11-14 Thread Luciano Coelho
On Tue, 2017-11-14 at 12:48 +0100, Greg KH wrote: > On Tue, Nov 14, 2017 at 01:38:20PM +0200, Luciano Coelho wrote: > > On Tue, 2017-11-14 at 13:29 +0200, Thomas Backlund wrote: > > > Den 14-11-2017 kl. 12:52, skrev Luca Coelho: > > > > On Tue, 2017-11-14 at 12:3

Re: [PATCH] iwlwifi: fix firmware names for 9xxx and a0 series hw

2017-11-14 Thread Luciano Coelho
On Tue, 2017-11-14 at 13:29 +0200, Thomas Backlund wrote: > Den 14-11-2017 kl. 12:52, skrev Luca Coelho: > > On Tue, 2017-11-14 at 12:37 +0200, Thomas Backlund wrote: > > > iwlwifi 9xxx and a0 series hw contains an extra dash in firmware > > > file > > > name > > > as seeen in modinfo output for ke

Re: Fwd: linux v4.14 causes firmware iwlwifi errors on Lenovo Thinkpad T440s

2017-11-13 Thread Luciano Coelho
On Mon, 2017-11-13 at 16:23 -0600, Larry Finger wrote: > On 11/13/2017 03:30 PM, Bartosz Golaszewski wrote: > > 2017-11-13 21:45 GMT+01:00 Larry Finger > > : > > > On 11/13/2017 02:22 PM, Bartosz Golaszewski wrote: > > > > > > > > Forwarding here too as I messed up the address the last time. > >

Re: [linuxwifi] Support Help on WiFi driver

2017-10-26 Thread Luciano Coelho
BTW, all mailing lists @vger.kernel.org drop emails sent in HTML format, so your original email didn't reach it. -- Cheers, Luca. On Thu, 2017-10-26 at 22:18 +0300, Luciano Coelho wrote: > Hi Edwin, > > Please give us a bit more information. What is the kernel version > that

Re: [PATCH 1/3] wireless: iwlwifi: use bool instead of int

2017-10-04 Thread Luciano Coelho
On Wed, 2017-10-04 at 10:55 -0700, Joe Perches wrote: > On Wed, 2017-10-04 at 19:39 +0300, Luciano Coelho wrote: > > On Wed, 2017-10-04 at 09:26 -0700, Joe Perches wrote: > > [] > > > This might be more intelligble as separate tests > > > > > &

Re: [PATCH 1/3] wireless: iwlwifi: use bool instead of int

2017-10-04 Thread Luciano Coelho
On Wed, 2017-10-04 at 09:26 -0700, Joe Perches wrote: > On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote: > > Change a usage of int in a boolean context to use the bool type > > instead, as it > > makes the intent of the function clearer and helps clarify its > > semantics. > > > > Al

Re: [PATCH 0/3] iwlwifi: cosmetic fixes

2017-10-04 Thread Luciano Coelho
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote: > Fix several code style issues, some of which were reported by > checkpatch.pl. > > The changes are: > * One instance of an `int` variable being used in a boolean context, > chaned to > use the more appropriate `bool` type. > * One

Re: [PATCH 1/3] wireless: iwlwifi: use bool instead of int

2017-10-04 Thread Luciano Coelho
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote: > Change a usage of int in a boolean context to use the bool type > instead, as it > makes the intent of the function clearer and helps clarify its > semantics. > > Also eliminate the if/else and just return the boolean result > direct

Re: [PATCH 2/3] wireless: iwlwifi: function definition cosmetic fix

2017-10-04 Thread Luciano Coelho
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote: > Separate the function from the previous definition with a newline and > put the `static` keyword on the same line, as it just looks nicer. > > Signed-off-by: Christoph Böhmwalder > --- > drivers/net/wireless/intel/iwlwifi/iwl-phy-d

Re: iwlwifi: ToF usage

2017-10-03 Thread Luciano Coelho
Hi Joel, Unfortunately we don't have full support for ToF on the mainline kernel yet. But you can try to use one of our Core releases (which is a backports-based tree) that you can find here: You could try the release/Core30 branch, for example. -- Cheers, Luca. On Thu, 2017-09-21 at 21:35 +02