The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
onal cc's
>
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
>
> --
> From: Luis de Bethencourt
er and will continue the work that our former
> colleagues started.
>
> Thanks, bye.
>
Nice :) This is good news
I am happy to help as well if I can get my hands on the hardware.
Acked-by: Luis de Bethencourt
Thanks,
Luis
--
To unsubscribe from this list: send th
Bo_moon Kim is no longer with Atmel Corporation."
"Min_su Kim is no longer with Atmel Corporation."
"Jun_hyuk Lee is no longer with Atmel Corporation."
Removing this entry since none of the maintainers are reachable.
Signed-off-by: Luis de Bethencourt
---
Hi,
This is unfortun
On 25/06/16 23:16, Greg KH wrote:
> On Sat, Jun 25, 2016 at 10:43:33PM +0100, Luis de Bethencourt wrote:
>> On 25/06/16 22:36, Greg KH wrote:
>>> On Thu, Jun 23, 2016 at 01:36:17PM +0100, Luis de Bethencourt wrote:
>>>> The common format to check if a function r
We can just ignore the return value from debugfs_create_dir() and
debugfs_create_file(). The second one already interanlly checks the dentry
created by the first before creating the file.
debugfs was written so it would be easy to use, no need for error checking.
Signed-off-by: Luis de
Bo_moon Kim is no longer with Atmel Corporation."
"Min_su Kim is no longer with Atmel Corporation."
"Jun_hyuk Lee is no longer with Atmel Corporation."
Removing these email addresses that don't reach the addressee anymore.
Signed-off-by: Luis de Bethencourt
---
Hi,
Ju
Bo_moon Kim is no longer with Atmel Corporation."
"Min_su Kim is no longer with Atmel Corporation."
Removing these email addresses that don't reach the addressees anymore.
Signed-off-by: Luis de Bethencourt
---
MAINTAINERS | 5 -
1 file changed, 5 deletions(-)
diff --git a/MAINTA
On 25/06/16 22:36, Greg KH wrote:
> On Thu, Jun 23, 2016 at 01:36:17PM +0100, Luis de Bethencourt wrote:
>> The common format to check if a function returned an error pointer is to
>> use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors.
>>
>> Signed-
On 24/06/16 00:54, Julian Calaby wrote:
> Hi Luis,
>
> On Fri, Jun 24, 2016 at 9:50 AM, Luis de Bethencourt
> wrote:
>> On 24/06/16 00:15, Julian Calaby wrote:
>>> Hi Joe,
>>>
>>> On Fri, Jun 24, 2016 at 5:24 AM, Joe Perches wrote:
>>>&g
On 24/06/16 00:15, Julian Calaby wrote:
> Hi Joe,
>
> On Fri, Jun 24, 2016 at 5:24 AM, Joe Perches wrote:
>> On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote:
>>> hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs
>>> which have
On 23/06/16 20:24, Joe Perches wrote:
> On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote:
>> hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs
>> which have the following element:
>> u8 bssid[6];
> []
>> I am aware this patch gives a
x27;hif_drv->usr_scan_req.net_info[hif_drv->usr_scan_req.rcvd_ch_cnt].bssid'
drivers/staging/wilc1000/host_interface.c:1254 Handle_RcvdNtwrkInfo() warn:
this array is probably non-NULL. 'pstrNetworkInfo->bssid'
Signed-off-by: Luis de Bethencourt
---
Hi,
I am aware this patch gives
If there was an error, returning -EINVAL is more appropriate than -1.
Signed-off-by: Luis de Bethencourt
Reviewed-by: Julian Calaby
---
drivers/staging/wilc1000/wilc_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b
The common format to check if a function returned an error pointer is to
use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors.
Signed-off-by: Luis de Bethencourt
Reviewed-by: Julian Calaby
---
drivers/staging/wilc1000/wilc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1
On 23/06/16 02:29, Julian Calaby wrote:
> Hi All,
>
> On Wed, Jun 22, 2016 at 10:39 PM, Luis de Bethencourt
> wrote:
>> The common format to check if a function returned an error pointer is to
>> use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors.
>
The common format to check if a function returned an error pointer is to
use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors.
Also, if there was an error returning -EINVAL instead of -1 is more
appropriate.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000
reg_eac and reg_ecc are only used if candidate is bigger than 0, and in
that case new values will be given to them. Removing the unused
assignments.
Signed-off-by: Luis de Bethencourt
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 2 --
1 file changed, 2 deletions(-)
diff --git a
On 18/03/16 17:46, Joe Perches wrote:
> On Fri, 2016-03-18 at 17:40 +0000, Luis de Bethencourt wrote:
>> On 18/03/16 17:29, Joe Perches wrote:
>>> On Fri, 2016-03-18 at 16:35 +, Luis de Bethencourt wrote:
>>>> Fix order of mac80211_rx_flags description to match th
On 18/03/16 16:09, Luis de Bethencourt wrote:
> Add documentation for the flag for duplication check.
>
> Fixes the following warning when running make htmldocs:
> warning: Enum value 'RX_FLAG_DUP_VALIDATED' not described in enum
> 'mac80211_rx_flags'
>
On 18/03/16 16:49, Johannes Berg wrote:
> On Fri, 2016-03-18 at 16:35 +0000, Luis de Bethencourt wrote:
>> Fix order of mac80211_rx_flags description to match the enum.
>>
>> Signed-off-by: Luis de Bethencourt
>> ---
>> Hi,
>>
>> I want ahead and fixed
On 18/03/16 17:29, Joe Perches wrote:
> On Fri, 2016-03-18 at 16:35 +0000, Luis de Bethencourt wrote:
>> Fix order of mac80211_rx_flags description to match the enum.
>>
>> Signed-off-by: Luis de Bethencourt
>> ---
>> Hi,
>>
>> I want ahead and fixed
Commit 976bd9efdae6 ("mac80211: move beacon_loss_count into ifmgd")
removed the member from the sta_info struct but the description stayed
lingering. Remove it.
Signed-off-by: Luis de Bethencourt
---
Hi,
A second patch fixing a warning in make htmldocs.
Thanks :)
Luis
net/mac80211/
Add documentation for the flag for duplication check.
Fixes the following warning when running make htmldocs:
warning: Enum value 'RX_FLAG_DUP_VALIDATED' not described in enum
'mac80211_rx_flags'
Signed-off-by: Luis de Bethencourt
---
Hi,
While running make htmldocs I not
Fix order of mac80211_rx_flags description to match the enum.
Signed-off-by: Luis de Bethencourt
---
Hi,
I want ahead and fixed the order of the descriptions. checkpatch.pl was giving
a warning to my previous patch and I had a hunch it was because the wrong order
breaks the parser. Indeed it
On 18/03/16 17:46, Luis de Bethencourt wrote:
> On 18/03/16 16:49, Johannes Berg wrote:
>> On Fri, 2016-03-18 at 16:35 +0000, Luis de Bethencourt wrote:
>>> Fix order of mac80211_rx_flags description to match the enum.
>>>
>>> Signed-off-by: Luis de Bethenc
The driver is using -1 instead of the -ENOMEM defined macro to specify that
a buffer allocation failed.
Fixes smatch warning and similars:
drivers/staging/wilc1000/host_interface.c:1757 Handle_Key() warn:
returning -1 instead of -ENOMEM is sloppy
Signed-off-by: Luis de Bethencourt
---
Hi
The driver is using -1 instead of the -ENOMEM defined macro to specify that
a buffer allocation failed.
Fixes smatch warning and similars:
drivers/staging/wilc1000/host_interface.c:1782 Handle_Key() warn:
returning -1 instead of -ENOMEM is sloppy
Signed-off-by: Luis de Bethencourt
---
drivers
For loop is outside of the else branch of the above conditional statement.
Fixing misleading indentation.
Fix a smatch warning:
drivers/staging/rtl8723au/core/rtw_wlan_util.c:528
WMMOnAssocRsp23a() warn: curly braces intended?
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8723au
Boolean tests do not need explicit comparison to true or false.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers
On Mon, Jul 06, 2015 at 07:22:09PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Jun 26, 2015 at 04:43:44PM +0200, Luis de Bethencourt wrote:
> > Patches to be applied on top of
> > https://patchwork.kernel.org/patch/6655831/
>
> I don't use patchwork, and when on an airpla
Switch printks with IP addresses to use vsprintf extension %pI4.
Suggested-by: Joe Perches
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b
On Fri, Jun 26, 2015 at 07:49:32AM -0700, Joe Perches wrote:
> On Fri, 2015-06-26 at 16:45 +0200, Luis de Bethencourt wrote:
> > Fix all checkpatch.pl warnings:
> > WARNING: unnecessary whitespace before a quoted newline
>
> Unassociated but:
>
> > diff --
Fix typo "packe" to "packet".
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
in
Fix typo "packe" to "packet".
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
in
Fix all checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000/host_interface.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging
Fix all checkpatch.pl warnings:
WARNING: unnecessary whitespace before a quoted newline
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000/host_interface.c | 84 +++
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/wilc1000
Removing all checkpatch.pl warnings:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000/host_interface.c | 276 ++
1 file changed, 92 insertions(+), 184 deletions(-)
diff --git a/drivers
Patches to be applied on top of
https://patchwork.kernel.org/patch/6655831/
Thanks!
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
if (s32Error) {
> --
> 1.9.1
>
Appliess cleanly on staging-testing. Removes all checkpatch ERRORS related to
spaces placing in that file.
Reviewed-by: Luis de Bethencourt
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
40 matches
Mail list logo
