Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

2016-08-16 Thread Malinen, Jouni
On Tue, Aug 16, 2016 at 08:52:47AM +0200, Johannes Berg wrote: > On Mon, 2016-08-15 at 21:07 +0300, Jouni Malinen wrote: > > From: Peng Xu > > Add HT and VHT information in struct cfg80211_ap_settings when > > starting ap so that driver does not need to parse IE to obtain > > the information. > >

Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

2016-10-03 Thread Malinen, Jouni
On Mon, Sep 12, 2016 at 12:09:42PM +0200, Johannes Berg wrote: > I have no major objections to this. However, a few things: > > 1) are you planning to add support for this into a kernel driver at >    all, anyway? > 2) are you planning to have a driver upstream that contains the now >    necessary

Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

2016-10-04 Thread Malinen, Jouni
On Tue, Oct 04, 2016 at 03:25:51PM +0200, Johannes Berg wrote: > > ath6kl: > > Use cfg80211_get_chandef_type(&info->chandef) != NL80211_CHAN_NO_HT > > to determine whether HT is enabled. No VHT support. HT-required case > > not covered. No parsing of HT/VHT IEs used. > > Hmm. Wouldn't the supporte

Re: [PATCH 5/8] cfg80211: Add KEK/nonces for FILS association frames

2016-10-26 Thread Malinen, Jouni
On Wed, Oct 26, 2016 at 07:36:27AM +0200, Johannes Berg wrote: > > +++ b/net/wireless/nl80211.c > > + [NL80211_ATTR_FILS_KEK] = { .type = NLA_BINARY, > > + .len = FILS_MAX_KEK_LEN }, > > + [NL80211_ATTR_FILS_NONCES] = { .type = NLA_BINARY, > > +

Re: [PATCH 8/8] mac80211: Claim Fast Initial Link Setup (FILS) support

2016-10-26 Thread Malinen, Jouni
On Wed, Oct 26, 2016 at 07:50:36AM +0200, Johannes Berg wrote: > On Wed, 2016-10-26 at 01:44 +0300, Jouni Malinen wrote: > > With the previous commits, initial FILS support is now functional in > > mac80211-based drivers for both AP and stations roles. > > That's a bit misleading, I guess AP role

Re: [PATCH 2/8] mac80211: Allow AUTH_DATA to be used for FILS

2016-10-26 Thread Malinen, Jouni
On Wed, Oct 26, 2016 at 07:30:00AM +0200, Johannes Berg wrote: > > >   if (req->auth_data_len >= 4) { > > - __le16 *pos = (__le16 *) req->auth_data; > > - auth_data->sae_trans = le16_to_cpu(pos[0]); > > - auth_data->sae_status = le16_to_cpu(pos[1]); > > +

Re: [PATCH 7/8] mac80211: FILS AEAD protection for station mode association frames

2016-10-26 Thread Malinen, Jouni
On Wed, Oct 26, 2016 at 07:49:59AM +0200, Johannes Berg wrote: > > +static u8 *fils_find_session(u8 *pos, u8 *end) > Hmm. I think we should try to write this in terms of cfg80211_find_ie, > or perhaps cfg80211_find_ie_match, maybe we need to extend those but > this won't be the only one using the

Re: [PATCH 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-02 Thread Malinen, Jouni
On Fri, Nov 25, 2016 at 11:21:15AM +0200, Luca Coelho wrote: > On Thu, 2016-11-24 at 00:07 +0200, Jouni Malinen wrote: > > From: vamsi krishna > > @@ -9670,6 +9689,15 @@ static int nl80211_send_wowlan_nd(struct sk_buff > > *msg, > > if (nla_put_u32(msg, NL80211_ATTR_SCHED_SCAN_DELAY, req->del

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-08 Thread Malinen, Jouni
On Wed, Dec 07, 2016 at 09:03:23PM +0100, Arend Van Spriel wrote: > On 7-12-2016 10:33, Vamsi, Krishna wrote: > >> -Original Message- > >> From: Johannes Berg [mailto:johan...@sipsolutions.net] > > > >> What about Arend's comment regarding this functionality overlapping with > >> the > >>

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-15 Thread Malinen, Jouni
On Tue, Dec 13, 2016 at 04:56:55PM +0100, Johannes Berg wrote: > Regarding reusing attributes, we have (for the BSS selection thing) the > attribute NL80211_BSS_SELECT_ATTR_RSSI_ADJUST, which is really quite > similar to your new NL80211_ATTR_SCHED_SCAN_RELATIVE_RSSI_5G_PREF since > while connected

Re: [PATCH v2 1/3] cfg80211: Allow a scan request for a specific BSSID

2016-03-04 Thread Malinen, Jouni
On Fri, Mar 04, 2016 at 10:07:56AM +0200, Luca Coelho wrote: > On Fri, 2016-02-26 at 22:12 +0200, Jouni Malinen wrote: > > This is an optimization and as such, it is acceptable for some of the > > drivers not to support the mechanism. If not supported, the wildcard > > BSSID will be used and more r

Re: [PATCHv3 RESEND 01/11] cfg80211: add start / stop NAN commands

2016-04-06 Thread Malinen, Jouni
On Tue, Mar 29, 2016 at 12:34:59PM +0300, Emmanuel Grumbach wrote: > Define several attributes that may be configured by user space > when starting NAN functionality (master preference and dual > band operation) > diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h > @@ -826,6

Re: [PATCHv3 RESEND 05/11] cfg80211: provide a function to report a match for NAN

2016-04-06 Thread Malinen, Jouni
On Tue, Mar 29, 2016 at 12:35:03PM +0300, Emmanuel Grumbach wrote: > Provide a function the driver can call to report a match. > This will send the event to the user space. > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h > +/** > + * struct cfg80211_nan_match_params - NAN match par

Re: [PATCHv3 RESEND 06/11] cfg80211: Provide an API to report NAN function termination

2016-04-06 Thread Malinen, Jouni
On Tue, Mar 29, 2016 at 12:35:04PM +0300, Emmanuel Grumbach wrote: > Provide a function that reports NAN DE function termination. The function > may be terminated due to one of the following reasons: user request, > ttl expiration or failure. > diff --git a/include/uapi/linux/nl80211.h b/include/u

Re: [PATCHv3 RESEND 01/11] cfg80211: add start / stop NAN commands

2016-04-06 Thread Malinen, Jouni
On Tue, Mar 29, 2016 at 12:34:59PM +0300, Emmanuel Grumbach wrote: > This allows user space to start/stop NAN interface. > A NAN interface is like P2P device in a few aspects: it > doesn't have a netdev associated to it. > Add the new interface type and prevent operations that > can't be executed o

Re: [PATCH 2/2] cfg80211: Specify frame and reason code for NL80211_CMD_DEL_STATION

2014-10-14 Thread Malinen, Jouni
On 14/10/14 11:21 am, "Johannes Berg" wrote: >On Fri, 2014-10-10 at 20:55 +0300, Jouni Malinen wrote: > >>+ * @reason_code: Reason code for the Disassociation/Deauthentication >>frame >> */ >> struct station_del_parameters { >> const u8 *mac; >> +u8 subtype; >> +u16 reason_code;

Re: [PATCH] ath9k: Reduce max roc duration

2014-10-14 Thread Malinen, Jouni
On 15/10/14 3:59 am, "Sujith Manoharan" wrote: >MCC is currently used in CUS227, an Allplay >device. Since audio streaming will be affected >with long offchannel periods, reduce the max. >offchannel duration to 200ms. >diff --git a/drivers/net/wireless/ath/ath9k/init.c >b/drivers/net/wireless/a

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-20 Thread Malinen, Jouni
On Fri, Dec 16, 2016 at 10:56:51AM +0100, Johannes Berg wrote: > On Thu, 2016-12-15 at 11:06 +0000, Malinen, Jouni wrote: > > Maybe the nl80211.h description was not clear enough, but the > > comments in cfg80211.h should be quite clear on how this was designed > > to work

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-11 Thread Malinen, Jouni
On Mon, Jan 09, 2017 at 09:24:56PM +0100, Arend Van Spriel wrote: > > diff --git a/net/wireless/sme.c b/net/wireless/sme.c > > @@ -38,6 +38,7 @@ struct cfg80211_conn { > > CFG80211_CONN_ASSOCIATE_NEXT, > > CFG80211_CONN_ASSOCIATING, > > CFG80211_CONN_ASSOC_FAILED

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-12 Thread Malinen, Jouni
On Wed, Jan 11, 2017 at 02:31:31PM +0100, Johannes Berg wrote: > > + * @timeout_reason: reason for connection timeout. This is used when > > the > > + * connection fails due to a timeout instead of an explicit > > rejection from > > + * the AP. 0 (NL80211_CONNECT_TIMEOUT_UNSPECIFIED) is used > > fo

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-12 Thread Malinen, Jouni
On Wed, Jan 11, 2017 at 02:26:06PM +0100, Johannes Berg wrote: > On Wed, 2017-01-11 at 13:13 +0000, Malinen, Jouni wrote: > > > > > > @@ -172,6 +174,7 @@ static int cfg80211_conn_do_work(struct > > > > wireless_dev *wdev) > > >

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-12 Thread Malinen, Jouni
On Thu, Jan 12, 2017 at 03:06:19PM +0100, Johannes Berg wrote: > On Thu, 2017-01-12 at 13:58 +0000, Malinen, Jouni wrote: > > > > > I think this description is misleading - one could easily > > > understand > > > "for other cases" to indicate

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-12 Thread Malinen, Jouni
On Thu, Jan 12, 2017 at 03:32:20PM +0100, Johannes Berg wrote: > > > We don't.. This discussion here is about the C API where we cannot > > remove the argument from the call without adding yet another inline > > wrapper, but the actual function that generates the netlink message > > does not add t

Re: [RFC PATCH 0/2] mac80211: use crypto shash for AES cmac

2017-02-03 Thread Malinen, Jouni
On Fri, Feb 03, 2017 at 07:25:53PM +, Ard Biesheuvel wrote: > The mac80211 aes_cmac code reimplements the CMAC algorithm based on the > core AES cipher, which is rather restrictive in how platforms can satisfy > the dependency on this algorithm. For instance, SIMD implementations may > have a c

Re: [RFC PATCH 0/2] mac80211: use crypto shash for AES cmac

2017-02-04 Thread Malinen, Jouni
On Fri, Feb 03, 2017 at 09:55:36PM +, Ard Biesheuvel wrote: > OK, that looks like something I could figure out how to use. But are > you saying the CMAC code is never called in practice? It will get called if there is a frame that were to need to use BIP. There are some APs that do send broadc

Re: [RFC PATCH 0/2] mac80211: use crypto shash for AES cmac

2017-02-04 Thread Malinen, Jouni
On Sat, Feb 04, 2017 at 02:24:36PM +, Ard Biesheuvel wrote: > There is another issue I spotted: the skcipher you allocate may be of > the async variant, which may return from skcipher_encrypt() with > -EINPROGRESS as soon as it has queued the request. Since you don't > deal with that result, yo

Re: [PATCH v2 0/2] mac80211: use crypto shash for AES cmac

2017-02-06 Thread Malinen, Jouni
On Sun, Feb 05, 2017 at 03:23:26PM +, Ard Biesheuvel wrote: > NOTE: Jouni has been so kind to test patch #2, and confirmed that it is > working. > I have not tested patch #1 myself, mainly because the test methodology > requires downloading Ubuntu installer images, and I am current

Re: FILS offloading

2017-03-01 Thread Malinen, Jouni
On Wed, Mar 01, 2017 at 11:28:48AM +0100, Arend Van Spriel wrote: > Not sure which email address to use ;-) I noticed a while ago that FILS > offloading was on the agenda of wireless workshop in Santa Fe. Recently, > looked at the FILS patches that were applied upstream and noticed: > static bool