Re: [PATCH] ath10k: fix out of bounds access to local buffer

2017-04-24 Thread Marcin Rokicki
2017-04-24 9:41 GMT+02:00 Michael Mera : > Marcin Rokicki writes: >> Please send again to ath...@lists.infradead.org with cc >> linux-wireless@vger.kernel.org >> > > Sorry for the mistake. Resent as requested. No problem. > > Just for the record, I follo

Re: [PATCH] ath10k: fix out of bounds access to local buffer

2017-04-23 Thread Marcin Rokicki
Hi, Please send again to ath...@lists.infradead.org with cc linux-wireless@vger.kernel.org Thanks. 2017-04-24 7:39 GMT+02:00 Michael Mera : > During write to debugfs file simulate_fw_crash, fixed-size local buffer > 'buf' is accessed and modified at index 'count-1', where 'count' is the > size o

[PATCH] ath10k: Modify macros to fix style issues

2017-02-22 Thread Marcin Rokicki
avoided Fix them by modify local variable in the middle and just return at the end. Btw add const to function that return string literals Signed-off-by: Marcin Rokicki --- drivers/net/wireless/ath/ath10k/wmi.h | 36 +-- 1 file changed, 26 insertions(+), 10

[PATCH v2] ath10k: Remove return statement from a void function

2017-02-21 Thread Marcin Rokicki
The empty 'return;' statement in a void function should be used to return from somewhere else than the end. Signed-off-by: Marcin Rokicki --- Changes for v2 -remove only return statement instead of empty err label which can be used in the future --- drivers/net/wireless/ath/ath

[PATCH] ath10k: Remove return statement from a void function

2017-02-21 Thread Marcin Rokicki
The empty 'return;' statement in a void function should be used to return from somewhere else then the end. Signed-off-by: Marcin Rokicki --- drivers/net/wireless/ath/ath10k/core.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/

[PATCH] ath10k: Clean header files from bad block comments

2017-02-20 Thread Marcin Rokicki
Fix output from checkpatch.pl like: Block comments use a trailing */ on a separate line Signed-off-by: Marcin Rokicki --- drivers/net/wireless/ath/ath10k/bmi.h | 3 ++- drivers/net/wireless/ath/ath10k/core.h | 9 ++--- drivers/net/wireless/ath/ath10k/hif.h | 6

[PATCH] ath10k: Clean header files from bad block comments

2017-02-20 Thread Marcin Rokicki
Fix output from checkpatch.pl like: Block comments use a trailing */ on a separate line Signed-off-by: Marcin Rokicki --- drivers/net/wireless/ath/ath10k/bmi.h | 3 ++- drivers/net/wireless/ath/ath10k/core.h | 9 ++--- drivers/net/wireless/ath/ath10k/hif.h | 6