Re: [PATCH 1/1] staging: Fix bitshifts by wrong offsets in wilc1000/host_interface.c

2015-12-18 Thread Mario J. Rugiero
El 18/12/15 a las 19:50, Greg KH escribió: On Tue, Dec 01, 2015 at 11:49:55PM -0300, Mario J. Rugiero wrote: struct set_multicast uses (implicitly) sizeof(bool) to determine how many bytes to copy in Handle_SetMulticastFilter. Since that is implementation defined, it triggered sparse to

[PATCH v3] staging: wilc1000: replace 'ptr > 0' check by 'ptr' check.

2015-12-03 Thread Mario J. Rugiero
This silences a sparse warning about incompatible comparisons, while making the intent of the check a bit clearer. Signed-off-by: Mario J. Rugiero --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000

Re: [PATCH 1/1] staging: cleanup: Fix incompatible type comparison in wilc1000/host_interface.c

2015-12-03 Thread Mario J. Rugiero
Would be v3, or remains v2 because of the lack of further changes afterwards? Regards, Mario. El 03/12/15 a las 12:17, Dan Carpenter escribió: On Thu, Dec 03, 2015 at 12:13:59PM -0300, Mario J. Rugiero wrote: Thank you. Then the patch itself should see no changes as of now, am I right

Re: [PATCH 1/1] staging: cleanup: Fix incompatible type comparison in wilc1000/host_interface.c

2015-12-03 Thread Mario J. Rugiero
Thank you. Then the patch itself should see no changes as of now, am I right? Should I submit a new one anyway to fix the subject line? Regards, Mario. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH 1/1] staging: cleanup: Fix incompatible type comparison in wilc1000/host_interface.c

2015-12-02 Thread Mario J. Rugiero
OK. Since the maintainers are CC'd, I guess I should wait for a clarification about this? El 02/12/15 a las 10:29, Dan Carpenter escribió: Put v2 in the subject. Also the subsystem prefix is: [PATCH v3] staging: wilc1000: ... On Mon, Nov 30, 2015 at 09:09:04PM -0300, Mario J. Rugiero

[PATCH 1/1] staging: Fix bitshifts by wrong offsets in wilc1000/host_interface.c

2015-12-01 Thread Mario J. Rugiero
replaced the bool member by a u32. Also, time_out and buf_size members of ba_session_info are u16, but while copying their bytes into ptr in Handle_AddBASession shift 16 bits for the second byte instead of 8 bits. This patch fixes those two issues. Signed-off-by: Mario J. Rugiero --- drivers

[PATCH 1/1] staging: cleanup: Fix incompatible type comparison in wilc1000/host_interface.c

2015-11-30 Thread Mario J. Rugiero
This patch replaces an "if (ptr > 0)" comparison that seems to be a confusing way to check for null by a simpler "if (ptr)" check. Signed-off-by: Mario J. Rugiero --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] [sparse-cleanup] Fix incompatible type comparison in wilc1000/host_interface.c

2015-11-30 Thread Mario J. Rugiero
Signed-off-by: Mario J. Rugiero --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index d5b7725..9ce1d22 100644 --- a/drivers/staging/wilc1000