Re: [PATCH v2] rt2x00: Fix MMIC Countermeasures.

2017-08-07 Thread Michael Skeffington
Sorry about that, I work on other projects that use spaces and I must have missed that when double checking the patch. I sent out a new patch with the correct line length, removal of trailing '.' and indentation fix. On Mon, Aug 7, 2017 at 2:31 AM, Stanislaw Gruszka wrote:

Re: [PATCH] rt2x00: Fix MMIC countermeasures.

2017-08-02 Thread Michael Skeffington
I traced through this code during MMIC failure and ieee80211_rx_h_decrypt() drops the frame before getting to ieee80211_rx_h_michael_mic_verify(). Johannes suggested this change to me in response to a previous thread and I am offering this patch after having conducted the proper testing on it.

[PATCH] rt2x00: Fix MMIC countermeasures.

2017-08-01 Thread Michael Skeffington
of those devices to test with. Signed-off-by: Michael Skeffington <m...@hellotwist.com> --- diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800mmio.c b/drivers/net/wireless/ralink/rt2x00/rt2800mmio.c index ee5276e233fa..ace91a2db756 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2800mmio.c

Re: [PATCH] mac80211: Validate michael MIC before attempting packet decode.

2017-05-16 Thread Michael Skeffington
Johannes, Thank you for that. I need to make a quick hack to send an invalid MIC packet from another device to test the countermeasures. Should I submit a new patch with this change when I've completed testing or are you already prepared to do so? Michael On Fri, May 12, 2017 at 4:52 AM,

Re: [PATCH] mac80211: Validate michael MIC before attempting packet decode.

2017-05-11 Thread Michael Skeffington
suspect thats related to the underlying bug. On Wed, May 10, 2017 at 8:24 AM, Jouni Malinen <j...@w1.fi> wrote: > On Tue, May 09, 2017 at 02:16:31PM -0400, Michael Skeffington wrote: >> In order to allow wpa_supplicant to correctly identify a perceived WPA TKIP >> key >> reco

[PATCH] mac80211: Validate michael MIC before attempting packet decode.

2017-05-09 Thread Michael Skeffington
bit of status flags describing the error would remain unset. Signed-off-by: Michael Skeffington <m...@hellotwist.com> --- diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index bc08185..71f1a56 100644 --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c @@ -3176,9 +3176,10 @@ stati

[no subject]

2017-05-09 Thread Michael Skeffington
subscribe linux-wireless