[PATCH v3 0/3] ath10k: speed up recovery

2014-10-28 Thread Michal Kazior
is fine though. v3: * skip shadow ring cleanup in #1 Michal Kazior (3): ath10k: fix possible bmi crash ath10k: expose hw restart via debugfs ath10k: speed up hw recovery drivers/net/wireless/ath/ath10k/ce.c | 7 +++ drivers/net/wireless/ath/ath10k/core.c | 23

Re: [PATCH 7/7] ath10k: implement wmi-tlv backend

2014-10-28 Thread Michal Kazior
On 20 October 2014 14:58, Michal Kazior michal.kaz...@tieto.com wrote: Latest firmware revision introduced a new WMI ABI called wmi-tlv. It is not a tlv strictly speaking but something that resembles it because it is ordered and may have duplicate id entries. This will be used by new

Re: Change channel bandwidth without iw command

2014-10-24 Thread Michal Kazior
On 23 October 2014 08:57, Okhwan Lee oh...@mwnl.snu.ac.kr wrote: Hi, Thank you for your answer. The panic printout would be most helpful. My best guess is this crashes in ath10k_dbg() at the very beginning of ath10k_config_chan because ar-chandef.chan is NULL. This is probably the case

Re: [PATCH 7/7] ath10k: implement wmi-tlv backend

2014-10-24 Thread Michal Kazior
On 20 October 2014 14:58, Michal Kazior michal.kaz...@tieto.com wrote: Latest firmware revision introduced a new WMI ABI called wmi-tlv. It is not a tlv strictly speaking but something that resembles it because it is ordered and may have duplicate id entries. This will be used by new

Re: Change channel bandwidth without iw command

2014-10-24 Thread Michal Kazior
On 24 October 2014 13:30, Okhwan Lee oh...@mwnl.snu.ac.kr wrote: Hi, This linked images are the printed error messages when the kernel is in panic. http://www.mwnl.snu.ac.kr/~ohlee/1.jpg http://www.mwnl.snu.ac.kr/~ohlee/2.jpg Thanks. Panic doesn't seem to include anything directly related

Re: [PATCH v2 4/6] ath10k: make warm reset a bit safer and faster

2014-10-23 Thread Michal Kazior
On 23 October 2014 15:14, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: On 20 October 2014 14:14, Michal Kazior michal.kaz...@tieto.com wrote: One of the problems with warm reset I've found is that it must be guaranteed that copy engine registers

Re: [PATCH v3] ath10k: Add the target register read/write and memory dump debugfs interface

2014-10-22 Thread Michal Kazior
On 21 October 2014 17:10, Li, Yanbo yan...@qti.qualcomm.com wrote: -Original Message- From: Michal Kazior [mailto:michal.kaz...@tieto.com] On 20 October 2014 18:38, Yanbo Li yan...@qti.qualcomm.com wrote: [...] 2. Read the value from mem value, the output is binary format IE

Re: [PATCH 1/2] ath10k: remove tsf argument from rx_desc tracing

2014-10-22 Thread Michal Kazior
On 21 October 2014 15:54, Michal Kazior michal.kaz...@tieto.com wrote: Fundamtenally this was wrong. Tsf is only valid in first MPDU of a PPDU. This means tsf value was s/first MPDU/last MPDU/ I must've had a brain fart when writing the commit log yesterday. @Kalle: Should I re-spin

Re: Change channel bandwidth without iw command

2014-10-22 Thread Michal Kazior
On 22 October 2014 12:14, Okhwan Lee oh...@mwnl.snu.ac.kr wrote: Hi, We are trying to implement a protocol to evaluate the performance our algorithm using QCA9880. To implement our protocol, a receiver have to change the bandwidth when a Action frame (what we define) is successfully

Re: [PATCH v3] Add the target register read/write and memory dump debugfs interface

2014-10-21 Thread Michal Kazior
You're missing ath10k: prefix in the patch subject. On 20 October 2014 18:38, Yanbo Li yan...@qti.qualcomm.com wrote: The debugfs interface reg_addrreg_val used to read and write the target register. The interface mem_addrmem_val used to dump the targer memory and also can be used to assign

Re: [PATCH v2 3/3] ath10k: speed up hw recovery

2014-10-21 Thread Michal Kazior
On 21 October 2014 10:17, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: In some cases hw recovery was taking an absurdly long time due to ath10k waiting for things that would never really complete. Instead of waiting for inevitable timeouts poke all

[PATCH 2/2] ath10k: re-use trace class

2014-10-21 Thread Michal Kazior
Instead of defining a completely new tracepoint use an existing tracepoint class. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/trace.h | 32 +--- 1 file changed, 5 insertions(+), 27 deletions(-) diff --git a/drivers/net

[PATCH 0/2] ath10k: minor htt tracing fix

2014-10-21 Thread Michal Kazior
Hi, I've just noticed that rx_desc tracing is somewhat wrong. This attempts to fix it and since the trace function prototype changes I re-use some tracing code as well. Michal Kazior (2): ath10k: remove tsf argument from rx_desc tracing ath10k: re-use trace class drivers/net/wireless/ath

[PATCH v2 0/6] ath10k: pci related fixes 2014-10-09

2014-10-20 Thread Michal Kazior
remove power_up/down [Kalle] * fix CE crash [Janusz] * remove irq workaround in patch #2 Michal Kazior (6): ath10k: re-disable interrupts after target init ath10k: mask/unmask msi fw irq ath10k: split ce pipe init/alloc further ath10k: make warm reset a bit safer and faster ath10k: split

[PATCH v2 1/6] ath10k: re-disable interrupts after target init

2014-10-20 Thread Michal Kazior
If MSI isn't configured device ROM program expects legacy interrupts to be enabled before it can fully boot. Don't forget to disable legacy interrupts after that. While at it re-use the legacy irq enabling helper instead of calling ath10k_pci_write32(). Signed-off-by: Michal Kazior michal.kaz

[PATCH v2 2/6] ath10k: mask/unmask msi fw irq

2014-10-20 Thread Michal Kazior
This was the final missing bit to making sure the device doesn't assert interrupts to host. This should fix possible race when target crashes during driver teardown. This also removes an early warm reset workaround during pci probing. Signed-off-by: Michal Kazior michal.kaz...@tieto.com

[PATCH v2 3/6] ath10k: split ce pipe init/alloc further

2014-10-20 Thread Michal Kazior
Calling init to reinit ce pipe state would also re-set all static structure links and setting (which don't change over driver lifecycle). Make it so alloc links structures and initializes static data and init part to setup state variables and clear stuff. Signed-off-by: Michal Kazior michal.kaz

[PATCH v2 5/6] ath10k: split reset logic from power up

2014-10-20 Thread Michal Kazior
The power up procedure was overly complex due to warm/cold reset workarounds and issues. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- Notes: v2: * fix indentation [Kalle] drivers/net/wireless/ath/ath10k/pci.c | 151 ++ 1 file changed, 80

[PATCH v2 3/3] ath10k: speed up hw recovery

2014-10-20 Thread Michal Kazior
waiters might be holding it introduce a new flag CRASH_FLUSH so it's possible to tell waiters to abort whatever they were waiting for. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- Notes: v2: * fix crash due to use-before-init of empty_tx_wq on early fw crash [Janusz

[PATCH v2 2/3] ath10k: expose hw restart via debugfs

2014-10-20 Thread Michal Kazior
Until now it was possible to simulate soft and hard fw crashes but it wasn't possible to trigger an immediately hw restart itself (without the fw crash). This can be useful when stress testing hw restarting stability, e.g. during heavy tx/rx traffic. Signed-off-by: Michal Kazior michal.kaz

[PATCH 2/7] ath10k: add sanity checks for service bmap parsing

2014-10-20 Thread Michal Kazior
This shouldn't really happen but take into account the original service bitmap length when mapping service ids. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi.c | 6 +- drivers/net/wireless/ath/ath10k/wmi.h | 121

[PATCH 3/7] ath10k: make wmi service bitmap non-debug

2014-10-20 Thread Michal Kazior
The service bitmap can be used to determine firmware capabilities. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.h | 2 +- drivers/net/wireless/ath/ath10k/debug.c | 11 +++ drivers/net/wireless/ath/ath10k/debug.h | 9 - drivers

[PATCH 6/7] ath10k: make some wmi functions public

2014-10-20 Thread Michal Kazior
Some functions can be shared across different WMI ABIs. Make them public so different WMI backends can use them from different source files in the future. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi.c | 136

[PATCH 7/7] ath10k: implement wmi-tlv backend

2014-10-20 Thread Michal Kazior
Latest firmware revision introduced a new WMI ABI called wmi-tlv. It is not a tlv strictly speaking but something that resembles it because it is ordered and may have duplicate id entries. This will be used by new hardware eventually. Signed-off-by: Michal Kazior michal.kaz...@tieto.com

Re: [PATCH 7/7] ath10k: implement wmi-tlv backend

2014-10-20 Thread Michal Kazior
On 20 October 2014 14:58, Michal Kazior michal.kaz...@tieto.com wrote: Latest firmware revision introduced a new WMI ABI called wmi-tlv. It is not a tlv strictly speaking but something that resembles it because it is ordered and may have duplicate id entries. This will be used by new

[PATCH 1/9] ath10k: don't drop control and null func Rx

2014-10-20 Thread Michal Kazior
HTT_RX_IND_MPDU_STATUS_MGMT_CTRL was pretty greedy and because of that ath10k ended up dropping Control Frames as well as Null Func frames. Reported-by: Okhwan Lee oh...@mwnl.snu.ac.kr Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htt_rx.c | 3 +-- 1

[PATCH 9/9] ath10k: clear htt-rx_confused on load

2014-10-20 Thread Michal Kazior
Once driver entered the rx_confused state it would refuse to rx even after firmware is restarted. Make sure to clear it so that rx works after, e.g. hw restart or after all interfaces are stopped. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htt_rx.c

[PATCH 8/9] ath10k: don't forget to replenish after fragmented Rx

2014-10-20 Thread Michal Kazior
In theory it was possible to drain entire HTT Rx ring via fragmented Rx leading to Rx lockup. In practice non-data traffic would always trigger replenishment via the regular Rx handler. For correctness sake make sure to replenish the ring on fragmented Rx. Signed-off-by: Michal Kazior

[PATCH 7/9] ath10k: add extra sanity check when popping amsdu

2014-10-20 Thread Michal Kazior
The netbuf pop can return NULL. Make sure to check for that. It shouldn't happen but better safe than sorry. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htt_rx.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/wireless/ath

Re: ath10k firmware crash

2014-10-13 Thread Michal Kazior
On 13 October 2014 09:35, voncken cedric.vonc...@acksys.fr wrote: Thanks for your reply, Can you then provide a crash register dump for 10.1, please? I can't help you much with the 636 dump. Yes I can, but where I find it?

Re: ath10k firmware crash

2014-10-13 Thread Michal Kazior
On 13 October 2014 11:20, voncken cedric.vonc...@acksys.fr wrote: -Message d'origine- De : Michal Kazior [mailto:michal.kaz...@tieto.com] Envoyé : lundi 13 octobre 2014 09:54 À : voncken Cc : ath...@lists.infradead.org; linux-wireless Objet : Re: ath10k firmware crash On 13

Re: ath10k firmware crash

2014-10-13 Thread Michal Kazior
On 13 October 2014 11:23, voncken cedric.vonc...@acksys.fr wrote: Are you perhaps trying to run STA with 4addr bridging? If so then make sure you use recent ath10k as this was known to be a problem. We tested without the 4addr bridging, that works fine but we can't add the interface in

Re: [PATCH] ath10k: use bss_info as txpower source

2014-10-12 Thread Michal Kazior
On 10 October 2014 16:01, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: This simply changes the source for txpower setup. It does not make ath10k use different txpower values for different vifs. This will make it easier to implement chanctx

[PATCH 2/3] ath10k: skip some commands on reassoc

2014-10-10 Thread Michal Kazior
It doesn't make much sense to reconfigure peer completely upon reassociation. This will make it easier to have a more uniform association code across different modes. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 52

[PATCH 3/3] ath10k: clean up sta auth/assoc code

2014-10-10 Thread Michal Kazior
The code can be symmetrical so make it so. This makes it easier to understand and work with. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 121 -- 1 file changed, 42 insertions(+), 79 deletions(-) diff --git

[PATCH] ath10k: simplify computation of mgmt rx band

2014-10-10 Thread Michal Kazior
Using global channel won't work with chanctx. Try to determine the channel from the information provided in the wmi event itself alone. This should be sufficient. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi.c | 32

[PATCH] ath10k: use bss_info as txpower source

2014-10-10 Thread Michal Kazior
This simply changes the source for txpower setup. It does not make ath10k use different txpower values for different vifs. This will make it easier to implement chanctx in ath10k in the future. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.h | 1

[PATCH 4/5] ath10k: split reset logic from power up

2014-10-09 Thread Michal Kazior
The power up procedure was overly complex due to warm/cold reset workarounds and issues. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c | 151 ++ 1 file changed, 80 insertions(+), 71 deletions(-) diff --git

[PATCH 3/5] ath10k: make warm reset a bit safer and faster

2014-10-09 Thread Michal Kazior
firmware indication register. As a side effect this makes driver boot/stop/recovery faster. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c | 108 +++--- 1 file changed, 46 insertions(+), 62 deletions(-) diff --git

[PATCH 3/3] ath10k: speed up hw recovery

2014-10-09 Thread Michal Kazior
In some cases hw recovery was taking an absurdly long time due to ath10k waiting for things that would never really complete. Instead of waiting for inevitable timeouts poke all completions and wakequeues and check if it's still worth waiting. Signed-off-by: Michal Kazior michal.kaz...@tieto.com

[PATCH 2/3] ath10k: expose hw restart via debugfs

2014-10-09 Thread Michal Kazior
Until now it was possible to simulate soft and hard fw crashes but it wasn't possible to trigger an immediately hw restart itself (without the fw crash). This can be useful when stress testing hw restarting stability, e.g. during heavy tx/rx traffic. Signed-off-by: Michal Kazior michal.kaz

[PATCH 1/3] ath10k: fix possible bmi crash

2014-10-09 Thread Michal Kazior
make sure to check BMI xfer pointer and print a splat instead of crashing the kernel. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/ce.c | 7 +++ drivers/net/wireless/ath/ath10k/pci.c | 3 +++ 2 files changed, 10 insertions(+) diff --git a/drivers/net

Re: [PATCH] ath10k: fix kernel panic while shutting down AP

2014-10-08 Thread Michal Kazior
On 8 October 2014 11:16, Rajkumar Manoharan rmano...@qti.qualcomm.com wrote: The commit ath10k: workaround fw beaconing bug is freeing DMA-coherent memory in irq context which is hitting BUG ON in ARM platforms. Fix this by moving dma_free out of spin lock. I hardly see how moving the freeing

Re: [PATCH] ath10k: fix kernel panic while shutting down AP

2014-10-08 Thread Michal Kazior
On 8 October 2014 13:08, Rajkumar Manoharan rmano...@qti.qualcomm.com wrote: On Wed, Oct 08, 2014 at 12:50:28PM +0200, Michal Kazior wrote: On 8 October 2014 12:33, Rajkumar Manoharan rmano...@qti.qualcomm.com wrote: On Wed, Oct 08, 2014 at 11:45:38AM +0200, Michal Kazior wrote: On 8

Re: [PATCH] ath10k: fix kernel panic while shutting down AP

2014-10-08 Thread Michal Kazior
On 8 October 2014 13:13, Rajkumar Manoharan rmano...@qti.qualcomm.com wrote: On Wed, Oct 08, 2014 at 04:38:44PM +0530, Rajkumar Manoharan wrote: On Wed, Oct 08, 2014 at 12:50:28PM +0200, Michal Kazior wrote: If anything the offender should be dma_unmap_single() but the thing is beacon_buf

Re: [PATCH] ath10k: fix kernel panic while shutting down AP

2014-10-08 Thread Michal Kazior
On 8 October 2014 12:48, Rajkumar Manoharan rmano...@qti.qualcomm.com wrote: On Wed, Oct 08, 2014 at 12:52:04PM +0300, Kalle Valo wrote: Rajkumar Manoharan rmano...@qti.qualcomm.com writes: The commit ath10k: workaround fw beaconing bug is freeing DMA-coherent memory in irq context which is

Re: How to know the information about RTS reception in mac80211 or device driver

2014-10-08 Thread Michal Kazior
+ath...@lists.infradead.org On 7 October 2014 13:30, Okhwan Lee oh...@mwnl.snu.ac.kr wrote: Hi, We are trying to develop an algorithm by using the information of RTS reception at the receiver side. (actually, we need the preceding frame of A-MPDU). As far as we know, RTS/CTS exchange is

Re: How to know the information about RTS reception in mac80211 or device driver

2014-10-08 Thread Michal Kazior
On 8 October 2014 16:50, Sujith Manoharan suj...@msujith.org wrote: Michal Kazior wrote: I think you've just found an ath10k bug. I've been running through Rx code lately. I was looking at htt_rx_mpdu_status and noticed it was a bit greedy. I then recalled someone was complaining about RTS

Re: [RFC] mac80211: enable DFS with channel contexts

2014-10-07 Thread Michal Kazior
On 7 October 2014 10:49, Johannes Berg johan...@sipsolutions.net wrote: On Thu, 2014-10-02 at 08:45 +0200, Michal Kazior wrote: It is okay to enable DFS for channel contexts based drivers as long as no combination advertises radar detection and multi-channel operation at the same time

[RFC] mac80211: enable DFS with channel contexts

2014-10-02 Thread Michal Kazior
It is okay to enable DFS for channel contexts based drivers as long as no combination advertises radar detection and multi-channel operation at the same time. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- I think this is enough for single-channel chanctx-based drivers or am I missing

[PATCH] ath10k: warn on unhandled htt events

2014-10-02 Thread Michal Kazior
It makes a lot more sense to print these kinds of problems as a warning instead of a debug. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/htt_rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k

Re: [PATCH 1/4] ath10k: Add support to configure pktlog filter

2014-10-02 Thread Michal Kazior
On 2 October 2014 14:12, Rajkumar Manoharan rmano...@qti.qualcomm.com wrote: Add support to configure packet log filters (tx, rx, rate control) via debugfs. To disable htt pktlog events set the filters to 0. [...] +static ssize_t ath10k_write_pktlog_filter(struct file *file, +

Re: [PATCH v2 07/10] ath10k: add fw-powerup-fail to ethtool stats.

2014-09-30 Thread Michal Kazior
On 29 September 2014 18:05, Ben Greear gree...@candelatech.com wrote: On 09/29/2014 01:24 AM, Kalle Valo wrote: gree...@candelatech.com writes: From: Ben Greear gree...@candelatech.com This gives user-space a normal-ish way to detect that firmware has failed to start and that a reboot is

Re: Question about debugging mac80211 without printk

2014-09-26 Thread Michal Kazior
On 25 September 2014 18:54, Pink p...@informatik.tu-cottbus.de wrote: Hi, actually if have the following problem, if have a lot of debug messages using printk inside the mac layer but if there is a critical bug in the source code of the mac80211 module the system goes into kernel panic state

Re: [PATCH 0/4] ath10k: fix/cleanup fw stats

2014-09-26 Thread Michal Kazior
On 26 September 2014 13:06, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: Hi, This cleans up and fixes fw stats aggregation. Michal Kazior (4): ath10k: split wmi stats parsing ath10k: rename fw_stats related stuff ath10k: request fw_stats

Re: [PATCH] ath10k: use configured nss instead of max nss.

2014-09-25 Thread Michal Kazior
On 24 September 2014 18:09, Ben Greear gree...@candelatech.com wrote: On 09/24/2014 12:09 AM, Michal Kazior wrote: On 23 September 2014 18:48, Ben Greear gree...@candelatech.com wrote: On 09/23/2014 01:59 AM, Michal Kazior wrote: On 23 September 2014 01:00, gree...@candelatech.com wrote

Re: [RFC 2/2] ath10k: re-config ht_caps when chainmask is modified.

2014-09-25 Thread Michal Kazior
On 24 September 2014 18:30, Ben Greear gree...@candelatech.com wrote: On 09/24/2014 08:05 AM, Michal Kazior wrote: On 24 September 2014 16:35, Ben Greear gree...@candelatech.com wrote: On 09/24/2014 12:51 AM, Michal Kazior wrote: On 24 September 2014 02:26, gree...@candelatech.com wrote

[PATCH 3/4] ath10k: request fw_stats once on open

2014-09-25 Thread Michal Kazior
Stats were requested and processed for each read call. This caused inconsistent readings. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/debug.c | 110 +++- 1 file changed, 79 insertions(+), 31 deletions(-) diff --git

[PATCH 1/4] ath10k: split wmi stats parsing

2014-09-25 Thread Michal Kazior
The parsing function was rather complex. Simplify by splitting it up into firmware branch specific implementations. While at it move the parsing code into wmi.c where it belongs. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/debug.c | 127

[PATCH 0/4] ath10k: fix/cleanup fw stats

2014-09-25 Thread Michal Kazior
Hi, This cleans up and fixes fw stats aggregation. Michal Kazior (4): ath10k: split wmi stats parsing ath10k: rename fw_stats related stuff ath10k: request fw_stats once on open ath10k: fix fw stats processing drivers/net/wireless/ath/ath10k/core.h | 26 +- drivers/net/wireless/ath

[PATCH 4/4] ath10k: fix fw stats processing

2014-09-25 Thread Michal Kazior
to get complete stat data. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.h | 19 +-- drivers/net/wireless/ath/ath10k/debug.c | 273 +++- drivers/net/wireless/ath/ath10k/wmi.c | 55 +-- 3 files changed, 252

[PATCH 2/4] ath10k: rename fw_stats related stuff

2014-09-25 Thread Michal Kazior
The naming was a bit inconsistent. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.h | 11 +-- drivers/net/wireless/ath/ath10k/debug.c | 18 +- drivers/net/wireless/ath/ath10k/debug.h | 6 +++--- drivers/net/wireless/ath

Re: [PATCH] ath10k: request firmware flush in ath10k_flush.

2014-09-24 Thread Michal Kazior
On 23 September 2014 16:19, Ben Greear gree...@candelatech.com wrote: On 09/23/2014 02:16 AM, Michal Kazior wrote: On 19 September 2014 20:28, gree...@candelatech.com wrote: [...] + /* If we are CT firmware, ask it to flush all tids on all peers on +* all vdevs. Normal

Re: [PATCH v2 1/3] ath10k: don't enable interrupts for the diagnostic window

2014-09-24 Thread Michal Kazior
On 23 September 2014 16:32, Kalle Valo kv...@qca.qualcomm.com wrote: [...] - for (ce_id = 0; ce_id CE_COUNT; ce_id++) + /* Skip the last copy engine, CE7 the diagnostic window, as that +* uses polling and isn't initialized for interrupts. */ Comment style :-) Michał --

Re: [PATCH] ath10k: use configured nss instead of max nss.

2014-09-24 Thread Michal Kazior
On 23 September 2014 18:48, Ben Greear gree...@candelatech.com wrote: On 09/23/2014 01:59 AM, Michal Kazior wrote: On 23 September 2014 01:00, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com [...] @@ -4086,6 +4086,10 @@ ath10k_default_bitrate_mask(struct ath10k *ar

Re: [PATCH v2 03/10] ath10k: support ethtool stats.

2014-09-24 Thread Michal Kazior
On 23 September 2014 23:17, gree...@candelatech.com wrote: [...] +void ath10k_get_et_stats(struct ieee80211_hw *hw, +struct ieee80211_vif *vif, +struct ethtool_stats *stats, u64 *data) +{ + struct ath10k *ar = hw-priv; + int i = 0;

Re: [RFC 2/2] ath10k: re-config ht_caps when chainmask is modified.

2014-09-24 Thread Michal Kazior
On 24 September 2014 02:26, gree...@candelatech.com wrote: [...] +static struct ieee80211_sta_vht_cap ath10k_create_vht_cap(struct ath10k *ar, + bool use_cfg_chains) { struct ieee80211_sta_vht_cap vht_cap = {0}; u16

Re: [RFC 2/2] ath10k: re-config ht_caps when chainmask is modified.

2014-09-24 Thread Michal Kazior
On 24 September 2014 16:35, Ben Greear gree...@candelatech.com wrote: On 09/24/2014 12:51 AM, Michal Kazior wrote: On 24 September 2014 02:26, gree...@candelatech.com wrote: [...] +static struct ieee80211_sta_vht_cap ath10k_create_vht_cap(struct ath10k *ar

[PATCH v2 0/3] ath10k: debug improvements

2014-09-23 Thread Michal Kazior
Hi, This adds extra prints and information for debugging purposes. v2: * merge scnprintfs Michal Kazior (3): ath10k: print wmi version info ath10k: dump hex bytes with dev string prefix ath10k: add debug dump for pci rx drivers/net/wireless/ath/ath10k/debug.c | 25

[PATCH v2 1/3] ath10k: print wmi version info

2014-09-23 Thread Michal Kazior
HTT version is already printed so print WMI version as well for consistency. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/debug.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/debug.c b

Re: [PATCH 2/2] ath10k: apply chainmask settings to vdev on creation.

2014-09-23 Thread Michal Kazior
On 22 September 2014 22:54, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com It appears it takes more than just setting the hardware's chainmask to make things work well. Without this patch, a vdev would only use 1x1 rates when chainmask was set to 0x3. Setting the

Re: [PATCH] ath10k: use configured nss instead of max nss.

2014-09-23 Thread Michal Kazior
On 23 September 2014 01:00, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com When re-associating a station, the nss was set back to maximum value even if user had configured small number of tx chains. So, pay attention to user's config in this case as well.

Re: [PATCH 1/3] ath10k: use 64-bit vdev map.

2014-09-23 Thread Michal Kazior
On 19 September 2014 20:04, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com This can allow more than 32 stations to be supported without over-running the bitmap. Signed-off-by: Ben Greear gree...@candelatech.com --- drivers/net/wireless/ath/ath10k/core.c | 4 ++--

Re: [PATCH 2/2] ath10k: support ethtool stats.

2014-09-23 Thread Michal Kazior
On 19 September 2014 20:17, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Add support for reading firmware stats through the ethtool API. This may be easier for applications to manipulate compared to parsing a text based debugfs file. You also seem to be adding fw

Re: [PATCH 6/9] ath10k: deduplicate wmi service ready logic

2014-09-22 Thread Michal Kazior
On 22 September 2014 11:46, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: [...] Like discussed in IRC, you don't need to resent the whole patchset just because of this. I have now folded the patch below onto your patch in ath-next-test, please review

Re: [PATCH 2/3] ath10k: dump hex bytes with dev string prefix

2014-09-22 Thread Michal Kazior
On 22 September 2014 12:52, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: This makes it easier to debug hex dumps on systems with more than a single ath10k device. Signed-off-by: Michal Kazior michal.kaz...@tieto.com

[PATCH 0/9] ath10k: mostly cleanups

2014-09-18 Thread Michal Kazior
Hi, Here's a bunch of clean up patches for WMI and a single fix. I'm including the fix in this patchset because one of the clean up patches depends on it. Michal Kazior (9): ath10k: fix tx/rx chainmask init ath10k: remove unused pdev_set_channel command ath10k: deduplicate wmi_channel

[PATCH 6/9] ath10k: deduplicate wmi service ready logic

2014-09-18 Thread Michal Kazior
. host mem chunks). Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.h | 4 +- drivers/net/wireless/ath/ath10k/debug.c | 2 +- drivers/net/wireless/ath/ath10k/debug.h | 4 +- drivers/net/wireless/ath/ath10k/wmi.c | 237

[PATCH 1/9] ath10k: fix tx/rx chainmask init

2014-09-18 Thread Michal Kazior
Firmware reports the number of RF chains so use that for initialization of supp_{tx,rx}_chainmask instead of using a macro for 3x3 chips. This should make tx/rx chainmask reports correct for chips other than 3x3. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath

[PATCH 5/9] ath10k: relocate wmi attach/deatch functions

2014-09-18 Thread Michal Kazior
Init functions should be placed at the end of files in most cases to avoid forward declarations for static functions. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi.c | 77 +-- 1 file changed, 38 insertions(+), 39

[PATCH 4/9] ath10k: deduplicate host mem chunk code

2014-09-18 Thread Michal Kazior
Simplify the code by deduplicating structure definitions and code. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi.c | 103 +- drivers/net/wireless/ath/ath10k/wmi.h | 30 +++--- 2 files changed, 34 insertions

[PATCH 0/3] ath10k: debug improvements

2014-09-18 Thread Michal Kazior
Hi, This adds extra prints and information for debugging purposes. Michal Kazior (3): ath10k: print wmi version info ath10k: dump hex bytes with dev string prefix ath10k: add debug dump for pci rx drivers/net/wireless/ath/ath10k/debug.c | 29 ++--- drivers/net

[PATCH 3/3] ath10k: add debug dump for pci rx

2014-09-18 Thread Michal Kazior
This makes it easier to debug the device-target communication at a very low level. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net

[PATCH 1/3] ath10k: print wmi version info

2014-09-18 Thread Michal Kazior
HTT version is already printed so print WMI version as well for consistency. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/debug.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/debug.c b

[PATCH 2/3] ath10k: dump hex bytes with dev string prefix

2014-09-18 Thread Michal Kazior
This makes it easier to debug hex dumps on systems with more than a single ath10k device. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/debug.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/net

Re: [PATCH v3] ath10k: fix debugfs_create_dir() checking

2014-09-11 Thread Michal Kazior
On 10 September 2014 18:14, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: [...] Since mine is just an extra precaution feel free to drop all but the first paragraph of my commit message if you want to. Thanks, I just left the first paragraph like you

Re: CSA broken with !use_chanctx drivers?

2014-09-11 Thread Michal Kazior
On 11 September 2014 08:49, Luca Coelho l...@coelho.fi wrote: Hi Michal, Johannes and I were checking the channel switch code (namely to see if implementing the drv_channel_switch op was fine in our case) and we saw that CSA with non-chanctx drivers seems to be broken. In commit 4c3ebc56

Re: [PATCH v4 2/2] ath10k: add testmode

2014-09-11 Thread Michal Kazior
On 10 September 2014 17:23, Kalle Valo kv...@qca.qualcomm.com wrote: [...] Just a small nitpick: +static int ath10k_tm_cmd_utf_stop(struct ath10k *ar, struct nlattr *tb[]) +{ + int ret; + + ath10k_dbg(ar, ATH10K_DBG_TESTMODE, testmode cmd utf stop\n); + +

[PATCH] amenth10k: fix debugfs_create_dir() checking

2014-09-04 Thread Michal Kazior
Croce mat...@openwrt.org Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- @Kalle: - this patch prevents kernel oops but ath10k will fail to load - Matteo's patch prevents kernel oops and ath10k will load fine Since mine is just an extra precaution feel free to drop all

<    2   3   4   5   6   7