nfo.c:2223:2: warning: left shift count >= width of type
sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
^
Signed-off-by: Omer Efrat
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c
b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 2ba8cf3..360c8d1 100644
--- a/drivers/
nfo.c:2223:2: warning: left shift count >= width of type
sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
^
Signed-off-by: Omer Efrat
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 46bc2e5..d0c5dbd 100644
--- a
nfo.c:2223:2: warning: left shift count >= width of type
sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
^
Signed-off-by: Omer Efrat
diff --git a/net/batman-adv/bat_v_elp.c b/net/batman-adv/bat_v_elp.c
index 71c20c1..71e6474 100644
--- a/net/batman-adv/bat_v_elp.c
+++ b/net/batman
Kalle Valo wrote:
> Omer Efrat wrote:
>
>> Since 'filled' member in station_info changed to u64, BIT_ULL macro
>> should be used with NL80211_STA_INFO_* attribute types instead of BIT.
>>
>> The BIT macro uses unsigned long type which some architectures
nfo.c:2223:2: warning: left shift count >= width of type
sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
^
Signed-off-by: Omer Efrat
---
net/wireless/nl80211.c | 22 +++---
net/wireless/wext-compat.c | 10 +-
2 files changed, 16 insertions(+), 16 deletions(
nfo.c:2223:2: warning: left shift count >= width of type
sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
^
This patch series replaces the described BIT usage with BIT_ULL.
Changes in v2: Split patches so cfg80211, mac80211 and batman will be
seperated.
Omer Efrat (5):
cfg80211:
nfo.c:2223:2: warning: left shift count >= width of type
sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
^
Signed-off-by: Omer Efrat
---
net/mac80211/ethtool.c | 6 ++--
net/mac80211/sta_info.c | 84 -
2 files changed, 45 insertions(
nfo.c:2223:2: warning: left shift count >= width of type
sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
^
Signed-off-by: Omer Efrat
---
drivers/net/wireless/ath/ath6kl/cfg80211.c | 14
drivers/net/wireless/ath/wil6210/cfg80211.c| 18 +-
.../br
nfo.c:2223:2: warning: left shift count >= width of type
sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
^
Signed-off-by: Omer Efrat
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 10 +-
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 14 +++---
drivers
is a bugfix and the others aren't.
Exactly my thoughts. I accept the need for the cleanup to be separated
to different patches as well, I will send a v3.
Omer Efrat.
From: Johannes Berg
Sent: Thursday, June 14, 2018 2:08:05 PM
To: Omer Efrat; linux-
Omer Efrat wrote:
>Johannes Berg wrote:
>>Perhaps, though I'm not sure I see it, there's some value in switching
>>them all so that if you copy something and change it to a new value you
>>don't run into this problem again, but if anything that should be (a)
&g
n
>focus on the remaining patches as cleanups for -next.
I will send both as v3.
Omer.
From: Johannes Berg
Sent: Thursday, June 14, 2018 7:12:13 PM
To: Omer Efrat; linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 2/5] mac80211: use BIT_ULL for N
macro
should be used with all NL80211_STA_INFO_* attribute types instead of BIT
to prevent future possible bugs when one will use BIT macro for higher
attributes by mistake.
This commit cleans up all usages of BIT macro with the above field
in mac80211 by changing it to BIT_ULL instead.
Signed-off
tion, there are
some places which don't use BIT nor BIT_ULL macros so align those as well.
Signed-off-by: Omer Efrat
---
net/wireless/nl80211.c | 26 +-
net/wireless/wext-compat.c | 10 +-
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/net/
macro
should be used with all NL80211_STA_INFO_* attribute types instead of BIT
to prevent future possible bugs when one will use BIT macro for higher
attributes by mistake.
This commit cleans up all usages of BIT macro with the above field
in batman-adv by changing it to BIT_ULL instead.
Sign
addition, there are
some places which don't use BIT nor BIT_ULL macros so align those as well.
Signed-off-by: Omer Efrat
---
drivers/net/wireless/ath/ath10k/mac.c | 4 +--
drivers/net/wireless/ath/ath6kl/cfg80211.c | 14
drivers/net/wireless/ath/wil6210/cf
macro
should be used with all NL80211_STA_INFO_* attribute types instead of BIT
to prevent future possible bugs when one will use BIT macro for higher
attributes by mistake.
This commit cleans up all usages of BIT macro with the above field
in cfg80211 by changing it to BIT_ULL instead.
Signed-off
macro
should be used with all NL80211_STA_INFO_* attribute types instead of BIT
to prevent future possible bugs when one will use BIT macro for higher
attributes by mistake.
This commit cleans up all usages of BIT macro with the above field
in cfg80211 by changing it to BIT_ULL instead.
Signed-off
18 matches
Mail list logo
