On Mon, Nov 19, 2018 at 08:01:21PM +0200, Priit Laes wrote:
> b43 wireless driver includes an internal implementation of
> cordic algorithm, although there's a common cordic library
> which was split out from brcmsmac driver. Use that and drop
> internal implementation.
>
From: Larry Finger
The cordic routine for calculating sines and cosines that was added in
commit 6f98e62a9f1b ("b43: update cordic code to match current specs")
contains an error whereby a quantity declared u32 can in fact go negative.
This problem was detected by Priit Laes who is
ce v2:
- Improvements to commit messages. No functional changes.
- Collect reviewed-by bits.
Changes since v1:
- Merged brcmsmac driver patches into single patch
- Merged b43 driver patches into single patch
Larry Finger (1):
b43: Fix error in cordic routine
Priit Laes (3):
lib: cordic: Move c
Now that these macros are in header file, we can eventually
clean up the duplicate macros present in the drivers that
utilize the same cordic algorithm implementation.
Also add CORDIC_ prefix to nonprefixed macros.
Reviewed-by: Arend van Spriel
Signed-off-by: Priit Laes
Acked-by: Larry Finger
Current driver includes macro that is available from general cordic
library. Use that and drop unused duplicate and unneeded internal
definitions.
Signed-off-by: Priit Laes
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h | 7 +---
drivers/net/wireless/broadcom/brcm80211
Kernel library has a common cordic algorithm which is identical
to internally implemented one, so use it and drop the duplicate
implementation.
Acked-by: Larry Finger
Signed-off-by: Priit Laes
---
drivers/net/wireless/broadcom/b43/Kconfig | 1 +-
drivers/net/wireless/broadcom/b43
On Sun, Nov 18, 2018 at 01:35:57PM -0600, Larry Finger wrote:
> On 11/18/18 2:23 AM, Priit Laes wrote:
> > On Sat, Nov 17, 2018 at 09:31:35PM -0600, Larry Finger wrote:
> > > On 11/14/18 12:27 PM, Priit Laes wrote:
> > > > Kernel library has a common cordic algorithm
On Mon, Nov 19, 2018 at 12:43:32PM +0200, Kalle Valo wrote:
> Larry Finger writes:
>
> @@ -1570,10 +1571,10 @@ static u16 b43_nphy_gen_load_samples(struct
> b43_wldev *dev, u32 freq, u16 max,
> angle = 0;
> for (i = 0; i < len; i++) {
> -
On Sat, Nov 17, 2018 at 09:31:35PM -0600, Larry Finger wrote:
> On 11/14/18 12:27 PM, Priit Laes wrote:
> > Kernel library has a common cordic algorithm which is identical
> > to internally implementatd one, so use it and drop the duplicate
> > implementation.
> >
&g
On Wed, Nov 14, 2018 at 07:46:28PM +0100, Michael Büsch wrote:
> On Wed, 14 Nov 2018 20:27:52 +0200
> Priit Laes wrote:
>
> > Kernel library has a common cordic algorithm which is identical
> > to internally implementatd one, so use it and drop the duplicate
> > imple
Current driver includes macro that is available from general cordic
library. Use that and drop unused duplicate and unneeded internal
definitions.
Signed-off-by: Priit Laes
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h | 7 +---
drivers/net/wireless/broadcom/brcm80211
Kernel library has a common cordic algorithm which is identical
to internally implementatd one, so use it and drop the duplicate
implementation.
Signed-off-by: Priit Laes
---
drivers/net/wireless/broadcom/b43/Kconfig | 1 +-
drivers/net/wireless/broadcom/b43/phy_common.c | 47
erged b43 driver patches into single patch
Priit Laes (3):
lib: cordic: Move cordic macros and defines to header file
brcmsmac: Use cordic-related macros from common cordic library
b43: Use cordic algorithm from kernel library
drivers/net/wireless/broadcom/b43/Kconfig
Now that these macros are in header file, we can eventually
clean up the duplicate macros present in the drivers that
utilize the same cordic algorithm implementation.
Also add CORDIC_ prefix to nonprefixed macros.
Reviewed-by: Arend van Spriel
Signed-off-by: Priit Laes
---
include/linux
On Mon, Nov 05, 2018 at 11:02:35PM +0100, Arend van Spriel wrote:
> On 11/5/2018 8:37 PM, Priit Laes wrote:
> > Also append CORDIC_ prefix to nonprefixed macros.
>
> Bit annoying that you made me look at LKML for this patch. Can you just post
> the entire series to linux-wir
Current driver includes macro that is available from general cordic
library. Use that and drop unused duplicate and unneeded internal
definitions.
Signed-off-by: Priit Laes
---
v2: Use single patch instead of change/removal patches.
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy
Kernel library has a common cordic algorithm which is identical
to internally implementatd one, so use it and drop the duplicate
implementation.
Signed-off-by: Priit Laes
---
v2: Merge the update/removal patches into single patch.
---
drivers/net/wireless/broadcom/b43/Kconfig | 1
Signed-off-by: Priit Laes
---
drivers/net/wireless/broadcom/b43/phy_common.c | 47 +---
drivers/net/wireless/broadcom/b43/phy_common.h | 9 +
2 files changed, 56 deletions(-)
diff --git a/drivers/net/wireless/broadcom/b43/phy_common.c
b/drivers/net/wireless/broadcom/b43
b43 wireless driver included internal implementation of cordic
algorithm which has now been removed in favor of library
implementation.
During the process, brcmfmac was driver was also cleaned.
Please note that this series is only compile-tested, as I
do not have access to the hardware.
Priit
Now that cordic library has the CORDIC_FLOAT macro, use that
Signed-off-by: Priit Laes
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 4 ++--
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff
Now that we use library macros, we can drop internal copies
Signed-off-by: Priit Laes
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h | 7 +---
1 file changed, 7 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h
b/drivers/net
Signed-off-by: Priit Laes
---
drivers/net/wireless/broadcom/b43/Kconfig | 1 +
drivers/net/wireless/broadcom/b43/phy_lp.c | 13 +++--
drivers/net/wireless/broadcom/b43/phy_n.c | 13 +++--
3 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless
On Wed, 2016-06-29 at 21:33 +0200, Arnd Bergmann wrote:
> On Wednesday, June 29, 2016 8:51:44 PM CEST Arend Van Spriel wrote:
> > > Typical wifi devices will have some sort of non volatile storage
> > > on board to not only store the ethernet(mac) address, but also
> > > to contain e.g. info about
Driver was reporting 'switch case not processed' after association,
so HW_VAR_KEEP_ALIVE was added and filled similarily to other drivers.
Positive side effect to this seems to be a bit more stable connection.
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8192c
On Sun, 2015-03-22 at 11:27 -0500, Larry Finger wrote:
> On 03/22/2015 08:35 AM, Priit Laes wrote:
> > Hi all,
> >
> > This is a small fixup to unify make the drivers use common helper
> > functions for driver statistics.
> >
> > There are no functional
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8188ee/trx.c | 8 +++
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 34 ++-
drivers/net/wireless/rtlwifi/rtl8192cu/mac.c | 33 ++
drivers/net/wireless/rtlwifi/rtl8192de/trx.c | 35
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 14 ++
drivers/net/wireless/rtlwifi/rtl8192cu/mac.c | 16 +++-
drivers/net/wireless/rtlwifi/rtl8192de/trx.c | 16 +++-
drivers/net/wireless/rtlwifi/stats.c | 7 ---
4
Hi all,
This is a small fixup to unify make the drivers use common helper
functions for driver statistics.
There are no functional changes since the first posting, except dropping
patches already applied and addressing the comments by Joe Perches.
Priit Laes (4):
rtlwifi: Use common
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 22 +-
drivers/net/wireless/rtlwifi/rtl8192cu/mac.c | 18 +-
drivers/net/wireless/rtlwifi/rtl8192de/trx.c | 17 +
3 files changed, 3 insertions(+), 54 deletions
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/stats.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/stats.c
b/drivers/net/wireless/rtlwifi/stats.c
index 9ebeb6e..4cce472 100644
--- a/drivers/net/wireless/rtlwifi
This function is used only by rtl8821ae so move it there
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8821ae/trx.c | 16 +++-
drivers/net/wireless/rtlwifi/stats.c | 15 ---
drivers/net/wireless/rtlwifi/stats.h | 1 -
3 files changed, 15
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 14 ++
drivers/net/wireless/rtlwifi/rtl8192cu/mac.c | 16 +++-
drivers/net/wireless/rtlwifi/rtl8192de/trx.c | 16 +++-
drivers/net/wireless/rtlwifi/stats.c | 4 ++--
4 files
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8188ee/trx.c | 8 +++
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 34 ++-
drivers/net/wireless/rtlwifi/rtl8192cu/mac.c | 33 ++
drivers/net/wireless/rtlwifi/rtl8192de/trx.c | 35
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/stats.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/stats.c
b/drivers/net/wireless/rtlwifi/stats.c
index c702d01..4739324 100644
--- a/drivers/net/wireless/rtlwifi
Hi all,
This is a small fixup to unify make the drivers use common helper
functions for driver statistics.
Priit Laes (6):
rtlwifi: Use common rtl_query_rxpwrpercentage function
rtlwifi: Clean rtl_evm_db_to_percentage a bit
rtlwifi: Use common rtl_evm_db_to_percentage
rtlwifi: No need to
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/stats.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/stats.c
b/drivers/net/wireless/rtlwifi/stats.c
index 874e7d1..2021223 100644
--- a/drivers/net/wireless/rtlwifi/stats.c
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 22 +-
drivers/net/wireless/rtlwifi/rtl8192cu/mac.c | 18 +-
drivers/net/wireless/rtlwifi/rtl8192de/trx.c | 17 +
3 files changed, 3 insertions(+), 54 deletions
Hi all,
This is v3 of the rtlwifi unused #define cleanup patchset.
No changes since v2 except added Signed-off-by.
Changes since v1:
- Rebase patches against wireless-driver-next tree.
Priit Laes (7):
rtlwifi: Remove unused defines from rtl8192cu driver
rtlwifi: Remove unused defines
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/core.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/core.h
b/drivers/net/wireless/rtlwifi/core.h
index 7b64e34..82733c6 100644
--- a/drivers/net/wireless/rtlwifi/core.h
+++ b/drivers/net/wireless
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/base.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/base.h
b/drivers/net/wireless/rtlwifi/base.h
index c6cb49c..dee4ac2 100644
--- a/drivers/net/wireless/rtlwifi/base.h
+++ b/drivers/net/wireless
HAL_RETRY_LIMIT_*
RESET_DELAY_8185
RT_IBSS_INT_MASKS
RT_AC_INT_MASKS
NUM_OF_*
BT_*,
MAX_{LINES,BYTES}_*,
*_THREE_WIRE
*_QUEUE related
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8188ee/def.h | 41
drivers/net/wireless/rtlwifi/rtl8192ce/def.h | 41
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/cam.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/cam.h
b/drivers/net/wireless/rtlwifi/cam.h
index 3550808..e2e647d 100644
--- a/drivers/net/wireless/rtlwifi/cam.h
+++ b/drivers/net/wireless/rtlwifi
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8192cu/hw.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.h
b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.h
index c1e33b0..6758808 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/efuse.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/efuse.h
b/drivers/net/wireless/rtlwifi/efuse.h
index fdab824..be02e78 100644
--- a/drivers/net/wireless/rtlwifi/efuse.h
+++ b/drivers/net
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8188ee/rf.h | 1 -
drivers/net/wireless/rtlwifi/rtl8192ce/rf.h | 1 -
drivers/net/wireless/rtlwifi/rtl8192cu/rf.h | 1 -
drivers/net/wireless/rtlwifi/rtl8192de/def.h | 1 -
drivers/net/wireless/rtlwifi/rtl8192ee/rf.h | 1
---
drivers/net/wireless/rtlwifi/rtl8192cu/hw.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.h
b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.h
index c1e33b0..6758808 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.h
+++ b/drivers/net/wireless
---
drivers/net/wireless/rtlwifi/rtl8188ee/rf.h | 1 -
drivers/net/wireless/rtlwifi/rtl8192ce/rf.h | 1 -
drivers/net/wireless/rtlwifi/rtl8192cu/rf.h | 1 -
drivers/net/wireless/rtlwifi/rtl8192de/def.h | 1 -
drivers/net/wireless/rtlwifi/rtl8192ee/rf.h | 1 -
drivers/net/wireless/rtlwifi/rtl87
---
drivers/net/wireless/rtlwifi/cam.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/cam.h
b/drivers/net/wireless/rtlwifi/cam.h
index 3550808..e2e647d 100644
--- a/drivers/net/wireless/rtlwifi/cam.h
+++ b/drivers/net/wireless/rtlwifi/cam.h
@@ -28,13 +28,11 @@
Hi all,
This is v2 of the rtlwifi unused #define cleanup patchset.
Changes since v1:
- Rebase patches against wireless-driver-next tree.
Priit Laes (7):
rtlwifi: Remove unused defines from rtl8192cu driver
rtlwifi: Remove unused defines from driver-specific def.h
rtlwifi: Remove
HAL_RETRY_LIMIT_*
RESET_DELAY_8185
RT_IBSS_INT_MASKS
RT_AC_INT_MASKS
NUM_OF_*
BT_*,
MAX_{LINES,BYTES}_*,
*_THREE_WIRE
*_QUEUE related
---
drivers/net/wireless/rtlwifi/rtl8188ee/def.h | 41
drivers/net/wireless/rtlwifi/rtl8192ce/def.h | 41
---
drivers/net/wireless/rtlwifi/core.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/core.h
b/drivers/net/wireless/rtlwifi/core.h
index 7b64e34..82733c6 100644
--- a/drivers/net/wireless/rtlwifi/core.h
+++ b/drivers/net/wireless/rtlwifi/core.h
@@ -33,8 +33,6 @
---
drivers/net/wireless/rtlwifi/efuse.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/efuse.h
b/drivers/net/wireless/rtlwifi/efuse.h
index fdab824..be02e78 100644
--- a/drivers/net/wireless/rtlwifi/efuse.h
+++ b/drivers/net/wireless/rtlwifi/efuse.h
@@ -40,
---
drivers/net/wireless/rtlwifi/base.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/base.h
b/drivers/net/wireless/rtlwifi/base.h
index c6cb49c..dee4ac2 100644
--- a/drivers/net/wireless/rtlwifi/base.h
+++ b/drivers/net/wireless/rtlwifi/base.h
@@ -45,9 +45
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/efuse.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/efuse.h
b/drivers/net/wireless/rtlwifi/efuse.h
index fdab824..be02e78 100644
--- a/drivers/net/wireless/rtlwifi/efuse.h
+++ b/drivers/net
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/core.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/core.h
b/drivers/net/wireless/rtlwifi/core.h
index 624e1dc..3b37557 100644
--- a/drivers/net/wireless/rtlwifi/core.h
+++ b/drivers/net/wireless
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8188ee/rf.h | 1 -
drivers/net/wireless/rtlwifi/rtl8192ce/rf.h | 1 -
drivers/net/wireless/rtlwifi/rtl8192cu/rf.h | 1 -
drivers/net/wireless/rtlwifi/rtl8192de/def.h | 1 -
drivers/net/wireless/rtlwifi/rtl8192ee/rf.h | 1
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/base.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/base.h
b/drivers/net/wireless/rtlwifi/base.h
index 982f245..ea3e3fc 100644
--- a/drivers/net/wireless/rtlwifi/base.h
+++ b/drivers/net/wireless
HAL_RETRY_LIMIT_*
RESET_DELAY_8185
RT_IBSS_INT_MASKS
RT_AC_INT_MASKS
NUM_OF_*
BT_*,
MAX_{LINES,BYTES}_*,
*_THREE_WIRE
*_QUEUE related
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8188ee/def.h | 41
drivers/net/wireless/rtlwifi/rtl8192ce/def.h | 41
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/rtl8192cu/hw.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.h
b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.h
index c1e33b0..6758808 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu
Signed-off-by: Priit Laes
---
drivers/net/wireless/rtlwifi/cam.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/cam.h
b/drivers/net/wireless/rtlwifi/cam.h
index 3550808..e2e647d 100644
--- a/drivers/net/wireless/rtlwifi/cam.h
+++ b/drivers/net/wireless/rtlwifi
60 matches
Mail list logo