[PATCH] ath10k: Drop WARN_ON()s that always trigger during system resume

2019-03-03 Thread Rafael J. Wysocki
From: Rafael J. Wysocki ath10k_mac_vif_chan() always returns an error for the given vif during system-wide resume which reliably triggers two WARN_ON()s in ath10k_bss_info_changed() and they are not particularly useful in that code path, so drop them. Signed-off-by: Rafael J. Wysocki

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-28 Thread Rafael J. Wysocki
On Thu, Feb 28, 2019 at 3:29 AM Brian Norris wrote: > > Hi Rafael, > > On Wed, Feb 27, 2019 at 3:04 PM Rafael J. Wysocki wrote: > > On Wed, Feb 27, 2019 at 9:58 PM Brian Norris > > wrote: > > > On Wed, Feb 27, 2019 at 11:16:12AM +0100, Ard Biesheuvel wrote: &g

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-27 Thread Rafael J. Wysocki
On Wed, Feb 27, 2019 at 9:58 PM Brian Norris wrote: > > Hi Ard, > > On Wed, Feb 27, 2019 at 11:16:12AM +0100, Ard Biesheuvel wrote: > > On Wed, 27 Feb 2019 at 11:02, Marc Zyngier wrote: > > > On 26/02/2019 23:28, Brian Norris wrote: > > > > You're not the first person to notice this. All the moti

Re: [PATCH v6 10/18] x86/power/64: Remove VLA usage

2018-07-25 Thread Rafael J. Wysocki
On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to > shash directly and allocating the descriptor in heap memory (which should > be fine: the tfm has already

Re: [RFC PATCH v12 0/5] PCI: rockchip: Move PCIe WAKE# handling into pci core

2017-12-26 Thread Rafael J. Wysocki
On Tuesday, December 26, 2017 3:36:41 AM CET Jeffy Chen wrote: > > Currently we are handling wake irq in mrvl wifi driver. Move it into > pci core. > > Tested on my chromebook bob(with cros 4.4 kernel and mrvl wifi). > > > Changes in v13: > Fix compiler error reported by kbuild test robot > >

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Rafael J. Wysocki
> > const struct raid6_calls raid6_sse2x2 = { > raid6_sse22_gen_syndrome, > @@ -366,9 +366,9 @@ static void raid6_sse24_gen_syndrome(int disks, size_t > bytes, void **ptrs) > kernel_fpu_end(); > } > > - static void raid6_sse24_xor_syndrome(int disks, int start, int stop, > +static void raid6_sse24_xor_syndrome(int disks, int start, int stop, >size_t bytes, void **ptrs) > - { > +{ > u8 **dptr = (u8 **)ptrs; > u8 *p, *q; > int d, z, z0; > @@ -471,7 +471,7 @@ static void raid6_sse24_gen_syndrome(int disks, size_t > bytes, void **ptrs) > } > asm volatile("sfence" : : : "memory"); > kernel_fpu_end(); > - } > +} > > > const struct raid6_calls raid6_sse2x4 = { > diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c > index 0c11f434a374..ec619f51d336 100644 > --- a/sound/soc/fsl/fsl_dma.c > +++ b/sound/soc/fsl/fsl_dma.c > @@ -879,7 +879,7 @@ static const struct snd_pcm_ops fsl_dma_ops = { > }; > > static int fsl_soc_dma_probe(struct platform_device *pdev) > - { > +{ > struct dma_object *dma; > struct device_node *np = pdev->dev.of_node; > struct device_node *ssi_np; > > -- Acked-by: Rafael J. Wysocki for the ACPI part. Thanks!

Re: [RFC PATCH v10 0/7] PCI: rockchip: Move PCIe WAKE# handling into pci core

2017-10-28 Thread Rafael J. Wysocki
On Friday, October 27, 2017 9:26:05 AM CEST Jeffy Chen wrote: > > Currently we are handling wake irq in mrvl wifi driver. Move it into > pci core. > > Tested on my chromebook bob(with cros 4.4 kernel and mrvl wifi). > > > Changes in v10: > Use device_set_wakeup_capable() instead of device_set_w

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-08-30 Thread Rafael J. Wysocki
On Wednesday, August 30, 2017 2:41:41 PM CEST Christoph Hellwig wrote: > On Wed, Jul 26, 2017 at 02:27:44AM +0200, Rafael J. Wysocki wrote: > > > >> > Cc: "Rafael J. Wysocki" > > > >> > Cc: Mika Westerberg > > > >> > > >

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-26 Thread Rafael J. Wysocki
On Wednesday, July 26, 2017 01:03:03 PM Andy Shevchenko wrote: > On Wed, 2017-07-26 at 02:27 +0200, Rafael J. Wysocki wrote: > > On Wednesday, July 26, 2017 03:35:01 AM Andy Shevchenko wrote: > > > On Wed, Jul 26, 2017 at 3:21 AM, Rafael J. Wysocki > > t> wrote: > &

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-25 Thread Rafael J. Wysocki
On Wednesday, July 26, 2017 03:35:01 AM Andy Shevchenko wrote: > On Wed, Jul 26, 2017 at 3:21 AM, Rafael J. Wysocki wrote: > > On Tuesday, July 25, 2017 05:12:35 PM Mika Westerberg wrote: > >> On Wed, Jul 19, 2017 at 09:28:57PM +0300, Andy Shevchenko wrote: > >> > T

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-25 Thread Rafael J. Wysocki
do > > the conversion here. > > > > Cc: "Rafael J. Wysocki" > > Cc: Mika Westerberg > > Acked-by: Mika Westerberg OK Andy, do you want me to apply this? Thanks, Rafael

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-19 Thread Rafael J. Wysocki
On Wed, Jul 19, 2017 at 8:28 PM, Andy Shevchenko wrote: > There are new types and helpers that are supposed to be used in new code. > > As a preparation to get rid of legacy types and API functions do > the conversion here. Please talk to Mika about this one. Thanks, Rafael

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread Rafael J. Wysocki
On Monday, September 28, 2015 10:24:58 AM Arnd Bergmann wrote: > On Sunday 27 September 2015 16:10:48 Rafael J. Wysocki wrote: > > On Saturday, September 26, 2015 09:33:56 PM Arnd Bergmann wrote: > > > On Saturday 26 September 2015 11:40:00 Viresh Kumar wrote: > > > >

Re: [PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-27 Thread Rafael J. Wysocki
needs to be robust for such a case. > > Fix that by changing type of 'global_lock' to u32. > > Signed-off-by: Viresh Kumar Acked-by: Rafael J. Wysocki Greg, please take this one along with the [2/2] if that one looks good to you. > --- > BCC'd a lot of people (

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-27 Thread Rafael J. Wysocki
On Saturday, September 26, 2015 09:33:56 PM Arnd Bergmann wrote: > On Saturday 26 September 2015 11:40:00 Viresh Kumar wrote: > > On 25 September 2015 at 15:19, Rafael J. Wysocki wrote: > > > So if you allow something like debugfs to update your structure, how > > > do

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-27 Thread Rafael J. Wysocki
On Saturday, September 26, 2015 12:52:08 PM James Bottomley wrote: > On Fri, 2015-09-25 at 22:58 +0200, Rafael J. Wysocki wrote: > > On Friday, September 25, 2015 01:25:49 PM Viresh Kumar wrote: > > > On 25 September 2015 at 13:33, Rafael J. Wysocki > > > wrote: >

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Rafael J. Wysocki
On Fri, Sep 25, 2015 at 11:44 PM, Viresh Kumar wrote: > On 25-09-15, 22:58, Rafael J. Wysocki wrote: >> Say you have three adjacent fields in a structure, x, y, z, each one byte >> long. >> Initially, all of them are equal to 0. >> >> CPU A writes 1 to x and CPU

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Rafael J. Wysocki
On Friday, September 25, 2015 01:25:49 PM Viresh Kumar wrote: > On 25 September 2015 at 13:33, Rafael J. Wysocki wrote: > > You're going to change that into bool in the next patch, right? > > Yeah. > > > So what if bool is a byte and the field is not word-aligned &

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Rafael J. Wysocki
On Friday, September 25, 2015 10:26:22 PM Rafael J. Wysocki wrote: > On Friday, September 25, 2015 11:52:56 AM Viresh Kumar wrote: > > On 25-09-15, 20:49, Johannes Berg wrote: > > > Ok, then, but that means Rafael is completely wrong ... > > > debugfs_create_bool() tak

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Rafael J. Wysocki
On Friday, September 25, 2015 11:52:56 AM Viresh Kumar wrote: > On 25-09-15, 20:49, Johannes Berg wrote: > > Ok, then, but that means Rafael is completely wrong ... > > debugfs_create_bool() takes a *pointer* and it needs to be long-lived, > > it can't be on the stack. You also don't get a call whe

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Rafael J. Wysocki
On Friday, September 25, 2015 10:18:13 PM Rafael J. Wysocki wrote: > On Friday, September 25, 2015 09:41:37 AM Viresh Kumar wrote: > > global_lock is defined as an unsigned long and accessing only its lower > > 32 bits from sysfs is incorrect, as we need to consider other 32 b

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Rafael J. Wysocki
ode needs to be robust for such a case. > > Fix that by passing a local variable to debugfs_create_bool() and > assigning its value to global_lock later. > > Signed-off-by: Viresh Kumar Acked-by: Rafael J. Wysocki Greg, please take this one if the [2/2] looks good to you. &

Re: [PATCH 1/5] device property: helper macros for property entry creation

2015-08-07 Thread Rafael J. Wysocki
On Thursday, August 06, 2015 10:48:48 AM Heikki Krogerus wrote: > On Wed, Aug 05, 2015 at 05:02:18PM +0300, Andy Shevchenko wrote: > > On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote: > > > Marcos for easier creation of build-in property entries. > > > > > > Signed-off-by: Heikki Krogerus

[Resend][PATCH] NFC / PM: Replace CONFIG_PM_RUNTIME with CONFIG_PM

2014-12-12 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Subject: NFC / PM: Replace CONFIG_PM_RUNTIME with CONFIG_PM After commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected) PM_RUNTIME is always set if PM is set, so #ifdef blocks depending on CONFIG_PM_RUNTIME may now be changed to depend on CONFIG_PM

[PATCH] NFC / PM: Replace CONFIG_PM_RUNTIME with CONFIG_PM

2014-12-03 Thread Rafael J. Wysocki
From: Rafael J. Wysocki After commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected) PM_RUNTIME is always set if PM is set, so #ifdef blocks depending on CONFIG_PM_RUNTIME may now be changed to depend on CONFIG_PM. Replace CONFIG_PM_RUNTIME with CONFIG_PM in drivers/nfc

Re: [PATCH RESEND] net: rfkill: gpio: Add ACPI default GPIO driver mappings

2014-10-28 Thread Rafael J. Wysocki
vm_gpiod_get(&pdev->dev, "shutdown"); > if (!IS_ERR(gpio)) { > ret = gpiod_direction_output(gpio, 0); > if (ret) > @@ -150,6 +160,8 @@ static int rfkill_gpio_remove(struct platform_device > *pdev) > rfkill_unregister(rfkill->

Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper

2014-09-25 Thread Rafael J. Wysocki
s. If in fu= > ture > > > there are no users (today we have quite a few), then we can remove the = > dead > > > macro, no harm. But that is not the situation today. > >=20 > > as I said, a commit that's bound to be useless. It's not like you're &

Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper

2014-09-24 Thread Rafael J. Wysocki
+-- > drivers/usb/musb/omap2430.c |6 +-- > drivers/video/fbdev/auo_k190x.c | 9 +--- > include/linux/pm_runtime.h |6 +++ > 31 files changed, 97 insertions(+), 177 deletions(-) OK, I guess this is as goo