Hi Amit,
On Tue, Jun 12, 2018 at 07:44:10PM +0530, Amit Pundir wrote:
> Fix unused variable warnings reported on next-20180612.
>
> Fixes: 7579d009c4a1 ("NFC: fdp: Remove __func__ from dev_dbg()")
> Signed-off-by: Amit Pundir
> ---
> drivers/nfc/fdp/fdp.c | 13 -
> 1 file changed, 1
Hi Daniel,
On Mon, May 28, 2018 at 09:39:01PM +0200, Daniel Mack wrote:
> On Monday, May 28, 2018 04:50 PM, Samuel Ortiz wrote:
> > Hi Daniel,
> >
> > On Mon, May 28, 2018 at 04:35:15PM +0200, Daniel Mack wrote:
> > > On Wednesday, May 16, 2018 03:32 PM, Daniel Mac
Hi Fabio,
On Mon, Apr 23, 2018 at 08:50:04AM -0300, Fabio Estevam wrote:
> Hi Samuel,
>
> Maybe this patch series got forgotten?
Both patches applied to nfc-next, sorry for the lag.
Cheers,
Samuel.
Hi Daniel,
On Mon, May 28, 2018 at 04:35:15PM +0200, Daniel Mack wrote:
> On Wednesday, May 16, 2018 03:32 PM, Daniel Mack wrote:
> > 'rm_lock' and 'exchange_lock' need to be ready before the IRQ handler has a
> > chance to fire.
> >
> > This fixes the oops below.
>
> Nobody seems to be interest
Hi Daniel,
On Mon, May 28, 2018 at 04:35:15PM +0200, Daniel Mack wrote:
> On Wednesday, May 16, 2018 03:32 PM, Daniel Mack wrote:
> > 'rm_lock' and 'exchange_lock' need to be ready before the IRQ handler has a
> > chance to fire.
> >
> > This fixes the oops below.
>
> Nobody seems to be interest
Hi David,
This is the NFC pull request for 4.15. We have:
- A new netlink command for explicitly deactivating NFC targets
- i2c constification for all NFC drivers
- One NFC device allocation error path fix
The following changes since commit 2798b80b385384d51a81832556ee9ad25d175f9b:
Merge bran
On Thu, Jun 15, 2017 at 08:57:24PM -0700, Mark Greer wrote:
> This series adds the ability for client apps to deactivate a currently
> active tag. Once deactivated, the client can either poll again to
> reactivate the tag or power the adapter off to save power. These
> changes will not work until
Hi Mark,
On Thu, Jun 15, 2017 at 11:24:53AM -0700, Mark Greer wrote:
> This is an assortment of commits that make some fixups, do some general
> tightening of NDEF data checking, add support for TI Standard and Pro
> Type 5 tags, and stop issuing the Read Multiple Blocks command when
> formatting
Hi Mark,
On Thu, Jun 15, 2017 at 08:34:20PM -0700, Mark Greer wrote:
> There is currently no way for userspace to deactivate an active target.
> Since the target is active, the adapter cannot be powered down which
> wastes wastes power when the target has been read and isn't needed
> anymore (but
On Thu, Oct 05, 2017 at 10:47:12AM +0100, Colin King wrote:
> From: Colin Ian King
>
> The structure nci_ops is local to the source and does not need to
> be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'nci_ops' was not declared. Should it be static?
>
> Signed-of
Hi Colin,
On Tue, Sep 19, 2017 at 03:25:15PM +0100, Colin King wrote:
> From: Colin Ian King
>
> Don't populate the read-only array match on the stack, instead make
> it static const. Makes the object code smaller by over 310 bytes:
>
> Before:
>text data bss dec hex f
Hi Arvind,
On Mon, Aug 21, 2017 at 10:33:52PM +0530, Arvind Yadav wrote:
> i2c_device_id are not supposed to change at runtime. All functions
> working with i2c_device_id provided by work with
> const i2c_device_id. So mark the non-const structs as const.
>
> Arvind Yadav (8):
> [PATCH 1/8] nf
Hi Johan,
On Sun, Jul 09, 2017 at 01:08:58PM +0200, Johan Hovold wrote:
> A recent change fixing NFC device allocation itself introduced an
> error-handling bug by returning an error pointer in case device-id
> allocation failed. This is clearly broken as the callers still expected
> NULL to be re
Hi David,
This is the NFC pull request for 4.13. We have:
- A conversion to unified device and GPIO APIs for the
fdp, pn544, and st{21,-nci} drivers.
- A fix for NFC device IDs allocation.
- A fix for the nfcmrvl driver firmware download mechanism.
- A trf7970a DT and GPIO cleanup and clock set
Hi Geoff,
On Thu, Apr 27, 2017 at 05:28:46PM -0400, Geoff Lansberry wrote:
> In prior commits the selected clock frequency does not propagate
> correctly to what is written to the TRF7970A_MODULATOR_SYS_CLK_CTRL
> register.
>
> Signed-off-by: Geoff Lansberry
> ---
> drivers/nfc/trf7970a.c | 7 +
Hi Shikha,
On Tue, May 02, 2017 at 02:03:39AM -0400, Shikha Singh wrote:
> +static int nfcst_in_send_cmd(struct nfc_digital_dev *ddev,
> + struct sk_buff *skb,
> + u16 timeout,
> + nfc_digital_cmd_complete_t cb,
> +
Hi Dan,
On Wed, Jun 14, 2017 at 10:49:46AM +0300, Dan Carpenter wrote:
> "conn_info" can't be NULL here. Also we just dereferenced it a couple
> lines earlier, so that makes static checkers complain.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c
> in
On Tue, Jun 13, 2017 at 06:44:28PM +0200, Mateusz Jurczyk wrote:
> Verify that the caller-provided sockaddr structure is large enough to
> contain the sa_family field, before accessing it in bind() handlers of the
> AF_NFC socket. Since the syscall doesn't enforce a minimum size of the
> correspond
On Tue, May 30, 2017 at 03:43:07PM -0500, Gustavo A. R. Silva wrote:
> NULL checks at line 457: if (!link0 || !link1) {, implies that both
> pointers link0 and link1 might be NULL.
> Function nfcsim_link_free() dereference pointers link0 and link1.
> Add NULL checks before calling nfcsim_link_free(
Hi Gustavo,
On Tue, Jun 13, 2017 at 11:37:18AM -0500, Gustavo A. R. Silva wrote:
> Remove unnecessary NULL check for pointer conn_info.
> conn_info is set in list_for_each_entry() using container_of(),
> which is never NULL.
>
> Addresses-Coverity-ID: 1362349
> Cc: Guenter Roeck
> Signed-off-by:
Hi Mateusz,
On Wed, May 24, 2017 at 12:42:26PM +0200, Mateusz Jurczyk wrote:
> Check that the NFC_ATTR_TARGET_INDEX and NFC_ATTR_PROTOCOLS attributes (in
> addition to NFC_ATTR_DEVICE_INDEX) are provided by the netlink client
> prior to accessing them. This prevents potential unhandled NULL pointe
Hi Mateusz,
On Wed, May 24, 2017 at 12:26:20PM +0200, Mateusz Jurczyk wrote:
> Fix the sockaddr length verification in the connect() handler of NFC/LLCP
> sockets, to compare against the size of the actual structure expected on
> input (sockaddr_nfc_llcp) instead of its shorter version (sockaddr_n
Hi Mark,
On Thu, Jun 15, 2017 at 10:46:14AM -0700, Mark Greer wrote:
> Add a couple minor fixups and remove the trf7970a erratum handling
> in which the last byte in the response to a Type 5 Read Multiple Blocks
> command is discarded. That handling is moved to the neard daemon where
> there is e
Hi Markus,
On Mon, May 22, 2017 at 02:57:42PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 22 May 2017 14:50:05 +0200
>
> Two update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (2):
> Improve a size determination in four fu
Hi Colin,
On Mon, Apr 24, 2017 at 02:36:02PM +0100, Colin King wrote:
> From: Colin Ian King
>
> The "or" condition (clk_freq != TRF7970A_27MHZ_CLOCK_FREQUENCY) ||
> (clk_freq != TRF7970A_13MHZ_CLOCK_FREQUE) will always be true because
> clk_freq cannot be equal to two different values at the sa
Hi Andy,
On Mon, Jun 19, 2017 at 01:08:45PM +0300, Andy Shevchenko wrote:
> This clean up series to NFC drivers that are using GPIOs on ACPI enabled
> platforms. Since GPIO ACPI library goes stricter about requesting
> resources we need to amend drivers for that. Here we are for NFC
> subsystem.
>
Hi Andy,
On Mon, Jun 05, 2017 at 11:19:57PM +0300, Andy Shevchenko wrote:
> Andy Shevchenko (12):
> NFC: pn544: Switch to devm_acpi_dev_add_driver_gpios()
> NFC: st21nfca: Add GPIO ACPI mapping table
> NFC: st21nfca: Get rid of code duplication in ->probe()
> NFC: fdp: Convert I2C driver t
Andy,
On Mon, Jun 12, 2017 at 06:36:12PM +0300, Andy Shevchenko wrote:
> On Mon, 2017-06-05 at 23:19 +0300, Andy Shevchenko wrote:
> > This clean up series to NFC drivers that are using GPIOs on ACPI
> > enabled
> > platforms. Since GPIO ACPI library goes stricter about requesting
> > resources we
Hi Shikha,
That one is next on my review list.
Could you please rebase it on top of nfc-next though ?
Cheers,
Samuel.
On Fri, Apr 28, 2017 at 04:31:16AM +, Shikha SINGH wrote:
> Hello Samuel,
>Could you please consider the below patch series for integration in
> Linux-NFC mainline?
Hi Johan,
On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote:
> This started out with the observation that the nfcmrvl_uart driver
> unconditionally dereferenced the tty class device despite the fact that
> not every tty has an associated struct device (Unix98 ptys). Some
> further chang
Hi Mark,
On Tue, Apr 25, 2017 at 03:43:47PM -0700, Mark Greer wrote:
> These trf7970a driver patches do the following things:
> - add Mark Greer as the maintainer of the trf7970a driver
> - some minor fixups
> - remove support for 'vin-voltage-override' DT property
> - change the DTS example t
On Thu, Apr 20, 2017 at 04:15:39PM -0400, David Miller wrote:
> From: Samuel Ortiz
> Date: Wed, 19 Apr 2017 01:22:31 +0200
>
> > This is the NFC pull request for 4.12. We have:
>
> Please CC netdev on all pull requests you'd like me to act upon.
Apologies, I forgot.
I
NFC: remove TI nfcwilink driver
Samuel Ortiz (1):
MAINTAINERS: Remove Lauro and Aloisio from the NFC maintainers list
Sudip Mukherjee (1):
nfc: fdp: fix NULL pointer dereference
Tobias Klauser (1):
NFC: nfcmrvl: Include unaligned.h instead of access_ok.h
.../devicetree/bindings
On Wed, Apr 19, 2017 at 02:47:34PM +0300, Dan Carpenter wrote:
> On Sun, Apr 02, 2017 at 12:11:17AM +0200, Samuel Ortiz wrote:
> > Hi Dan,
> >
> > On Wed, Mar 08, 2017 at 08:22:37AM +0300, Dan Carpenter wrote:
> > > The nci_spi_send() function calls kfree_skb(skb) o
Hi Johan,
On Tue, Apr 18, 2017 at 12:09:16PM +0200, Johan Hovold wrote:
> On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote:
> > This started out with the observation that the nfcmrvl_uart driver
> > unconditionally dereferenced the tty class device despite the fact that
> > not every t
RC-S380* in port100_send_ack()
Rob Herring (1):
NFC: remove TI nfcwilink driver
Samuel Ortiz (1):
MAINTAINERS: Remove Lauro and Aloisio from the NFC maintainers list
Sudip Mukherjee (1):
nfc: fdp: fix NULL pointer dereference
Tobias Klauser (1):
NFC: nfcmrvl: Include unalig
On Thu, Apr 06, 2017 at 05:58:59PM +0100, Al Viro wrote:
> On Thu, Apr 06, 2017 at 05:48:47PM +0100, Al Viro wrote:
> > * use unaligned.h, not unaligned/access_ok.h
>
> ... which got misspelled in that patch, sorry... Fixed variant follows:
>
> commit b3e79ba1708c9b74781079c9f8617448fce36b51
> A
Hi Michał,
On Thu, Apr 06, 2017 at 05:49:02AM +0200, Michał Mirosław wrote:
> fix for WARN:
>
> usb 3-2.4.1: NFC: Exchanging data failed (error 0x13)
> llcp: nfc_llcp_recv: err -5
> llcp: nfc_llcp_symm_timer: SYMM timeout
> [ cut here ]
> WARNING: CPU: 1 PID: 26397 at .../
Hi Geoff,
On Wed, Dec 21, 2016 at 11:18:32PM -0500, Geoff Lansberry wrote:
> The TRF7970A has configuration options to support hardware designs
> which use a 27.12MHz clock. This commit adds a device tree option
> 'clock-frequency' to support configuring the this chip for default
> 13.56MHz clock
Hi Michał,
On Tue, Apr 04, 2017 at 07:09:10AM +0200, Michał Mirosław wrote:
> This fixes following WARNing:
>
> usb 3-2.4.1: NFC: Exchanging data failed (error 0x13)
> llcp: nfc_llcp_recv: err -5
> llcp: nfc_llcp_symm_timer: SYMM timeout
> [ cut here ]
> WARNING: CPU: 1 PI
On Wed, Mar 22, 2017 at 09:22:51PM +0200, Andy Shevchenko wrote:
> In some cases nfc_dbg() is useful. Add such macro to a header.
>
> Signed-off-by: Andy Shevchenko
> ---
> include/net/nfc/nfc.h | 1 +
> 1 file changed, 1 insertion(+)
Applied as well.
Cheers,
Samuel.
Hi Andy,
On Wed, Mar 22, 2017 at 09:20:58PM +0200, Andy Shevchenko wrote:
> It looks like a typo to assign a return code to a variable which is not
> used. Found due to a compiler warning:
>
> net/nfc/netlink.c: In function ‘nfc_genl_activate_target’:
> net/nfc/netlink.c:903:6: warning: variable
Hi Andy,
On Tue, Mar 07, 2017 at 12:25:42PM +0200, Andy Shevchenko wrote:
> We return -ENODEV if ACPI provides a GPIO resource. Looks really wrong.
> If it has even been tested?
>
> Signed-off-by: Andy Shevchenko
> ---
> drivers/nfc/st21nfca/i2c.c | 4 ++--
> 1 file changed, 2 insertions(+), 2
Hi Andy,
On Tue, Mar 28, 2017 at 12:36:35PM +0300, Andy Shevchenko wrote:
> Legacy platform data must go away. We are on the safe side here since
> there are no users of it in the kernel.
>
> If anyone by any odd reason needs it the GPIO lookup tables and
> built-in device properties at your serv
Hi Andrey,
On Wed, Dec 28, 2016 at 08:10:56PM +0300, Andrey Rusalin wrote:
> Each of these patches fix some oops that I met during
> tests of the driver with itead pn532 nfc module.
>
> First and third patches related to order of initialization driver,
> where interrupt handler was registered b
Hi Sudip,
On Tue, Dec 20, 2016 at 09:09:04PM +, Sudip Mukherjee wrote:
> We are checking phy after dereferencing it. We can print the debug
> information after checking it. If phy is NULL then we will get a good
> stack trace to tell us that we are in this irq handler.
>
> Signed-off-by: Sudi
Hi Heiko,
On Tue, Feb 07, 2017 at 06:22:04AM +0100, Heiko Schocher wrote:
> From: Guan Ben
>
> Make the EN2 pin optional. This is useful for boards,
> which have this pin fix wired, for example to ground.
>
> Signed-off-by: Guan Ben
> Signed-off-by: Mark Jonas
> Signed-off-by: Heiko Schocher
Hi Nicholas,
On Sun, Jan 22, 2017 at 01:28:39PM +0100, Nicholas Mc Guire wrote:
> ulseep_range() uses hrtimers and provides no advantage over msleep()
> for larger delays. For this large delay msleep() is preferable.
>
> Fixes: commit 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI
>
riant for unaligned access to use needs to be
> left to the arch level and not used at the driver level. Since not
> all arch will have sourced asm/unaligned.h already, we need to call
> it out and then the arch can give us just the one definition that
> is needed.
>
> See commit 06410
Hi Christophe,
On Sun, Feb 19, 2017 at 10:58:47AM +0100, Christophe JAILLET wrote:
> If all bits of 'dev_mask' are already set, there is a memory leak because
> 'info' should be freed before returning.
>
> While fixing it, 'return -ENOMEM' directly if the first kzalloc fails.
> This makes the cod
Hi Dan,
On Wed, Mar 08, 2017 at 08:22:37AM +0300, Dan Carpenter wrote:
> The nci_spi_send() function calls kfree_skb(skb) on both error and
> success so this extra kfree_skb() is a double free.
>
> Fixes: caf6e49bf6d0 ("NFC: nfcmrvl: add spi driver")
> Signed-off-by: Dan Carpenter
> ---
> Static
Hi Corentin,
On Thu, Dec 15, 2016 at 03:22:44PM +0100, Corentin Labbe wrote:
> drivers/nfc/nxp-nci/i2c.c does not use any miscdevice, so this patch
> remove this unnecessary inclusion.
>
> Signed-off-by: Corentin Labbe
> ---
> drivers/nfc/nxp-nci/i2c.c | 1 -
> 1 file changed, 1 deletion(-)
All
Hi Tobias,
On Wed, Oct 26, 2016 at 11:00:12AM +0200, Tobias Klauser wrote:
> Including linux/unaligned/access_ok.h causes the allmodconfig build on
> ia64 (and maybe others) to fail with the following warnings:
>
> include/linux/unaligned/access_ok.h:7:19: error: redefinition of
> 'get_unaligned
Hi Geliang,
On Thu, Nov 24, 2016 at 09:58:34PM +0800, Geliang Tang wrote:
> Drop duplicate header gpio.h from nfcmrvl/spi.c.
>
> Signed-off-by: Geliang Tang
> ---
> drivers/nfc/nfcmrvl/spi.c | 1 -
> 1 file changed, 1 deletion(-)
Patch applied, thanks.
Cheers,
Samuel.
Hi Paul,
On Tue, Mar 28, 2017 at 06:55:26PM -0400, Paul Gortmaker wrote:
> On Mon, Jan 9, 2017 at 12:52 PM, Paul Gortmaker
> wrote:
> > Currently ia64 fails building allmodconfig with variations of:
> >
> >In file included from drivers/nfc/nxp-nci/i2c.c:39:0:
> >./include/linux/unaligned/
Hi Andy,
It's not abandoned. I just got swamped for the past 3 months but things
are slowing down now.
I'll go through my patches backlog during the next 10 days.
Apologies for the delays.
Cheers,
Samuel.
On Fri, Mar 24, 2017 at 06:10:35PM +0200, Andy Shevchenko wrote:
> Hi!
>
> I have sent co
t; Cc: Ilan Elias
> Cc: Marcel Holtmann
> Cc: Samuel Ortiz
> Cc: Lauro Ramos Venancio
> Cc: Aloisio Almeida Jr
> Cc: linux-wireless@vger.kernel.org
> Signed-off-by: Rob Herring
> ---
> drivers/nfc/Kconfig | 11 -
>
Hi Hirofumi,
On Sat, Feb 04, 2017 at 10:15:22AM +0900, OGAWA Hirofumi wrote:
>
>
> Signed-off-by: OGAWA Hirofumi
> ---
>
> drivers/nfc/port100.c |8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
All 4 patches applied, thanks.
Cheers,
Samuel.
Hi Rob,
On Fri, Feb 24, 2017 at 02:56:48PM -0600, Rob Herring wrote:
> On Wed, Jan 25, 2017 at 11:54 PM, Marcel Holtmann wrote:
> > Hi Rob,
> >
> >> It appears that TI WiLink devices including NFC (WL185x/WL189x) never
> >> shipped. The only information I found were announcements in Feb
> >> 2012
Hi Julia,
On Tue, Aug 09, 2016 at 07:03:50PM +0200, Julia Lawall wrote:
> The nfcmrvl_if_ops structures are never modified, so declare them as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall
>
> ---
> drivers/nfc/nfcmrvl/i2c.c |2 +-
> drivers/nfc/nfcmrvl/
Hi Julia,
On Tue, Aug 09, 2016 at 06:11:02PM +0200, Julia Lawall wrote:
> The pn533_phy_ops are never modified, so declare them as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall
>
> ---
> drivers/nfc/pn533/i2c.c |2 +-
> drivers/nfc/pn533/pn533.c |2 +-
Hi Markus,
On Mon, Aug 15, 2016 at 09:12:29AM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 15 Aug 2016 09:00:26 +0200
>
> The field "owner" is set by core. Thus delete an extra initialisation.
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> Signed-o
Hi David,
This is the first NFC pull request for 4.8. We have:
- A fairly large NFC digital stack patchset:
* RTOX fixes.
* Proper DEP RWT support.
* ACK and NACK PDUs handling fixes, in both initiator
and target modes.
* A few memory leak fixes.
- A conversion of the nfcsim driver t
Hi Colin,
On Fri, Jul 15, 2016 at 02:00:33PM +0100, Colin King wrote:
> From: Colin Ian King
>
> When the firmware is released for info->ram_patch currently
> info->otp_patch is being nullified and not info->ram_patch.
> This looks like a cut-n-paste coding error. Fix this by
> nullifing the cor
Hi Marcel,
On Wed, Jul 13, 2016 at 11:56:02AM +0100, Marcel Holtmann wrote:
> Hi Mauro,
>
> >> On mips and parisc:
> >>
> >>drivers/bluetooth/btwilink.c: In function 'ti_st_open':
> >>drivers/bluetooth/btwilink.c:174:21: warning: overflow in implicit
> >> constant conversion [-Woverflow
Hi Colin,
On Mon, Jul 11, 2016 at 04:46:57PM +0100, Colin King wrote:
> diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c
> index e44a7a2..d93d314 100644
> --- a/drivers/nfc/fdp/fdp.c
> +++ b/drivers/nfc/fdp/fdp.c
> @@ -345,7 +345,7 @@ static void fdp_nci_release_firmware(struct nci_dev *
Hi Krzysztof,
On Wed, Mar 30, 2016 at 09:51:04AM +0900, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
>
> Signed-off-by: Krzysztof Kozlowski
>
> ---
>
> The coccinelle script which generated the patch was sent here:
> http://
it is used,
> so we can get rid of the header file and dead code altogether.
>
> Signed-off-by: Jean Delvare
> Cc: Eric Lapuyade
> Cc: Lauro Ramos Venancio
> Cc: Aloisio Almeida Jr
> Cc: Samuel Ortiz
> ---
> Makes me wonder if this driver is used at all? I can'
Hi Mika,
On Thu, Mar 03, 2016 at 11:26:18AM +0200, Mika Westerberg wrote:
> When pn544_hci_i2c_acpi_request_resources() gets called we already know
> that the entries in ->acpi_match_table have matched ACPI ID of the device.
> In addition I2C client pointer cannot be NULL in any case (otherwise I2
rvice_name_len is set,
> but llcp_sock->service_name is not, in this case we would
> lead to copy some bytes from a NULL pointer.
>
> Just lock the sock since this is not a hot path anyway.
>
> Reported-by: Dmitry Vyukov
> Cc: Lauro Ramos Venancio
> Cc: Aloisio Almei
: Lauro Ramos Venancio
> Cc: Aloisio Almeida Jr
> Cc: Samuel Ortiz
> Signed-off-by: Cong Wang
> ---
> net/nfc/llcp_commands.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to nfc-next, thanks.
Cheers,
Samuel.
--
To unsubscribe from this list: send the line
on purpose.
> >
> > Reported-by: Dmitry Vyukov
> > Cc: Lauro Ramos Venancio
> > Cc: Aloisio Almeida Jr
> > Cc: Samuel Ortiz
> > Signed-off-by: Cong Wang
>
> Ping...
>
> David, this patch seems still not applied, I guess you expect NFC
>
Hi Tang,
On Wed, Dec 23, 2015 at 12:18:42AM +0800, Geliang Tang wrote:
> Use to_spi_device() instead of open-coding it.
>
> Signed-off-by: Geliang Tang
> ---
> drivers/nfc/trf7970a.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Applied and pushed, thanks.
Cheers,
Samuel.
--
Hi Shikha,
On Tue, Dec 22, 2015 at 04:53:37AM -0500, Shikha Singh wrote:
> Modification in core.c to rename function "irq_handler"
> and "irq_thread_handler" to "st95hf_irq_handler" and
> "st95hf_irq_thread_handler" respectively. This modification
> was done to remove build error.
>
> Signed-off-
On Mon, Dec 21, 2015 at 11:45:35PM +0100, Samuel Ortiz wrote:
> Hi Shikha,
>
> On Mon, Dec 21, 2015 at 07:57:23PM +0800, Shikha SINGH wrote:
> > Hello Samuel,
> > Please see my answer below.
> >
> > >This looks a lot better than the initial ve
Hi Shikha,
On Mon, Dec 21, 2015 at 07:57:23PM +0800, Shikha SINGH wrote:
> Hello Samuel,
> Please see my answer below.
>
> >This looks a lot better than the initial version.
> >I only have one question:
> >
> >On Fri, Nov 20, 2015 at 06:40:20AM -0500, Shikha Singh wrote:
> >> +/*
> >>
Hi Saurabh,
On Mon, Dec 21, 2015 at 12:29:30AM +0530, Saurabh Sengar wrote:
> added the rx delay parameter as a device tunable parameter.
>
> Signed-off-by: Saurabh Sengar
> ---
> This is a follow up patch after the review comments by Samuel Ortiz
> on the initial patch.
>
Hi Julia,
On Fri, Nov 13, 2015 at 01:04:41PM +0100, Julia Lawall wrote:
> The s3fwrn5_phy_ops structure is never modified, so declare it as const.
>
> Done with the help of Coccinelle.
Applied to nfc-next, thanks.
Cheers,
Samuel.
--
To unsubscribe from this list: send the line "unsubscribe linux
Hi Singh,
This looks a lot better than the initial version.
I only have one question:
On Fri, Nov 20, 2015 at 06:40:20AM -0500, Shikha Singh wrote:
> +/*
> + * st95hf_send_recv_cmd() is for sending commands to ST95HF
> + * that are described in the cmd_array[]. It can optionally
> + * receive the
Hi Saurabh,
On Sun, Dec 13, 2015 at 01:34:35PM +0530, Saurabh Sengar wrote:
> added the sysfs entry for nfcsim workqueue delay, as tx_delay
>
> Signed-off-by: Saurabh Sengar
> ---
> In case this TODO is not expected to be done, please let me know.
> I wonder after my repeated attempts since last
Hi Arnd,
On Tue, Nov 03, 2015 at 03:03:33PM +0100, Arnd Bergmann wrote:
> The newly added nfcmrvl_spi driver uses the spi_nci
> infrastructure, but does not have a Kconfig dependency on
> that, so we can get a link-time error:
>
> drivers/built-in.o: In function `nfcmrvl_spi_nci_send':
> (.text+0
Hi Shikha,
On Sat, Sep 12, 2015 at 03:21:34AM -0400, Shikha Singh wrote:
> diff --git a/drivers/nfc/st95hf/Makefile b/drivers/nfc/st95hf/Makefile
> new file mode 100644
> index 000..2d8f8f3
> --- /dev/null
> +++ b/drivers/nfc/st95hf/Makefile
> @@ -0,0 +1,6 @@
> +#
> +# Makefile for STMicroelec
Hi Julia,
On Sat, Oct 17, 2015 at 11:32:19AM +0200, Julia Lawall wrote:
> The exit label performs device_unlock(&dev->dev);, which will fail when dev
> is NULL, and nfc_put_device(dev);, which is not useful when dev is NULL, so
> just exit the function immediately.
>
> Problem found using scripts
Hi Christophe,
On Tue, Oct 13, 2015 at 08:31:04AM +0200, Christophe JAILLET wrote:
> There is no need to have the 'struct nfcwilink *drv' variable static in the
> probe function.
> It only wastes a few bytes of memory.
>
> Signed-off-by: Christophe JAILLET
> ---
> drivers/nfc/nfcwilink.c | 2 +-
gt;
> ./net/nfc/netlink.c:1175:21-24: ERROR: dev is NULL but dereferenced.
>
> Signed-off-by: Vincent Stehlé
> Cc: Thierry Escande
> Cc: Samuel Ortiz
> ---
> net/nfc/netlink.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/n
Hi Julia,
On Sun, Oct 11, 2015 at 01:24:13PM +0200, Julia Lawall wrote:
> The only instance of a nxp_nci_phy_ops structure is never modified. Thus
> the declaration of the structure and all references to the structure type
> can be made const.
>
> Done with the help of Coccinelle.
>
> Signed-of
Hi Javier,
On Wed, Sep 16, 2015 at 11:08:42AM +0200, Javier Martinez Canillas wrote:
> The Documentation/devicetree/bindings/net/nfc/trf7970a.txt DT binding doc
> lists "ti,trf7970a" as a compatible string but the corresponding driver
> does not have an OF match table. Add the table to the driver
Hi Jean,
On Fri, Sep 25, 2015 at 10:49:36AM +0200, Jean Delvare wrote:
> As I understand it, the core nfc_pn544 module is useless without
> either the I2C or the MEI access module. So hide NFC_PN544 and
> select it automatically if either NFC_PN544_I2C or NFC_PN544_MEI is
> selected.
>
> This avo
ose_setup()
> callback.
>
> Best regards,
> Robert Baldyga
>
> Changelog:
>
> v3:
> - Addressed comments from Samuel Ortiz:
> - Used nci_prop_cmd and nci_prop_ops to handle proprietary requests
> - Refactorized s3fwrn5_i2c_nci_read and s3fwrn5_i2c_fw_read
>
Hi Robert,
On Thu, Jul 30, 2015 at 04:26:16PM +0200, Robert Baldyga wrote:
> +static int s3fwrn5_firmware_update(struct s3fwrn5_info *info)
> +{
> + u32 version;
> + bool need_update;
> + int ret;
> +
> + ENTER();
We have many tracing tools and frameworks in the kernel, I don't thi
Hi Joe,
On Sun, May 31, 2015 at 05:44:45PM -0700, Joe Perches wrote:
> Several of these goto exit; uses should be direct returns
> as skb is not yet initialized by nci_hci_get_param().
>
> Miscellanea:
>
> o Use !memcmp instead of memcmp() == 0
> o Remove unnecessary goto from if () {... goto ex
Hi Uwe,
On Tue, May 19, 2015 at 09:22:56AM +0200, Uwe Kleine-König wrote:
> Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
> which appeared in v3.17-rc1, the gpiod_get* functions take an additional
> parameter that allows to specify direction and initial value for output.
Hi Tomas,
On Thu, May 07, 2015 at 04:38:30PM +0300, Tomas Winkler wrote:
> In microread_i2c_irq_thread_fn 'client' set but not used
>
> Cc: Lauro Ramos Venancio
> Cc: Aloisio Almeida Jr
> Signed-off-by: Tomas Winkler
> ---
> drivers/nfc/microread/i2c.c | 3 ---
> 1 file changed, 3 deletions(-
Hi Valentin,
On Tue, Apr 28, 2015 at 11:08:47AM +0200, Valentin Rothberg wrote:
> The CPP identifier 'DEBUG' is not used in the source code of nfc at all,
> so we can safely remove setting it in both Makefiles.
>
> Signed-off-by: Valentin Rothberg
> ---
> I detected this issue with ./scripts/che
Hi Msanari,
On Fri, Jun 05, 2015 at 09:38:19PM +0900, Masanari Iida wrote:
> This patch fix a spelling typo in nfc-hci.txt
>
> Signed-off-by: Masanari Iida
> ---
> Documentation/nfc/nfc-hci.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Cheers,
Samuel.
--
To unsub
Hi Robert,
On Tue, Mar 31, 2015 at 05:05:53PM +0300, Robert Dolca wrote:
> On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz wrote:
> > Hi Robert,
> >
> > On Tue, Feb 24, 2015 at 12:01:47PM +0200, Robert Dolca wrote:
> >> In order to communicate with the device du
Hi Robert,
On Tue, Mar 31, 2015 at 05:03:42PM +0300, Robert Dolca wrote:
> On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz wrote:
> > Hi Robert,
> >
> > On Tue, Feb 24, 2015 at 12:01:45PM +0200, Robert Dolca wrote:
> >> By calling __nci_request instead of nci_re
Hi Robert,
On Wed, Apr 01, 2015 at 06:35:31PM +0300, Robert Dolca wrote:
> On Thu, Mar 26, 2015 at 2:30 AM, Samuel Ortiz wrote:
> >> + /* If a patch was applied the new version is checked */
> >> + if (patched) {
> >> + r = nci_init(n
Hi Joe,
On Tue, Apr 07, 2015 at 12:17:00AM -0700, Joe Perches wrote:
> Add missing terminating newlines to nfc_info and nfc_err
> to avoid possible interleaving from other messages.
>
> Miscellanea:
>
> o typo fix of "unknonwn" in message
> o remove unnecessary OOM messages as there's a generic
Hi Julia,
On Sun, Apr 05, 2015 at 02:06:36PM +0200, Julia Lawall wrote:
> Return a negative error code on failure.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> //
> @@
> identifier ret; expression e1,e2;
> @@
> (
> if (
1 - 100 of 118 matches
Mail list logo
