Re: [PATCH] wireless: ipw2x00: Remove unnecessary parentheses

On 21/09/2018, Nathan Chancellor wrote: > Clang warns when multiple pairs of parentheses are used for a single > conditional statement. > > drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: warning: equality > comparison with extraneous parentheses [-Wparentheses-equality] > if

Re: [PATCH 3/8] wireless: ipw2200: fix old-style declaration

x27;inline' is not > at beginning of declaration [-Werror=old-style-declaration] > > Signed-off-by: Arnd Bergmann > --- > drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Stanislav Yakovlev Stanislav. --

Re: [PATCH 02/19] ipw2x00: use to_pci_dev()

1 insertion(+), 1 deletion(-) > Acked-by: Stanislav Yakovlev Stanislav. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] wireless: ipw2100: fix timeout bug - always evaluated to 0

On 15 June 2015 at 21:24, Nicholas Mc Guire wrote: > commit: commit 2c86c275015c ("Add ipw2100 wireless driver.") introduced > HW_PHY_OFF_LOOP_DELAY (HZ / 5000) which always evaluated to 0. Clarified > by Stanislav Yakovlev that it should be 50 > milliseconds thus fixed up

Re: [BUG ?] delay always evaluates to 0

Hi Nicholas, On 12 June 2015 at 20:58, Nicholas Mc Guire wrote: > Hi ! > > commit 2c86c275015c ("Add ipw2100 wireless driver.") introduced > > drivers/net/wireless/ipw2100.c - line-numbers are from next-20150511 > 1410 static int ipw2100_hw_phy_off(struct ipw2100_priv *priv) > 1411 { > 1412 > 141

Re: [PATCH] treewide: Fix typo compatability -> compatibility

On 27 May 2015 at 16:05, Laurent Pinchart wrote: > Even though 'compatability' has a dedicated entry in the Wiktionary, > it's listed as 'Mispelling of compatibility'. Fix it. > > Signed-off-by: Laurent Pinchart > --- > drivers/net/wireless/ipw2x0

Re: [patch] ipw2x00: shift wrap bugs setting ->rt_tsf

Hello, Joe, On 24 October 2014 02:43, Joe Perches wrote: > > struct ipw_rt_hdr { > struct ieee80211_radiotap_header rt_hdr; > u64 rt_tsf; /* TSF */ /* XXX */ > u8 rt_flags;/* radiotap packet flags * > u8 rt_rate; /* rate in 500kb/s */ > __

Re: ipw2200 driver in kernels 3+

Hello Frank, On 15 October 2014 12:34, Frank Langille wrote: > ... the menuconfig option to select this > driver seems to have disappeared sometime after kernel 3.4.104, which > is the last longterm version I can see that allows me to include the > driver in my build. > > Is it possible to have t

Re: [patch 2/2] ipw2x00: clean up a condition

Hello Dan, On 9 October 2014 02:59, Dan Carpenter wrote: > The original condition was "(PAGE_SIZE - len)" when "(len < PAGE_SIZE)" > is intended. > > This condition is not really sufficient, but also not really needed... > If "len > PAGE_SIZE" then it we will print a warning message in dmesg > bu

Re: [patch 1/2] ipw2x00: remove unused ->ibss_dfs pointer

Hello Dan, On 9 October 2014 02:57, Dan Carpenter wrote: > The ->ibss_dfs pointer is always allocated with a user controlled > length. This caused a static checker warning because what if the length > was zero? In that case, any dereference of ->ibss_dfs would lead to an > Oops. > > It turns ou

Re: [PATCH] Check ieee80211softmac_auth_resp kmalloc result

Hello Dan, > So far as I can see this is harmless because we never use ->ibss_dfs > and we should just delete it along with all the related code? Yes, you are right. This code is not used by ipw2x00 driver, so it can be deleted. Will you send a patch? Stanislav. -- To unsubscribe from this list: