Re: [v8, bpf-next, 4/9] net/wireless/iwlwifi: fix iwlwifi_dev_ucode_error tracepoint

2018-05-24 Thread Steven Rostedt
On Thu, 24 May 2018 16:28:39 -0700 Alexei Starovoitov wrote: > Ohh. I didn't realize that networking wireless doesn't fall under netdev. > I thought wireless folks are silent because they are embarrassed > by a function with 17 arguments. Please lets refrain from the demeaning comments. I agree

Re: [RFC v4 8/8] mac80211: use Kconfig counters to determine feature optimisation

2015-11-13 Thread Steven Rostedt
On Fri, 13 Nov 2015 17:35:39 +0100 Johannes Berg wrote: > On Fri, 2015-11-13 at 11:29 -0500, Steven Rostedt wrote: > > > > - select MAC80211_HW_HAS_RATE_CONTROL_OFF > > > - select MAC80211_HW_RX_INCLUDES_FCS_OFF > > > > What happened to these two? >

Re: [RFC v4 8/8] mac80211: use Kconfig counters to determine feature optimisation

2015-11-13 Thread Steven Rostedt
On Thu, 12 Nov 2015 09:47:53 +0100 Johannes Berg wrote: > From: Johannes Berg > > Drivers that would like to have feature flag optimisations are > currently required to select _ON and _OFF symbols for each one, > indicating whether they'd like to be optimised for being on or > off respectively.

Re: [RFC v4 6/8] kconfig: introduce "count"

2015-11-13 Thread Steven Rostedt
On Thu, 12 Nov 2015 09:47:51 +0100 Johannes Berg wrote: > From: Johannes Berg > > "count" works similar to "select"; take, for example, this snippet: > > config MY_COUNTER > int > > config MY_DRIVER_1 > bool "my driver 1" > count MY_COUNTER > >

Re: [RFC v4 5/8] mac80211: generate hw flags from include file

2015-11-13 Thread Steven Rostedt
On Thu, 12 Nov 2015 09:47:50 +0100 Johannes Berg wrote: > +#define __DEFINE_HWFLAG(_flg, _on, _off) \ > + HWFLAGS_DEFSTATE_##_flg = -1 + ((_on) ^ (_off)) * (1 + _on), > +#define DEFINE_HWFLAG(_flg) \ > + __DEFINE_HWFLAG

Re: [RFC v4 3/8] mac80211: use static keys for hw flags

2015-11-13 Thread Steven Rostedt
On Thu, 12 Nov 2015 09:47:48 +0100 Johannes Berg wrote: > index ..e220c5e04406 > --- /dev/null > +++ b/net/mac80211/hwflags.h > @@ -0,0 +1,89 @@ > +/* > + * Copyright 2015Intel Deutschland GmbH > + * > + * This program is free software; you can redistribute it and/or modify > + *

Re: [RFC v2 3/4] mac80211: use static keys for hw flags

2015-11-11 Thread Steven Rostedt
On Wed, 11 Nov 2015 15:29:02 +0100 Johannes Berg wrote: config MY_DRIVER_1 SELECT SET_FLAG config MY_DRIVER_2 SELECT SET_FLAG [...] config FLAG_ALL_SET default y depends on MY_DRIVER_1 && !MY_DRIVER_2 && ... && MY_DRIVER_N > Right. Basically it'd be one of three options

Re: [RFC v2 3/4] mac80211: use static keys for hw flags

2015-11-11 Thread Steven Rostedt
On Wed, 11 Nov 2015 14:39:16 +0100 Johannes Berg wrote: > On Wed, 2015-11-11 at 08:34 -0500, Steven Rostedt wrote: > > > > config MY_DRIVER > > > depends on MAC80211 > > > increment MAC80211_NUM_DRIVERS > > > increment MAC80211_HW_MYFLAG > &

Re: [RFC v2 3/4] mac80211: use static keys for hw flags

2015-11-11 Thread Steven Rostedt
On Wed, 11 Nov 2015 08:37:52 +0100 Johannes Berg wrote: > On Wed, 2015-11-11 at 02:22 +0200, Luca Coelho wrote: > >  > > Now that you have all these options in Kconfig, wouldn't it be > > possible > > to remove the calls to the "static" ieee80211_hw_set() in the drivers > > and somehow set all th

Re: [PATCH] iwlwifi: Move each system tracepoints to their own header

2015-04-13 Thread Steven Rostedt
On Mon, 13 Apr 2015 11:17:17 +0300 Emmanuel Grumbach wrote: > I overthought it. Stephen fixed the conflict correctly. > Good, because I needed that change in my tree as other patches depended on it. Linus should be able to figure this out. I'll have to write up a bit for him when I do my pull

Re: [PATCH] brcmsmac: Move each system tracepoints to their own header

2015-04-08 Thread Steven Rostedt
On Wed, 8 Apr 2015 09:32:44 +0200 Arend van Spriel wrote: > On 04/07/15 18:11, Steven Rostedt wrote: > > > > Every tracing file must have its own TRACE_SYSTEM defined. > > The brcmsmac tracepoint header broke this and added in the middle > > of the file: &g

[PATCH] iwlwifi: Move each system tracepoints to their own header

2015-04-07 Thread Steven Rostedt
. Cc: Johannes Berg Signed-off-by: Steven Rostedt --- Johannes, can you ack this one too. Thanks, -- Steve drivers/net/wireless/iwlwifi/iwl-devtrace-data.h | 79 drivers/net/wireless/iwlwifi/iwl-devtrace-io.h | 155 .../net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h| 200

[PATCH] brcmsmac: Move each system tracepoints to their own header

2015-04-07 Thread Steven Rostedt
brcmsmac_msg Unfortunately, this broke new code in the ftrace infrastructure. Moving each of these TRACE_SYSTEMs into their own trace file with just one TRACE_SYSTEM per file fixes the issue. Cc: Arend van Spriel Signed-off-by: Steven Rostedt --- Requesting an Acked-by so I can pull this into my tree

Re: [PATCH] mac80211: Move message tracepoints to their own header

2015-04-07 Thread Steven Rostedt
On Tue, 07 Apr 2015 08:58:58 +0200 Johannes Berg wrote: > On Mon, 2015-04-06 at 23:13 -0400, Steven Rostedt wrote: > > Every tracing file must have its own TRACE_SYSTEM defined. > > Oh, that requirement is new to me. I also have the same in iwlwifi, with > even more TRACE

Re: [PATCH] mac80211: Move message tracepoints to their own header

2015-04-07 Thread Steven Rostedt
On Tue, 07 Apr 2015 08:58:58 +0200 Johannes Berg wrote: > On Mon, 2015-04-06 at 23:13 -0400, Steven Rostedt wrote: > > Every tracing file must have its own TRACE_SYSTEM defined. > > Oh, that requirement is new to me. I also have the same in iwlwifi, with > even more TRACE_SY

[PATCH] mac80211: Move message tracepoints to their own header

2015-04-06 Thread Steven Rostedt
own trace file with its own TRACE_SYSTEM defined fixes the issue. Cc: Johannes Berg Signed-off-by: Steven Rostedt --- net/mac80211/trace.c | 1 + net/mac80211/trace.h | 38 -- net/mac80211/trace_msg.h | 53