Re: [PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM

2018-01-26 Thread Tejun Heo
Hello, On Fri, Jan 26, 2018 at 09:08:02AM +0100, Johannes Berg wrote: > Not that you mention it ... Honestly though, wifi connections break all > the time, so not sure you'd really want that. But anyway, that's what > we have. I'd be a lot happier to remove WQ_MEM_RECLAIM from wireless drivers

Re: [PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM

2018-01-25 Thread Tejun Heo
Hello, On Thu, Jan 25, 2018 at 10:01:26PM +0100, Johannes Berg wrote: > I guess we should just ask Tejun :-) > > Tejun, the problem was a report that a WQ_MEM_RECLAIM workqueue is > flushing another that isn't, and it turns out that lots of wireless > drivers are using WQ_MEM_RECLAIM for some

Re: [PATCH v2] cfg80211: Remove deprecated create_singlethread_workqueue

2016-08-31 Thread Tejun Heo
off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com> Acked-by: Tejun Heo <t...@kernel.org> Thanks. -- tejun

Re: [PATCH] libertas_tf: Remove create_workqueue

2016-06-11 Thread Tejun Heo
Bhaktipriya Shridhar <bhaktipriy...@gmail.com> Acked-by: Tejun Heo <t...@kernel.org> Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: wireless: marvell: libertas: Remove create_workqueue

2016-06-05 Thread Tejun Heo
e calls to flush_workqueue() before > destroy_workqueue() have been dropped. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com> Acked-by: Tejun Heo <t...@kernel.org> Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-wireless&

Re: [RFD] workqueue: WQ_MEM_RECLAIM usage in network drivers

2016-03-20 Thread Tejun Heo
Hello, On Fri, Mar 18, 2016 at 05:24:05PM -0400, J. Bruce Fields wrote: > > But does that actually work? It's pointless to add WQ_MEM_RECLAIM to > > workqueues unless all other things are also guaranteed to make forward > > progress regardless of memory pressure. > > It's supposed to work. > >

Re: [RFD] workqueue: WQ_MEM_RECLAIM usage in network drivers

2016-03-19 Thread Tejun Heo
Hello, Jeff. On Thu, Mar 17, 2016 at 09:32:16PM -0400, Jeff Layton wrote: > > * Are network devices expected to be able to serve as a part of > > storage stack which is depended upon for memory reclamation? > > I think they should be. Cached NFS pages can consume a lot of memory, > and

Re: [PATCH] iwlwifi: dvm: convert create_singlethread_workqueue() to alloc_workqueue()

2016-03-19 Thread Tejun Heo
Hello, On Thu, Mar 17, 2016 at 01:43:22PM +0100, Johannes Berg wrote: > On Thu, 2016-03-17 at 20:37 +0800, Eva Rachel Retuya wrote: > > Use alloc_workqueue() to allocate the workqueue instead of > > create_singlethread_workqueue() since the latter is deprecated and is > > scheduled for removal. >

[RFD] workqueue: WQ_MEM_RECLAIM usage in network drivers

2016-03-19 Thread Tejun Heo
Hello, Years ago, workqueue got reimplemented to use common worker pools across different workqueues and a new set of more expressive workqueue creation APIs, alloc_*workqueue() were introduced. The old create_*workqueue() became simple wrappers around alloc_*workqueue() with the most

Re: [Outreachy kernel] [PATCH v2] iwlwifi: dvm: use alloc_ordered_workqueue()

2016-03-18 Thread Tejun Heo
think "not depended during memory reclaim" probalby is a better way to describe it. > Signed-off-by: Eva Rachel Retuya <eraret...@gmail.com> But other than that, Acked-by: Tejun Heo <t...@kernel.org> Thanks. -- tejun -- To unsubscribe from this list: send the

Re: [PATCH v2 3/8] kernel/params.c: generalize bool_enable_only

2015-04-23 Thread Tejun Heo
Hello, On Wed, Apr 22, 2015 at 02:55:06PM -0700, Luis R. Rodriguez wrote: +int param_set_bool_enable_only(const char *val, const struct kernel_param *kp) +{ + int err = 0; + bool new_value; + bool orig_value = *(bool *)kp-arg; + struct kernel_param dummy_kp = *kp; + +

Re: [PATCH v1 4/6] moduleparam.h: add module_param_config_*() helpers

2015-04-21 Thread Tejun Heo
On Mon, Apr 20, 2015 at 04:30:35PM -0700, Luis R. Rodriguez wrote: /** + * module_param_config_on_off - bool parameter with run time override + * @name: a valid C identifier which is the parameter name. + * @value: the actual lvalue to alter. + * @perm: visibility in sysfs. + * @config:

Re: [PATCH v1 4/6] moduleparam.h: add module_param_config_*() helpers

2015-04-21 Thread Tejun Heo
Hello, Luis. On Tue, Apr 21, 2015 at 06:55:16PM +0200, Luis R. Rodriguez wrote: A use then would be for instance: module_param_config_on_off(power_efficient, wq_power_efficient, 0444, IS_ENABLED(CONFIG_WQ_POWER_EFFICIENT_DEFAULT)); this as an alternative would

[PATCH 21/32] wireless: use %*pb[l] to print bitmaps including cpumasks and nodemasks

2015-01-24 Thread Tejun Heo
patches. lib/vsprintf: implement bitmap printing through '%*pb[l]' cpumask, nodemask: implement cpumask/nodemask_pr_args() Please wait till the forementioned patches are merged to mainline before applying to subsystem trees. Signed-off-by: Tejun Heo t...@kernel.org Cc: Andrew Morton a...@linux