Re: [PATCH v2 1/2] mac80211: Add rcu read side critical sections

2017-09-20 Thread Ville Syrjälä
if you want (not sure you do if you think it's wrong as well). After that I'll leave it to someone who actually knows what they're doing with mac80211 ;) -- Ville Syrjälä Intel OTC

Re: [PATCH 1/2] mac80211: Add rcu read side critical sections

2017-09-19 Thread Ville Syrjälä
_hw *hw, > >  out: > >   spin_unlock_bh(>lock); > >   > > + rcu_read_unlock(); > > > > i.e. this in itself should be sufficient, though you should probably > reorder and acquire the spinlock first since that might spin, and you > want to keep the RCU section minimal (it's trivial here, after all) Good point. I'll respin with that change. -- Ville Syrjälä Intel OTC