Re: [PATCH V2 8/8] brcmfmac: disable command decode in sdio_aos

On 2018/11/12 下午 06:33, Arend van Spriel wrote: > On 11/12/2018 8:30 AM, Chi-Hsien Lin wrote: >> From: Wright Feng >> >> AOS is a part of the SDIOD core that becomes active when the rest of >> SDIOD is sleeping to keep SDIO bus alive responding to reduced set of >

Re: [PATCH 1/5] brcmfmac: set apsta to 1 when AP start on primary interface.

On 2018/11/9 下午 08:48, Arend van Spriel wrote: > On 11/8/2018 4:48 AM, Chi-Hsien Lin wrote: >> From: Wright Feng >> >> APSTA can work on two band concurrently with using VSDB(Virtual >> Simultaneous Dual-Band) or RSDB(Real Simultaneous Dual-Band) features. >> In

Re: [PATCH 2/5] brcmfmac: remove "arp_hostip_clear" from "brcmf_netdev_stop"

On 2018/11/9 上午 03:19, Franky Lin wrote: > On Wed, Nov 7, 2018 at 7:48 PM Chi-Hsien Lin > wrote: >> >> From: Wright Feng >> >> The firmware does not respond ARP request and causes ping failure with >> following steps: >> >> 1. Brin

[PATCH v3 1/3] brcmfmac: add credit numbers updating support

host driver has ability of updating the credit numbers when receiving the BRCMF_E_FIFO_CREDIT_MAP event. Signed-off-by: Wright Feng --- v2: Replace brcmf_err with WARN_ONCE --- .../broadcom/brcm80211/brcmfmac/fwsignal.c| 23 --- 1 file changed, 15 insertions(+), 8 deletions

[PATCH v3 0/3] brcmfmac: throughput enhancement for flow control mode

g a module parameter Changes since v1: - Remove the patch "calling skb_orphan before sending skb to SDIO bus" - Revise the patch "brcmfmac: add credit numbers updating support" Chung-Hsien Hsu (1): brcmfmac: handle compressed tx status signal Wright Feng (2): brcmfmac: add c

[PATCH v3 2/3] brcmfmac: enable frameburst mode in default firmware setting

The frameburst feature can enable per-packet framebursting in firmware side and get higher TX throughput in High Throughput(HT) mode. To enhance TX throughput, we enable frameburst mode in default firmware setting. Signed-off-by: Wright Feng --- v3: Enable frameburst in default instead of being

[PATCH v3 3/3] brcmfmac: handle compressed tx status signal

From: Chung-Hsien Hsu Firmware inform the driver about tx status by normal tx status signal or compressed tx status signal. This patch adds support to handle the compressed tx status signal. Signed-off-by: Chung-Hsien Hsu Signed-off-by: Chi-Hsien Lin Signed-off-by: Wright Feng --- v3: Add

Re: [PATCH v2 2/2] brcmfmac: make firmware frameburst mode a module parameter

Arend van Spriel 於 11/2/2018 8:31 PM 寫道: > On 11/2/2018 9:24 AM, Wright Feng wrote: >> This patch is for adding a new module parameter "frameburst". >> With setting "frameburst=1" in module parameters, firmware frameburst >> mode >> wil

Re: [PATCH 1/3] brcmfmac: calling skb_orphan before sending skb to SDIO bus

Franky Lin 於 11/3/2018 3:51 AM 寫道: > On Thu, Nov 1, 2018 at 8:08 PM Wright Feng wrote: >> >> >> >> On 2018/10/30 上午 02:50, Franky Lin wrote: >>> On Mon, Oct 29, 2018 at 3:27 AM Wright Feng wrote: >>>> >>>> Linux 3.6 introduces

[PATCH v2 2/2] brcmfmac: make firmware frameburst mode a module parameter

T) mode. Signed-off-by: Wright Feng --- .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c| 7 +++ drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 5 + drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h | 2 ++ drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil

[PATCH v2 1/2] brcmfmac: add credit numbers updating support

host driver has ability of updating the credit numbers when receiving the BRCMF_E_FIFO_CREDIT_MAP event. Signed-off-by: Wright Feng --- v2: replace brcmf_err with WARN_ONCE --- .../broadcom/brcm80211/brcmfmac/fwsignal.c| 23 --- 1 file changed, 15 insertions(+), 8 deletions

[PATCH v2 0/2] brcmfmac: throughput enhancement for flow control mode

umbers updating support" Wright Feng (2): brcmfmac: add credit numbers updating support brcmfmac: make firmware frameburst mode a module parameter .../broadcom/brcm80211/brcmfmac/cfg80211.c| 7 ++ .../broadcom/brcm80211/brcmfmac/common.c | 5 .../broadcom/brcm802

Re: [PATCH 2/3] brcmfmac: add credit numbers updating support

On 2018/10/30 下午 07:04, Arend van Spriel wrote: > On 10/29/2018 11:27 AM, Wright Feng wrote: >> The credit numbers are static and tunable per chip in firmware side. >> However the credit number may be changed that is based on packet pool >> length and will send BRCMF_E_

Re: [PATCH 3/3] brcmfmac: make firmware frameburst mode a module parameter

On 2018/10/30 下午 07:33, Arend van Spriel wrote: > On 10/29/2018 11:27 AM, Wright Feng wrote: >> This patch is for adding a new module parameter "frameburst". >> With setting "frameburst=1" in module parameters, firmware frameburst >> mode >> wil

Re: [PATCH 1/3] brcmfmac: calling skb_orphan before sending skb to SDIO bus

On 2018/10/30 上午 02:50, Franky Lin wrote: > On Mon, Oct 29, 2018 at 3:27 AM Wright Feng wrote: >> >> Linux 3.6 introduces TSQ which has a per socket threshold for TCP Tx >> packets to reduce latency. In fcmode 1 and fcmode 2, host driver enqueues >> skb in hanger a

[PATCH 3/3] brcmfmac: make firmware frameburst mode a module parameter

T) mode. Signed-off-by: Wright Feng --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 7 +++ drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 5 + drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h | 2 ++ drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.

[PATCH 0/3] brcmfmac: throughput enhancement for SDIO and flow control mode

These are for throughput enhancement with SDIO bus or with flow control mode enabled, and also introuce a new module parameter to enhance TX throughput as well. Wright Feng (3): brcmfmac: calling skb_orphan before sending skb to SDIO bus brcmfmac: add credit numbers updating support

[PATCH 1/3] brcmfmac: calling skb_orphan before sending skb to SDIO bus

-by: Wright Feng --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index b2e1ab5..519b25d 100644 --- a/drivers/net/wireless

[PATCH 2/3] brcmfmac: add credit numbers updating support

host driver has ability of updating the credit numbers when receiving the BRCMF_E_FIFO_CREDIT_MAP event. Signed-off-by: Wright Feng --- .../broadcom/brcm80211/brcmfmac/fwsignal.c | 23 ++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless

[PATCH v4] brcmfmac: fix CLM load error for legacy chips when user helper is enabled

to -EAGAIN in firmware_class.c with user helper. Because of that, we continue with CLM data currently present in firmware if getting error from doing request_firmware(). Cc: sta...@vger.kernel.org # v4.15.y Reviewed-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by: Wright Feng <

[PATCH v3] brcmfmac: fix CLM load error for legacy chips when user helper is enabled

to -EAGAIN in firmware_class.c with user helper. Because of that, we continue with CLM data currently present in firmware if getting error from doing request_firmware(). Signed-off-by: Wright Feng <wright.f...@cypress.com> --- v2: remove retry from patch v1 v3: remove redundant log print --- drive

Re: [PATCH v2] brcmfmac: fix CLM load error for legacy chips when user helper is enabled

On 2018/1/16 上午 03:54, Arend van Spriel wrote: On 1/15/2018 11:09 AM, Wright Feng wrote: [...] --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211

Re: [PATCH v2] brcmfmac: fix CLM load error for legacy chips when user helper is enabled

On 2018/1/12 下午 07:16, Kalle Valo wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: On 1/12/2018 8:44 AM, Wright Feng wrote: For legacy chips without CLM blob files, kernel with user helper function returns -EAGAIN when we request_firmware() for blob file.

[PATCH v2] brcmfmac: fix CLM load error for legacy chips when user helper is enabled

if getting -EAGAIN when doing request_firmware(). Signed-off-by: Wright Feng <wright.f...@cypress.com> --- v2: remove retry from patch v1 --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/br

[PATCH v2] brcmfmac: Support 43455 save-restore (SR) feature if FW include -sr

From: Double Lo <double...@cypress.com> This patch will add 43455 into the save-restore(SR) capable chip list, so the SR engine will be enabled with 43455 FW which built-in the -sr function. Signed-off-by: Double Lo <double...@cypress.com> Signed-off-by: Wright Feng <wright.f

Re: brcmfmac: Support 43455 save-restore (SR) feature if FW include -sr

On 2017/12/14 下午 08:39, Kalle Valo wrote: Wright Feng <wright.f...@cypress.com> wrote: From: Double Lo <double...@cypress.com> This patch will add 43455 into the save-restore(SR) capable chip list, so the SR engine will be enabled with 43455 FW which built-in the -sr function.

Re: [PATCH] brcmfmac: fix CLM load error for legacy chips when user helper is enabled

Hi Kalle, On 2017/12/12 下午 08:57, Kalle Valo wrote: Wright Feng <wright.f...@cypress.com> writes: For legacy chips w/o CLM blob files, kernel with user helper function enables returns -EAGAIN when we request_firmware() for blob file: "request_firmware() -> _re

[PATCH] brcmfmac: fix CLM load error for legacy chips when user helper is enabled

ore retry and continue brcmf_c_process_clm_blob if getting -EAGAIN from request_firmware function. Signed-off-by: Wright Feng <wright.f...@cypress.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff

[PATCH] brcmfmac: enlarge buffer size of caps to 512 bytes

and add the error print for cap iovar error. Signed-off-by: Wright Feng <wright.f...@cypress.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fea

[PATCH] brcmfmac: Support 43455 save-restore (SR) feature if FW include -sr

From: Double Lo This patch will add 43455 into the save-restore(SR) capable chip list, so the SR engine will be enabled with 43455 FW which built-in the -sr function. Signed-off-by: Double Lo ---

Re: [PATCH] brcmfmac: transfer firmware error to Linux error code in fwil

Hi Arend, On 2017/11/23 下午 06:41, Arend van Spriel wrote: On 11/22/2017 10:11 AM, Wright Feng wrote: fil_cmd_data_set and fil_cmd_data_get return proprietary error code when getting error from firmware layer. The vendor tools or utilities that uses libnl may stuck in some commands when wl

[PATCH] brcmfmac: transfer firmware error to Linux error code in fwil

ode instead of the proprietary error code, and the tools or utilities should get the real firmware error code by command "bcmerror" or "bcmerrorstr" after receiving the error from libnl. Signed-off-by: Wright Feng <wright.f...@cypress.com> --- .../wireless/broadcom/brcm8

[PATCH v7] brcmfmac: add CLM download support

From: Chung-Hsien Hsu The firmware for brcmfmac devices includes information regarding regulatory constraints. For certain devices this information is kept separately in a binary form that needs to be downloaded to the device. This patch adds support to download this

[PATCH v6] brcmfmac: add CLM download support

From: Chung-Hsien Hsu The firmware for brcmfmac devices includes information regarding regulatory constraints. For certain devices this information is kept separately in a binary form that needs to be downloaded to the device. This patch adds support to download this

Re: [PATCH] brcmfmac: return -EPERM when getting error in vendor command handler

Hi Franky, On 2017/9/6 上午 04:02, Franky Lin wrote: On Mon, Sep 4, 2017 at 12:34 AM, Wright Feng <wright.f...@cypress.com> wrote: Firmware returns proprietary error code when getting error in fil_cmd_data_set or fil_cmd_data_get. The vendor tools or utilities which uses libnl may stuck i

[PATCH] brcmfmac: return -EPERM when getting error in vendor command handler

stead of the proprietary error code, and the tools or utilities need to get the real firmware error code by command "bcmerror" or "bcmerrorstr" after receiving the error. Signed-off-by: Wright Feng <wright.f...@cypress.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac

[PATCH v5] brcmfmac: add CLM download support

From: Chung-Hsien Hsu The firmware for brcmfmac devices includes information regarding regulatory constraints. For certain devices this information is kept separately in a binary form that needs to be downloaded to the device. This patch adds support to download this

[PATCH v4] brcmfmac: add CLM download support

From: Chung-Hsien Hsu The firmware for brcmfmac devices includes information regarding regulatory constraints. For certain devices this information is kept separately in a binary form that needs to be downloaded to the device. This patch adds support to download this

[PATCH v3] brcmfmac: add CLM download support

From: Chung-Hsien Hsu The firmware for brcmfmac devices includes information regarding regulatory constraints. For certain devices this information is kept separately in a binary form that needs to be downloaded to the device. This patch adds support to download this

[PATCH v2] brcmfmac: add CLM download support

From: Chung-Hsien Hsu The firmware for brcmfmac devices includes information regarding regulatory constraints. For certain devices this information is kept separately in a binary form that needs to be downloaded to the device. This patch adds support to download this

[PATCH] brcmfmac: add CLM download support

From: Chung-Hsien Hsu The firmware for brcmfmac devices includes information regarding regulatory constraints. For certain devices this information is kept separately in a binary form that needs to be downloaded to the device. This patch adds support to download this

[PATCH] brcmfmac: add setting carrier state ON for successful roaming

From: Chung-Hsien Hsu After association, ping is not working when sweeping the channel at the AP side. It is caused by having incorrect carrier state (OFF) for the STA in successful roaming. This patch sets the carrier state ON for the case. Signed-off-by: Chung-Hsien

[PATCH v2 2/3] brcmfmac: Add support for CYW4373 SDIO/USB chipset

From: Chi-Hsien Lin Add support for CYW4373 SDIO/USB chipset. CYW4373 is a 1x1 dual-band 11ac chipset with 20/40/80Mhz channel support. It's a WiFi/BT combo device. Signed-off-by: Chi-Hsien Lin --- v2: add new chip(4737) info in commit

[PATCH v2 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled

s was always overridden to 1 in brcmf_setup_ifmodes even multi-channel was enabled. We correct the logic by moving num_different_channels setting forward. Signed-off-by: Wright Feng <wright.f...@cypress.com> --- v2: Describe the motivation and reason for this patch in commit message ---

Re: [PATCH 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled

On 2017/8/2 下午 09:40, Kalle Valo wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: On 8/2/2017 11:32 AM, Kalle Valo wrote: Wright Feng <wright.f...@cypress.com> writes: The num_different_channels in wiphy info is not correct when firmware supports mchan

Re: [PATCH 1/3] brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/opensecurity mode

On 2017/8/1 下午 08:41, Arend van Spriel wrote: On 01-08-17 10:48, Wright Feng wrote: When setting wpa_auth to WPA_AUTH_NONE(1) in AP mode with WEP secuirty, firmware will set privacy bit and add WPA OUI in VENDOR IE in beacon and probe response. It confuses the supplicant in sation client

[PATCH 1/3] brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/opensecurity mode

WPA_AUTH_DISABLED in softAP mode with opensecurity. Signed-off-by: Wright Feng <wright.f...@cypress.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cf

[PATCH 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled

The num_different_channels in wiphy info is not correct when firmware supports mchan. When mchan is on, num_different_channels is always overridden to 1 in brcmf_setup_ifmodes. Correct the logic by moving num_different_channels setting forward. Signed-off-by: Wright Feng <wright.f...@cypress.

[PATCH 2/3] brcmfmac: Add support for CYW4373 SDIO/USB chipset

From: Chi-Hsien Lin These changes add support for CYW4373 SDIO/USB chipset. Signed-off-by: Chi-Hsien Lin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 1 + drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c

[PATCH] brcmfmac: remove setting IBSS mode when stopping AP

SS has been set to IBSS mode in firmware side. The IBSS mode should be set when cfg80211 changes the interface. Reviewed-by: Wright Feng <wright.f...@cypress.com> Signed-off-by: Chi-hsien Lin <chi-hsien@cypress.com> Signed-off-by: Wright Feng <wright.f...@cypress.com> --- drive

[PATCH V2] brcmfmac: update beacon IE after bss up and clear when AP stopped

Firmware doesn't update beacon/Probe Response vendor IEs correctly when bss is down, so we move brcmf_config_ap_mgmt_ie after BSS up. And host driver should clear IEs when AP stopped so that the IEs in host side will be synced with in firmware side. Signed-off-by: Wright Feng <wrigh

[PATCH] brcmfmac: update beacon IE when bss up and clear when stopped

Firmware doesn't update beacon vendor IEs when bss is down, so move brcmf_config_ap_mgmt_ie after BSS up. And host driver should clear IEs when AP stopped so that the IEs in host side will be synced with in firmware side. Signed-off-by: Wright Feng <wright.f...@cypress.com> --- drive

RE: [PATCH v2] brcmfmac: shut down AP and set IBSS mode only on primary interface

From: Rafał Miłecki [mailto:zaj...@gmail.com] > On 11 August 2016 at 07:44, Wright Feng <wright.f...@cypress.com> wrote: > > When stopping hostap on virtual interface, driver will set INFRA and > > AP mode that may affect the functionality on primary interface. For >

RE: [PATCH] brcmfmac: shut down AP and set IBSS mode only on primary interface

Hi Kalle and Arend, > -Original Message- > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: Monday, August 15, 2016 4:05 PM > To: Arend Van Spriel <arend.vanspr...@broadcom.com> > Cc: Wright Feng <w...@cypress.com>; brcm80211-dev- > list@broadco

[PATCH v2] brcmfmac: shut down AP and set IBSS mode only on primary interface

shut down AP and set IBSS mode only on primary interface. Signed-off-by: Wright Feng <wright.f...@cypress.com> --- V2:Remove the footnote from the mail. --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/d

RE: [PATCH] brcmfmac: shut down AP and set IBSS mode only on primary interface

On 10-8-2016 12:15, Arend Van Spriel wrote: > On 10-8-2016 11:44, Wright Feng wrote: > > Hi Arend, > > > > Thanks for the reply. > > > > On 10-8-2016 10:26, Arend Van Spriel wrote: > >> On 10-8-2016 10:01, Wright Feng wrote: > >>> When stopp

RE: [PATCH] brcmfmac: shut down AP and set IBSS mode only on primary interface

Hi Arend, Thanks for the reply. On 10-8-2016 10:26, Arend Van Spriel wrote: > On 10-8-2016 10:01, Wright Feng wrote: > > When stopping hostap on virtual interface, driver will set INFRA and > > AP mode that may affect the functionality on primary interface. For > > example,