Re: [PATCH 0/2] iw: fixes to Android.mk to include "iw" in AOSP builds

2015-08-13 Thread enh
On Thu, Aug 13, 2015 at 1:01 PM, Johannes Berg wrote: > On Thu, 2015-08-13 at 12:48 -0700, enh wrote: >> >> i think you misunderstand what AOSP is. this code is currently in >> AOSP master, and thus in internal master, and thus in a future >> release. > > Great

Re: [PATCH 0/2] iw: fixes to Android.mk to include "iw" in AOSP builds

2015-08-13 Thread enh
rom upstream altogether and maintain it in our AOSP downstream. > > Given what I just said above about vendor builds etc. not being AOSP, > that probably wouldn't be all that helpful; I'm pretty sure it'd make > our life more difficult so I don't really like that idea mu

Re: [PATCH 2/2] iw: remove android-nl.c with unneeded workaround

2015-08-02 Thread enh
On Sat, Aug 1, 2015 at 11:57 PM, Arik Nemtsov wrote: > On Fri, Jul 31, 2015 at 7:01 PM, enh wrote: >> no, because this is meant for the platform build system rather than >> the NDK. although the NDK has a concept of target API level, the >> platform only has "cu

Re: [PATCH 2/2] iw: remove android-nl.c with unneeded workaround

2015-07-31 Thread enh
d returned 1 exit status > > Since this is required by earlier versions, can't you #ifdef the code > according to version? Also for the makefile change.. -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by/add me as a reviewer.

Re: [PATCH 1/2] iw: fix references to libnl in Android.mk

2015-07-30 Thread enh
_LDFLAGS := -Wl,--no-gc-sections > #LOCAL_MODULE_TAGS := optional > LOCAL_MODULE_TAGS := eng > -LOCAL_STATIC_LIBRARIES := libnl_2 > +LOCAL_STATIC_LIBRARIES := libnl > LOCAL_MODULE := iw > > $(IW_SOURCE_DIR)/version.c: > -- > 2.5.0.rc2.392.g76e840b > -- Elliott Hugh