Re: [08/11] rtlwifi: rtl_pci: Refactor TX/RX flow

2017-11-08 Thread Kalle Valo
based on my comments. 4 patches set to Changes Requested. 10036501 [08/11] rtlwifi: rtl_pci: Refactor TX/RX flow 10036503 [09/11] rtlwifi: rtl_pci: 8822BE puts broadcast and multicast packet to HIQ 10036507 [10/11] rtlwifi: Add beacon check mechanism to check if AP settings changed. 10036505 [

Re: [PATCH 08/11] rtlwifi: rtl_pci: Refactor TX/RX flow

2017-11-08 Thread Kalle Valo
Larry Finger writes: > From: Steven Ting > > After this refactoring, the variables wp and rp in TX ring can only be > updated in OP_TX and TX_OK respectively without protection. Why? Try to always answer that, that's the most important part of the commit log. Are you fixing a bug (if yes, descr

[PATCH 08/11] rtlwifi: rtl_pci: Refactor TX/RX flow

2017-11-01 Thread Larry Finger
From: Steven Ting After this refactoring, the variables wp and rp in TX ring can only be updated in OP_TX and TX_OK respectively without protection. The other changes are listed below: 1. remove avl_desc from TX ring, because it can be calculated by wp and rp. Moreover, we update this variabl