[PATCH] Fix kernel oops in failed chip_attach

2016-05-04 Thread Christian Daudt
When chip attach fails, brcmf_sdiod_intr_unregister is being called but that is too early as sdiodev->settings has not been set yet nor has brcmf_sdiod_intr_register been called. Change to use oob_irq_requested + newly created sd_irq_requested to decide on what to unregister at intr_unregister time

Re: [PATCH] Fix kernel oops in failed chip_attach

2016-05-06 Thread Kalle Valo
Christian Daudt writes: > When chip attach fails, brcmf_sdiod_intr_unregister is being called > but that is too early as sdiodev->settings has not been set yet > nor has brcmf_sdiod_intr_register been called. > Change to use oob_irq_requested + newly created sd_irq_requested > to decide on what t

Re: [PATCH] Fix kernel oops in failed chip_attach

2016-05-06 Thread Christian Daudt
On Fri, May 6, 2016 at 4:53 AM, Kalle Valo wrote: > Christian Daudt writes: > >> When chip attach fails, brcmf_sdiod_intr_unregister is being called >> but that is too early as sdiodev->settings has not been set yet >> nor has brcmf_sdiod_intr_register been called. >> Change to use oob_irq_reques

Re: [PATCH] Fix kernel oops in failed chip_attach

2016-05-06 Thread Kalle Valo
Christian Daudt writes: > On Fri, May 6, 2016 at 4:53 AM, Kalle Valo wrote: >> Christian Daudt writes: >> >>> When chip attach fails, brcmf_sdiod_intr_unregister is being called >>> but that is too early as sdiodev->settings has not been set yet >>> nor has brcmf_sdiod_intr_register been called