Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-11-15 Thread Valo, Kalle
"Vittorio Gambaletta (VittGam)" writes: > Hello, > > On 12/10/2016 17:01:08 CEST, Valo, Kalle wrote: > >> So to tell the full story I'll change the commit log to something like >> below. Does it look ok to you? > > Yes; but I'd change "So" to "This turned out to be wrong", and add a note > about

Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-10-14 Thread Vittorio Gambaletta (VittGam)
Hello, On 12/10/2016 17:01:08 CEST, Valo, Kalle wrote: "Vittorio Gambaletta (VittGam)" writes: So, after seeing that the rest of the file is sorted this way (generic section after the specific ones), I concluded that the 0x002A sorting was wrong in the first place, and so is 0x0029. Then I se

Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-10-12 Thread Valo, Kalle
"Vittorio Gambaletta (VittGam)" writes: >>> So, after seeing that the rest of the file is sorted this way (generic >>> section after the specific ones), I concluded that the 0x002A sorting >>> was wrong in the first place, and so is 0x0029. Then I sent this patch >>> to fix this. >> >> I can't se

Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-10-12 Thread Vittorio Gambaletta (VittGam)
Hello, On 12/10/2016 15:34:46 CEST, Kalle Valo wrote: "Vittorio Gambaletta (VittGam)" writes: Hello, On 04/10/2016 17:46:44 CEST, Kalle Valo wrote: "Vittorio Gambaletta (VittGam)" writes: If generic entries are positioned above specific ones, then the former will be matched first and use

Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-10-12 Thread Kalle Valo
"Vittorio Gambaletta (VittGam)" writes: > Hello, > > On 04/10/2016 17:46:44 CEST, Kalle Valo wrote: >> "Vittorio Gambaletta (VittGam)" writes: >> >>> If generic entries are positioned above specific ones, then the >>> former will be matched first and used instead of the latter. >>> >>> Cc: >>>

Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-10-04 Thread Vittorio Gambaletta (VittGam)
Hello, On 04/10/2016 17:46:44 CEST, Kalle Valo wrote: "Vittorio Gambaletta (VittGam)" writes: If generic entries are positioned above specific ones, then the former will be matched first and used instead of the latter. Cc: Cc: Cc: Cc: Signed-off-by: Vittorio Gambaletta Why? What kind

Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-10-04 Thread Kalle Valo
"Vittorio Gambaletta (VittGam)" writes: > If generic entries are positioned above specific ones, then the > former will be matched first and used instead of the latter. > > Cc: > Cc: > Cc: > Cc: > Signed-off-by: Vittorio Gambaletta Why? What kind of bug you are fixing? You are not really de

[PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-10-03 Thread Vittorio Gambaletta (VittGam)
If generic entries are positioned above specific ones, then the former will be matched first and used instead of the latter. Cc: Cc: Cc: Cc: Signed-off-by: Vittorio Gambaletta --- --- a/drivers/net/wireless/ath/ath9k/pci.c +++ b/drivers/net/wireless/ath/ath9k/pci.c @@ -26,7 +26,6 @@