Re: [PATCH] bitfield: add constant field preparation macros

2018-10-15 Thread Johannes Berg
On Mon, 2018-10-15 at 09:53 +0100, John Garry wrote: > > +/** > > + * __FIELD_PREP() - prepare a constant bitfield element > > My impression is that the name prefix - '__' - tells little about the > function. If you agree, how about even CFIELD_PREP() or > FIELD_PREP_CONST() or similar? I prepe

Re: [PATCH] bitfield: add constant field preparation macros

2018-10-15 Thread John Garry
On 12/10/2018 20:45, Johannes Berg wrote: From: Johannes Berg John Garry requested to be able to use FIELD_PREP() and friends in constant initializers, but we cannot completely switch all of the current assertions to BUILD_BUG_ON_ZERO(). Thanks for this. So instead of this, add __FIELD_PRE

[PATCH] bitfield: add constant field preparation macros

2018-10-12 Thread Johannes Berg
From: Johannes Berg John Garry requested to be able to use FIELD_PREP() and friends in constant initializers, but we cannot completely switch all of the current assertions to BUILD_BUG_ON_ZERO(). So instead of this, add __FIELD_PREP() which is suitable in such contexts, and also add __{u,le,be}{