Re: [PATCH] brcmfmac: fix error handling of irq_of_parse_and_map

2014-11-16 Thread Arend van Spriel
On 11/14/14 23:12, Dmitry Torokhov wrote: Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Whoops, that is bad. Thanks for catching this. It probably needs to go to stable as well for 3.17 kernel. +Cc:

[PATCH] brcmfmac: fix error handling of irq_of_parse_and_map

2014-11-14 Thread Dmitry Torokhov
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov d...@chromium.org --- Not tested, found by casual code inspection. drivers/net/wireless/brcm80211/brcmfmac/of.c | 4 ++-- 1 file