Re: [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}

I'll try to come up with a patch that is easier for me to read, but I am really busy right now. Ping me in a week if you have heard from me earlier. So how it is going with this patch? In hindsight, I would use a different name for the macro parameter here: #define

Re: [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}

On Tue, Jul 14, 2015 at 3:41 PM, Denys Vlasenko vda.li...@googlemail.com wrote: On Tue, Jul 14, 2015 at 2:38 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: +#define IWL_READ_WRITE(static_inline) \ +static_inline void iwl_write8(struct iwl_trans *trans, u32 ofs, u8 val) \ +{ \

[PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}

With CONFIG_IWLWIFI_DEVICE_TRACING=y, these functions are rather large, too big for inlining. With this .config: http://busybox.net/~vda/kernel_config, after uninlining these functions have sizes and callsite counts as follows: iwl_read32 475 bytes, 51 callsites iwl_write32 477 bytes, 90