Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

2014-10-09 Thread Karl Beldan
On Thu, Oct 09, 2014 at 05:22:21PM +0200, Johannes Berg wrote: > On Thu, 2014-10-09 at 16:45 +0200, Karl Beldan wrote: > > > > > The typo is clearly showing but the faulty behavior clearly demands more > > > > detail indeed. > > > > > > > > It affects non-(V)HT rates and can lead to selecting an

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

2014-10-09 Thread Johannes Berg
On Thu, 2014-10-09 at 18:28 +0200, Karl Beldan wrote: > > But it's still pretty misbehaving, no? That IMHO warrants fixing and > > even cc stable. > You'd like me to reword with these details in a v2 and cc stable or ? Yes please, if you don't mind. johannes -- To unsubscribe from this list: s

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

2014-10-09 Thread Karl Beldan
On Thu, Oct 09, 2014 at 05:22:21PM +0200, Johannes Berg wrote: > On Thu, 2014-10-09 at 16:45 +0200, Karl Beldan wrote: > > > > > The typo is clearly showing but the faulty behavior clearly demands more > > > > detail indeed. > > > > > > > > It affects non-(V)HT rates and can lead to selecting an

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

2014-10-09 Thread Johannes Berg
On Thu, 2014-10-09 at 16:45 +0200, Karl Beldan wrote: > > > The typo is clearly showing but the faulty behavior clearly demands more > > > detail indeed. > > > > > > It affects non-(V)HT rates and can lead to selecting an rts_cts rate > > > that is not a basic rate or way superior to the referenc

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

2014-10-09 Thread Karl Beldan
On Thu, Oct 09, 2014 at 04:15:03PM +0200, Johannes Berg wrote: > On Thu, 2014-10-09 at 16:06 +0200, Karl Beldan wrote: > > On Thu, Oct 09, 2014 at 11:06:26AM +0200, Johannes Berg wrote: > > > On Tue, 2014-10-07 at 15:53 +0200, Karl Beldan wrote: > > > > From: Karl Beldan > > > > > > Is that reall

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

2014-10-09 Thread Johannes Berg
On Thu, 2014-10-09 at 16:06 +0200, Karl Beldan wrote: > On Thu, Oct 09, 2014 at 11:06:26AM +0200, Johannes Berg wrote: > > On Tue, 2014-10-07 at 15:53 +0200, Karl Beldan wrote: > > > From: Karl Beldan > > > > Is that really trivial? It seems to have some impact on the code, but I > > can't right

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

2014-10-09 Thread Karl Beldan
On Thu, Oct 09, 2014 at 11:06:26AM +0200, Johannes Berg wrote: > On Tue, 2014-10-07 at 15:53 +0200, Karl Beldan wrote: > > From: Karl Beldan > > Is that really trivial? It seems to have some impact on the code, but I > can't right now say exactly what the impact is. Can you describe it and > say

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

2014-10-09 Thread Johannes Berg
On Tue, 2014-10-07 at 15:53 +0200, Karl Beldan wrote: > From: Karl Beldan Is that really trivial? It seems to have some impact on the code, but I can't right now say exactly what the impact is. Can you describe it and say whether I should add it to mac80211 or mac80211-next? For "trivial" I'd pro

[PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

2014-10-07 Thread Karl Beldan
From: Karl Beldan Fixes: 5253ffb8 ("mac80211: always pick a basic rate to tx RTS/CTS for pre-HT rates") Signed-off-by: Karl Beldan --- net/mac80211/rate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c index 8fdadfd..6081329 100644