Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-24 Thread Arik Nemtsov
On Wed, Feb 24, 2016 at 3:37 PM, Ben Greear wrote: > > > On 02/24/2016 05:32 AM, Arik Nemtsov wrote: >> >> On Wed, Feb 24, 2016 at 3:24 PM, Ben Greear >> wrote: Also it's pretty easy to just leave the code there and condition the check on the 5GHz band. There's no need to remove it

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-24 Thread Ben Greear
On 02/24/2016 05:32 AM, Arik Nemtsov wrote: On Wed, Feb 24, 2016 at 3:24 PM, Ben Greear wrote: Also it's pretty easy to just leave the code there and condition the check on the 5GHz band. There's no need to remove it. Ok, so I can enable VHT on any band as long as the 5Ghz band exists and

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-24 Thread Arik Nemtsov
On Wed, Feb 24, 2016 at 3:24 PM, Ben Greear wrote: >> Also it's pretty easy to just leave the code there and condition the >> check on the 5GHz band. There's no need to remove it. > > > Ok, so I can enable VHT on any band as long as the 5Ghz band exists and > allows 80Mhz? > No idea about that. I

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-24 Thread Ben Greear
On 02/24/2016 12:40 AM, Arik Nemtsov wrote: On Tue, Feb 23, 2016 at 3:46 PM, Ben Greear wrote: On 02/23/2016 02:47 AM, Arik Nemtsov wrote: On Tue, Feb 23, 2016 at 12:42 AM, wrote: From: Ben Greear ath10k supports VHT on 2.4Ghz band. If supplicant and hostapd and radio think VHT shou

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-24 Thread Arik Nemtsov
On Tue, Feb 23, 2016 at 3:46 PM, Ben Greear wrote: > > > On 02/23/2016 02:47 AM, Arik Nemtsov wrote: >> >> On Tue, Feb 23, 2016 at 12:42 AM, wrote: >>> >>> >>> From: Ben Greear >>> >>> ath10k supports VHT on 2.4Ghz band. >>> If supplicant and hostapd and radio think >>> VHT should be allowed, th

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-23 Thread Ben Greear
On 02/23/2016 01:08 PM, Jouni Malinen wrote: On Tue, Feb 23, 2016 at 03:10:27PM +0100, Johannes Berg wrote: What you really "want" is to use VHT modulations, mostly for the dubious purpose of marketing benchmarks to reach 256-QAM modulations. I think the de-facto standard for this would be to u

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-23 Thread Jouni Malinen
On Tue, Feb 23, 2016 at 03:10:27PM +0100, Johannes Berg wrote: > What you really "want" is to use VHT modulations, mostly for the > dubious purpose of marketing benchmarks to reach 256-QAM modulations. > > I think the de-facto standard for this would be to use IEs similar to > VHT ones, encapsulat

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-23 Thread Ben Greear
On 02/23/2016 06:22 AM, Johannes Berg wrote: On Tue, 2016-02-23 at 06:18 -0800, Ben Greear wrote: [root@ben-ota2 lanforge]# iw phy wiphy0 info Wiphy wiphy0 Band 1: [...] VHT Capabilities (0x338001b2): Max MPDU length: 11454

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-23 Thread Johannes Berg
On Tue, 2016-02-23 at 06:18 -0800, Ben Greear wrote: > [root@ben-ota2 lanforge]# iw phy wiphy0 info > Wiphy wiphy0 >  > Band 1: [...] > VHT Capabilities (0x338001b2): > Max MPDU length: 11454 > Supported Channel Width: neither 160 nor

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-23 Thread Ben Greear
On 02/23/2016 06:10 AM, Johannes Berg wrote: On Mon, 2016-02-22 at 14:42 -0800, gree...@candelatech.com wrote: From: Ben Greear ath10k supports VHT on 2.4Ghz band. It can't. At least not formally, as this sentence is written, since VHT per the spec requires operating on the 5 GHz band, and

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-23 Thread Johannes Berg
On Mon, 2016-02-22 at 14:42 -0800, gree...@candelatech.com wrote: > From: Ben Greear > > ath10k supports VHT on 2.4Ghz band. It can't. At least not formally, as this sentence is written, since VHT per the spec requires operating on the 5 GHz band, and it also requires 80 MHz bandwidth which isn'

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-23 Thread Ben Greear
On 02/23/2016 02:47 AM, Arik Nemtsov wrote: On Tue, Feb 23, 2016 at 12:42 AM, wrote: From: Ben Greear ath10k supports VHT on 2.4Ghz band. If supplicant and hostapd and radio think VHT should be allowed, then kernel should let them try. Removing the 80Mhz check entirely is not the right w

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-23 Thread Arik Nemtsov
On Tue, Feb 23, 2016 at 12:42 AM, wrote: > > From: Ben Greear > > ath10k supports VHT on 2.4Ghz band. > If supplicant and hostapd and radio think > VHT should be allowed, then kernel should let them > try. Removing the 80Mhz check entirely is not the right way to go IMO. The check is there becau

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-22 Thread Ben Greear
On 02/22/2016 02:48 PM, Julian Calaby wrote: Hi Ben, On Tue, Feb 23, 2016 at 9:42 AM, wrote: From: Ben Greear ath10k supports VHT on 2.4Ghz band. If supplicant and hostapd and radio think VHT should be allowed, then kernel should let them try. Signed-off-by: Ben Greear --- net/mac80211/

Re: [PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-22 Thread Julian Calaby
Hi Ben, On Tue, Feb 23, 2016 at 9:42 AM, wrote: > From: Ben Greear > > ath10k supports VHT on 2.4Ghz band. > If supplicant and hostapd and radio think > VHT should be allowed, then kernel should let them > try. > > Signed-off-by: Ben Greear > --- > net/mac80211/mlme.c | 16 >

[PATCH] mac80211: Let VHT work on 2.4Ghz

2016-02-22 Thread greearb
From: Ben Greear ath10k supports VHT on 2.4Ghz band. If supplicant and hostapd and radio think VHT should be allowed, then kernel should let them try. Signed-off-by: Ben Greear --- net/mac80211/mlme.c | 16 net/mac80211/util.c | 13 + net/mac80211/vht.c | 15 -