[PATCH] mac80211: Move crypto IV generation to after TXQ dequeue.

2016-08-17 Thread Toke Høiland-Jørgensen
The FQ portion of the intermediate queues will reorder packets, which means that crypto IV generation needs to happen after dequeue when they are enabled, or the receiver will throw packets away when receiving them. This fixes the performance regression introduced by enabling softq in ath9k. Cc:

Re: [PATCH] mac80211: Move crypto IV generation to after TXQ dequeue.

2016-08-17 Thread Johannes Berg
> @@ -1573,6 +1574,7 @@ struct ieee80211_key_conf { >   u8 iv_len; >   u8 hw_key_idx; >   u8 flags; > + u8 pn_offs; > This is completely wrong. johannes

Re: [PATCH] mac80211: Move crypto IV generation to after TXQ dequeue.

2016-08-17 Thread Toke Høiland-Jørgensen
Johannes Berg writes: >> @@ -1573,6 +1574,7 @@ struct ieee80211_key_conf { >>  u8 iv_len; >>  u8 hw_key_idx; >>  u8 flags; >> +u8 pn_offs; >> > This is completely wrong. Well, the ieee80211_fast_tx struct is not available in ieee80211_tx_dequeue, and I need the offset there. I t

Re: [PATCH] mac80211: Move crypto IV generation to after TXQ dequeue.

2016-08-17 Thread Johannes Berg
On Wed, 2016-08-17 at 15:16 +0200, Toke Høiland-Jørgensen wrote: > Johannes Berg writes: > > > > > > > > > @@ -1573,6 +1574,7 @@ struct ieee80211_key_conf { > > >   u8 iv_len; > > >   u8 hw_key_idx; > > >   u8 flags; > > > + u8 pn_offs; > > > > > This is completely wrong. > > Well, the ieee80

Re: [PATCH] mac80211: Move crypto IV generation to after TXQ dequeue.

2016-08-17 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Wed, 2016-08-17 at 15:16 +0200, Toke Høiland-Jørgensen wrote: >> Johannes Berg writes: >> >> > >> > > >> > > @@ -1573,6 +1574,7 @@ struct ieee80211_key_conf { >> > >  u8 iv_len; >> > >  u8 hw_key_idx; >> > >  u8 flags; >> > > +u8 pn_o