Re: [PATCH] mac80211: Move message tracepoints to their own header

2015-04-07 Thread Johannes Berg
On Tue, 2015-04-07 at 10:21 -0400, Steven Rostedt wrote: > On Tue, 07 Apr 2015 08:58:58 +0200 > Johannes Berg wrote: > > > On Mon, 2015-04-06 at 23:13 -0400, Steven Rostedt wrote: > > > Every tracing file must have its own TRACE_SYSTEM defined. > > > > Oh, that requirement is new to me. I also h

Re: [PATCH] mac80211: Move message tracepoints to their own header

2015-04-07 Thread Steven Rostedt
On Tue, 07 Apr 2015 08:58:58 +0200 Johannes Berg wrote: > On Mon, 2015-04-06 at 23:13 -0400, Steven Rostedt wrote: > > Every tracing file must have its own TRACE_SYSTEM defined. > > Oh, that requirement is new to me. I also have the same in iwlwifi, with > even more TRACE_SYSTEMs. OK, the reaso

Re: [PATCH] mac80211: Move message tracepoints to their own header

2015-04-07 Thread Johannes Berg
On Tue, 2015-04-07 at 08:55 -0400, Steven Rostedt wrote: > Hmm, I must have missed the iwlwifi part, as that should have not built > with an allmodconfig :-/ Dunno, it seems that should be selected with allmodconfig, and it has 5 different ones ... :) > > I could merge through my tree but I gues

Re: [PATCH] mac80211: Move message tracepoints to their own header

2015-04-07 Thread Steven Rostedt
On Tue, 07 Apr 2015 08:58:58 +0200 Johannes Berg wrote: > On Mon, 2015-04-06 at 23:13 -0400, Steven Rostedt wrote: > > Every tracing file must have its own TRACE_SYSTEM defined. > > Oh, that requirement is new to me. I also have the same in iwlwifi, with > even more TRACE_SYSTEMs. Well, it's ne

Re: [PATCH] mac80211: Move message tracepoints to their own header

2015-04-07 Thread Johannes Berg
On Mon, 2015-04-06 at 23:13 -0400, Steven Rostedt wrote: > Every tracing file must have its own TRACE_SYSTEM defined. Oh, that requirement is new to me. I also have the same in iwlwifi, with even more TRACE_SYSTEMs. > The mac80211 tracepoint header broke this and add in the middle > of the file h

[PATCH] mac80211: Move message tracepoints to their own header

2015-04-06 Thread Steven Rostedt
Every tracing file must have its own TRACE_SYSTEM defined. The mac80211 tracepoint header broke this and add in the middle of the file had: #undef TRACE_SYSTEM #define TRACE_SYSTEM mac80211_msg Unfortunately, this broke new code in the ftrace infrastructure. Moving the mac80211_msg into its ow