Re: [PATCH] mac80211: Remove invalid flag operations in mesh TSF synchronization

2016-12-07 Thread Masashi Honma
On 2016年12月07日 22:33, Bob Copeland wrote: This mesh_sync_offset_adjust_tbtt is definitely doing offset synchronization, so probably "tbtt" should be renamed "tsf" here. Right. I will send a patch for this. Actually, looking at the code now it doesn't make a lot of sense to set this flag for o

Re: [PATCH] mac80211: Remove invalid flag operations in mesh TSF synchronization

2016-12-07 Thread Bob Copeland
On Wed, Dec 07, 2016 at 09:55:41PM +0900, Masashi Honma wrote: > >It's called mesh_sync_offset_adjust_tbtt() which matches more closely > >"TBTT adjustment" than "neighbor offset synchronization"? > > I think so. Because there is not any code creating "TBTT Adjustment Request > frame" even though

Re: [PATCH] mac80211: Remove invalid flag operations in mesh TSF synchronization

2016-12-07 Thread Masashi Honma
On 2016年12月07日 18:24, Johannes Berg wrote: And the flag is refered by 1) as you said. The purpose of the flag is to prevent 1) while 2) is ongoing. In other words, 1) has only read access authority to the flag. However, previous code updated the flag in 1). In addition, there is no code for 2)

Re: [PATCH] mac80211: Remove invalid flag operations in mesh TSF synchronization

2016-12-07 Thread Johannes Berg
Hi, I'm not sure what to do with this now :) > > There are two functionalities. > > > > 1) 13.13.2.2 Neighbor offset synchronization method > > 2) 13.13.4.4 TBTT adjustment Yes, this much is obvious. > > The flag is updated by 2). Yes, the definition of the flag says: "The TBTT Adjusting sub

Re: [PATCH] mac80211: Remove invalid flag operations in mesh TSF synchronization

2016-12-05 Thread Thomas Pedersen
On Fri, Dec 2, 2016 at 10:59 PM, Masashi Honma wrote: > On 2016/12/03 06:13, Bob Copeland wrote: >> >> On Fri, Dec 02, 2016 at 12:07:18PM -0800, Thomas Pedersen wrote: > > > # Rejected by linux wireless ML. This is resubmission. > > thomas and Bob, Thanks for comments. > >> 802.11-2012 13.13.2.2.3

Re: [PATCH] mac80211: Remove invalid flag operations in mesh TSF synchronization

2016-12-02 Thread Masashi Honma
On 2016/12/03 06:13, Bob Copeland wrote: On Fri, Dec 02, 2016 at 12:07:18PM -0800, Thomas Pedersen wrote: # Rejected by linux wireless ML. This is resubmission. thomas and Bob, Thanks for comments. > 802.11-2012 13.13.2.2.3: > The mesh STA checks if the transmitter of the Beacon frame or Prob

Re: [PATCH] mac80211: Remove invalid flag operations in mesh TSF synchronization

2016-12-02 Thread Bob Copeland
On Fri, Dec 02, 2016 at 12:07:18PM -0800, Thomas Pedersen wrote: > On Wed, Nov 30, 2016 at 2:44 PM, Masashi Honma > wrote: > > mesh_sync_offset_adjust_tbtt() implements Extensible synchronization > > framework ([1] 13.13.2 Extensible synchronization framework). It shall > > not operate the flag "

Re: [PATCH] mac80211: Remove invalid flag operations in mesh TSF synchronization

2016-12-02 Thread Thomas Pedersen
On Wed, Nov 30, 2016 at 2:44 PM, Masashi Honma wrote: > mesh_sync_offset_adjust_tbtt() implements Extensible synchronization > framework ([1] 13.13.2 Extensible synchronization framework). It shall > not operate the flag "TBTT Adjusting subfield" ([1] 8.4.2.100.8 Mesh > Capability), since it is us

[PATCH] mac80211: Remove invalid flag operations in mesh TSF synchronization

2016-11-30 Thread Masashi Honma
mesh_sync_offset_adjust_tbtt() implements Extensible synchronization framework ([1] 13.13.2 Extensible synchronization framework). It shall not operate the flag "TBTT Adjusting subfield" ([1] 8.4.2.100.8 Mesh Capability), since it is used only for MBCA ([1] 13.13.4 Mesh beacon collision avoidance,