Re: [PATCH] mac80211: add ieee80211_hw flag for QoS NDP support

2018-03-21 Thread Ben Caradoc-Davies
On 21/03/18 22:53, Johannes Berg wrote: I've applied a modified version of this patch - it will also require setting the new "broken" flag in the driver. Thanks very much, Johannes. I have tested your modified patch together with the patch

Re: [PATCH] mac80211: add ieee80211_hw flag for QoS NDP support

2018-03-21 Thread Johannes Berg
On Mon, 2018-03-19 at 12:57 +1300, Ben Caradoc-Davies wrote: > Commit 7b6ddeaf27ec ("mac80211: use QoS NDP for AP probing") adds an > argument qos_ok to ieee80211_nullfunc_get to support QoS NDP. Despite > the claim in the commit log "Change all the drivers to *not* allow > QoS NDP for now, even th

Re: [PATCH] mac80211: add ieee80211_hw flag for QoS NDP support

2018-03-19 Thread kbuild test robot
Hi Ben, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [cannot apply to next-20180319] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ben-Caradoc-Davies

Re: [PATCH] mac80211: add ieee80211_hw flag for QoS NDP support

2018-03-19 Thread kbuild test robot
Hi Ben, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [cannot apply to next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ben-Caradoc-Davies

[PATCH] mac80211: add ieee80211_hw flag for QoS NDP support

2018-03-18 Thread Ben Caradoc-Davies
Commit 7b6ddeaf27ec ("mac80211: use QoS NDP for AP probing") adds an argument qos_ok to ieee80211_nullfunc_get to support QoS NDP. Despite the claim in the commit log "Change all the drivers to *not* allow QoS NDP for now, even though it looks like most of them should be OK with that", this commit

Re: [PATCH] mac80211: add ieee80211_hw flag for QoS NDP support

2018-03-18 Thread Ben Caradoc-Davies
Good grief. Typo. Please reject this one too. Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited New Zealand

[PATCH] mac80211: add ieee80211_hw flag for QoS NDP support

2018-03-18 Thread Ben Caradoc-Davies
Commit 7b6ddeaf27ec ("mac80211: use QoS NDP for AP probing") adds an argument qos_ok to ieee80211_nullfunc_get to support QoS NDP. Despite the claim in the commit log "Change all the drivers to *not* allow QoS NDP for now, even though it looks like most of them should be OK with that", this commit

Re: [PATCH] mac80211: add ieee80211_hw flag for QoS NDP support

2018-03-18 Thread Ben Caradoc-Davies
On 19/03/18 11:12, kbuild test robot wrote: net/mac80211/debugfs.c: In function 'hwflags_read': include/linux/compiler.h:339:38: error: call to '__compiletime_assert_234' declared with attribute error: BUILD_BUG_ON failed: ARRAY_SIZE(hw_flag_names) != NUM_IEEE80211_HW_FLAGS Please reject

Re: [PATCH] mac80211: add ieee80211_hw flag for QoS NDP support

2018-03-18 Thread kbuild test robot
Hi Ben, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [cannot apply to next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ben-Caradoc-Davies

Re: [PATCH] mac80211: add ieee80211_hw flag for QoS NDP support

2018-03-17 Thread Ben Caradoc-Davies
Note that this patch supersedes . Kind regards, -- Ben Caradoc-Davies Director Transient Software Limited New Zealand

[PATCH] mac80211: add ieee80211_hw flag for QoS NDP support

2018-03-17 Thread Ben Caradoc-Davies
Commit 7b6ddeaf27ec ("mac80211: use QoS NDP for AP probing") adds an argument qos_ok to ieee80211_nullfunc_get to support QoS NDP. Despite the claim in the commit log "Change all the drivers to *not* allow QoS NDP for now, even though it looks like most of them should be OK with that", this commit