Re: [PATCH] mac80211: do not aggregate frames if max_frags is set to one

2018-08-29 Thread Lorenzo Bianconi
> On Tue, 2018-08-28 at 23:41 +0200, Lorenzo Bianconi wrote: > > > Assuming the A-MSDU subframe is composed by two packets, the last one > > must not contain padding, is my understanding correct? > > Yes. More generally, assuming the A-MSDU subframe is composed of *any > number of* packets, the

Re: [PATCH] mac80211: do not aggregate frames if max_frags is set to one

2018-08-29 Thread Johannes Berg
On Tue, 2018-08-28 at 23:41 +0200, Lorenzo Bianconi wrote: > Assuming the A-MSDU subframe is composed by two packets, the last one > must not contain padding, is my understanding correct? Yes. More generally, assuming the A-MSDU subframe is composed of *any number of* packets, the last one must

Re: [PATCH] mac80211: do not aggregate frames if max_frags is set to one

2018-08-28 Thread Lorenzo Bianconi
> > On Tue, 2018-08-28 at 23:07 +0200, Lorenzo Bianconi wrote: > > Do not try to aggregate packets in a A-MSDU frame if max_tx_fragments > > or max_amsdu_subframes is set to 1. > > Yeah that seems valid. > > > Moreover take into account > > tail padding added on the first frame into flow backlog

Re: [PATCH] mac80211: do not aggregate frames if max_frags is set to one

2018-08-28 Thread Johannes Berg
On Tue, 2018-08-28 at 23:07 +0200, Lorenzo Bianconi wrote: > Do not try to aggregate packets in a A-MSDU frame if max_tx_fragments > or max_amsdu_subframes is set to 1. Yeah that seems valid. > Moreover take into account > tail padding added on the first frame into flow backlog if >

[PATCH] mac80211: do not aggregate frames if max_frags is set to one

2018-08-28 Thread Lorenzo Bianconi
Do not try to aggregate packets in a A-MSDU frame if max_tx_fragments or max_amsdu_subframes is set to 1. Moreover take into account tail padding added on the first frame into flow backlog if ieee80211_amsdu_realloc_pad routine on the second frame fails. This patch fixes a kernel freeze that