Re: [PATCH] mac80211: fix "warning: ‘target_metric’ may be used uninitialized"

2016-04-06 Thread Johannes Berg
On Mon, 2016-04-04 at 14:15 -0400, Jeff Mahoney wrote: > This fixes: > > net/mac80211/mesh_hwmp.c:603:26: warning: ‘target_metric’ may be used > uninitialized in this function > > target_metric is only consumed when reply = true so no bug exists > here, > but gcc doesn't notice that.  

Re: [PATCH] mac80211: fix "warning: ‘target_metric’ may be used uninitialized"

2016-04-05 Thread Jeff Mahoney
On 4/5/16 9:40 AM, Johannes Berg wrote: > On Tue, 2016-04-05 at 09:33 -0400, Jeff Mahoney wrote: >> On 4/5/16 5:43 AM, Johannes Berg wrote: >>> >>> On Mon, 2016-04-04 at 14:15 -0400, Jeff Mahoney wrote: This fixes: net/mac80211/mesh_hwmp.c:603:26: warning: ‘target_metric’ may

Re: [PATCH] mac80211: fix "warning: ‘target_metric’ may be used uninitialized"

2016-04-05 Thread Johannes Berg
On Tue, 2016-04-05 at 09:33 -0400, Jeff Mahoney wrote: > On 4/5/16 5:43 AM, Johannes Berg wrote: > > > > On Mon, 2016-04-04 at 14:15 -0400, Jeff Mahoney wrote: > > > > > > This fixes: > > > > > > net/mac80211/mesh_hwmp.c:603:26: warning: ‘target_metric’ may be > > > used > > > uninitialized in

Re: [PATCH] mac80211: fix "warning: ‘target_metric’ may be used uninitialized"

2016-04-05 Thread Jeff Mahoney
On 4/5/16 5:43 AM, Johannes Berg wrote: > On Mon, 2016-04-04 at 14:15 -0400, Jeff Mahoney wrote: >> This fixes: >> >> net/mac80211/mesh_hwmp.c:603:26: warning: ‘target_metric’ may be used >> uninitialized in this function >> >> target_metric is only consumed when reply = true so no bug exists >>

Re: [PATCH] mac80211: fix "warning: ‘target_metric’ may be used uninitialized"

2016-04-05 Thread Johannes Berg
On Mon, 2016-04-04 at 14:15 -0400, Jeff Mahoney wrote: > This fixes: > > net/mac80211/mesh_hwmp.c:603:26: warning: ‘target_metric’ may be used > uninitialized in this function > > target_metric is only consumed when reply = true so no bug exists > here, > but gcc doesn't notice that.  

[PATCH] mac80211: fix "warning: ‘target_metric’ may be used uninitialized"

2016-04-04 Thread Jeff Mahoney
This fixes: net/mac80211/mesh_hwmp.c:603:26: warning: ‘target_metric’ may be used uninitialized in this function target_metric is only consumed when reply = true so no bug exists here, but gcc doesn't notice that. Initializing to 0 clears the warning. Signed-off-by: Jeff Mahoney